summaryrefslogtreecommitdiff
path: root/core/controllers/items.php
diff options
context:
space:
mode:
authorBharat Mediratta <bharat@menalto.com>2008-12-03 23:31:10 +0000
committerBharat Mediratta <bharat@menalto.com>2008-12-03 23:31:10 +0000
commitccee9854c29f9fedfeb5647d058e76154f9a8295 (patch)
treec3892fa5ac75b63634ad00c0d0616e933432a02e /core/controllers/items.php
parent76196be483e92e01543c8dc1c488e44ae527db64 (diff)
Rename file::unlink() to dir::unlink(). This creates an API that is
clearer about its actions, otherwise we may accidentally blow away an entire hierarchy when we think we're deleting a single file (there's a reason why rm won't let you delete dirs that aren't empty!) Name it "dir" instead of "directory" because apparently "directory" is already reserved. Move the delete call out of Items_Controller and into the model. The model is responsible for keeping state integrity, not the controller.
Diffstat (limited to 'core/controllers/items.php')
-rw-r--r--core/controllers/items.php1
1 files changed, 0 insertions, 1 deletions
diff --git a/core/controllers/items.php b/core/controllers/items.php
index 6ba7db65..f10a30c3 100644
--- a/core/controllers/items.php
+++ b/core/controllers/items.php
@@ -102,7 +102,6 @@ class Items_Controller extends REST_Controller {
module::event("{$item->type}_before_delete", $item);
$item->delete();
- file::unlink($item->file_path());
}
url::redirect("{$parent->type}s/{$parent->id}");