From ccee9854c29f9fedfeb5647d058e76154f9a8295 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Wed, 3 Dec 2008 23:31:10 +0000 Subject: Rename file::unlink() to dir::unlink(). This creates an API that is clearer about its actions, otherwise we may accidentally blow away an entire hierarchy when we think we're deleting a single file (there's a reason why rm won't let you delete dirs that aren't empty!) Name it "dir" instead of "directory" because apparently "directory" is already reserved. Move the delete call out of Items_Controller and into the model. The model is responsible for keeping state integrity, not the controller. --- core/controllers/items.php | 1 - 1 file changed, 1 deletion(-) (limited to 'core/controllers/items.php') diff --git a/core/controllers/items.php b/core/controllers/items.php index 6ba7db65..f10a30c3 100644 --- a/core/controllers/items.php +++ b/core/controllers/items.php @@ -102,7 +102,6 @@ class Items_Controller extends REST_Controller { module::event("{$item->type}_before_delete", $item); $item->delete(); - file::unlink($item->file_path()); } url::redirect("{$parent->type}s/{$parent->id}"); -- cgit v1.2.3