| Age | Commit message (Collapse) | Author |
|
to reflect this move. Not completely moved yet, but the git st is rather large so lets commit this now as a base for the cleanup.
|
|
the only parent for which the id is relevant. In a perfect world each
parent's link would have a ?show=<id> for the next child's id. But
that would require some confusing code and I don't want to put that
into the default/example theme yet.
|
|
we're not relying on overriding url::site() to do tricks around item
urls. This means that you won't get item urls by doing
url::site("albums/37"), for example, but it also means that we won't
get pretty urls where we don't expect them (like in the action of a
<form> element).
Incidentally, this will help us move over to using the slug format
because if you've got a bad character in a url, the edit forms will
now work on it since they'll be id based.
|
|
unsused admin styles in the process. Fixed problem in admin header that broke the theme's layout in IE7. Moved the Gallery logo and shortcut icon to lib/images for easier reuse.
|
|
|
|
|
|
|
|
other view template.
|
|
string delimiters)
|
|
Conflicts:
modules/akismet/views/admin_akismet.html.php
modules/comment/helpers/comment_rss.php
modules/gallery/helpers/gallery_rss.php
modules/gallery/libraries/I18n.php
modules/gallery/views/permissions_browse.html.php
modules/gallery/views/simple_uploader.html.php
modules/info/views/info_block.html.php
modules/organize/controllers/organize.php
modules/organize/views/organize.html.php
modules/organize/views/organize_album.html.php
themes/default/views/album.html.php
themes/default/views/movie.html.php
themes/default/views/photo.html.php
|
|
Xss: Rename UNKNOWN back to DIRTY, JS_XSS to DIRTY_JS.
(using a different flag value to highlight potential XSS vectors in JS)
|
|
SafeString::purify().
Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
|
|
and album covers in the context menu.
Notes:
- This requires context_menu() to have a CSS selector that refers to the
<img> that we're operating on, otherwise we don't know how to find the
thumbnail, etc.
- Create Menu_Element_Ajax_Link which has an ajax_handler attribute
that contains a snippet of JS that we're going to run when the ajax
call returns.
- Add $.gallery_replace_image in gallery.common.js
- Add lib/gallery.ajax.js which can be used to ajaxify any link, and have
ui.init.js in the themes call that on all .gAjaxLink elements.
|
|
theme. Because the theme comes first, this means that themes can
override any module resources, at the cost that we no longer have
namespacing for JS and CSS files.
The only file getting used outside of this model is
themes/default/screen.css which is used in the admin theme. I fixed
that by copying screen.css into admin_default and renaming its
screen.css to admin_screen.css. I also copied over all the images
that it was referencing.
Fixes tickets #48 and #539.
Theme API changes:
- theme_script(), theme_url() and theme_css() are no longer needed
- script(), url() and css() now refer to the first matching asset in
the module load path, where gallery3/lib is at the end of the path
|
|
|
|
|
|
to load them conditionally.
|
|
Implement the combined css functionality. Local url references and replace with absolute urls instead of relative.
|
|
Conflicts:
modules/gallery/libraries/Theme_View.php
themes/admin_default/views/admin.html.php
|
|
$theme->theme_script().
|
|
Gallery_View base class from Theme_View and Admin_View.
1) Move all the theme specific jquery stuff from gallery_theme::head()
and admin_head() into the theme files. Use $theme->script() as
appropriate.
2) Get rid of the extra boolean on $theme->url() that we were using so
that we could call $theme->script($theme->url(...)) -- add
$theme->theme_script() instead (poorly named, but still clearer than
what we had before)
3) Fix the bug that combined scripts didn't work at all in the admin
theme.
4) Get rid of $theme->display() in favor of new View(...)
|
|
gallery_theme::admin_head. This allows us to potentially manage the scripts like we do in g2 (single file and compressed)
2) Change Theme_View::_call to always call the gallery_theme::$function first.
|
|
contents are are not shown
|
|
album to tag->title. which doesn't exist.
|
|
while. This fixes ticket #342.
The bug is that we were using $item instead of $theme->item(). But we
were also not special casing tags properly, and they are effectively
first class citizens (at least for now) so treat them properly. Also,
set page_title by default in the theme so that we don't have to do an
empty() check on it (makes the theme easier to read) and move the
title out of Tags_Controller so that the theme has more control over
it.
|
|
viewing photo view. White space cleanup, removed debug print from template.
|
|
more intuitive for themers.
|
|
|
|
|
|
|
|
|
|
toggle, and forms to external files.
|
|
150. Use this in the the default theme, or any other, to reduce the size of CSS widths and heights in albums, including .gItem.
|
|
|
|
into each theme. I chose to create methods Theme_View::file($path)
and Admin_View::file($path). These methods check for a theme override
file in the theme and return a link to it if it exists. So to
override the themeroller files. just create a lib/themeroller in the
theme and the files will be picked up.
|
|
|
|
creating the page. Provide for a default page title if none is
set. This allows less changes to page.html.php as different modules
want to change the page title.
|
|
url:site(url::abs_file(...))
Create a login_page.html to be used when there is no guest access to
the root album. It doesn't have a sidebar nor breadcrumb.
|
|
item. ticket #118.
|
|
content now clears the menu. Added IE-specific stylesheet to admin theme.
|
|
|
|
updates, keep default theme directories clean.
|
|
|
|
includes calls to the widget css we're currently using. Add new widget css here.
|
|
|
|
icons. No need to fix position dialogs anymore. Included the following in the combined file + i18n files. Requires push back up to vendor branch.
UI Core
Effects Core
Draggable - Req'd by Sortable
Resizeable - Image/watermark/avatar scaling
Sortable - Rearrange
Dialog - All over :)
Datepicker - Edit albums/items
Progressbar
Highlight - Message display, comment addition
Transfer - Adding tags from available list to field
Not fully integrated into the default theme yet.
|
|
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
|
|
|
|
images, these are included in the default theme. Added a favicon.
|
|
1) drop unnecessary semicolon
2) start with <?php for extra security in the case that the server itself doesn't
have short_tags enabled (the app won't work, but we need to make sure that we're
still secure)
|