| Age | Commit message (Collapse) | Author |
|---|
|
|
|
- added extra $var_subdir argument to item::find_by_path.
- changed item::find_by_path to use $var_subdir to detect if we should look for a jpg-converted item or not (e.g. movie thumbs)
- moved the album thumb detection to item::find_by_path to ensure it knows to look for an exact album match.
- added more sanity checks to item::find_by_path (now has fewer false positive possibilities).
- updated file_proxy to remove the need to guess different movie files.
- updated File_Proxy_Controller - new sanity checks catch previously undetected bug.
- added additional unit tests for item::find_by_path.
|
|
images so that we can see how efficient our proxying is. Follow-on
for #1959.
|
|
Moved the "if (TEST_MODE)" statement before the buffer calls in file_proxy and data_rest.
This has no impact on normal use, but will make the unit tests more compatible with different server/PHP configurations.
Note: We do not have to skip setting the headers, which means we can build unit tests around them if we wish.
|
|
|
|
edge case behaviors. It doesn't cover the various headers, but it does cover
the permission based code paths.
|
|
Correct result: always "image/jpeg"
Old data_rest result: mime of cover item
Old file_proxy result: mime of album item (null)
|
|
documentation/formatting changes.
No actual functionality changed here.
|
|
hard-coded list of movie file extensions.
bug fix: updated uploader.php to use legal_file helper instead of hard-coded list of movie file extensions.
Fixes #1926
|
|
|
|
|
|
cases
when zlib.output_compression is enabled.
|
|
thanks to pvalsecc.
|
|
|
|
|
|
Follow-on for #1518.
|
|
|
|
values, and request is only processed further in case of a match. => this is unnecessary
|
|
does all the right permission checks. This prevents a hotlink to a
private photo in a private gallery from kicking the user out to a
login page. Fixes #1594.
|
|
forbidden in other places like add album/item) and explitely look for /../ instead
Note: directory path can't end in '.' forcibly so this shall be fine
Fixes Ticket #1518
|
|
|
|
ticket #974.
|
|
|
|
I've done some tests on a 60M flv and found that there's no difference
in memory consumption with these three approaches:
public function test() {
Kohana::close_buffers(false);
$file = "/home/bharat/basketball.flv";
if ($fd = fopen($file, "rb")) {
while (true) {
$bits = fread($fd, 65535);
if (strlen($bits) == 0) {
break;
}
print $bits;
set_time_limit(30);
}
fclose($fd);
}
Kohana_Log::add("error","test: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1));
}
public function test2() {
Kohana::close_buffers(false);
$file = "/home/bharat/basketball.flv";
$fd = fopen($file, "rb");
fpassthru($fd);
fclose($fd);
Kohana_Log::add("error","test2: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1));
}
public function test3() {
Kohana::close_buffers(false);
$file = "/home/bharat/basketball.flv";
readfile($file);
Kohana_Log::add("error","test3: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1));
}
|
|
|
|
find the item. Thanks to samdavidoff for the initial fix.
|
|
|
|
mostly issues around uninitialized variables, calling non-static
functions in a static context, calling Session functions directly
instead of on its singleton, passing non-variables by reference, and
subclasses not using the same interface as the parent class.
|
|
path. Otherwise, we will encode the slashes and won't find the item.
|
|
Fixes ticket #954.
|
|
last-modified header
|
|
expiration. Fixes ticket #953.
|
|
Kohana_404_Exception instead. These are the ones where we used a
lower-case 'k' so my previous filter didn't catch it.
|
|
1) Controller::$input is gone -- use Input::instance() now
2) Handle new 'database.<default>.connection.params' parameter
3) Handle new 'cache.<default>.prefix' parameter
|
|
|
|
|
|
instead of a thumbnail. Fixes ticket #925, thanks to lsowen.
|
|
Convert all open_paren() calls to and_open() or or_open() as appropriate.
|
|
- Kohana::log() -> Kohana_Log::add()
- Kohana::config_XXX -> Kohana_Config::instance()->XXX
- Implement View::set_global in MY_View
- Updated Cache_Database_Driver to latest APIs
- ORM::$loaded -> ORM::loaded()
- Updated item::viewable() to use K2.4 parenthesization
|
|
in Item_Model when creating the relative_path_cache.
|
|
http://gallery.menalto.com/node/90306
Thanks rWatcher
Signed-off-by: Tim Almdal <tnalmdal@shaw.ca>
|
|
the thumbnail to the movie and then showing it as a JPG. Fixes ticket
#570.
|
|
highly inefficient to me, so let's see if we can live without it.
|
|
|
|
|
|
change, but this is the part that we want to keep.
|
|
Obsoleted by upstream fix.
This reverts commit 06f066164f60fe0babbc7a480e6319a0702e0c46.
|
|
Filed upstream as: http://dev.kohanaphp.com/issues/1801
|
|
|
|
|
