summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-01-28#1945 - Extend legal_file helper functions.shadlaws
- Added get_types_by_extension function, which is a merged version of get...types_by_extension functions (similar to get_extensions). - Added optional extension argument to get...extensions functions similar to get...types_by_extension functions. - Added unit tests. Now, every legal_file function has one. - Restructured helper file to include caches. - Added array_unique to get...types (derived from get...types_by_extension, which can be many-to-one). - Edited server_add, uploader, and item model to use new functionality.
2013-01-28Automated update of .build_number to 302 for branch masterAutomatic Build Number Updater
Last update: daad29e5c391d15d99cd8f3f5af8aaf3e3b76749 (1 commits ago)
2013-01-28Merge pull request #109 from shadlaws/fix_1971Bharat Mediratta
#1971 - Make resequence_child_weights_test unit test more reliable.
2013-01-28#1971 - Make resequence_child_weights_test unit test more reliable.shadlaws
- Set the sort_column of the parent album to id, which has no possibility of being identical between the two photos. - Now, the reweighting will reverse the order even if they were created during the same second.
2013-01-27Automated update of .build_number to 301 for branch masterAutomatic Build Number Updater
Last update: 0c214d85e63fc74fb315ca1b542251d5c6112201 (1 commits ago)
2013-01-27Add a key on relative_path_cache in the items table to improve performance ↵Bharat Mediratta
on installs that use File_Proxy heavily. Fixes #1920.
2013-01-26Automated update of .build_number to 300 for branch masterAutomatic Build Number Updater
Last update: c508fc4a45f0af94c89ba7f0ac1533244a7f35a3 (1 commits ago)
2013-01-26Merge pull request #104 from shadlaws/fix_1966Bharat Mediratta
#1966 - "Fix your Gallery" shows 60/59 items completed.
2013-01-26Automated update of .build_number to 299 for branch masterAutomatic Build Number Updater
Last update: 847a825b2527584662da277fd6a47921287cbbf4 (1 commits ago)
2013-01-26Merge pull request #91 from shadlaws/fix_1946_1947Bharat Mediratta
#1946, 1947 - Make altered names/slugs more user-friendly, make conflict-finding code check filenames with no extensions
2013-01-26#1966 - "Fix your Gallery" shows 60/59 items completed.shadlaws
- Fixed counter in gallery_task::fix that was often one too many. For FIX_STATE_RUN_MISSING_ACCESS_CACHES, changed this: $stack = explode(" ", $task->get("stack")); To this: $stack = array_filter(explode(" ", $task->get("stack")));
2013-01-26#1946, 1947 - Make altered names/slugs more user-friendly, make ↵shadlaws
conflict-finding code check filenames with no extensions - Reduced from four places that alter names/slugs to two (one to populate empty slugs, one to handle conflicting names/slugs). - For empty slugs, fill with generic human-readable name (e.g. "photo") instead of random value. - For conflicting names/slugs, add suffix that's sequential (e.g. "-01"), only using random after 99 conflicts. - Made conflict-finding code check filenames with no extensions. - Renamed _randomize_name_or_slug_on_conflict to _check_and_fix_conflicts. - Added unit tests. Also cleaned up existing unit tests to reflect new logic and removed a redundant test. - Added installer logic to correct existing items now considered in conflict. - Revised gallery_task to look for duplicate names based on new criteria.
2013-01-25Automated update of .build_number to 298 for branch masterAutomatic Build Number Updater
Last update: 066f4cdf8e44585790711797baf9130511d4203d (1 commits ago)
2013-01-25Merge pull request #103 from shadlaws/fix_1965Bharat Mediratta
#1965 - Improve sanity checks and copy/convert/process logic for rotate and resize
2013-01-25Automated update of .build_number to 297 for branch masterAutomatic Build Number Updater
Last update: 776fe75ceb93f8eb729d13d58fb411d6ceeb9270 (1 commits ago)
2013-01-25Merge pull request #96 from shadlaws/fix_1951Bharat Mediratta
#1951 - Make metadata generation more flexible (photo and movie helpers).
2013-01-26#1951 - Make metadata generation more flexible (photo and movie helpers).shadlaws
- added photo_get_file_metadata and movie_get_file_metadata events - modified photo::get_file_metadata and movie::get_file_metadata to use them - ensure that non-readable files throw exceptions - redirected other photo metadata calls in core to photo::get_file_metadata (the helper function already exists, but in many places getimagesize is still called directly) - added some unit tests (neither of the functions above had one)
2013-01-25#1965 - Improve sanity checks and copy/convert/process logic for rotate and ↵shadlaws
resize. - resize: ensured that resize is skipped *only* if the metadata is valid or the options are well-defined and would upscale. Then, if resize is skipped, check to see if it still needs to be converted. Previous conditions would allow a small PNG to get copied to a JPG, and would allow a corrupted JPG to be copied to the output. - rotate: add checks for empty file or empty options. - use get_file_metadata instead of direct getimagesize call. - add unit tests for rotate and resize, including some for corrupted input files and missing options.
2013-01-25Automated update of .build_number to 296 for branch masterAutomatic Build Number Updater
Last update: 7e710366de1514c900807881aaf2fdd42a467fe9 (1 commits ago)
2013-01-25Fix an assignment-instead-of-comparison bug. I wish PHP had a betterBharat Mediratta
warning system for this stuff. In this case it's innocuous because the UI only allows you to rearrange stuff inside a single album, so the assignment doesn't do anything. Fixes #1914.
2013-01-25Automated update of .build_number to 295 for branch masterAutomatic Build Number Updater
Last update: c71f3091d2c3d87467640c0d7a0e701c259dd519 (1 commits ago)
2013-01-25Merge pull request #102 from shadlaws/fix_1964Bharat Mediratta
#1964 - TMPPATH is mis-defined in index.php.
2013-01-25Automated update of .build_number to 294 for branch masterAutomatic Build Number Updater
Last update: ba3b0c06b0874faeed0eaa62e507c8d44f2a68f5 (1 commits ago)
2013-01-25Follow-on to 8e954cf5f0be61eb9ac6fa6e8f04ee6dcf4aaf23 - use HTTP_HOST if ↵Bharat Mediratta
there's no SERVER_NAME
2013-01-25Automated update of .build_number to 293 for branch masterAutomatic Build Number Updater
Last update: 0397497ba0a019548eaf909e7ef61a53008d9403 (2 commits ago)
2013-01-25Use SERVER_NAME instead of HTTP_HOST. Fixes #1963.Bharat Mediratta
2013-01-25Properly escape backslashes. Fixes #1962.Bharat Mediratta
2013-01-25Automated update of .build_number to 292 for branch masterAutomatic Build Number Updater
Last update: 4c1dc8457e82bd8960e10416981b5dadfc3aebe4 (1 commits ago)
2013-01-25Merge pull request #100 from shadlaws/fix_1956Bharat Mediratta
#1956 - Escape LIKE queries (for _ and %).
2013-01-25#1964 - TMPPATH is mis-defined in index.php.shadlaws
- fixed mis-definition of TMPPATH, which was resulting in something like .../gallery/var//tmp/
2013-01-25#1956 - Escape LIKE queries (for _ and %).shadlaws
In MySQL queries, _ and % characters are treated as wildcards (similar to ? and *, respectively). - Added escape_for_like function to MY_Database.php - Added unit test to Database_Test - Corrected the five unescaped instances in the code using this function.
2013-01-24Automated update of .build_number to 291 for branch masterAutomatic Build Number Updater
Last update: 4926615cd01ff829324b61ac3e8f61f32f52a36b (1 commits ago)
2013-01-24Follow-on to b50768142745dc4bfd8a9460c7490ddd00e3b06a - add a defaultBharat Mediratta
value for lock_timeout so that folks who get the latest code but don't run the upgrader don't get burned by a SQL error.
2013-01-24Automated update of .build_number to 290 for branch masterAutomatic Build Number Updater
Last update: 31807a59a5160a816718fbea1b1659398a2110bb (13 commits ago)
2013-01-24Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2013-01-24If profiling is enabled, dump out profiling data instead of proxiedBharat Mediratta
images so that we can see how efficient our proxying is. Follow-on for #1959.
2013-01-24Add back a comment that I accidentally removed in the last commit.Bharat Mediratta
2013-01-24Automated update of .build_number to 289 for branch masterAutomatic Build Number Updater
Last update: c9a30e3b7e3b85b645a987d7024572345091364a (1 commits ago)
2013-01-24Merge pull request #99 from shadlaws/fix_1955Bharat Mediratta
#1955 - Make unit test photos unique.
2013-01-24Automated update of .build_number to 288 for branch masterAutomatic Build Number Updater
Last update: 3e451d6edc6ab3586ef730e4458ca0b2d55f5170 (1 commits ago)
2013-01-24Merge pull request #101 from shadlaws/fix_1960Bharat Mediratta
#1960 - Add unit test to look for extra spaces at end of line
2013-01-24#1955 - Make unit test photos unique.shadlaws
- Added test::random_unique_photo and test::random_unique_photo_unsaved to uniquify test photos. - Uniquified the black dot of test.jpg by coloring it with the six-digit hex code already used to name the random photos (e.g. "name_a48801.jpg"). - Modified four tests in Item_Model_Test that check photo file contents to use new functions to guarantee uniqueness.
2013-01-24#1960 - Add unit test to look for extra spaces at end of lineshadlaws
- Added no_extra_spaces_at_end_of_line_test to File_Structure_Test. - Updated Gallery_Filters to exclude testing code that isn't ours. - Removed existing extra spaces. New test now passes.
2013-01-23Automated update of .build_number to 287 for branch masterAutomatic Build Number Updater
Last update: 31807a59a5160a816718fbea1b1659398a2110bb (10 commits ago)
2013-01-23Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2013-01-23Extract reweighting logic out of Organize_Controller intoBharat Mediratta
item::reweight_all_children as an API and write a test for it. Work in progress on #1914.
2013-01-23Automated update of .build_number to 286 for branch masterAutomatic Build Number Updater
Last update: 31807a59a5160a816718fbea1b1659398a2110bb (8 commits ago)
2013-01-23Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2013-01-23Add a cache buster to all data_rest urls, add caching headers to allBharat Mediratta
data_rest responses, and check cache validity. Fixes #1909.
2013-01-23Automated update of .build_number to 285 for branch masterAutomatic Build Number Updater
Last update: 31807a59a5160a816718fbea1b1659398a2110bb (6 commits ago)