summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBharat Mediratta <bharat@menalto.com>2013-01-25 15:49:04 -0500
committerBharat Mediratta <bharat@menalto.com>2013-01-25 15:49:04 -0500
commit21a43410141579e4347e2255ae3ab1da9d27ae11 (patch)
tree47abecf153dc941c4a476d04794323ae02b3632b
parent7e710366de1514c900807881aaf2fdd42a467fe9 (diff)
Fix an assignment-instead-of-comparison bug. I wish PHP had a better
warning system for this stuff. In this case it's innocuous because the UI only allows you to rearrange stuff inside a single album, so the assignment doesn't do anything. Fixes #1914.
-rw-r--r--modules/organize/controllers/organize.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/organize/controllers/organize.php b/modules/organize/controllers/organize.php
index 9e5bce84..ba73ae75 100644
--- a/modules/organize/controllers/organize.php
+++ b/modules/organize/controllers/organize.php
@@ -154,7 +154,7 @@ class Organize_Controller extends Controller {
// Move all the source items to the right spots.
for ($i = 0; $i < count($source_ids); $i++) {
$source = ORM::factory("item", $source_ids[$i]);
- if ($source->parent_id = $album->id) {
+ if ($source->parent_id == $album->id) {
$source->weight = $base_weight + $i;
$source->save();
}