summaryrefslogtreecommitdiff
path: root/modules/g2_import
diff options
context:
space:
mode:
Diffstat (limited to 'modules/g2_import')
-rw-r--r--modules/g2_import/controllers/admin_g2_import.php5
-rw-r--r--modules/g2_import/helpers/g2_import.php11
-rw-r--r--modules/g2_import/helpers/g2_import_task.php12
-rw-r--r--modules/g2_import/views/admin_g2_import.html.php2
4 files changed, 26 insertions, 4 deletions
diff --git a/modules/g2_import/controllers/admin_g2_import.php b/modules/g2_import/controllers/admin_g2_import.php
index 1c65f482..6dd155b9 100644
--- a/modules/g2_import/controllers/admin_g2_import.php
+++ b/modules/g2_import/controllers/admin_g2_import.php
@@ -19,6 +19,7 @@
*/
class Admin_g2_import_Controller extends Admin_Controller {
public function index() {
+ g2_import::lower_error_reporting();
if (g2_import::is_configured()) {
g2_import::init();
}
@@ -31,6 +32,7 @@ class Admin_g2_import_Controller extends Admin_Controller {
$view = new Admin_View("admin.html");
$view->content = new View("admin_g2_import.html");
$view->content->form = $this->_get_import_form();
+ $view->content->version = g2_import::version();
if (g2_import::is_initialized()) {
$view->content->g2_stats = $g2_stats;
@@ -38,11 +40,13 @@ class Admin_g2_import_Controller extends Admin_Controller {
$view->content->thumb_size = module::get_var("gallery", "thumb_size");
$view->content->resize_size = module::get_var("gallery", "resize_size");
}
+ g2_import::restore_error_reporting();
print $view;
}
public function save() {
access::verify_csrf();
+ g2_import::lower_error_reporting();
$form = $this->_get_import_form();
if ($form->validate()) {
@@ -63,6 +67,7 @@ class Admin_g2_import_Controller extends Admin_Controller {
$view = new Admin_View("admin.html");
$view->content = new View("admin_g2_import.html");
$view->content->form = $form;
+ g2_import::restore_error_reporting();
print $view;
}
diff --git a/modules/g2_import/helpers/g2_import.php b/modules/g2_import/helpers/g2_import.php
index fa95e547..0fcc0539 100644
--- a/modules/g2_import/helpers/g2_import.php
+++ b/modules/g2_import/helpers/g2_import.php
@@ -24,6 +24,7 @@ class g2_import_Core {
public static $g2_base_url = null;
private static $current_g2_item = null;
+ private static $error_reporting = null;
static function is_configured() {
return module::get_var("g2_import", "embed_path");
@@ -931,6 +932,16 @@ class g2_import_Core {
"useAuthToken" => false));
return str_replace(self::$g2_base_url, "", $url);
}
+
+ static function lower_error_reporting() {
+ // Gallery 2 was not designed to run in E_STRICT mode and will barf out errors. So dial down
+ // the error reporting when we make G2 calls.
+ self::$error_reporting = error_reporting(error_reporting() & ~E_STRICT);
+ }
+
+ static function restore_error_reporting() {
+ error_reporting(self::$error_reporting);
+ }
}
/**
diff --git a/modules/g2_import/helpers/g2_import_task.php b/modules/g2_import/helpers/g2_import_task.php
index e80b88b9..e0212b33 100644
--- a/modules/g2_import/helpers/g2_import_task.php
+++ b/modules/g2_import/helpers/g2_import_task.php
@@ -19,17 +19,19 @@
*/
class g2_import_task_Core {
static function available_tasks() {
+ g2_import::lower_error_reporting();
if (g2_import::is_configured()) {
g2_import::init();
}
-
+ $version = g2_import::version();
+ g2_import::restore_error_reporting();
if (class_exists("GalleryCoreApi")) {
return array(Task_Definition::factory()
->callback("g2_import_task::import")
->name(t("Import from Gallery 2"))
->description(
- t("Gallery %version detected", array("version" => g2_import::version())))
+ t("Gallery %version detected", array("version" => $version)))
->severity(log::SUCCESS));
}
@@ -37,6 +39,8 @@ class g2_import_task_Core {
}
static function import($task) {
+ g2_import::lower_error_reporting();
+
$start = microtime(true);
g2_import::init();
@@ -185,7 +189,7 @@ class g2_import_task_Core {
}
$task->status = t(
"Album highlights (%count of %total)",
- array("count" => $done["tags"] + 1, "total" => $stats["albums"]));
+ array("count" => $done["highlights"] + 1, "total" => $stats["highlights"]));
break;
@@ -207,5 +211,7 @@ class g2_import_task_Core {
$task->set("mode", $mode);
$task->set("queue", $queue);
$task->set("done", $done);
+
+ g2_import::restore_error_reporting();
}
}
diff --git a/modules/g2_import/views/admin_g2_import.html.php b/modules/g2_import/views/admin_g2_import.html.php
index 0875e7f7..6a5214a3 100644
--- a/modules/g2_import/views/admin_g2_import.html.php
+++ b/modules/g2_import/views/admin_g2_import.html.php
@@ -34,7 +34,7 @@
<h2> <?= t("Import") ?> </h2>
<ul id="g-action-status" class="g-message-block">
<li class="g-success">
- <?= t("Gallery version %version detected", array("version" => g2_import::version())) ?>
+ <?= t("Gallery version %version detected", array("version" => $version)) ?>
</li>
<? if ($g2_sizes["thumb"]["size"] && $thumb_size != $g2_sizes["thumb"]["size"]): ?>
<li class="g-warning">