Refactor all translation strings that have ambiguous placeholders.

E.g. "%link_startClick here%link_end" is now '<a href="%url">Click here</a>'.

Note: This isn't always the best solution. E.g. consider "Foo <a href='%url' class='gDialogLink'>bar</a>." Now the translator has to deal with 
preserving CSS classes too... 

1 files changed, 2 insertions, 5 deletions

diff --git a/modules/search/helpers/search.php b/modules/search/helpers/search.php
index 3e425289..1cb28519 100644
--- a/modules/search/helpers/search.php
+++ b/modules/search/helpers/search.php
@@ -53,11 +53,8 @@ class search_Core {
   static function check_index() {
     if ($count = ORM::factory("search_record")->where("dirty", 1)->count_all()) {
       site_status::warning(
-        t("Your search index needs to be updated.  %link_startFix this now%link_end",
-          array("link_start" => "<a href=\"" .
-                url::site("admin/maintenance/start/search_task::update_index?csrf=__CSRF__") .
-                   "\" class=\"gDialogLink\">",
-                   "link_end" => "</a>")),
+        t('Your search index needs to be updated.  <a href="%url" class="gDialogLink">Fix this now</a>',
+          array("url" => url::site("admin/maintenance/start/search_task::update_index?csrf=__CSRF__"))),
         "search_index_out_of_date");
     }
   }