Rename "user_access_tokens" table to "user_access_keys" as step 1 of a

multi step process to refer to REST access keys as "access_key"
everywhere.  Bump the rest module to version 2.

6 files changed, 24 insertions, 16 deletions

diff --git a/modules/rest/helpers/rest.php b/modules/rest/helpers/rest.php
index 7440350f..e87ee91c 100644
--- a/modules/rest/helpers/rest.php
+++ b/modules/rest/helpers/rest.php
@@ -42,7 +42,7 @@ class rest_Core {
       throw new Rest_Exception("Forbidden", 403);
     }
 
-    $key = ORM::factory("user_access_token")
+    $key = ORM::factory("user_access_key")
       ->where("access_key", "=", $access_token)
       ->find();
 
@@ -59,7 +59,7 @@ class rest_Core {
   }
 
   static function get_access_token($user_id) {
-    $key = ORM::factory("user_access_token")
+    $key = ORM::factory("user_access_key")
       ->where("user_id", "=", $user_id)
       ->find();
 
diff --git a/modules/rest/helpers/rest_event.php b/modules/rest/helpers/rest_event.php
index 91affe7a..c89436c0 100644
--- a/modules/rest/helpers/rest_event.php
+++ b/modules/rest/helpers/rest_event.php
@@ -24,7 +24,7 @@ class rest_event {
    */
   static function user_before_delete($user) {
     db::build()
-      ->delete("user_access_tokens")
+      ->delete("user_access_keys")
        ->where("id", "=", $user->id)
        ->execute();
   }
@@ -34,7 +34,7 @@ class rest_event {
    * on every add.
    */
   static function user_add_form_admin_completed($user, $form) {
-    $key = ORM::factory("user_access_token");
+    $key = ORM::factory("user_access_key");
     $key->user_id = $user->id;
     $key->access_key = md5($user->name . rand());
     $key->save();
@@ -58,7 +58,7 @@ class rest_event {
    * Get the form fields for user edit
    */
   static function _get_access_key_form($user, $form) {
-    $key = ORM::factory("user_access_token")
+    $key = ORM::factory("user_access_key")
       ->where("user_id", "=", $user->id)
       ->find();
 
@@ -68,7 +68,7 @@ class rest_event {
       $key->save();
     }
 
-    $form->edit_user->input("user_access_token")
+    $form->edit_user->input("user_access_key")
       ->value($key->access_key)
       ->readonly("readonly")
       ->class("g-form-static")
@@ -87,9 +87,9 @@ class rest_event {
     }
 
     $view = new View("user_profile_rest.html");
-    $key = ORM::factory("user_access_token")
-        ->where("user_id", "=", $data->user->id)
-        ->find();
+    $key = ORM::factory("user_access_key")
+      ->where("user_id", "=", $data->user->id)
+      ->find();
 
     if (!$key->loaded()) {
       $key->user_id = $data->user->id;
diff --git a/modules/rest/helpers/rest_installer.php b/modules/rest/helpers/rest_installer.php
index f69f62d1..aeb9573e 100644
--- a/modules/rest/helpers/rest_installer.php
+++ b/modules/rest/helpers/rest_installer.php
@@ -20,7 +20,7 @@
 class rest_installer {
   static function install() {
     Database::instance()
-      ->query("CREATE TABLE {user_access_tokens} (
+      ->query("CREATE TABLE {user_access_keys} (
                 `id` int(9) NOT NULL auto_increment,
                 `user_id` int(9) NOT NULL,
                 `access_key` char(32) NOT NULL,
@@ -28,10 +28,18 @@ class rest_installer {
                 UNIQUE KEY(`access_key`),
                 UNIQUE KEY(`user_id`))
               DEFAULT CHARSET=utf8;");
-    module::set_version("rest", 1);
+    module::set_version("rest", 2);
+  }
+
+  static function upgrade($version) {
+    $db = Database::instance();
+    if ($version == 1) {
+      $db->query("RENAME TABLE {user_access_tokens} TO {user_access_keys}");
+      module::set_version("rest", $version = 2);
+    }
   }
 
   static function uninstall() {
-    Database::instance()->query("DROP TABLE IF EXISTS {user_access_tokens}");
+    Database::instance()->query("DROP TABLE IF EXISTS {user_access_keys}");
   }
 }
diff --git a/modules/rest/models/user_access_token.php b/modules/rest/models/user_access_key.php
index 44330768..1da0f5eb 100644
--- a/modules/rest/models/user_access_token.php
+++ b/modules/rest/models/user_access_key.php
@@ -17,5 +17,5 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
-class User_Access_Token_Model extends ORM {
+class User_Access_Key_Model extends ORM {
 }
diff --git a/modules/rest/module.info b/modules/rest/module.info
index 45bd79e4..3ab7e165 100644
--- a/modules/rest/module.info
+++ b/modules/rest/module.info
@@ -1,4 +1,4 @@
 name = "REST Access Module"
 description = "The RESTful implementation/interface to Gallery3"
 
-version = 1
+version = 2
diff --git a/modules/rest/tests/Rest_Controller_Test.php b/modules/rest/tests/Rest_Controller_Test.php
index 21be8300..e8b9dbd0 100644
--- a/modules/rest/tests/Rest_Controller_Test.php
+++ b/modules/rest/tests/Rest_Controller_Test.php
@@ -34,14 +34,14 @@ class Rest_Controller_Test extends Gallery_Unit_Test_Case {
 
     // There's no access key at first
     $this->assert_false(
-      ORM::factory("user_access_token")->where("user_id", "=", $user->id)->find()->loaded());
+      ORM::factory("user_access_key")->where("user_id", "=", $user->id)->find()->loaded());
 
     $_POST["user"] = $user->name;
     $_POST["password"] = "password";
 
     $response = test::call_and_capture(array(new Rest_Controller(), "index"));
     $expected =
-      ORM::factory("user_access_token")->where("user_id", "=", $user->id)->find()->access_key;
+      ORM::factory("user_access_key")->where("user_id", "=", $user->id)->find()->access_key;
 
     // Now there is an access key, and it was returned
     $this->assert_equal(json_encode($expected), $response);