Changes to support updating the child elements within an album. In this change the urls of the children are sent up asan array of post fields children[0].... children[n]. If an existing child is not included it is deleted. Including a url to an child in another album will move the child. Changing the order of the children will respect the order of the children, if the sort column is 'weight'

3 files changed, 79 insertions, 13 deletions

diff --git a/modules/gallery/helpers/item_rest.php b/modules/gallery/helpers/item_rest.php
index 16abec5a..5d31291e 100644
--- a/modules/gallery/helpers/item_rest.php
+++ b/modules/gallery/helpers/item_rest.php
@@ -88,35 +88,91 @@ class item_rest_Core {
 
     $params = $request->params;
 
+    $sort_order_changed_to_weight = false;
+    // Start the batch
+    batch::start();
+
     // Only change fields from a whitelist.
     foreach (array("album_cover", "captured", "description",
                    "height", "mime_type", "name", "parent", "rand_key", "resize_dirty",
                    "resize_height", "resize_width", "slug", "sort_column", "sort_order",
                    "thumb_dirty", "thumb_height", "thumb_width", "title", "view_count",
                    "weight", "width") as $key) {
-      switch ($key) {
-      case "album_cover":
-        if (property_exists($request->params, "album_cover")) {
+      if (property_exists($request->params, $key)) {
+        switch ($key) {
+        case "album_cover":
           $album_cover_item = rest::resolve($request->params->album_cover);
           access::required("view", $album_cover_item);
           $item->album_cover_item_id = $album_cover_item->id;
-        }
-        break;
-
-      case "parent":
-        if (property_exists($request->params, "parent")) {
+          break;
+
+        case "sort_column":
+          if ($request->params->sort_column == "weight" && $item->sort_column != "weight") {
+            $sort_order_changed_to_weight = true;
+            $item->sort_column = "weight";
+          }
+          break;
+        case "parent":
           $parent = rest::resolve($request->params->parent);
           access::required("edit", $parent);
           $item->parent_id = $parent->id;
-        }
         break;
-      default:
-        if (property_exists($request->params, $key)) {
+        default:
           $item->$key = $request->params->$key;
         }
       }
     }
     $item->save();
+
+    //  If children are supplied, then update the children based on that client tells us.
+    //  if the sort order changed, then update the weights if there are no children to be updated
+    if (property_exists($request->params, "children")) {
+      // Map the existing children by their restful urls
+      $children = array();
+      foreach ($item->children() as $child) {
+        $children[rest::url("item", $child)] = $child;
+      }
+      $update_weight = $item->sort_column == "weight";
+      $weight = $item->sort_order == "ASC" ? -1 : $request->params->url->length;
+      $weight_increment =  $item->sort_order == "ASC" ? 1 : -1;
+
+      foreach($request->params->children as $url) {
+        if (isset($children[$url])) {
+          $child = $children[$url];
+          unset($children[$url]);
+        } else {
+          $child = rest::resolve($url);
+          $child->parent_id = $item->id;
+        }
+        $child->save();
+        if ($update_weight) {
+          $weight += $weight_increment;
+          db::build()
+            ->update("items")
+            ->set("weight",  $weight)
+            ->where("id", "=", $child->id)
+            ->execute();
+        }
+      }
+      // Anything left in the mapping needs to be deleted
+      foreach ($children as $child) {
+        $child->delete();
+      }
+    } else if ($sort_order_changed_to_weight) {
+      $weight = $item->sort_order == "ASC" ? -1 : $request->params->url->length;
+      $weight_increment =  $item->sort_order == "ASC" ? 1 : -1;
+      foreach ($item->children() as $child) {
+        // Do this directly in the database to avoid sending notifications
+        $weight += $weight_increment;
+        db::build()
+          ->update("items")
+          ->set("weight",  $weight)
+          ->where("id", "=", $child->id)
+          ->execute();
+      }
+    }
+
+    batch::stop();
   }
 
   static function post($request) {
diff --git a/modules/gallery/helpers/items_rest.php b/modules/gallery/helpers/items_rest.php
index 05ca65cf..48839dc9 100644
--- a/modules/gallery/helpers/items_rest.php
+++ b/modules/gallery/helpers/items_rest.php
@@ -19,10 +19,12 @@
  */
 class items_rest_Core {
   static function get($request) {
+    $parent = rest::resolve($request->url);
+    access::required("view", $parent);
 
     $items = array();
     if (isset($request->params->url)) {
-      foreach($request->params->url as $url) {
+      foreach ($request->params->url as $url) {
         $item = rest::resolve($url);
         if (access::can("view", $item)) {
           $members = array();
@@ -41,4 +43,12 @@ class items_rest_Core {
 
     return $items;
   }
+
+  static function resolve($id) {
+    $item = ORM::factory("item", $id);
+    if (!access::can("view", $item)) {
+      throw new Kohana_404_Exception();
+    }
+    return $item;
+  }
 }
diff --git a/modules/rest/controllers/rest.php b/modules/rest/controllers/rest.php
index eed54bd4..7a9e3b0b 100644
--- a/modules/rest/controllers/rest.php
+++ b/modules/rest/controllers/rest.php
@@ -46,7 +46,7 @@ class Rest_Controller extends Controller {
       $request->params = (object) $input->get();
       break;
 
-    case "post":
+    default:
       $request->params = (object) $input->post();
       if (isset($_FILES["file"])) {
         $request->file = upload::save("file");