summaryrefslogtreecommitdiff
path: root/modules/user/libraries
diff options
context:
space:
mode:
authorBharat Mediratta <bharat@menalto.com>2010-09-06 18:20:46 -0700
committerBharat Mediratta <bharat@menalto.com>2010-09-06 18:20:46 -0700
commit8a36c24f39e7a6111f7872ec443e6efa63580c82 (patch)
treed08ebc1976c024514fcbfbcae851cc0a73b6fb9c /modules/user/libraries
parentcc399bf4f07fd7060536f442373a1e9c0ea4a5aa (diff)
Fix some broken identity APIs:
- add_user_to_group and remove_user_from_group should take Group_Definition instances to be consistent - add_user_to_group and remove_user_from_group in drivers/IdentityProvider.php should not be static
Diffstat (limited to 'modules/user/libraries')
-rw-r--r--modules/user/libraries/drivers/IdentityProvider/Gallery.php7
1 files changed, 2 insertions, 5 deletions
diff --git a/modules/user/libraries/drivers/IdentityProvider/Gallery.php b/modules/user/libraries/drivers/IdentityProvider/Gallery.php
index 1ed7dd4f..44433ad7 100644
--- a/modules/user/libraries/drivers/IdentityProvider/Gallery.php
+++ b/modules/user/libraries/drivers/IdentityProvider/Gallery.php
@@ -148,9 +148,7 @@ class IdentityProvider_Gallery_Driver implements IdentityProvider_Driver {
/**
* @see IdentityProvider_Driver::add_user_to_group.
*/
- static function add_user_to_group($user, $group_id) {
- $group = self::lookup_group($group_id);
-
+ public function add_user_to_group($user, $group) {
$group->add($user);
$group->save();
}
@@ -158,8 +156,7 @@ class IdentityProvider_Gallery_Driver implements IdentityProvider_Driver {
/**
* @see IdentityProvider_Driver::remove_user_to_group.
*/
- static function remove_user_from_group($user, $group_id) {
- $group = self::lookup_group_by_name($group_id);
+ public function remove_user_from_group($user, $group_id) {
$group->remove($user);
$group->save();
}