diff options
| author | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
|---|---|---|
| committer | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
| commit | f3ba69c1d67c425ffa180d082a373e5cce0c86ce (patch) | |
| tree | 5ecbbe0ba96a94e3f4aadd26042c8ad1a32ef1bc /modules/user/helpers/user_block.php | |
| parent | 02af2d8b7639fdc18fba3d69a4ca0a3f5c92b948 (diff) | |
Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.
According to the PHP docs, the "public" keyword is implied on static
functions, so remove it. Also, require private static functions to
start with an _.
http://php.net/manual/en/language.oop5.visibility.php
Diffstat (limited to 'modules/user/helpers/user_block.php')
| -rw-r--r-- | modules/user/helpers/user_block.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/user/helpers/user_block.php b/modules/user/helpers/user_block.php index 5e406fef..bb9e567f 100644 --- a/modules/user/helpers/user_block.php +++ b/modules/user/helpers/user_block.php @@ -18,7 +18,7 @@ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ class user_block_Core { - public static function head($theme) { + static function head($theme) { // @todo: move this into the theme $user = user::active(); if (!user::active()->guest) { @@ -27,7 +27,7 @@ class user_block_Core { } } - public static function header_top($theme) { + static function header_top($theme) { $view = new View("login.html"); $view->user = user::active(); return $view->render(); |