diff options
| author | Bharat Mediratta <bharat@menalto.com> | 2009-06-29 17:44:02 -0700 |
|---|---|---|
| committer | Bharat Mediratta <bharat@menalto.com> | 2009-06-29 17:44:02 -0700 |
| commit | 3080317d6e5e4ea9e56b1fd5444c4bcf5852c362 (patch) | |
| tree | b8c45bb7f6adde996184175e5d29d0a43f520097 /modules/unit_test | |
| parent | 006b63030a364677143799c7ce41eabb10c86eee (diff) | |
Refactor combined controller a bit
1) Create public javascript() and css() functions and turn __call()
into a private function to protect us against having some random
type show up in there. Otherwise anything you put in the 2nd
argument gets emitted in the header which is a security hole.
2) Fix a bug ("$key = $key[0]") which was breaking functionality.
Eliminate the hex check, it's not really necessary in the majority
case and doesn't hurt us in edge cases.
3) Convert some empty() calls to !, no need for a function call there.
4) Add phpDoc.
Diffstat (limited to 'modules/unit_test')
0 files changed, 0 insertions, 0 deletions