Cleanups.

- Show the "Server Add needs configuration" message whenever
  there are no paths.

- Un-ajaxify the admin code to remove complexity and allow us to
  update the status message as appropriate.

- Rename server_add_admin.html.php to admin_server_add.html.php
  for consistency.

- Fix up form to properly display error messages

- Get rid of server_add_dir_list.html.php now that we're
  non-ajaxified.

- Change delete <span> to an <a> for non-ajax world.

1 files changed, 3 insertions, 7 deletions

diff --git a/modules/server_add/helpers/server_add_installer.php b/modules/server_add/helpers/server_add_installer.php
index 0418ea15..26d8bd0d 100644
--- a/modules/server_add/helpers/server_add_installer.php
+++ b/modules/server_add/helpers/server_add_installer.php
@@ -28,18 +28,14 @@ class server_add_installer {
 
       module::set_version("server_add", 1);
       module::set_var("server_add", "authorized_paths", serialize(array()));
-      message::warning(
-        t("Server Add needs configuration. <a href=\"%url\">Configure it now!</a>",
-          array("url" => url::site("/admin/server_add"))));
+
+      server_add::check_config();
     }
   }
 
   static function uninstall() {
     access::delete_permission("server_add");
-    $module = module::get("server_add");
-
-    // @todo remove this after the next alpha
-    module::delete("local_import");
     module::delete("server_add");
+    site_status::clear("server_add_configuration");
   }
 }