Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

2 files changed, 3 insertions, 3 deletions

diff --git a/modules/rearrange/helpers/rearrange_block.php b/modules/rearrange/helpers/rearrange_block.php
index 579c9362..999be91e 100644
--- a/modules/rearrange/helpers/rearrange_block.php
+++ b/modules/rearrange/helpers/rearrange_block.php
@@ -18,7 +18,7 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class rearrange_block_Core {
-  public static function head($theme) {
+  static function head($theme) {
     $head[] = html::script("modules/rearrange/js/jquery.gallery.rearrange.tree.js");
 
     $url = url::file("modules/rearrange/css/rearrange.css");
diff --git a/modules/rearrange/helpers/rearrange_installer.php b/modules/rearrange/helpers/rearrange_installer.php
index e2a82160..46672007 100644
--- a/modules/rearrange/helpers/rearrange_installer.php
+++ b/modules/rearrange/helpers/rearrange_installer.php
@@ -18,14 +18,14 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class rearrange_installer {
-  public static function install() {
+  static function install() {
     $version = module::get_version("rearrange");
     if ($version == 0) {
       module::set_version("rearrange", 1);
     }
   }
 
-  public static function uninstall() {
+  static function uninstall() {
     module::delete("rearrange");
   }
 }