Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

2 files changed, 4 insertions, 4 deletions

diff --git a/modules/polar_rose/helpers/polar_rose_block.php b/modules/polar_rose/helpers/polar_rose_block.php
index 659181ac..85486917 100644
--- a/modules/polar_rose/helpers/polar_rose_block.php
+++ b/modules/polar_rose/helpers/polar_rose_block.php
@@ -18,7 +18,7 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class polar_rose_block_Core {
-  public static function head($theme) {
+  static function head($theme) {
     if (module::is_installed("media_rss")) {
       if ($theme->item()) {
         $url = media_rss::item_feed($theme->item());
@@ -44,7 +44,7 @@ class polar_rose_block_Core {
     }
   }
 
-  public static function page_bottom($theme) {
+  static function page_bottom($theme) {
     return "<div id=\"gPolarRose\"></div>";
   }
 }
diff --git a/modules/polar_rose/helpers/polar_rose_installer.php b/modules/polar_rose/helpers/polar_rose_installer.php
index 8e565a61..d8e779f4 100644
--- a/modules/polar_rose/helpers/polar_rose_installer.php
+++ b/modules/polar_rose/helpers/polar_rose_installer.php
@@ -18,7 +18,7 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class polar_rose_installer {
-  public static function install() {
+  static function install() {
     $db = Database::instance();
     $version = module::get_version("polar_rose");
     if ($version == 0) {
@@ -26,7 +26,7 @@ class polar_rose_installer {
     }
   }
 
-  public static function uninstall() {
+  static function uninstall() {
     module::delete("polar_rose");
   }
 }