Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

2 files changed, 3 insertions, 3 deletions

diff --git a/modules/gmaps/helpers/gmaps_block.php b/modules/gmaps/helpers/gmaps_block.php
index 4024ec55..06894005 100644
--- a/modules/gmaps/helpers/gmaps_block.php
+++ b/modules/gmaps/helpers/gmaps_block.php
@@ -19,7 +19,7 @@
  */
 
 class gmaps_block_Core {
-  public static function sidebar_blocks($theme) {
+  static function sidebar_blocks($theme) {
     if ($theme->item()) {
       $block = new Block();
       $block->css_id = "gMaps";
diff --git a/modules/gmaps/helpers/gmaps_installer.php b/modules/gmaps/helpers/gmaps_installer.php
index fd3ddbe7..747f84f7 100644
--- a/modules/gmaps/helpers/gmaps_installer.php
+++ b/modules/gmaps/helpers/gmaps_installer.php
@@ -18,14 +18,14 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class gmaps_installer {
-  public static function install() {
+  static function install() {
     $version = module::get_version("gmaps");
     if ($version == 0) {
       module::set_version("gmaps", 1);
     }
   }
 
-  public static function uninstall() {
+  static function uninstall() {
     module::delete("gmaps");
   }
 }