summaryrefslogtreecommitdiff
path: root/modules/gallery/tests/Legal_File_Helper_Test.php
diff options
context:
space:
mode:
authorshadlaws <shad@shadlaws.com>2013-01-18 20:06:05 +0100
committershadlaws <shad@shadlaws.com>2013-01-18 20:06:05 +0100
commit3a9009492e6d05fe657e3aacf34cf40ca3495db5 (patch)
treee244c6dd635eda6c7a0a73f1ec4d7bf556a9000d /modules/gallery/tests/Legal_File_Helper_Test.php
parent61724f78da98d192cc86db6b3a12cdac506a916e (diff)
#1943 - Make legal_file::change_extension more robust.
Previously would fail with dots in the directory but no extension. Added unit tests to verify the new change works.
Diffstat (limited to 'modules/gallery/tests/Legal_File_Helper_Test.php')
-rw-r--r--modules/gallery/tests/Legal_File_Helper_Test.php18
1 files changed, 18 insertions, 0 deletions
diff --git a/modules/gallery/tests/Legal_File_Helper_Test.php b/modules/gallery/tests/Legal_File_Helper_Test.php
index d80bcafe..d2813633 100644
--- a/modules/gallery/tests/Legal_File_Helper_Test.php
+++ b/modules/gallery/tests/Legal_File_Helper_Test.php
@@ -36,6 +36,24 @@ class Legal_File_Helper_Test extends Gallery_Unit_Test_Case {
legal_file::change_extension("/website/foo.com/VID_20120513_105421.mp4", "jpg"));
}
+ public function change_extension_path_containing_dots_and_no_extension_test() {
+ $this->assert_equal(
+ "/website/foo.com/VID_20120513_105421.jpg",
+ legal_file::change_extension("/website/foo.com/VID_20120513_105421", "jpg"));
+ }
+
+ public function change_extension_path_containing_dots_and_dot_extension_test() {
+ $this->assert_equal(
+ "/website/foo.com/VID_20120513_105421.jpg",
+ legal_file::change_extension("/website/foo.com/VID_20120513_105421.", "jpg"));
+ }
+
+ public function change_extension_path_containing_dots_and_non_standard_chars_test() {
+ $this->assert_equal(
+ "/j'écris@un#nom/bizarre(mais quand.même/ça_passe.jpg",
+ legal_file::change_extension("/j'écris@un#nom/bizarre(mais quand.même/ça_passe.\$ÇÀ@€#_", "jpg"));
+ }
+
public function smash_extensions_test() {
$this->assert_equal("foo_bar.jpg", legal_file::smash_extensions("foo.bar.jpg"));
$this->assert_equal("foo_bar_baz.jpg", legal_file::smash_extensions("foo.bar.baz.jpg"));