Drop the requirement to have the install() function set the module

version.  It's redundant.  Fixes #1985.

2 files changed, 1 insertions, 4 deletions

diff --git a/modules/gallery/helpers/gallery_installer.php b/modules/gallery/helpers/gallery_installer.php
index d4c4de14..7f10cdee 100644
--- a/modules/gallery/helpers/gallery_installer.php
+++ b/modules/gallery/helpers/gallery_installer.php
@@ -315,8 +315,6 @@ class gallery_installer {
     module::set_var("gallery", "timezone", null);
     module::set_var("gallery", "lock_timeout", 1);
     module::set_var("gallery", "movie_extract_frame_time", 3);
-
-    module::set_version("gallery", 55);
   }
 
   static function upgrade($version) {
diff --git a/modules/gallery/helpers/module.php b/modules/gallery/helpers/module.php
index f4ab5571..df258e87 100644
--- a/modules/gallery/helpers/module.php
+++ b/modules/gallery/helpers/module.php
@@ -175,9 +175,8 @@ class module_Core {
     $installer_class = "{$module_name}_installer";
     if (method_exists($installer_class, "install")) {
       call_user_func_array(array($installer_class, "install"), array());
-    } else {
-      module::set_version($module_name, module::available()->$module_name->code_version);
     }
+    module::set_version($module_name, module::available()->$module_name->code_version);
 
     // Set the weight of the new module, which controls the order in which the modules are
     // loaded. By default, new modules are installed at the end of the priority list.  Since the