Cleanup remove task processing. Change Task_Model::delete to call parent::delete

instead of parent::save. :-) Also change admin_maintenance_controller to delete
via looping over all of the completed tasks and delete individually, so we can
delete the associated cache entries at the same time.

1 files changed, 8 insertions, 1 deletions

diff --git a/modules/gallery/controllers/admin_maintenance.php b/modules/gallery/controllers/admin_maintenance.php
index a65bd770..37cc5222 100644
--- a/modules/gallery/controllers/admin_maintenance.php
+++ b/modules/gallery/controllers/admin_maintenance.php
@@ -161,7 +161,14 @@ class Admin_Maintenance_Controller extends Admin_Controller {
 
   public function remove_finished_tasks() {
     access::verify_csrf();
-    Database::instance()->delete("tasks", array("done" => 1));
+
+    // Do it the long way so we can call delete and remove the cache.
+    $finished = ORM::factory("task")
+      ->where(array("done" => 1))
+      ->find_all();
+    foreach ($finished as $task) {
+      task::remove($task->id);
+    }
     message::success(t("All finished tasks removed"));
     url::redirect("admin/maintenance");
   }