Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

1 files changed, 1 insertions, 1 deletions

diff --git a/modules/atom/helpers/atom.php b/modules/atom/helpers/atom.php
index b1bea5d3..e2f2d9ce 100644
--- a/modules/atom/helpers/atom.php
+++ b/modules/atom/helpers/atom.php
@@ -30,7 +30,7 @@ class atom_Core {
    * @param int Unix timestamp
    * @return string Internet timestamp
    */
-  public static function unix_to_internet_timestamp($timestamp) {
+  static function unix_to_internet_timestamp($timestamp) {
     return sprintf("%sZ", date("Y-m-d\TH:i:s", $timestamp));
   }
 }