Revert "Fix for ticket #544."

This reverts commit f6973431b7f8df24c081a03c7c989f621ab2a708.

3 files changed, 39 insertions, 37 deletions

diff --git a/installer/views/get_db_info.html.php b/installer/views/get_db_info.html.php
index adc775a4..94c19585 100644
--- a/installer/views/get_db_info.html.php
+++ b/installer/views/get_db_info.html.php
@@ -1,4 +1,32 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
+<h1> Welcome! </h1>
+<p>
+  Installing Gallery is very easy.  We just need to know how to talk
+  to your MySQL database, and we need a place to store your photos on
+  your web host.
+</p>
+
+
+<fieldset>
+  <legend>Photo Storage</legend>
+  <?php if (!installer::var_writable()): ?>
+  <p class="error">
+    We're having trouble creating a place for your photos.  Can you
+    help?  Please create a directory called "var" using <code>mkdir var</code> in your
+    gallery3 directory, then run <code>chmod 777 var</code>.  That
+    should fix it.
+    <br/><br/>
+    <a href="index.php">Check again</a>
+  </p>
+  <?php else: ?>
+  <p class="success">
+    We've found a place to store your photos:
+    <code class="location"> <?= VARPATH ?> </code>
+  </p>
+  <?php endif ?>
+</fieldset>
+
+<?php if (installer::var_writable()): ?>
 <form method="post" action="index.php?step=save_db_info">
   <fieldset>
     <legend>Database</legend>
@@ -13,7 +41,7 @@
           Database Name
         </td>
         <td>
-          <input name="dbname" value="<?= $dbname ?>"/>
+          <input name="dbname" value="gallery3"/>
         </td>
       </tr>
       <tr>
@@ -21,7 +49,7 @@
           User
         </td>
         <td>
-          <input name="dbuser" value="<?= $user ?>"/>
+          <input name="dbuser" value="root"/>
         </td>
       </tr>
       <tr>
@@ -29,7 +57,7 @@
           Password
         </td>
         <td>
-          <input name="dbpass" value="<?= $password ?>"/>
+          <input name="dbpass" value=""/>
         </td>
       </tr>
       <tr>
@@ -37,7 +65,7 @@
           Host
         </td>
         <td>
-          <input name="dbhost" value="<?= $host ?>"/>
+          <input name="dbhost" value="localhost"/>
         </td>
       </tr>
       <tr>
@@ -45,14 +73,19 @@
           Table Prefix
         </td>
         <td>
-          <input name="prefix" value="<?= $prefix ?>"/>
+          <input name="prefix" value=""/>
         </td>
       </tr>
       <tr>
         <td colspan="2">
+          <?php if (installer::var_writable()): ?>
           <input type="submit" value="Continue"/>
+          <?php else: ?>
+          <i class="error">(Please fix the photo storage problem before continuing)</i>
+          <?php endif ?>
         </td>
       </tr>
     </table>
   </fieldset>
 </form>
+<? endif ?>
diff --git a/installer/views/install.html.php b/installer/views/install.html.php
index 31112c28..a0eddaf3 100644
--- a/installer/views/install.html.php
+++ b/installer/views/install.html.php
@@ -8,8 +8,7 @@
     <div id="outer">
       <img src="../modules/gallery/images/gallery.png" />
       <div id="inner">
-        <?= $content ?>
-        <?= empty($database_form) ? "" : $database_form ?>
+        <?php print $content ?>
       </div>
       <div id="footer">
         <p>
diff --git a/installer/views/var_dir_status.html.php b/installer/views/var_dir_status.html.php
deleted file mode 100644
index 8211e13c..00000000
--- a/installer/views/var_dir_status.html.php
+++ /dev/null
@@ -1,30 +0,0 @@
-<?php defined("SYSPATH") or die("No direct script access.") ?>
-<h1> Welcome! </h1>
-<p>
-  Installing Gallery is very easy.  We just need to know how to talk
-  to your MySQL database, and we need a place to store your photos on
-  your web host.
-</p>
-
-
-<fieldset>
-  <legend>Photo Storage</legend>
-  <?php if (empty($writable)): ?>
-  <p class="error">
-    We're having trouble creating a place for your photos.  Can you
-    help?  Please create a directory called "var" using <code>mkdir var</code> in your
-    gallery3 directory, then run <code>chmod 777 var</code>.  That
-    should fix it.
-    <br/><br/>
-    <a href="index.php">Check again</a>
-    <br /><br/>
-    <i>(Please fix the photo storage problem before continuing)</i>
-  </p>
-  <?php else: ?>
-  <p class="success">
-    We've found a place to store your photos:
-    <code class="location"> <?= VARPATH ?> </code>
-  </p>
-  <?php endif ?>
-</fieldset>
-