Add first test; this verifies that we leave the ?> off at the end of PHP files.

1 files changed, 46 insertions, 0 deletions

diff --git a/core/tests/File_Structure_Test.php b/core/tests/File_Structure_Test.php
new file mode 100644
index 00000000..d0749062
--- /dev/null
+++ b/core/tests/File_Structure_Test.php
@@ -0,0 +1,46 @@
+<?php
+/**
+ * Gallery - a web based photo album viewer and editor
+ * Copyright (C) 2000-2008 Bharat Mediratta
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+class File_Structure_Test extends Unit_Test_Case {
+  public function no_trailing_closing_php_tag_test() {
+    $dir = new GalleryCodeFilterIterator(
+      new RecursiveIteratorIterator(new RecursiveDirectoryIterator(DOCROOT)));
+    foreach ($dir as $file) {
+      if (preg_match('/(\?\>\s*)$/', file_get_contents($file), $matches)) {
+	$this->assert_true(false, "$file ends in a trailing ?>");
+      }
+    }
+  }
+}
+
+class GalleryCodeFilterIterator extends FilterIterator {
+  public function accept() {
+    // Skip anything that we didn't write
+    $path_name = $this->getInnerIterator()->getPathName();
+    return !(strstr($path_name, ".svn") ||
+	     substr($path_name, -1, 1) == "~" ||
+	     strstr($path_name, SYSPATH) !== false ||
+	     strstr($path_name, MODPATH . 'forge') !== false ||
+	     strstr($path_name, MODPATH . 'unit_test') !== false ||
+	     strstr($path_name, MODPATH . 'mptt') !== false ||
+	     strstr($path_name, DOCROOT . 'var') !== false ||
+	     strstr($path_name, DOCROOT . 'test') !== false);
+  }
+}