Restructure the theme code to be more like WordPress / Habari. Now,

the controller initiates a request to a top level page (eg:
album.html.php) which is then free to include whatever other page
chunks it wants with calls like <?= $theme->display('header.html') ?>

Variables like $item and $children are in the global space for all
views.

theme.php helper is now Theme.php library which lets us store the name
of the theme inside the variable itself.  This means that the theme
does not have to know its own name because you can use $theme->url()
for all urls to stuff inside the theme itself, which makes it possible
to cline a theme without changing a single line.

Still using the mock album UI.

2 files changed, 2 insertions, 33 deletions

diff --git a/core/helpers/core_installer.php b/core/helpers/core_installer.php
index 9dd5224c..ea01a0c0 100644
--- a/core/helpers/core_installer.php
+++ b/core/helpers/core_installer.php
@@ -43,6 +43,7 @@ class core_installer {
 		   `id` int(9) NOT NULL auto_increment,
 		   `type` char(32) default NULL,
 		   `title` char(255) default NULL,
+		   `description` char(255) default NULL,
 		   `path` char(255) default NULL,
 		   `left` int(9) default NULL,
 		   `right` int(9) default NULL,
@@ -64,6 +65,7 @@ class core_installer {
 
       $root = ORM::factory("item");
       $root->title = "Gallery";
+      $root->description = "Welcome to your Gallery3";
       $root->make_root();
     }
   }
diff --git a/core/helpers/theme.php b/core/helpers/theme.php
deleted file mode 100644
index 5aa568c7..00000000
--- a/core/helpers/theme.php
+++ /dev/null
@@ -1,33 +0,0 @@
-<?php defined("SYSPATH") or die("No direct script access.");
-/**
- * Gallery - a web based photo album viewer and editor
- * Copyright (C) 2000-2008 Bharat Mediratta
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
- */
-class theme_Core {
-  public static $debug_backtrace = "debug_backtrace";
-
-  public static function url($path) {
-    // Using debug_backtrace() sucks.  But I don't know of another way to get
-    // the location of the caller without forcing them to pass it in as an argument, which
-    // makes for a crappy API.
-    $backtrace = call_user_func(theme::$debug_backtrace);
-    $calling_file = $backtrace[1]['file'];
-    $theme_name = substr($calling_file, strlen(THEMEPATH));
-    $theme_name = substr($theme_name, 0, strcspn($theme_name, "/"));
-    return url::base() . "themes/{$theme_name}/$path";
-  }
-}