diff options
| author | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
|---|---|---|
| committer | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
| commit | f3ba69c1d67c425ffa180d082a373e5cce0c86ce (patch) | |
| tree | 5ecbbe0ba96a94e3f4aadd26042c8ad1a32ef1bc /core/helpers/core_menu.php | |
| parent | 02af2d8b7639fdc18fba3d69a4ca0a3f5c92b948 (diff) | |
Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.
According to the PHP docs, the "public" keyword is implied on static
functions, so remove it. Also, require private static functions to
start with an _.
http://php.net/manual/en/language.oop5.visibility.php
Diffstat (limited to 'core/helpers/core_menu.php')
| -rw-r--r-- | core/helpers/core_menu.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/helpers/core_menu.php b/core/helpers/core_menu.php index 30c8e419..6246f3f6 100644 --- a/core/helpers/core_menu.php +++ b/core/helpers/core_menu.php @@ -18,7 +18,7 @@ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ class core_menu_Core { - public static function site($menu, $theme) { + static function site($menu, $theme) { $menu ->append(Menu::factory("link") ->id("browse") @@ -74,7 +74,7 @@ class core_menu_Core { } } - public static function album($menu, $theme) { + static function album($menu, $theme) { $menu ->append(Menu::factory("link") ->id("hybrid") @@ -83,7 +83,7 @@ class core_menu_Core { ->css_id("gHybridLink")); } - public static function photo($menu, $theme) { + static function photo($menu, $theme) { $menu ->append(Menu::factory("link") ->id("fullsize") @@ -97,7 +97,7 @@ class core_menu_Core { ->css_id("gAlbumLink")); } - public static function admin($menu, $theme) { + static function admin($menu, $theme) { $menu ->append(Menu::factory("link") ->id("dashboard") |