diff options
| author | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
|---|---|---|
| committer | Bharat Mediratta <bharat@menalto.com> | 2009-01-14 04:12:02 +0000 |
| commit | f3ba69c1d67c425ffa180d082a373e5cce0c86ce (patch) | |
| tree | 5ecbbe0ba96a94e3f4aadd26042c8ad1a32ef1bc /core/helpers/core_installer.php | |
| parent | 02af2d8b7639fdc18fba3d69a4ca0a3f5c92b948 (diff) | |
Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.
According to the PHP docs, the "public" keyword is implied on static
functions, so remove it. Also, require private static functions to
start with an _.
http://php.net/manual/en/language.oop5.visibility.php
Diffstat (limited to 'core/helpers/core_installer.php')
| -rw-r--r-- | core/helpers/core_installer.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/helpers/core_installer.php b/core/helpers/core_installer.php index 20edd47d..3ee67358 100644 --- a/core/helpers/core_installer.php +++ b/core/helpers/core_installer.php @@ -18,7 +18,7 @@ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ class core_installer { - public static function install() { + static function install() { $db = Database::instance(); $version = 0; try { @@ -246,7 +246,7 @@ class core_installer { } } - public static function uninstall() { + static function uninstall() { $db = Database::instance(); $db->query("DROP TABLE IF EXISTS `access_caches`;"); $db->query("DROP TABLE IF EXISTS `access_intents`;"); |