Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

1 files changed, 6 insertions, 6 deletions

diff --git a/core/helpers/core_event.php b/core/helpers/core_event.php
index f9ab2ed0..819a6a63 100644
--- a/core/helpers/core_event.php
+++ b/core/helpers/core_event.php
@@ -19,27 +19,27 @@
  */
 
 class core_event_Core {
-  public static function group_created($group) {
+  static function group_created($group) {
     access::add_group($group);
   }
 
-  public static function group_before_delete($group) {
+  static function group_before_delete($group) {
     access::delete_group($group);
   }
 
-  public static function photo_created($photo) {
+  static function photo_created($photo) {
     access::add_item($photo);
   }
 
-  public static function photo_before_delete($photo) {
+  static function photo_before_delete($photo) {
     access::delete_item($photo);
   }
 
-  public static function album_created($album) {
+  static function album_created($album) {
     access::add_item($album);
   }
 
-  public static function album_before_delete($album) {
+  static function album_before_delete($album) {
     access::delete_item($album);
   }
 }