Make sure that helper functions are all static. Add new

File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php

1 files changed, 3 insertions, 3 deletions

diff --git a/core/helpers/MY_url.php b/core/helpers/MY_url.php
index 12c51f8d..fa358543 100644
--- a/core/helpers/MY_url.php
+++ b/core/helpers/MY_url.php
@@ -21,7 +21,7 @@ class url extends url_Core {
   /**
    * Just like url::file() except that it returns an absolute URI
    */
-  public static function abs_file($path) {
+  static function abs_file($path) {
     return url::base(false, "http") . $path;
   }
 
@@ -29,14 +29,14 @@ class url extends url_Core {
    * Just like url::site() except that it returns an absolute URI and
    * doesn't take a protocol parameter.
    */
-  public static function abs_site($path) {
+  static function abs_site($path) {
     return url::site($path, "http");
   }
 
   /**
    * Just like url::current except that it returns an absolute URI
    */
-  public static function abs_current($qs=false) {
+  static function abs_current($qs=false) {
     return self::abs_site(url::current($qs));
   }
 }