Cache variables in core._cache so that we can retrieve them all in a

single query.  In most cases, we were fetching 4-5 variables per page
load, so this is 2-3x faster.

1 files changed, 4 insertions, 12 deletions

diff --git a/core/controllers/admin_advanced_settings.php b/core/controllers/admin_advanced_settings.php
index 1797b162..e8e608df 100644
--- a/core/controllers/admin_advanced_settings.php
+++ b/core/controllers/admin_advanced_settings.php
@@ -21,7 +21,9 @@ class Admin_Advanced_Settings_Controller extends Admin_Controller {
   public function index() {
     $view = new Admin_View("admin.html");
     $view->content = new View("admin_advanced_settings.html");
-    $view->content->vars = ORM::factory("var")->orderby("module_name", "name")->find_all();
+    $view->content->vars = ORM::factory("var")
+      ->orderby("module_name", "name")
+      ->find_all();
     print $view;
   }
 
@@ -41,17 +43,7 @@ class Admin_Advanced_Settings_Controller extends Admin_Controller {
   public function save($module_name, $var_name) {
     access::verify_csrf();
 
-    $var = ORM::factory("var")
-      ->where("module_name", $module_name)
-      ->where("name", $var_name)
-      ->find();
-    if (!$var->loaded) {
-      kohana::show_404();
-    }
-
-    $var->value = Input::instance()->post("value");
-    $var->save();
-
+    module::set_var($module_name, $var_name, Input::instance()->post("value"));
     message::success(
       t("Saved value for %var (%module_name)",
         array("var" => $var->name, "module_name" => $var->module_name)));