diff options
author | Tim Almdal <tnalmdal@shaw.ca> | 2008-12-07 21:52:06 +0000 |
---|---|---|
committer | Tim Almdal <tnalmdal@shaw.ca> | 2008-12-07 21:52:06 +0000 |
commit | eaffc5e085141a639c15699739b63368eccca945 (patch) | |
tree | 791f37c4021ce66368523126dc9258e312f5e210 | |
parent | 5f9e35bf93f25c272f89775e02149f81300d85df (diff) |
Changed how drawForms handles hidden fields. I make the assumption that hidden fields will never have an error or label so rather then recursing to draw the hidden fields, we just render them. Also moved the hidden fields outside the <ul>.
-rw-r--r-- | themes/default/views/form.html.php | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/themes/default/views/form.html.php b/themes/default/views/form.html.php index 6d527aed..86f1e38a 100644 --- a/themes/default/views/form.html.php +++ b/themes/default/views/form.html.php @@ -20,18 +20,23 @@ if (!function_exists("DrawForm")) { print "$prefix<fieldset>\n"; print "$prefix <legend>$input->name</legend>\n"; print "$prefix <ul>\n"; + DrawForm($input->inputs, $level + 2); - DrawForm($input->hidden, $level + 2); print "$prefix </ul>\n"; + + // Since hidden fields can only have name and value attributes lets just render it now + $hidden_prefix = "$prefix "; + foreach ($input->hidden as $hidden) { + print "$prefix {$hidden->render()}\n"; + } print "$prefix</fieldset>\n"; } else { if ($input->error_messages()) { print "$prefix<li class=\"gError\">\n"; - } else if ($input->class) { - print "$prefix<li>\n"; } else { - // no class means its a "hidden" so don't wrap it in <li> + print "$prefix<li>\n"; } + if ($input->label()) { print "$prefix {$input->label()}\n"; } @@ -46,9 +51,7 @@ if (!function_exists("DrawForm")) { print "$prefix </p>\n"; } } - if ($input->class) { - print "$prefix</li>\n"; - } + print "$prefix</li>\n"; } } } |