diff options
author | Bharat Mediratta <bharat@menalto.com> | 2011-01-11 21:21:59 -0800 |
---|---|---|
committer | Bharat Mediratta <bharat@menalto.com> | 2011-01-11 21:21:59 -0800 |
commit | 7eabf6c1c27c2c0e98895f663bb2853d72976e01 (patch) | |
tree | a0989b39530c63ac57d3b04d7888e63599f4794d | |
parent | 09d34696a12ae15f6c7378a64b2359465b2d7277 (diff) |
Use Math.round() instead of Number() to convert floating point numbers
to integer. Fixes overflow probelm that causes #1490. Thanks to
nkinkade for the fix.
-rw-r--r-- | lib/gallery.common.js | 8 | ||||
-rw-r--r-- | lib/gallery.show_full_size.js | 6 |
2 files changed, 8 insertions, 6 deletions
diff --git a/lib/gallery.common.js b/lib/gallery.common.js index 2dbd7c7c..697a33cb 100644 --- a/lib/gallery.common.js +++ b/lib/gallery.common.js @@ -171,10 +171,10 @@ // handle the case where the calculation is almost zero (2.14e-14) return { - top: Number((height - imageHeight) / 2), - left: Number((width - imageWidth) / 2), - width: Number(imageWidth), - height: Number(imageHeight) + top: Math.round((height - imageHeight) / 2), + left: Math.round((width - imageWidth) / 2), + width: Math.round(imageWidth), + height: Math.round(imageHeight) }; }; diff --git a/lib/gallery.show_full_size.js b/lib/gallery.show_full_size.js index 9eb6f3af..531d2a3a 100644 --- a/lib/gallery.show_full_size.js +++ b/lib/gallery.show_full_size.js @@ -20,8 +20,10 @@ image_size = $.gallery_auto_fit_window(image_width, image_height); } else { image_size = { - top: Number((height - image_height) / 2), left: Number((width - image_width) / 2), - width: Number(image_width), height: Number(image_height) + top: Math.round((height - image_height) / 2), + left: Math.round((width - image_width) / 2), + width: Math.round(image_width), + height: Math.round(image_height) }; } |