From 5400c4be26a809be8b0571f1291aa528ef39b743 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta <bharat@menalto.com>
Date: Mon, 7 May 2012 13:45:13 -0700
Subject: Oops, fix up a bug originally added in
 7d66ab2e949bc915f108737f08cac2f9057ef729 when I tweaked the name of the
 rss_available variable to be rss_visible, but got it wrong.  Bump the comment
 module to 6 so that we run the installer and clean up old vars.

Fixes #1854.
---
 modules/comment/controllers/admin_comments.php |  4 ++--
 modules/comment/helpers/comment_installer.php  | 14 ++++++++++++--
 modules/comment/module.info                    |  2 +-
 3 files changed, 15 insertions(+), 5 deletions(-)

(limited to 'modules')

diff --git a/modules/comment/controllers/admin_comments.php b/modules/comment/controllers/admin_comments.php
index bcd6a939..00a7a608 100644
--- a/modules/comment/controllers/admin_comments.php
+++ b/modules/comment/controllers/admin_comments.php
@@ -32,8 +32,8 @@ class Admin_Comments_Controller extends Admin_Controller {
     $form->validate();
     module::set_var("comment", "access_permissions",
                     $form->comment_settings->access_permissions->value);
-    module::set_var("comment", "rss_available",
-                    $form->comment_settings->rss_available->value);
+    module::set_var("comment", "rss_visible",
+                    $form->comment_settings->rss_visible->value);
     message::success(t("Comment settings updated"));
     url::redirect("admin/comments");
   }
diff --git a/modules/comment/helpers/comment_installer.php b/modules/comment/helpers/comment_installer.php
index a64064f6..cbb8c783 100644
--- a/modules/comment/helpers/comment_installer.php
+++ b/modules/comment/helpers/comment_installer.php
@@ -48,8 +48,8 @@ class comment_installer {
 
     module::set_var("comment", "spam_caught", 0);
     module::set_var("comment", "access_permissions", "everybody");
-    module::set_var("comment", "rss_available", "both");
-    module::set_version("comment", 5);
+    module::set_var("comment", "rss_visible", "both");
+    module::set_version("comment", 6);
   }
 
   static function upgrade($version) {
@@ -81,6 +81,16 @@ class comment_installer {
       module::set_var("comment", "rss_visible", "all");
       module::set_version("comment", $version = 5);
     }
+
+    // In version 5 we accidentally set the installer variable to rss_available when it should
+    // have been rss_visible.  Migrate it over now, if necessary.
+    if ($version == 5) {
+      if (!module::get_var("comment", "rss_visible")) {
+        module::set_var("comment", "rss_visible", module::get_var("comment", "rss_available"));
+      }
+      module::clear_var("comment", "rss_available");
+      module::set_version("comment", $version = 6);
+    }
   }
 
   static function uninstall() {
diff --git a/modules/comment/module.info b/modules/comment/module.info
index ecbf8885..bd4abe9f 100644
--- a/modules/comment/module.info
+++ b/modules/comment/module.info
@@ -1,6 +1,6 @@
 name = "Comments"
 description = "Allows users and guests to leave comments on photos and albums."
-version = 5
+version = 6
 author_name = "Gallery Team"
 author_url = "http://codex.gallery2.org/Gallery:Team"
 info_url = "http://codex.gallery2.org/Gallery3:Modules:comment"
-- 
cgit v1.2.3