From d398651c080c18e4f1bf623548091465dac1d528 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta <bharat@menalto.com>
Date: Tue, 7 Sep 2010 00:34:41 -0700
Subject: Disable selectFirst in the autocomplete box, which makes it a little
 harder to select pre-existing tags, but avoids the problem where we force the
 user to pick from existing tags.  Fixes ticket #1339

---
 modules/tag/views/tag_block.html.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'modules/tag')

diff --git a/modules/tag/views/tag_block.html.php b/modules/tag/views/tag_block.html.php
index 8b887282..cc204c72 100644
--- a/modules/tag/views/tag_block.html.php
+++ b/modules/tag/views/tag_block.html.php
@@ -7,7 +7,8 @@
         max: 30,
         multiple: true,
         multipleSeparator: ',',
-        cacheLength: 1
+        cacheLength: 1,
+        selectFirst: false,
       }
     );
     $("#g-add-tag-form").ajaxForm({
@@ -24,4 +25,4 @@
 <div id="g-tag-cloud" ref="<?= url::site("tags") ?>">
   <?= $cloud ?>
 </div>
-<?= $form ?>
\ No newline at end of file
+<?= $form ?>
-- 
cgit v1.2.3


From cef7ca9cf27dc7bcdbc92e754cfe9ae3a30ae3b0 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta <bharat@menalto.com>
Date: Sat, 11 Sep 2010 10:26:48 -0700
Subject: Change tag url form to be /tag/{name} from /tags/show/{id}.  This is
 a much friendlier url format.  Fixes ticket #1363.

---
 modules/tag/controllers/tag.php  | 49 ++++++++++++++++++++++++++++++++++++++++
 modules/tag/controllers/tags.php | 28 -----------------------
 modules/tag/models/tag.php       |  2 +-
 3 files changed, 50 insertions(+), 29 deletions(-)
 create mode 100644 modules/tag/controllers/tag.php

(limited to 'modules/tag')

diff --git a/modules/tag/controllers/tag.php b/modules/tag/controllers/tag.php
new file mode 100644
index 00000000..0e924f3d
--- /dev/null
+++ b/modules/tag/controllers/tag.php
@@ -0,0 +1,49 @@
+<?php defined("SYSPATH") or die("No direct script access.");
+/**
+ * Gallery - a web based photo album viewer and editor
+ * Copyright (C) 2000-2010 Bharat Mediratta
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+class Tag_Controller extends Controller {
+  public function __call($function, $args) {
+    $tag_name = $function;
+    $tag = ORM::factory("tag")->where("name", "=", $tag_name)->find();
+    $page_size = module::get_var("gallery", "page_size", 9);
+    $page = (int) Input::instance()->get("page", "1");
+    $children_count = $tag->items_count();
+    $offset = ($page-1) * $page_size;
+    $max_pages = max(ceil($children_count / $page_size), 1);
+
+    // Make sure that the page references a valid offset
+    if ($page < 1) {
+      url::redirect($album->abs_url());
+    } else if ($page > $max_pages) {
+      url::redirect($album->abs_url("page=$max_pages"));
+    }
+
+    $template = new Theme_View("page.html", "collection", "tag");
+    $template->set_global("page", $page);
+    $template->set_global("max_pages", $max_pages);
+    $template->set_global("page_size", $page_size);
+    $template->set_global("tag", $tag);
+    $template->set_global("children", $tag->items($page_size, $offset));
+    $template->set_global("children_count", $children_count);
+    $template->content = new View("dynamic.html");
+    $template->content->title = t("Tag: %tag_name", array("tag_name" => $tag->name));
+
+    print $template;
+  }
+}
diff --git a/modules/tag/controllers/tags.php b/modules/tag/controllers/tags.php
index bc657644..aa39b6cd 100644
--- a/modules/tag/controllers/tags.php
+++ b/modules/tag/controllers/tags.php
@@ -18,34 +18,6 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 class Tags_Controller extends Controller {
-  public function show($tag_id) {
-    $tag = ORM::factory("tag", $tag_id);
-    $page_size = module::get_var("gallery", "page_size", 9);
-    $page = (int) Input::instance()->get("page", "1");
-    $children_count = $tag->items_count();
-    $offset = ($page-1) * $page_size;
-    $max_pages = max(ceil($children_count / $page_size), 1);
-
-    // Make sure that the page references a valid offset
-    if ($page < 1) {
-      url::redirect($album->abs_url());
-    } else if ($page > $max_pages) {
-      url::redirect($album->abs_url("page=$max_pages"));
-    }
-
-    $template = new Theme_View("page.html", "collection", "tag");
-    $template->set_global("page", $page);
-    $template->set_global("max_pages", $max_pages);
-    $template->set_global("page_size", $page_size);
-    $template->set_global("tag", $tag);
-    $template->set_global("children", $tag->items($page_size, $offset));
-    $template->set_global("children_count", $children_count);
-    $template->content = new View("dynamic.html");
-    $template->content->title = t("Tag: %tag_name", array("tag_name" => $tag->name));
-
-    print $template;
-  }
-
   public function index() {
     // Far from perfection, but at least require view permission for the root album
     $album = ORM::factory("item", 1);
diff --git a/modules/tag/models/tag.php b/modules/tag/models/tag.php
index e8bd69c5..269a0f39 100644
--- a/modules/tag/models/tag.php
+++ b/modules/tag/models/tag.php
@@ -124,7 +124,7 @@ class Tag_Model extends ORM {
    * @param string $query the query string (eg "page=3")
    */
   public function url($query=null) {
-    $url = url::site("tags/show/$this->id");
+    $url = url::site("tag/{$this->name}");
     if ($query) {
       $url .= "?$query";
     }
-- 
cgit v1.2.3


From ac64614d4da7174c085f257f3b8e39aa7afa9eb5 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Sun, 12 Sep 2010 10:53:06 -0700
Subject: Path for ticket #1140. Add a size0 to the tag cloud.

---
 modules/tag/css/tag.css | 6 ++++++
 1 file changed, 6 insertions(+)

(limited to 'modules/tag')

diff --git a/modules/tag/css/tag.css b/modules/tag/css/tag.css
index 6d6438e3..8a64960a 100644
--- a/modules/tag/css/tag.css
+++ b/modules/tag/css/tag.css
@@ -19,6 +19,12 @@
   display: none;
 }
 
+#g-tag-cloud ul li.size0 a {
+  color: #9cf;
+  font-size: 70%;
+  font-weight: 100;
+}
+
 #g-tag-cloud ul li.size1 a {
   color: #9cf;
   font-size: 80%;
-- 
cgit v1.2.3