From a5670d8d708c35589a695640694199c7b026877b Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sat, 30 May 2009 17:14:17 -0700 Subject: gate $can_edit and $can_add on whether or not we have an $item at all (fixes a bug where search doesn't render because it has no item). --- modules/gallery/helpers/gallery_menu.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/gallery') diff --git a/modules/gallery/helpers/gallery_menu.php b/modules/gallery/helpers/gallery_menu.php index 0f0e676d..09c2d91a 100644 --- a/modules/gallery/helpers/gallery_menu.php +++ b/modules/gallery/helpers/gallery_menu.php @@ -28,8 +28,8 @@ class gallery_menu_Core { $item = $theme->item(); - $can_edit = access::can("edit", $item) || $is_admin; - $can_add = access::can("add", $item) || $is_admin; + $can_edit = $item && access::can("edit", $item) || $is_admin; + $can_add = $item && (access::can("add", $item) || $is_admin); if ($item && $can_edit || $can_add) { $menu->append($options_menu = Menu::factory("submenu") -- cgit v1.2.3 From ad81861c331f60ec8c19ea11e47e2826660fa142 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 00:11:02 -0700 Subject: First pass at an XSS security test, along with the "p" helper which can clean HTML output. --- modules/gallery/helpers/p.php | 33 +++++++ modules/gallery/tests/Xss_Security_Test.php | 138 ++++++++++++++++++++++++++++ 2 files changed, 171 insertions(+) create mode 100644 modules/gallery/helpers/p.php create mode 100644 modules/gallery/tests/Xss_Security_Test.php (limited to 'modules/gallery') diff --git a/modules/gallery/helpers/p.php b/modules/gallery/helpers/p.php new file mode 100644 index 00000000..69032840 --- /dev/null +++ b/modules/gallery/helpers/p.php @@ -0,0 +1,33 @@ +purify($dirty_html)); + } + + function clean($dirty_html) { + // return $dirty_html; + return htmlentities($dirty_html, ENT_QUOTES); + // return Purify::instance()->purify($dirty_html); + } +} diff --git a/modules/gallery/tests/Xss_Security_Test.php b/modules/gallery/tests/Xss_Security_Test.php new file mode 100644 index 00000000..22c4a767 --- /dev/null +++ b/modules/gallery/tests/Xss_Security_Test.php @@ -0,0 +1,138 @@ + array(), "t2" => array()); + $token_number = 0; + // Filter out HTML / whitespace, and build a lookup for global function calls. + foreach ($raw_tokens as $token) { + if ((!is_array($token)) || (($token[0] != T_WHITESPACE) && ($token[0] != T_INLINE_HTML))) { + if (is_array($token)) { + if ($token[0] == T_STRING && in_array($token[1], array("t", "t2"))) { + $func_token_list[$token[1]][] = $token_number; + } + } + $tokens[] = $token; + $token_number++; + } + } + unset($raw_tokens); + + if (!empty($func_token_list["t"])) { + l10n_scanner::_parse_t_calls($tokens, $func_token_list["t"], $cache); + } + if (!empty($func_token_list["t2"])) { + l10n_scanner::_parse_plural_calls($tokens, $func_token_list["t2"], $cache); + } + } + + public function find_unescaped_variables_in_views_test() { + // foreach (glob("*/*/views/*.php") as $view) { + foreach (array("modules/search/views/search.html.php") as $view) { + $expr = null; + $line = null; + $level = 0; + $php = 0; + $str = null; + $in_p_clean = 0; + foreach (token_get_all(file_get_contents($view)) as $token) { + if (false /* useful for debugging */) { + if (is_array($token)) { + printf("[$str] [$in_p_clean] %-15s %s\n", token_name($token[0]), $token[1]); + } else { + printf("[$str] [$in_p_clean] %-15s %s\n", "", $token); + } + } + + // If we find a "(" after a "p::clean" then start counting levels of parens and assume + // that we're inside a p::clean() call until we find the matching close paren. + if ($token[0] == "(" && $str == "p::clean") { + $in_p_clean = 1; + } else if ($token[0] == "(" && $in_p_clean) { + $in_p_clean++; + } else if ($token[0] == ")" && $in_p_clean) { + $in_p_clean--; + } + + // Concatenate runs of strings for convenience, which we use above to figure out if we're + // inside a p::clean() call or not + if ($token[0] == T_STRING || $token[0] == T_DOUBLE_COLON) { + $str .= $token[1]; + } else { + $str = null; + } + + // Scan for any occurrences of < ? = $variable ? > and store it in $expr + if ($token[0] == T_OPEN_TAG_WITH_ECHO) { + $php++; + } else if ($php && $token[0] == T_CLOSE_TAG) { + $php--; + } else if ($php && $token[0] == T_VARIABLE) { + if (!$expr) { + $entry = array($token[2], $in_p_clean); + } + $expr .= $token[1]; + } else if ($expr) { + if ($token[0] == T_OBJECT_OPERATOR) { + $expr .= $token[1]; + } else if ($token[0] == T_STRING) { + $expr .= $token[1]; + } else if ($token == "(") { + $expr .= $token; + $level++; + } else if ($level > 0 && $token == ")") { + $expr .= $token; + $level--; + } else if ($level > 0) { + $expr .= is_array($token) ? $token[1] : $token; + } else { + $entry[] = $expr; + $found[$view][] = $entry; + $expr = null; + $entry = null; + } + } + } + } + + $canonical = MODPATH . "gallery/tests/xss_data.txt"; + $new = TMPPATH . "xss_data.txt"; + $fd = fopen($new, "wb"); + ksort($found); + foreach ($found as $view => $entries) { + foreach ($entries as $entry) { + fwrite($fd, + sprintf("%-60s %-3s %-9s %s\n", + $view, $entry[0], $entry[1] ? "CLEAN" : "NOT_CLEAN", $entry[2])); + } + } + fclose($fd); + + exec("diff $canonical $new", $output, $return_value); + $this->assert_false( + $return_value, "XSS golden file mismatch. Output:\n" . implode("\n", $output) ); + } +} -- cgit v1.2.3 From 708f27f483d70660446ea2132b02cb7b39225f98 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 00:11:48 -0700 Subject: Run p::clean() on any variables that contain data entered by users. --- .../comment/views/admin_block_recent_comments.html.php | 6 +++--- modules/comment/views/admin_comments.html.php | 10 +++++----- modules/comment/views/comment.html.php | 6 +++--- modules/comment/views/comments.html.php | 6 +++--- modules/exif/views/exif_dialog.html.php | 4 ++-- modules/gallery/views/admin_advanced_settings.html.php | 8 ++++---- modules/gallery/views/admin_block_log_entries.html.php | 2 +- .../gallery/views/admin_block_photo_stream.html.php | 4 ++-- modules/gallery/views/admin_maintenance.html.php | 2 +- modules/gallery/views/after_install.html.php | 2 +- modules/gallery/views/move_tree.html.php | 8 ++++---- modules/gallery/views/permissions_browse.html.php | 4 ++-- modules/gallery/views/permissions_form.html.php | 2 +- modules/gallery/views/simple_uploader.html.php | 6 +++--- modules/info/views/info_block.html.php | 8 ++++---- modules/notification/views/comment_published.html.php | 18 +++++++++++------- modules/notification/views/item_added.html.php | 14 +++++++++----- modules/search/views/search.html.php | 10 ++++++---- 18 files changed, 65 insertions(+), 55 deletions(-) (limited to 'modules/gallery') diff --git a/modules/comment/views/admin_block_recent_comments.html.php b/modules/comment/views/admin_block_recent_comments.html.php index d7b8d2b0..d5aab84c 100644 --- a/modules/comment/views/admin_block_recent_comments.html.php +++ b/modules/comment/views/admin_block_recent_comments.html.php @@ -4,13 +4,13 @@
  • "> " class="gAvatar" - alt="author_name() ?>" + alt="author_name()) ?>" width="32" height="32" /> created) ?> %author_name said %comment_text", - array("author_name" => $comment->author_name(), - "comment_text" => text::limit_words($comment->text, 50))); ?> + array("author_name" => p::clean($comment->author_name()), + "comment_text" => text::limit_words(p::clean($comment->text), 50))); ?>
    • diff --git a/modules/comment/views/admin_comments.html.php b/modules/comment/views/admin_comments.html.php index 16816636..79bdb1f3 100644 --- a/modules/comment/views/admin_comments.html.php +++ b/modules/comment/views/admin_comments.html.php @@ -108,12 +108,12 @@ " class="gAvatar" - alt="author_name() ?>" + alt="author_name()) ?>" width="40" height="40" /> -

    author_name() ?>

    +

    author_name()) ?>

    @@ -122,7 +122,7 @@ has_thumb()): ?> <?= $item->title ?>thumb_width, $item->thumb_height, 75) ?> /> @@ -132,7 +132,7 @@

    created); ?>

    - text ?> + text) ?>
      diff --git a/modules/comment/views/comment.html.php b/modules/comment/views/comment.html.php index 1a674142..0337173b 100644 --- a/modules/comment/views/comment.html.php +++ b/modules/comment/views/comment.html.php @@ -4,14 +4,14 @@ " class="gAvatar" - alt="author_name() ?>" + alt="author_name()) ?>" width="40" height="40" /> created) ?> - author_name() ?> + author_name()) ?>

      - text ?> + text) ?>
      diff --git a/modules/comment/views/comments.html.php b/modules/comment/views/comments.html.php index 25928ab5..95f07baf 100644 --- a/modules/comment/views/comments.html.php +++ b/modules/comment/views/comments.html.php @@ -12,16 +12,16 @@ " class="gAvatar" - alt="author_name() ?>" + alt="author_name()) ?>" width="40" height="40" /> %name said", array("date" => date("Y-M-d H:i:s", $comment->created), - "name" => $comment->author_name())); ?> + "name" => p::clean($comment->author_name()))); ?>

      - text ?> + text) ?>
      diff --git a/modules/exif/views/exif_dialog.html.php b/modules/exif/views/exif_dialog.html.php index d7985a30..6494b2b0 100644 --- a/modules/exif/views/exif_dialog.html.php +++ b/modules/exif/views/exif_dialog.html.php @@ -14,14 +14,14 @@ - + - + diff --git a/modules/gallery/views/admin_advanced_settings.html.php b/modules/gallery/views/admin_advanced_settings.html.php index 9f90d671..77aff050 100644 --- a/modules/gallery/views/admin_advanced_settings.html.php +++ b/modules/gallery/views/admin_advanced_settings.html.php @@ -20,12 +20,12 @@ module_name == "gallery" && $var->name == "_cache") continue ?> module_name ?> - name ?> + name) ?> - module_name/$var->name") ?>" + module_name/" . p::clean($var->name)) ?>" class="gDialogLink" - title=" $var->name, "module_name" => $var->module_name)) ?>"> - value ?> + title=" p::clean($var->name), "module_name" => $var->module_name)) ?>"> + value) ?> diff --git a/modules/gallery/views/admin_block_log_entries.html.php b/modules/gallery/views/admin_block_log_entries.html.php index db6313e1..5d8f3084 100644 --- a/modules/gallery/views/admin_block_log_entries.html.php +++ b/modules/gallery/views/admin_block_log_entries.html.php @@ -2,7 +2,7 @@
      • - user_id") ?>">user->name ?> + user_id") ?>">user->name) ?> timestamp) ?> message ?> html ?> diff --git a/modules/gallery/views/admin_block_photo_stream.html.php b/modules/gallery/views/admin_block_photo_stream.html.php index e8a4d933..1e1329d1 100644 --- a/modules/gallery/views/admin_block_photo_stream.html.php +++ b/modules/gallery/views/admin_block_photo_stream.html.php @@ -2,9 +2,9 @@
        • - id") ?>" title="title ?>"> + id") ?>" title="title) ?>"> width, $photo->height, 72) ?> - src="thumb_url() ?>" alt="title ?>" /> + src="thumb_url() ?>" alt="title) ?>" />
          • diff --git a/modules/gallery/views/admin_maintenance.html.php b/modules/gallery/views/admin_maintenance.html.php index bc060a7b..66c4eea0 100644 --- a/modules/gallery/views/admin_maintenance.html.php +++ b/modules/gallery/views/admin_maintenance.html.php @@ -90,7 +90,7 @@ status ?> - owner()->name ?> + owner()->name) ?> state == "stalled"): ?> diff --git a/modules/gallery/views/after_install.html.php b/modules/gallery/views/after_install.html.php index aa26858a..d6ba8e7c 100644 --- a/modules/gallery/views/after_install.html.php +++ b/modules/gallery/views/after_install.html.php @@ -8,7 +8,7 @@

          - %user_name account. The very first thing you should do is to change your password to something that you'll remember.", array("user_name" => $user->name)) ?> + %user_name account. The very first thing you should do is to change your password to something that you'll remember.", array("user_name" => p::clean($user->name))) ?>

          diff --git a/modules/gallery/views/move_tree.html.php b/modules/gallery/views/move_tree.html.php index a3a4bc8f..91a2f9da 100644 --- a/modules/gallery/views/move_tree.html.php +++ b/modules/gallery/views/move_tree.html.php @@ -1,18 +1,18 @@ thumb_tag(array(), 25); ?> is_descendant($parent)): ?> - title ?> + title) ?> - title ?> + title) ?>

          • thumb_tag(array(), 25); ?> is_descendant($child)): ?> - title ?> + title) ?> - title ?> + title) ?>
            • diff --git a/modules/gallery/views/permissions_browse.html.php b/modules/gallery/views/permissions_browse.html.php index 749bee4f..5cd9cf82 100644 --- a/modules/gallery/views/permissions_browse.html.php +++ b/modules/gallery/views/permissions_browse.html.php @@ -35,14 +35,14 @@
          • - title ?> + title) ?>
            • - title ?> + title) ?>
              diff --git a/modules/gallery/views/permissions_form.html.php b/modules/gallery/views/permissions_form.html.php index 94103705..adf2bd94 100644 --- a/modules/gallery/views/permissions_form.html.php +++ b/modules/gallery/views/permissions_form.html.php @@ -6,7 +6,7 @@ - name ?> + name) ?> diff --git a/modules/gallery/views/simple_uploader.html.php b/modules/gallery/views/simple_uploader.html.php index b6725c31..abda6d26 100644 --- a/modules/gallery/views/simple_uploader.html.php +++ b/modules/gallery/views/simple_uploader.html.php @@ -5,7 +5,7 @@
              ">
              - $item->title)) ?> + p::clean($item->title))) ?>
              @@ -25,9 +25,9 @@

                parents() as $parent): ?> -
              • title ?>
                • +
              • title) ?>
                • -
              • title ?>
                • +
              • title) ?>

              diff --git a/modules/info/views/info_block.html.php b/modules/info/views/info_block.html.php index 880d5d3e..db664894 100644 --- a/modules/info/views/info_block.html.php +++ b/modules/info/views/info_block.html.php @@ -3,18 +3,18 @@ - title; ?> + title) ?> description): ?> - description; ?> + description) ?> id != 1): ?> - name; ?> + name) ?> captured): ?> @@ -26,7 +26,7 @@ owner): ?> - owner->name ?> + owner->name) ?> diff --git a/modules/notification/views/comment_published.html.php b/modules/notification/views/comment_published.html.php index 23588c72..ff2ba0bc 100644 --- a/modules/notification/views/comment_published.html.php +++ b/modules/notification/views/comment_published.html.php @@ -1,30 +1,34 @@ - <?= $subject ?> + <?= p::clean($subject) ?> -

              +

              - + - + - + - + - +
              text ?>text) ?>
              author_name() ?>author_name()) ?>
              author_email() ?>author_email()) ?>
              author_url() ?>author_url()) ?>
              item()->url(array(), true) ?>#comments + + item()->url(array(), true) ?>#comments + +
              diff --git a/modules/notification/views/item_added.html.php b/modules/notification/views/item_added.html.php index b67b9f38..32857c08 100644 --- a/modules/notification/views/item_added.html.php +++ b/modules/notification/views/item_added.html.php @@ -1,23 +1,27 @@ - <?= $subject ?> + <?= p::clean($subject) ?> -

              +

              - + - + description): ?> - +
              title ?>title) ?>
              url(array(), true) ?> + + url(array(), true) ?> + +
              description ?>description) ?>
              diff --git a/modules/search/views/search.html.php b/modules/search/views/search.html.php index fb1fd8a9..de4343ae 100644 --- a/modules/search/views/search.html.php +++ b/modules/search/views/search.html.php @@ -8,7 +8,7 @@
              -- cgit v1.2.3 From a049de28ace48a3970371caf24d7c389d8d93cd7 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 00:13:28 -0700 Subject: Update the clean/dirty format, check all ffiles instead of just one (which was for debugging) --- modules/gallery/tests/Xss_Security_Test.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'modules/gallery') diff --git a/modules/gallery/tests/Xss_Security_Test.php b/modules/gallery/tests/Xss_Security_Test.php index 22c4a767..8bee8c42 100644 --- a/modules/gallery/tests/Xss_Security_Test.php +++ b/modules/gallery/tests/Xss_Security_Test.php @@ -50,8 +50,7 @@ class Xss_Security_Test extends Unit_Test_Case { } public function find_unescaped_variables_in_views_test() { - // foreach (glob("*/*/views/*.php") as $view) { - foreach (array("modules/search/views/search.html.php") as $view) { + foreach (glob("*/*/views/*.php") as $view) { $expr = null; $line = null; $level = 0; @@ -125,8 +124,8 @@ class Xss_Security_Test extends Unit_Test_Case { foreach ($found as $view => $entries) { foreach ($entries as $entry) { fwrite($fd, - sprintf("%-60s %-3s %-9s %s\n", - $view, $entry[0], $entry[1] ? "CLEAN" : "NOT_CLEAN", $entry[2])); + sprintf("%-60s %-3s %-5s %s\n", + $view, $entry[0], $entry[1] ? "CLEAN" : "DIRTY", $entry[2])); } } fclose($fd); -- cgit v1.2.3 From af0031e02946a53062ce2c9dd209a50fb1a12e0c Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 01:10:52 -0700 Subject: Xss scanner golden file. Up to date. --- modules/gallery/tests/xss_data.txt | 618 +++++++++++++++++++++++++++++++++++++ 1 file changed, 618 insertions(+) create mode 100644 modules/gallery/tests/xss_data.txt (limited to 'modules/gallery') diff --git a/modules/gallery/tests/xss_data.txt b/modules/gallery/tests/xss_data.txt new file mode 100644 index 00000000..68bf2302 --- /dev/null +++ b/modules/gallery/tests/xss_data.txt @@ -0,0 +1,618 @@ +modules/akismet/views/admin_akismet.html.php 14 DIRTY $form +modules/akismet/views/admin_akismet_stats.html.php 9 DIRTY $api_key +modules/akismet/views/admin_akismet_stats.html.php 9 DIRTY $blog_url +modules/comment/views/admin_block_recent_comments.html.php 4 DIRTY $i +modules/comment/views/admin_block_recent_comments.html.php 5 DIRTY $comment->author()->avatar_url(32, $theme->url("images/avatar.jpg", true)) +modules/comment/views/admin_block_recent_comments.html.php 7 CLEAN $comment->author_name() +modules/comment/views/admin_block_recent_comments.html.php 10 DIRTY $comment->created +modules/comment/views/admin_block_recent_comments.html.php 12 CLEAN $comment->author_name() +modules/comment/views/admin_block_recent_comments.html.php 13 CLEAN $comment->text +modules/comment/views/admin_comments.html.php 4 DIRTY $csrf +modules/comment/views/admin_comments.html.php 15 DIRTY $csrf +modules/comment/views/admin_comments.html.php 42 DIRTY $menu +modules/comment/views/admin_comments.html.php 65 DIRTY $spam_caught +modules/comment/views/admin_comments.html.php 72 DIRTY $counts->spam +modules/comment/views/admin_comments.html.php 75 DIRTY $csrf +modules/comment/views/admin_comments.html.php 106 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 106 DIRTY $i +modules/comment/views/admin_comments.html.php 109 DIRTY $comment->author()->avatar_url(40, $theme->url("images/avatar.jpg", true)) +modules/comment/views/admin_comments.html.php 111 CLEAN $comment->author_name() +modules/comment/views/admin_comments.html.php 115 CLEAN $comment->author_email() +modules/comment/views/admin_comments.html.php 116 CLEAN $comment->author_email() +modules/comment/views/admin_comments.html.php 116 CLEAN $comment->author_name() +modules/comment/views/admin_comments.html.php 122 DIRTY $item->url() +modules/comment/views/admin_comments.html.php 124 DIRTY $item->thumb_url() +modules/comment/views/admin_comments.html.php 125 CLEAN $item->title +modules/comment/views/admin_comments.html.php 126 DIRTY $item->thumb_width +modules/comment/views/admin_comments.html.php 126 DIRTY $item->thumb_height +modules/comment/views/admin_comments.html.php 134 DIRTY $comment->created +modules/comment/views/admin_comments.html.php 135 CLEAN $comment->text +modules/comment/views/admin_comments.html.php 141 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 150 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 159 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 167 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 174 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 181 DIRTY $comment->id +modules/comment/views/admin_comments.html.php 194 DIRTY $pager +modules/comment/views/comment.html.php 2 DIRTY $comment->id +modules/comment/views/comment.html.php 5 DIRTY $comment->author()->avatar_url(40, $theme->url("images/avatar.jpg", true)) +modules/comment/views/comment.html.php 7 CLEAN $comment->author_name() +modules/comment/views/comment.html.php 11 DIRTY $comment->created +modules/comment/views/comment.html.php 12 CLEAN $comment->author_name() +modules/comment/views/comment.html.php 15 CLEAN $comment->text +modules/comment/views/comments.html.php 10 DIRTY $comment->id +modules/comment/views/comments.html.php 13 DIRTY $comment->author()->avatar_url(40, $theme->url("images/avatar.jpg", true)) +modules/comment/views/comments.html.php 15 CLEAN $comment->author_name() +modules/comment/views/comments.html.php 20 DIRTY $comment->created +modules/comment/views/comments.html.php 21 CLEAN $comment->author_name() +modules/comment/views/comments.html.php 24 CLEAN $comment->text +modules/exif/views/exif_dialog.html.php 14 DIRTY $details +modules/exif/views/exif_dialog.html.php 14 DIRTY $i +modules/exif/views/exif_dialog.html.php 17 CLEAN $details +modules/exif/views/exif_dialog.html.php 17 CLEAN $i +modules/exif/views/exif_dialog.html.php 21 DIRTY $details +modules/exif/views/exif_dialog.html.php 21 DIRTY $i +modules/exif/views/exif_dialog.html.php 24 CLEAN $details +modules/exif/views/exif_dialog.html.php 24 CLEAN $i +modules/exif/views/exif_sidebar.html.php 2 DIRTY $item->id +modules/g2_import/views/admin_g2_import.html.php 8 DIRTY $form +modules/g2_import/views/admin_g2_import.html.php 26 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 29 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 32 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 35 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 38 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 41 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 45 DIRTY $g2_stats +modules/g2_import/views/admin_g2_import.html.php 53 DIRTY $g2_sizes +modules/g2_import/views/admin_g2_import.html.php 54 DIRTY $thumb_size +modules/g2_import/views/admin_g2_import.html.php 62 DIRTY $g2_sizes +modules/g2_import/views/admin_g2_import.html.php 63 DIRTY $resize_size +modules/gallery/views/admin_advanced_settings.html.php 22 DIRTY $var->module_name +modules/gallery/views/admin_advanced_settings.html.php 23 CLEAN $var->name +modules/gallery/views/admin_advanced_settings.html.php 25 DIRTY $var->module_name +modules/gallery/views/admin_advanced_settings.html.php 25 CLEAN $var->name +modules/gallery/views/admin_advanced_settings.html.php 27 CLEAN $var->name +modules/gallery/views/admin_advanced_settings.html.php 27 DIRTY $var->module_name +modules/gallery/views/admin_advanced_settings.html.php 28 CLEAN $var->value +modules/gallery/views/admin_block_log_entries.html.php 4 DIRTY $entry->severity +modules/gallery/views/admin_block_log_entries.html.php 5 DIRTY $entry->user_id +modules/gallery/views/admin_block_log_entries.html.php 5 CLEAN $entry->user->name +modules/gallery/views/admin_block_log_entries.html.php 6 DIRTY $entry->timestamp +modules/gallery/views/admin_block_log_entries.html.php 7 DIRTY $entry->message +modules/gallery/views/admin_block_log_entries.html.php 8 DIRTY $entry->html +modules/gallery/views/admin_block_news.html.php 5 DIRTY $entry +modules/gallery/views/admin_block_news.html.php 5 DIRTY $entry +modules/gallery/views/admin_block_news.html.php 7 DIRTY $entry +modules/gallery/views/admin_block_photo_stream.html.php 5 DIRTY $photo->id +modules/gallery/views/admin_block_photo_stream.html.php 5 CLEAN $photo->title +modules/gallery/views/admin_block_photo_stream.html.php 6 DIRTY $photo->width +modules/gallery/views/admin_block_photo_stream.html.php 6 DIRTY $photo->height +modules/gallery/views/admin_block_photo_stream.html.php 7 DIRTY $photo->thumb_url() +modules/gallery/views/admin_block_photo_stream.html.php 7 CLEAN $photo->title +modules/gallery/views/admin_block_platform.html.php 16 DIRTY $load_average +modules/gallery/views/admin_block_stats.html.php 7 DIRTY $album_count +modules/gallery/views/admin_block_stats.html.php 10 DIRTY $photo_count +modules/gallery/views/admin_dashboard.html.php 5 DIRTY $csrf +modules/gallery/views/admin_dashboard.html.php 37 DIRTY $blocks +modules/gallery/views/admin_graphics.html.php 6 DIRTY $csrf +modules/gallery/views/admin_graphics.html.php 21 DIRTY $active +modules/gallery/views/admin_graphics.html.php 25 DIRTY $available +modules/gallery/views/admin_graphics_gd.html.php 2 DIRTY $is_active +modules/gallery/views/admin_graphics_gd.html.php 2 DIRTY $tk->gd +modules/gallery/views/admin_graphics_gd.html.php 11 DIRTY $tk->gd +modules/gallery/views/admin_graphics_gd.html.php 19 DIRTY $tk->gd +modules/gallery/views/admin_graphics_graphicsmagick.html.php 2 DIRTY $is_active +modules/gallery/views/admin_graphics_graphicsmagick.html.php 2 DIRTY $tk->graphicsmagick +modules/gallery/views/admin_graphics_graphicsmagick.html.php 11 DIRTY $tk->graphicsmagick +modules/gallery/views/admin_graphics_imagemagick.html.php 2 DIRTY $is_active +modules/gallery/views/admin_graphics_imagemagick.html.php 2 DIRTY $tk->imagemagick +modules/gallery/views/admin_graphics_imagemagick.html.php 11 DIRTY $tk->imagemagick +modules/gallery/views/admin_languages.html.php 5 DIRTY $settings_form +modules/gallery/views/admin_languages.html.php 8 DIRTY $csrf +modules/gallery/views/admin_languages.html.php 14 DIRTY $share_translations_form +modules/gallery/views/admin_maintenance.html.php 23 DIRTY $task->severity +modules/gallery/views/admin_maintenance.html.php 25 DIRTY $task->name +modules/gallery/views/admin_maintenance.html.php 28 DIRTY $task->description +modules/gallery/views/admin_maintenance.html.php 31 DIRTY $task->callback +modules/gallery/views/admin_maintenance.html.php 31 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 44 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 70 DIRTY $task->state +modules/gallery/views/admin_maintenance.html.php 72 DIRTY $task->updated +modules/gallery/views/admin_maintenance.html.php 75 DIRTY $task->name +modules/gallery/views/admin_maintenance.html.php 86 DIRTY $task->percent_complete +modules/gallery/views/admin_maintenance.html.php 90 DIRTY $task->status +modules/gallery/views/admin_maintenance.html.php 93 CLEAN $task->owner()->name +modules/gallery/views/admin_maintenance.html.php 97 DIRTY $task->id +modules/gallery/views/admin_maintenance.html.php 97 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 101 DIRTY $task->id +modules/gallery/views/admin_maintenance.html.php 101 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 113 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 140 DIRTY $task->state +modules/gallery/views/admin_maintenance.html.php 142 DIRTY $task->updated +modules/gallery/views/admin_maintenance.html.php 145 DIRTY $task->name +modules/gallery/views/admin_maintenance.html.php 157 DIRTY $task->status +modules/gallery/views/admin_maintenance.html.php 160 DIRTY $task->owner()->name +modules/gallery/views/admin_maintenance.html.php 164 DIRTY $task->id +modules/gallery/views/admin_maintenance.html.php 164 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 168 DIRTY $task->id +modules/gallery/views/admin_maintenance.html.php 168 DIRTY $csrf +modules/gallery/views/admin_maintenance.html.php 171 DIRTY $task->id +modules/gallery/views/admin_maintenance.html.php 171 DIRTY $csrf +modules/gallery/views/admin_maintenance_task.html.php 5 DIRTY $task->id +modules/gallery/views/admin_maintenance_task.html.php 5 DIRTY $csrf +modules/gallery/views/admin_modules.html.php 19 DIRTY $i +modules/gallery/views/admin_modules.html.php 22 DIRTY $data +modules/gallery/views/admin_modules.html.php 22 DIRTY $module_name +modules/gallery/views/admin_modules.html.php 23 DIRTY $module_info->name +modules/gallery/views/admin_modules.html.php 24 DIRTY $module_info->version +modules/gallery/views/admin_modules.html.php 25 DIRTY $module_info->description +modules/gallery/views/admin_theme_details.html.php 5 DIRTY $form +modules/gallery/views/admin_themes.html.php 5 DIRTY $csrf +modules/gallery/views/admin_themes.html.php 18 DIRTY $site +modules/gallery/views/admin_themes.html.php 19 DIRTY $themes +modules/gallery/views/admin_themes.html.php 19 DIRTY $site +modules/gallery/views/admin_themes.html.php 20 DIRTY $themes +modules/gallery/views/admin_themes.html.php 20 DIRTY $site +modules/gallery/views/admin_themes.html.php 22 DIRTY $themes +modules/gallery/views/admin_themes.html.php 22 DIRTY $site +modules/gallery/views/admin_themes.html.php 33 DIRTY $id +modules/gallery/views/admin_themes.html.php 33 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 34 DIRTY $id +modules/gallery/views/admin_themes.html.php 35 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 36 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 38 DIRTY $info->description +modules/gallery/views/admin_themes.html.php 56 DIRTY $admin +modules/gallery/views/admin_themes.html.php 57 DIRTY $themes +modules/gallery/views/admin_themes.html.php 57 DIRTY $admin +modules/gallery/views/admin_themes.html.php 58 DIRTY $themes +modules/gallery/views/admin_themes.html.php 58 DIRTY $admin +modules/gallery/views/admin_themes.html.php 60 DIRTY $themes +modules/gallery/views/admin_themes.html.php 60 DIRTY $admin +modules/gallery/views/admin_themes.html.php 71 DIRTY $id +modules/gallery/views/admin_themes.html.php 71 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 72 DIRTY $id +modules/gallery/views/admin_themes.html.php 73 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 74 DIRTY $info->name +modules/gallery/views/admin_themes.html.php 76 DIRTY $info->description +modules/gallery/views/admin_themes_preview.html.php 3 DIRTY $type +modules/gallery/views/admin_themes_preview.html.php 3 DIRTY $theme_name +modules/gallery/views/admin_themes_preview.html.php 3 DIRTY $csrf +modules/gallery/views/admin_themes_preview.html.php 4 DIRTY $info->name +modules/gallery/views/admin_themes_preview.html.php 7 DIRTY $url +modules/gallery/views/after_install.html.php 11 CLEAN $user->name +modules/gallery/views/after_install.html.php 15 DIRTY $user->id +modules/gallery/views/kohana_error_page.php 98 DIRTY $message +modules/gallery/views/kohana_error_page.php 100 DIRTY $file +modules/gallery/views/kohana_error_page.php 100 DIRTY $line +modules/gallery/views/kohana_error_page.php 112 DIRTY $trace +modules/gallery/views/kohana_profiler.php 32 DIRTY $profile->render() +modules/gallery/views/kohana_profiler.php 34 DIRTY $execution_time +modules/gallery/views/l10n_client.html.php 13 DIRTY $string +modules/gallery/views/l10n_client.html.php 14 DIRTY $string +modules/gallery/views/l10n_client.html.php 18 DIRTY $l10n_search_form +modules/gallery/views/l10n_client.html.php 25 DIRTY $l10n_form +modules/gallery/views/l10n_client.html.php 29 DIRTY $string_list +modules/gallery/views/move_browse.html.php 4 DIRTY $source->id +modules/gallery/views/move_browse.html.php 39 DIRTY $tree +modules/gallery/views/move_browse.html.php 42 DIRTY $source->id +modules/gallery/views/move_tree.html.php 2 DIRTY $parent->thumb_tag(array(), 25) +modules/gallery/views/move_tree.html.php 4 DIRTY $parent->id +modules/gallery/views/move_tree.html.php 4 CLEAN $parent->title +modules/gallery/views/move_tree.html.php 6 DIRTY $parent->id +modules/gallery/views/move_tree.html.php 6 CLEAN $parent->title +modules/gallery/views/move_tree.html.php 8 DIRTY $parent->id +modules/gallery/views/move_tree.html.php 10 DIRTY $child->id +modules/gallery/views/move_tree.html.php 11 DIRTY $child->thumb_tag(array(), 25) +modules/gallery/views/move_tree.html.php 13 DIRTY $child->id +modules/gallery/views/move_tree.html.php 13 CLEAN $child->title +modules/gallery/views/move_tree.html.php 15 DIRTY $child->id +modules/gallery/views/move_tree.html.php 15 CLEAN $child->title +modules/gallery/views/permissions_browse.html.php 15 DIRTY $csrf +modules/gallery/views/permissions_browse.html.php 37 DIRTY $parent->id +modules/gallery/views/permissions_browse.html.php 38 CLEAN $parent->title +modules/gallery/views/permissions_browse.html.php 40 DIRTY $parent->id +modules/gallery/views/permissions_browse.html.php 44 DIRTY $item->id +modules/gallery/views/permissions_browse.html.php 45 CLEAN $item->title +modules/gallery/views/permissions_browse.html.php 47 DIRTY $item->id +modules/gallery/views/permissions_browse.html.php 48 DIRTY $form +modules/gallery/views/permissions_form.html.php 9 CLEAN $group->name +modules/gallery/views/permissions_form.html.php 15 DIRTY $permission->display_name +modules/gallery/views/permissions_form.html.php 24 DIRTY $lock->id +modules/gallery/views/permissions_form.html.php 32 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 32 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 32 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 36 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 36 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 36 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 43 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 43 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 43 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 47 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 47 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 47 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 56 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 56 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 56 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 63 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 63 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 63 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 74 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 74 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 74 DIRTY $item->id +modules/gallery/views/permissions_form.html.php 79 DIRTY $group->id +modules/gallery/views/permissions_form.html.php 79 DIRTY $permission->id +modules/gallery/views/permissions_form.html.php 79 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 9 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 9 DIRTY $page_type +modules/gallery/views/quick_pane.html.php 10 DIRTY $title +modules/gallery/views/quick_pane.html.php 12 DIRTY $title +modules/gallery/views/quick_pane.html.php 17 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 17 DIRTY $csrf +modules/gallery/views/quick_pane.html.php 17 DIRTY $page_type +modules/gallery/views/quick_pane.html.php 24 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 24 DIRTY $csrf +modules/gallery/views/quick_pane.html.php 24 DIRTY $page_type +modules/gallery/views/quick_pane.html.php 41 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 42 DIRTY $title +modules/gallery/views/quick_pane.html.php 44 DIRTY $title +modules/gallery/views/quick_pane.html.php 61 DIRTY $disabledState +modules/gallery/views/quick_pane.html.php 61 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 61 DIRTY $csrf +modules/gallery/views/quick_pane.html.php 61 DIRTY $page_type +modules/gallery/views/quick_pane.html.php 62 DIRTY $title +modules/gallery/views/quick_pane.html.php 64 DIRTY $title +modules/gallery/views/quick_pane.html.php 78 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 78 DIRTY $csrf +modules/gallery/views/quick_pane.html.php 78 DIRTY $page_type +modules/gallery/views/quick_pane.html.php 78 DIRTY $message +modules/gallery/views/quick_pane.html.php 78 DIRTY $title +modules/gallery/views/quick_pane.html.php 80 DIRTY $title +modules/gallery/views/quick_pane.html.php 93 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 98 DIRTY $item->id +modules/gallery/views/quick_pane.html.php 103 DIRTY $item->id +modules/gallery/views/simple_uploader.html.php 8 CLEAN $item->title +modules/gallery/views/simple_uploader.html.php 28 CLEAN $parent->title +modules/gallery/views/simple_uploader.html.php 30 CLEAN $item->title +modules/gallery/views/simple_uploader.html.php 77 DIRTY $item->id +modules/gallery/views/simple_uploader.html.php 81 DIRTY $csrf +modules/image_block/views/image_block_block.html.php 3 DIRTY $item->url() +modules/image_block/views/image_block_block.html.php 4 DIRTY $item->thumb_tag(array("class" => "gThumbnail")) +modules/info/views/info_block.html.php 6 CLEAN $item->title +modules/info/views/info_block.html.php 11 CLEAN $item->description +modules/info/views/info_block.html.php 17 CLEAN $item->name +modules/info/views/info_block.html.php 23 DIRTY $item->captured +modules/info/views/info_block.html.php 29 CLEAN $item->owner->name +modules/notification/views/comment_published.html.php 4 CLEAN $subject +modules/notification/views/comment_published.html.php 7 CLEAN $subject +modules/notification/views/comment_published.html.php 11 CLEAN $comment->text +modules/notification/views/comment_published.html.php 15 CLEAN $comment->author_name() +modules/notification/views/comment_published.html.php 19 CLEAN $comment->author_email() +modules/notification/views/comment_published.html.php 23 CLEAN $comment->author_url() +modules/notification/views/comment_published.html.php 28 DIRTY $comment->item()->url(array(), true) +modules/notification/views/comment_published.html.php 29 DIRTY $comment->item()->url(array(), true) +modules/notification/views/item_added.html.php 4 CLEAN $subject +modules/notification/views/item_added.html.php 7 CLEAN $subject +modules/notification/views/item_added.html.php 11 CLEAN $item->title +modules/notification/views/item_added.html.php 16 DIRTY $item->url(array(), true) +modules/notification/views/item_added.html.php 17 DIRTY $item->url(array(), true) +modules/notification/views/item_added.html.php 24 CLEAN $item->description +modules/notification/views/item_deleted.html.php 4 CLEAN $subject +modules/notification/views/item_deleted.html.php 7 CLEAN $subject +modules/notification/views/item_deleted.html.php 12 CLEAN $item->parent()->title +modules/notification/views/item_deleted.html.php 18 DIRTY $item->parent()->url(array(), true) +modules/notification/views/item_deleted.html.php 19 DIRTY $item->parent()->url(array(), true) +modules/notification/views/item_updated.html.php 4 CLEAN $subject +modules/notification/views/item_updated.html.php 7 CLEAN $subject +modules/notification/views/item_updated.html.php 12 CLEAN $new->title +modules/notification/views/item_updated.html.php 15 CLEAN $new->title +modules/notification/views/item_updated.html.php 20 DIRTY $new->url(array(), true) +modules/notification/views/item_updated.html.php 20 DIRTY $new->url(array(), true) +modules/notification/views/item_updated.html.php 25 CLEAN $new->description +modules/notification/views/item_updated.html.php 30 CLEAN $new->description +modules/organize/views/organize.html.php 10 DIRTY $item->id +modules/organize/views/organize.html.php 12 DIRTY $csrf +modules/organize/views/organize.html.php 13 DIRTY $csrf +modules/organize/views/organize.html.php 19 CLEAN $item->title +modules/organize/views/organize.html.php 33 DIRTY $album_tree +modules/organize/views/organize.html.php 48 DIRTY $button_pane +modules/organize/views/organize_album.html.php 3 DIRTY $album->id +modules/organize/views/organize_album.html.php 4 DIRTY $album->id +modules/organize/views/organize_album.html.php 4 DIRTY $album->id +modules/organize/views/organize_album.html.php 5 DIRTY $album_icon +modules/organize/views/organize_album.html.php 5 DIRTY $album_icon +modules/organize/views/organize_album.html.php 8 DIRTY $album->id +modules/organize/views/organize_album.html.php 8 DIRTY $album->id +modules/organize/views/organize_album.html.php 9 DIRTY $selected +modules/organize/views/organize_album.html.php 10 CLEAN $album->title +modules/organize/views/organize_album.html.php 12 DIRTY $album->id +modules/organize/views/organize_album.html.php 13 DIRTY $album_icon +modules/organize/views/organize_album.html.php 14 DIRTY $children +modules/organize/views/organize_edit.html.php 4 DIRTY $idx +modules/organize/views/organize_edit.html.php 4 DIRTY $pane +modules/organize/views/organize_edit.html.php 10 DIRTY $idx +modules/organize/views/organize_edit.html.php 10 DIRTY $pane +modules/organize/views/organize_thumb_grid.html.php 7 DIRTY $child->id +modules/organize/views/organize_thumb_grid.html.php 7 DIRTY $child->id +modules/organize/views/organize_thumb_grid.html.php 8 DIRTY $child->id +modules/organize/views/organize_thumb_grid.html.php 8 DIRTY $item_class +modules/organize/views/organize_thumb_grid.html.php 9 DIRTY $child->thumb_tag(array("class" => "gThumbnail"), $thumbsize, true) +modules/recaptcha/views/admin_recaptcha.html.php 5 DIRTY $form->get_key_url +modules/recaptcha/views/admin_recaptcha.html.php 8 DIRTY $form +modules/recaptcha/views/admin_recaptcha.html.php 21 DIRTY $public_key +modules/rss/views/comment.mrss.php 9 CLEAN $title +modules/rss/views/comment.mrss.php 10 DIRTY $link +modules/rss/views/comment.mrss.php 11 CLEAN $description +modules/rss/views/comment.mrss.php 13 DIRTY $feed_link +modules/rss/views/comment.mrss.php 16 DIRTY $previous_page_link +modules/rss/views/comment.mrss.php 19 DIRTY $next_page_link +modules/rss/views/comment.mrss.php 21 DIRTY $pub_date +modules/rss/views/comment.mrss.php 22 DIRTY $pub_date +modules/rss/views/comment.mrss.php 25 CLEAN $child +modules/rss/views/comment.mrss.php 26 CLEAN $child +modules/rss/views/comment.mrss.php 27 CLEAN $child +modules/rss/views/comment.mrss.php 28 DIRTY $child +modules/rss/views/comment.mrss.php 29 DIRTY $child +modules/rss/views/comment.mrss.php 32 CLEAN $child +modules/rss/views/comment.mrss.php 34 DIRTY $child +modules/rss/views/comment.mrss.php 35 DIRTY $child +modules/rss/views/comment.mrss.php 35 DIRTY $child +modules/rss/views/feed.mrss.php 9 CLEAN $title +modules/rss/views/feed.mrss.php 10 DIRTY $link +modules/rss/views/feed.mrss.php 11 CLEAN $description +modules/rss/views/feed.mrss.php 13 DIRTY $feed_link +modules/rss/views/feed.mrss.php 16 DIRTY $previous_page_link +modules/rss/views/feed.mrss.php 19 DIRTY $next_page_link +modules/rss/views/feed.mrss.php 21 DIRTY $pub_date +modules/rss/views/feed.mrss.php 22 DIRTY $pub_date +modules/rss/views/feed.mrss.php 25 CLEAN $child->title +modules/rss/views/feed.mrss.php 26 DIRTY $child->type +modules/rss/views/feed.mrss.php 26 DIRTY $child->id +modules/rss/views/feed.mrss.php 27 DIRTY $child->type +modules/rss/views/feed.mrss.php 27 DIRTY $child->id +modules/rss/views/feed.mrss.php 28 DIRTY $child->created +modules/rss/views/feed.mrss.php 31 CLEAN $child->description +modules/rss/views/feed.mrss.php 34 DIRTY $child->resize_url(true) +modules/rss/views/feed.mrss.php 35 CLEAN $child->title +modules/rss/views/feed.mrss.php 36 DIRTY $child->resize_height +modules/rss/views/feed.mrss.php 36 DIRTY $child->resize_width +modules/rss/views/feed.mrss.php 38 DIRTY $child->type +modules/rss/views/feed.mrss.php 38 DIRTY $child->id +modules/rss/views/feed.mrss.php 39 DIRTY $child->thumb_url(true) +modules/rss/views/feed.mrss.php 40 CLEAN $child->title +modules/rss/views/feed.mrss.php 41 DIRTY $child->thumb_height +modules/rss/views/feed.mrss.php 41 DIRTY $child->thumb_width +modules/rss/views/feed.mrss.php 43 CLEAN $child->description +modules/rss/views/feed.mrss.php 47 DIRTY $child->thumb_url(true) +modules/rss/views/feed.mrss.php 48 DIRTY $child->thumb_path() +modules/rss/views/feed.mrss.php 49 DIRTY $child->thumb_height +modules/rss/views/feed.mrss.php 50 DIRTY $child->thumb_width +modules/rss/views/feed.mrss.php 54 DIRTY $child->resize_url(true) +modules/rss/views/feed.mrss.php 55 DIRTY $child->resize_path() +modules/rss/views/feed.mrss.php 56 DIRTY $child->mime_type +modules/rss/views/feed.mrss.php 57 DIRTY $child->resize_height +modules/rss/views/feed.mrss.php 58 DIRTY $child->resize_width +modules/rss/views/feed.mrss.php 62 DIRTY $child->file_url(true) +modules/rss/views/feed.mrss.php 63 DIRTY $child->file_path() +modules/rss/views/feed.mrss.php 64 DIRTY $child->mime_type +modules/rss/views/feed.mrss.php 65 DIRTY $child->height +modules/rss/views/feed.mrss.php 66 DIRTY $child->width +modules/rss/views/feed.mrss.php 70 DIRTY $child->file_url(true) +modules/rss/views/feed.mrss.php 71 DIRTY $child->file_path() +modules/rss/views/feed.mrss.php 72 DIRTY $child->height +modules/rss/views/feed.mrss.php 73 DIRTY $child->width +modules/rss/views/feed.mrss.php 74 DIRTY $child->mime_type +modules/rss/views/rss_block.html.php 6 DIRTY $url +modules/rss/views/rss_block.html.php 8 DIRTY $text +modules/search/views/search.html.php 11 CLEAN $q +modules/search/views/search.html.php 30 DIRTY $item_class +modules/search/views/search.html.php 31 DIRTY $item->id +modules/search/views/search.html.php 32 DIRTY $item->thumb_tag() +modules/search/views/search.html.php 34 CLEAN $item->title +modules/search/views/search.html.php 37 CLEAN $item->description +modules/search/views/search.html.php 43 DIRTY $theme->pager() +modules/search/views/search.html.php 47 CLEAN $q +modules/server_add/views/admin_server_add.html.php 11 DIRTY $path +modules/server_add/views/admin_server_add.html.php 11 DIRTY $csrf +modules/server_add/views/admin_server_add.html.php 12 DIRTY $id +modules/server_add/views/admin_server_add.html.php 16 DIRTY $path +modules/server_add/views/admin_server_add.html.php 24 DIRTY $form +modules/server_add/views/server_add_tree.html.php 3 DIRTY $tree_id +modules/server_add/views/server_add_tree.html.php 4 DIRTY $tree_id +modules/server_add/views/server_add_tree.html.php 8 DIRTY $tree_id +modules/server_add/views/server_add_tree.html.php 13 DIRTY $tree_id +modules/server_add/views/server_add_tree.html.php 15 DIRTY $file_info +modules/server_add/views/server_add_tree.html.php 19 CLEAN $file_info +modules/server_add/views/server_add_tree.html.php 19 CLEAN $file +modules/server_add/views/server_add_tree_dialog.html.php 8 CLEAN $album_title +modules/server_add/views/server_add_tree_dialog.html.php 13 CLEAN $parent->title +modules/server_add/views/server_add_tree_dialog.html.php 15 CLEAN $album_title +modules/server_add/views/server_add_tree_dialog.html.php 18 DIRTY $action +modules/server_add/views/server_add_tree_dialog.html.php 20 DIRTY $tree +modules/tag/views/admin_tags.html.php 14 DIRTY $csrf +modules/tag/views/admin_tags.html.php 28 DIRTY $tags->count() +modules/tag/views/admin_tags.html.php 36 DIRTY $current_letter +modules/tag/views/admin_tags.html.php 46 DIRTY $current_letter +modules/tag/views/admin_tags.html.php 51 DIRTY $tag->id +modules/tag/views/admin_tags.html.php 51 CLEAN $tag->name +modules/tag/views/admin_tags.html.php 52 DIRTY $tag->count +modules/tag/views/admin_tags.html.php 53 DIRTY $tag->id +modules/tag/views/tag_block.html.php 3 DIRTY $cloud +modules/tag/views/tag_block.html.php 5 DIRTY $form +modules/tag/views/tag_cloud.html.php 4 DIRTY $tag->count +modules/tag/views/tag_cloud.html.php 4 DIRTY $max_count +modules/tag/views/tag_cloud.html.php 5 DIRTY $tag->count +modules/tag/views/tag_cloud.html.php 6 DIRTY $tag->id +modules/tag/views/tag_cloud.html.php 6 CLEAN $tag->name +modules/user/views/admin_users.html.php 3 DIRTY $csrf +modules/user/views/admin_users.html.php 36 DIRTY $csrf +modules/user/views/admin_users.html.php 67 DIRTY $user->id +modules/user/views/admin_users.html.php 67 DIRTY $user->admin +modules/user/views/admin_users.html.php 68 DIRTY $user->id +modules/user/views/admin_users.html.php 69 DIRTY $user->avatar_url(20, $theme->url("images/avatar.jpg", true)) +modules/user/views/admin_users.html.php 71 CLEAN $user->name +modules/user/views/admin_users.html.php 74 CLEAN $user->name +modules/user/views/admin_users.html.php 77 CLEAN $user->full_name +modules/user/views/admin_users.html.php 80 CLEAN $user->email +modules/user/views/admin_users.html.php 83 DIRTY $user->last_login +modules/user/views/admin_users.html.php 83 DIRTY $user->last_login +modules/user/views/admin_users.html.php 86 DIRTY $user->id +modules/user/views/admin_users.html.php 91 DIRTY $user->id +modules/user/views/admin_users.html.php 121 DIRTY $group->id +modules/user/views/admin_users.html.php 123 DIRTY $v +modules/user/views/admin_users_group.html.php 2 CLEAN $group->name +modules/user/views/admin_users_group.html.php 4 DIRTY $group->id +modules/user/views/admin_users_group.html.php 5 CLEAN $group->name +modules/user/views/admin_users_group.html.php 16 CLEAN $user->name +modules/user/views/admin_users_group.html.php 18 DIRTY $user->id +modules/user/views/admin_users_group.html.php 18 DIRTY $group->id +modules/user/views/admin_users_group.html.php 22 CLEAN $user->name +modules/user/views/admin_users_group.html.php 22 CLEAN $group->name +modules/user/views/login.html.php 11 DIRTY $user->id +modules/user/views/login.html.php 14 CLEAN $user->full_name +modules/user/views/login.html.php 14 CLEAN $user->name +modules/user/views/login.html.php 14 CLEAN $user->full_name +modules/user/views/login_ajax.html.php 37 DIRTY $form +modules/user/views/reset_password.html.php 9 CLEAN $user->full_name +modules/user/views/reset_password.html.php 9 CLEAN $user->full_name +modules/user/views/reset_password.html.php 9 CLEAN $user->name +modules/user/views/reset_password.html.php 12 DIRTY $confirm_url +modules/watermark/views/admin_watermarks.html.php 19 DIRTY $width +modules/watermark/views/admin_watermarks.html.php 19 DIRTY $height +modules/watermark/views/admin_watermarks.html.php 19 DIRTY $url +modules/watermark/views/admin_watermarks.html.php 21 DIRTY $position +themes/admin_default/views/admin.html.php 17 DIRTY $theme->url("css/screen.css") +themes/admin_default/views/admin.html.php 20 DIRTY $theme->url("css/fix-ie.css") +themes/admin_default/views/admin.html.php 29 DIRTY $theme->url("js/jquery.dropshadow.js") +themes/admin_default/views/admin.html.php 30 DIRTY $theme->url("js/ui.init.js") +themes/admin_default/views/admin.html.php 31 DIRTY $theme->admin_head() +themes/admin_default/views/admin.html.php 35 DIRTY $theme->admin_page_top() +themes/admin_default/views/admin.html.php 41 DIRTY $theme->site_status() +themes/admin_default/views/admin.html.php 43 DIRTY $theme->admin_header_top() +themes/admin_default/views/admin.html.php 50 DIRTY $theme->admin_menu() +themes/admin_default/views/admin.html.php 52 DIRTY $theme->admin_header_bottom() +themes/admin_default/views/admin.html.php 58 DIRTY $theme->messages() +themes/admin_default/views/admin.html.php 59 DIRTY $content +themes/admin_default/views/admin.html.php 65 DIRTY $sidebar +themes/admin_default/views/admin.html.php 70 DIRTY $theme->admin_footer() +themes/admin_default/views/admin.html.php 72 DIRTY $theme->admin_credits() +themes/admin_default/views/admin.html.php 76 DIRTY $theme->admin_page_bottom() +themes/admin_default/views/block.html.php 2 DIRTY $id +themes/admin_default/views/block.html.php 2 DIRTY $css_id +themes/admin_default/views/block.html.php 5 DIRTY $id +themes/admin_default/views/block.html.php 5 DIRTY $csrf +themes/admin_default/views/block.html.php 10 DIRTY $title +themes/admin_default/views/block.html.php 13 DIRTY $content +themes/admin_default/views/pager.html.php 9 DIRTY $from_to_msg +themes/admin_default/views/pager.html.php 11 DIRTY $url +themes/admin_default/views/pager.html.php 16 DIRTY $previous_page +themes/admin_default/views/pager.html.php 16 DIRTY $url +themes/admin_default/views/pager.html.php 21 DIRTY $next_page +themes/admin_default/views/pager.html.php 21 DIRTY $url +themes/admin_default/views/pager.html.php 26 DIRTY $last_page +themes/admin_default/views/pager.html.php 26 DIRTY $url +themes/default/views/album.html.php 4 DIRTY $theme->album_top() +themes/default/views/album.html.php 5 CLEAN $item->title +themes/default/views/album.html.php 6 CLEAN $item->description +themes/default/views/album.html.php 15 DIRTY $child->id +themes/default/views/album.html.php 15 DIRTY $item_class +themes/default/views/album.html.php 16 DIRTY $theme->thumb_top($child) +themes/default/views/album.html.php 17 DIRTY $child->url() +themes/default/views/album.html.php 18 DIRTY $child->thumb_tag(array("class" => "gThumbnail")) +themes/default/views/album.html.php 20 DIRTY $theme->thumb_bottom($child) +themes/default/views/album.html.php 21 DIRTY $child->url() +themes/default/views/album.html.php 21 CLEAN $child->title +themes/default/views/album.html.php 23 DIRTY $theme->thumb_info($child) +themes/default/views/album.html.php 28 DIRTY $theme->album_bottom() +themes/default/views/album.html.php 30 DIRTY $theme->pager() +themes/default/views/block.html.php 2 DIRTY $anchor +themes/default/views/block.html.php 3 DIRTY $css_id +themes/default/views/block.html.php 4 DIRTY $title +themes/default/views/block.html.php 6 DIRTY $content +themes/default/views/dynamic.html.php 4 DIRTY $theme->dynamic_top() +themes/default/views/dynamic.html.php 6 CLEAN $tag->name +themes/default/views/dynamic.html.php 11 DIRTY $child->is_album() +themes/default/views/dynamic.html.php 12 DIRTY $theme->thumb_top($child) +themes/default/views/dynamic.html.php 13 DIRTY $child->url() +themes/default/views/dynamic.html.php 14 DIRTY $child->id +themes/default/views/dynamic.html.php 15 DIRTY $child->thumb_url() +themes/default/views/dynamic.html.php 16 DIRTY $child->thumb_width +themes/default/views/dynamic.html.php 17 DIRTY $child->thumb_height +themes/default/views/dynamic.html.php 19 CLEAN $child->title +themes/default/views/dynamic.html.php 20 DIRTY $theme->thumb_bottom($child) +themes/default/views/dynamic.html.php 22 DIRTY $theme->thumb_info($child) +themes/default/views/dynamic.html.php 27 DIRTY $theme->dynamic_bottom() +themes/default/views/dynamic.html.php 29 DIRTY $theme->pager() +themes/default/views/footer.html.php 2 DIRTY $theme->footer() +themes/default/views/footer.html.php 4 DIRTY $footer_text +themes/default/views/footer.html.php 7 DIRTY $theme->credits() +themes/default/views/header.html.php 2 DIRTY $theme->header_top() +themes/default/views/header.html.php 4 DIRTY $header_text +themes/default/views/header.html.php 7 DIRTY $theme->url("images/logo.png") +themes/default/views/header.html.php 12 DIRTY $theme->site_menu() +themes/default/views/header.html.php 15 DIRTY $theme->header_bottom() +themes/default/views/header.html.php 21 DIRTY $parent->id +themes/default/views/header.html.php 21 DIRTY $item->id +themes/default/views/header.html.php 22 CLEAN $parent->title +themes/default/views/header.html.php 26 CLEAN $item->title +themes/default/views/login_page.html.php 10 DIRTY $theme->url("images/favicon.ico") +themes/default/views/login_page.html.php 17 DIRTY $theme->url("css/screen.css") +themes/default/views/login_page.html.php 20 DIRTY $theme->url("css/fix-ie.css") +themes/default/views/login_page.html.php 28 DIRTY $theme->url("js/ui.init.js") +themes/default/views/movie.html.php 4 DIRTY $theme->photo_top() +themes/default/views/movie.html.php 7 DIRTY $position +themes/default/views/movie.html.php 7 DIRTY $sibling_count +themes/default/views/movie.html.php 9 DIRTY $previous_item->url() +themes/default/views/movie.html.php 12 DIRTY $next_item->url() +themes/default/views/movie.html.php 16 DIRTY $item->id +themes/default/views/movie.html.php 17 DIRTY $item->file_url(true) +themes/default/views/movie.html.php 18 DIRTY $item->width +themes/default/views/movie.html.php 18 DIRTY $item->height +themes/default/views/movie.html.php 21 DIRTY $item->id +themes/default/views/movie.html.php 35 CLEAN $item->title +themes/default/views/movie.html.php 36 CLEAN $item->description +themes/default/views/movie.html.php 39 DIRTY $theme->photo_bottom() +themes/default/views/page.html.php 11 CLEAN $item->title +themes/default/views/page.html.php 14 DIRTY $page_title +themes/default/views/page.html.php 16 DIRTY $theme->page_type +themes/default/views/page.html.php 18 DIRTY $theme->url("images/favicon.ico") +themes/default/views/page.html.php 25 DIRTY $theme->url("css/screen.css") +themes/default/views/page.html.php 28 DIRTY $theme->url("css/fix-ie.css") +themes/default/views/page.html.php 37 DIRTY $new_width +themes/default/views/page.html.php 38 DIRTY $new_height +themes/default/views/page.html.php 39 DIRTY $thumb_proportion +themes/default/views/page.html.php 51 DIRTY $theme->url("js/jquery.scrollTo.js") +themes/default/views/page.html.php 52 DIRTY $theme->url("js/jquery.localscroll.js") +themes/default/views/page.html.php 53 DIRTY $theme->url("js/ui.init.js") +themes/default/views/page.html.php 54 DIRTY $theme->head() +themes/default/views/page.html.php 58 DIRTY $theme->page_top() +themes/default/views/page.html.php 60 DIRTY $theme->site_status() +themes/default/views/page.html.php 62 DIRTY $theme->display("header.html") +themes/default/views/page.html.php 68 DIRTY $theme->messages() +themes/default/views/page.html.php 69 DIRTY $content +themes/default/views/page.html.php 74 DIRTY $theme->display("sidebar.html") +themes/default/views/page.html.php 78 DIRTY $theme->display("footer.html") +themes/default/views/page.html.php 81 DIRTY $theme->page_bottom() +themes/default/views/pager.html.php 11 DIRTY $url +themes/default/views/pager.html.php 18 DIRTY $previous_page +themes/default/views/pager.html.php 18 DIRTY $url +themes/default/views/pager.html.php 25 DIRTY $from_to_msg +themes/default/views/pager.html.php 28 DIRTY $next_page +themes/default/views/pager.html.php 28 DIRTY $url +themes/default/views/pager.html.php 35 DIRTY $last_page +themes/default/views/pager.html.php 35 DIRTY $url +themes/default/views/photo.html.php 3 DIRTY $theme->photo_top() +themes/default/views/photo.html.php 8 DIRTY $previous_item->url() +themes/default/views/photo.html.php 15 DIRTY $position +themes/default/views/photo.html.php 15 DIRTY $sibling_count +themes/default/views/photo.html.php 18 DIRTY $next_item->url() +themes/default/views/photo.html.php 28 DIRTY $theme->resize_top($item) +themes/default/views/photo.html.php 32 DIRTY $item->resize_tag(array("id" => "gPhotoId-{$item->id}", "class" => "gResize")) +themes/default/views/photo.html.php 36 DIRTY $theme->resize_bottom($item) +themes/default/views/photo.html.php 40 CLEAN $item->title +themes/default/views/photo.html.php 41 CLEAN $item->description +themes/default/views/photo.html.php 44 DIRTY $theme->photo_bottom() +themes/default/views/sidebar.html.php 2 DIRTY $theme->sidebar_top() +themes/default/views/sidebar.html.php 6 DIRTY $theme->album_menu() +themes/default/views/sidebar.html.php 8 DIRTY $theme->photo_menu() +themes/default/views/sidebar.html.php 13 DIRTY $theme->sidebar_blocks() +themes/default/views/sidebar.html.php 14 DIRTY $theme->sidebar_bottom() -- cgit v1.2.3 From 897ca2806d46134aa00167c5d9d9ab34eee65e37 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 01:22:48 -0700 Subject: Updated for renamed variable --- modules/gallery/tests/xss_data.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules/gallery') diff --git a/modules/gallery/tests/xss_data.txt b/modules/gallery/tests/xss_data.txt index 68bf2302..c79f859a 100644 --- a/modules/gallery/tests/xss_data.txt +++ b/modules/gallery/tests/xss_data.txt @@ -402,7 +402,7 @@ modules/rss/views/feed.mrss.php 72 DIRTY $child->h modules/rss/views/feed.mrss.php 73 DIRTY $child->width modules/rss/views/feed.mrss.php 74 DIRTY $child->mime_type modules/rss/views/rss_block.html.php 6 DIRTY $url -modules/rss/views/rss_block.html.php 8 DIRTY $text +modules/rss/views/rss_block.html.php 8 DIRTY $title modules/search/views/search.html.php 11 CLEAN $q modules/search/views/search.html.php 30 DIRTY $item_class modules/search/views/search.html.php 31 DIRTY $item->id -- cgit v1.2.3 From f9a741782da848c707ac0a122c35e86061a0fbb2 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 12:33:10 -0700 Subject: Switch to using html::specialchars() for cleaning. --- modules/gallery/helpers/p.php | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'modules/gallery') diff --git a/modules/gallery/helpers/p.php b/modules/gallery/helpers/p.php index 69032840..c3074c23 100644 --- a/modules/gallery/helpers/p.php +++ b/modules/gallery/helpers/p.php @@ -18,16 +18,7 @@ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ class p_Core { - static function attr($dirty_html) { - // return $dirty_html; - return htmlentities($dirty_html, ENT_QUOTES); - // return str_replace('"', '"', $dirty_html); - // return str_replace('"', '"', Purify::instance()->purify($dirty_html)); - } - function clean($dirty_html) { - // return $dirty_html; - return htmlentities($dirty_html, ENT_QUOTES); - // return Purify::instance()->purify($dirty_html); + return html::specialchars($dirty_html); } } -- cgit v1.2.3 From 181c97ef4b29bb3c68a6c9b5d2f8165e8b44ba29 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 12:53:03 -0700 Subject: Relax the regex we use to extract the movie size so that it works with the new version of ffmpeg that I have on my dev box (ffmpeg 0.5-svn17737+3:0.svn20090303-1) --- modules/gallery/helpers/movie.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'modules/gallery') diff --git a/modules/gallery/helpers/movie.php b/modules/gallery/helpers/movie.php index 15225fe7..3aa40dc9 100644 --- a/modules/gallery/helpers/movie.php +++ b/modules/gallery/helpers/movie.php @@ -118,8 +118,7 @@ class movie_Core { $cmd = escapeshellcmd($ffmpeg) . " -i " . escapeshellarg($filename) . " 2>&1"; $result = `$cmd`; - if (preg_match("/Stream.*?Video:.*?(\d+)x(\d+).*\ +([0-9\.]+) (fps|tb).*/", - $result, $regs)) { + if (preg_match("/Stream.*?Video:.*?(\d+)x(\d+)/", $result, $regs)) { list ($width, $height) = array($regs[1], $regs[2]); } else { list ($width, $height) = array(0, 0); -- cgit v1.2.3 From 0ec3f1b830a5b183b9901ab19c934596516e4c69 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 19:32:13 -0700 Subject: Update for changes to admin_users_group.html.php --- modules/gallery/tests/xss_data.txt | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'modules/gallery') diff --git a/modules/gallery/tests/xss_data.txt b/modules/gallery/tests/xss_data.txt index c79f859a..4aaa520d 100644 --- a/modules/gallery/tests/xss_data.txt +++ b/modules/gallery/tests/xss_data.txt @@ -458,15 +458,16 @@ modules/user/views/admin_users.html.php 83 DIRTY $user->la modules/user/views/admin_users.html.php 86 DIRTY $user->id modules/user/views/admin_users.html.php 91 DIRTY $user->id modules/user/views/admin_users.html.php 121 DIRTY $group->id +modules/user/views/admin_users.html.php 121 DIRTY $group->special modules/user/views/admin_users.html.php 123 DIRTY $v -modules/user/views/admin_users_group.html.php 2 CLEAN $group->name -modules/user/views/admin_users_group.html.php 4 DIRTY $group->id -modules/user/views/admin_users_group.html.php 5 CLEAN $group->name -modules/user/views/admin_users_group.html.php 16 CLEAN $user->name -modules/user/views/admin_users_group.html.php 18 DIRTY $user->id -modules/user/views/admin_users_group.html.php 18 DIRTY $group->id -modules/user/views/admin_users_group.html.php 22 CLEAN $user->name -modules/user/views/admin_users_group.html.php 22 CLEAN $group->name +modules/user/views/admin_users_group.html.php 3 CLEAN $group->name +modules/user/views/admin_users_group.html.php 5 DIRTY $group->id +modules/user/views/admin_users_group.html.php 6 CLEAN $group->name +modules/user/views/admin_users_group.html.php 20 CLEAN $user->name +modules/user/views/admin_users_group.html.php 22 DIRTY $user->id +modules/user/views/admin_users_group.html.php 22 DIRTY $group->id +modules/user/views/admin_users_group.html.php 25 CLEAN $user->name +modules/user/views/admin_users_group.html.php 25 CLEAN $group->name modules/user/views/login.html.php 11 DIRTY $user->id modules/user/views/login.html.php 14 CLEAN $user->full_name modules/user/views/login.html.php 14 CLEAN $user->name -- cgit v1.2.3 From 297fb737ac1e8b5a50a3220cb0841457b042ac92 Mon Sep 17 00:00:00 2001 From: bharat Date: Mon, 1 Jun 2009 01:07:05 -0400 Subject: Convert %7E to ~ when proxying files to work around Firefox's overzealous security model. --- modules/gallery/controllers/file_proxy.php | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'modules/gallery') diff --git a/modules/gallery/controllers/file_proxy.php b/modules/gallery/controllers/file_proxy.php index 2037ad98..1901bd9f 100644 --- a/modules/gallery/controllers/file_proxy.php +++ b/modules/gallery/controllers/file_proxy.php @@ -32,9 +32,13 @@ class File_Proxy_Controller extends Controller { $request_uri = $this->input->server("REQUEST_URI"); $request_uri = preg_replace("/\?.*/", "", $request_uri); + // Firefox converts ~ to %7E breaking our url comparison, below. Convert that back here. + $request_uri = str_replace("%7E", "~", $request_uri); + // var_uri: http://example.com/gallery3/var/ $var_uri = url::file("var/"); + // Make sure that the request is for a file inside var $offset = strpos($request_uri, $var_uri); if ($offset === false) { -- cgit v1.2.3 From 54ae9fac88512f1bac05a5952fca9ade2eab0898 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 22:12:14 -0700 Subject: Remove extra blank line --- modules/gallery/controllers/file_proxy.php | 1 - 1 file changed, 1 deletion(-) (limited to 'modules/gallery') diff --git a/modules/gallery/controllers/file_proxy.php b/modules/gallery/controllers/file_proxy.php index 1901bd9f..dfdb4f34 100644 --- a/modules/gallery/controllers/file_proxy.php +++ b/modules/gallery/controllers/file_proxy.php @@ -38,7 +38,6 @@ class File_Proxy_Controller extends Controller { // var_uri: http://example.com/gallery3/var/ $var_uri = url::file("var/"); - // Make sure that the request is for a file inside var $offset = strpos($request_uri, $var_uri); if ($offset === false) { -- cgit v1.2.3 From 33df7de391eebdab2cb09ca97207cb81f4274cd1 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 22:25:53 -0700 Subject: Accidentally broke the AllowOverride info url in the migration from core -> modules/gallery. Fixed, and incidentally make the link appear in a new tab/window. --- modules/gallery/views/permissions_browse.html.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules/gallery') diff --git a/modules/gallery/views/permissions_browse.html.php b/modules/gallery/views/permissions_browse.html.php index 5cd9cf82..8bb2e830 100644 --- a/modules/gallery/views/permissions_browse.html.php +++ b/modules/gallery/views/permissions_browse.html.php @@ -27,7 +27,7 @@
              • - AllowOverride FileInfo Options to fix this.", array("url" => "http://httpd.apache.org/docs/2.0/mod/gallery.html#allowoverride")) ?> + AllowOverride FileInfo Options to fix this.", array("attrs" => "href=\"http://httpd.apache.org/docs/2.0/mod/core.html#allowoverride\" target=\"_blank\"")) ?>
              -- cgit v1.2.3 From 9a7e642cd6cc3d250d9d413c3ce0414e92e9d769 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 31 May 2009 22:30:48 -0700 Subject: Don't let relative_path() try to update the database if the Item_Model is not loaded, else you get weird errors. --- modules/gallery/models/item.php | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'modules/gallery') diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php index 4b8cac8e..9406f5d9 100644 --- a/modules/gallery/models/item.php +++ b/modules/gallery/models/item.php @@ -287,6 +287,10 @@ class Item_Model extends ORM_MPTT { * @return string */ public function relative_path() { + if (!$this->loaded) { + return; + } + if (!isset($this->relative_path_cache)) { $paths = array(); foreach (Database::instance() -- cgit v1.2.3