From 301754db7365262804a40a59d4cbf277d7d1085e Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Sun, 18 Oct 2009 18:16:19 -0700
Subject: Create a administration page that allows the administrator to change
 the the Identity provider if more than two are Identity providers are
 installed

---
 modules/gallery/views/admin_identity.html.php | 61 +++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)
 create mode 100644 modules/gallery/views/admin_identity.html.php

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
new file mode 100644
index 00000000..dcf1dbc1
--- /dev/null
+++ b/modules/gallery/views/admin_identity.html.php
@@ -0,0 +1,61 @@
+<?php defined("SYSPATH") or die("No direct script access.") ?>
+<script type="text/javascript">
+  $(document).ready(function() {
+    $("#g-modules form").submit(function() {
+      var eDialog = '<div id="g-dialog"></div>';
+      var params = $(this).serialize();
+      var url = $(this).attr("action");
+      $("body").append(eDialog);
+      $.post($(this).attr("action"), $(this).serialize(), function(data, textStatus) {
+        $("#g-dialog").html(data);
+        $("#g-dialog").dialog({
+          bgiframe: true,
+          title: "<?= t("Confirm Change Identity Provider") ?>",
+          resizable: false,
+          height:165,
+          modal: true,
+          overlay: {
+	    backgroundColor: '#000',
+	    opacity: 0.5
+          },
+          buttons: {
+	    "Continue": function() {
+              $("##g-dialog form").submit();
+            },
+            Cancel: function() {
+              $(this).dialog('close');
+            }
+          }
+        });
+      });
+      return false;
+    });
+  });
+
+</script>
+<div id="g-modules">
+  <h1> <?= t("Gallery Identity Management") ?> </h1>
+  <p>
+    <?= t("Choose a different user/group management provider.") ?>
+  </p>
+
+  <form method="post" action="<?= url::site("admin/identity/confirm") ?>">
+    <?= access::csrf_form_field() ?>
+    <table>
+      <tr>
+        <th> <?= t("Active") ?> </th>
+        <th> <?= t("Description") ?> </th>
+      </tr>
+      <? $i = 0 ?>
+      <? foreach ($available as $module_name => $description):  ?>
+      <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?>">
+        <? $data = array("name" => "provider"); ?>
+        <td> <?= form::radio($data, $module_name, $module_name == $active) ?> </td>
+        <td> <?= t($description) ?> </td>
+      </tr>
+      <? $i++ ?>
+      <? endforeach ?>
+    </table>
+    <input type="submit" value="<?= t("Change")->for_html_attr() ?>" />
+  </form>
+</div>
-- 
cgit v1.2.3


From 098b57bf18112d0a3173dbe28b5ed76782431ff7 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Mon, 19 Oct 2009 12:53:44 -0700
Subject: Simplify the user interface by moving the password reset
 functionality into the user module Bagging the User_Definition and
 Group_Definition abstract classes and replacing them with interfaces with the
 same names. Make sure all the unit tests work.

---
 modules/gallery/controllers/password.php           | 133 --------------
 modules/gallery/helpers/access.php                 |   4 +-
 modules/gallery/libraries/Identity.php             |  34 +---
 modules/gallery/libraries/drivers/Identity.php     | 196 ++-------------------
 modules/gallery/tests/Albums_Controller_Test.php   |   1 +
 modules/gallery/tests/Photos_Controller_Test.php   |   2 +-
 modules/gallery/views/admin_identity.html.php      |   6 +-
 modules/gallery/views/reset_password.html.php      |  17 --
 modules/user/controllers/password.php              | 133 ++++++++++++++
 modules/user/helpers/group.php                     |   4 +-
 modules/user/helpers/user.php                      |  15 +-
 .../user/libraries/drivers/Identity/Gallery.php    |  99 ++---------
 modules/user/models/group.php                      |   2 +-
 modules/user/models/user.php                       |   2 +-
 modules/user/views/admin_users.html.php            |   2 +-
 modules/user/views/reset_password.html.php         |  17 ++
 16 files changed, 206 insertions(+), 461 deletions(-)
 delete mode 100644 modules/gallery/controllers/password.php
 delete mode 100644 modules/gallery/views/reset_password.html.php
 create mode 100644 modules/user/controllers/password.php
 create mode 100644 modules/user/views/reset_password.html.php

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/gallery/controllers/password.php b/modules/gallery/controllers/password.php
deleted file mode 100644
index ce6d67b1..00000000
--- a/modules/gallery/controllers/password.php
+++ /dev/null
@@ -1,133 +0,0 @@
-<?php defined("SYSPATH") or die("No direct script access.");
-/**
- * Gallery - a web based photo album viewer and editor
- * Copyright (C) 2000-2009 Bharat Mediratta
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
- */
-class Password_Controller extends Controller {
-  public function reset() {
-    if (request::method() == "post") {
-      // @todo separate the post from get parts of this function
-      access::verify_csrf();
-      $this->_send_reset();
-    } else {
-      print $this->_reset_form();
-    }
-  }
-
-  public function do_reset() {
-    if (request::method() == "post") {
-      $this->_change_password();
-    } else {
-      $user = Identity::lookup_user_by_hash(Input::instance()->get("key"));
-      if (!empty($user)) {
-        print $this->_new_password_form($user->hash);
-      } else {
-        throw new Exception("@todo FORBIDDEN", 503);
-      }
-    }
-  }
-
-  private function _send_reset() {
-    $form = $this->_reset_form();
-
-    $valid = $form->validate();
-    if ($valid) {
-      $user = Identity::lookup_user_by_name($form->reset->inputs["name"]->value);
-      if (!$user->loaded || empty($user->email)) {
-        $form->reset->inputs["name"]->add_error("no_email", 1);
-        $valid = false;
-      }
-    }
-
-    if ($valid) {
-      $user->hash = md5(rand());
-      $user->save();
-      $message = new View("reset_password.html");
-      $message->confirm_url = url::abs_site("password/do_reset?key=$user->hash");
-      $message->user = $user;
-
-      Sendmail::factory()
-        ->to($user->email)
-        ->subject(t("Password Reset Request"))
-        ->header("Mime-Version", "1.0")
-        ->header("Content-type", "text/html; charset=iso-8859-1")
-        ->message($message->render())
-        ->send();
-
-      log::success(
-        "user",
-        t("Password reset email sent for user %name", array("name" => $user->name)));
-    } else {
-      // Don't include the username here until you're sure that it's XSS safe
-      log::warning(
-        "user", "Password reset email requested for bogus user");
-    }
-
-    message::success(t("Password reset email sent"));
-    print json_encode(
-      array("result" => "success"));
-  }
-
-  private function _reset_form() {
-    $form = new Forge(url::current(true), "", "post", array("id" => "g-reset-form"));
-    $group = $form->group("reset")->label(t("Reset Password"));
-    $group->input("name")->label(t("Username"))->id("g-name")->class(null)->rules("required");
-    $group->inputs["name"]->error_messages("no_email", t("No email, unable to reset password"));
-    $group->submit("")->value(t("Reset"));
-
-    return $form;
-  }
-
-  private function _new_password_form($hash=null) {
-    $template = new Theme_View("page.html", "reset");
-
-    $form = new Forge("password/do_reset", "", "post", array("id" => "g-change-password-form"));
-    $group = $form->group("reset")->label(t("Change Password"));
-    $hidden = $group->hidden("hash");
-    if (!empty($hash)) {
-      $hidden->value($hash);
-    }
-    $group->password("password")->label(t("Password"))->id("g-password")
-      ->rules("required|length[1,40]");
-    $group->password("password2")->label(t("Confirm Password"))->id("g-password2")
-      ->matches($group->password);
-    $group->inputs["password2"]->error_messages(
-      "mistyped", t("The password and the confirm password must match"));
-    $group->submit("")->value(t("Update"));
-
-    $template->content = $form;
-    return $template;
-  }
-
-  private function _change_password() {
-    $view = $this->_new_password_form();
-    if ($view->content->validate()) {
-      $user = Identity::lookup_user_by_hash(Input::instance()->get("key"));
-      if (empty($user)) {
-        throw new Exception("@todo FORBIDDEN", 503);
-      }
-
-      $user->password = $view->content->reset->password->value;
-      $user->hash = null;
-      $user->save();
-      message::success(t("Password reset successfully"));
-      url::redirect(item::root()->abs_url());
-    } else {
-      print $view;
-    }
-  }
-}
\ No newline at end of file
diff --git a/modules/gallery/helpers/access.php b/modules/gallery/helpers/access.php
index 21f4de81..fba161e3 100644
--- a/modules/gallery/helpers/access.php
+++ b/modules/gallery/helpers/access.php
@@ -197,8 +197,8 @@ class access_Core {
    * @param  Item_Model  $item
    * @param  boolean     $value
    */
-  private static function _set(Group_Model $group, $perm_name, $album, $value) {
-    if (get_class($group) != "Group_Model") {
+  private static function _set(Group_Definition $group, $perm_name, $album, $value) {
+    if (!($group instanceof Group_Definition)) {
       throw new Exception("@todo PERMISSIONS_ONLY_WORK_ON_GROUPS");
     }
     if (!$album->loaded) {
diff --git a/modules/gallery/libraries/Identity.php b/modules/gallery/libraries/Identity.php
index 9e5f0bb5..e77fd2d2 100644
--- a/modules/gallery/libraries/Identity.php
+++ b/modules/gallery/libraries/Identity.php
@@ -133,37 +133,17 @@ class Identity_Core {
   }
 
   /**
-   * @see Identity_Driver::hash_password.
-   */
-  static function hash_password($password) {
-    return self::instance()->driver->hash_password($password);
-  }
-
-  /**
-   * Look up a user by id.
-   * @param integer      $id the user id
-   * @return User_Definition  the user object, or null if the id was invalid.
+   * @see Identity_Driver::lookup_user.
    */
   static function lookup_user($id) {
-    return self::instance()->driver->lookup_user_by_field("id", $id);
+    return self::instance()->driver->lookup_user($id);
   }
 
   /**
-   * Look up a user by name.
-   * @param integer      $name the user name
-   * @return User_Definition  the user object, or null if the name was invalid.
+   * @see Identity_Driver::lookup_user_by_name.
    */
   static function lookup_user_by_name($name) {
-    return self::instance()->driver->lookup_user_by_field("name", $name);
-  }
-
-  /**
-   * Look up a user by hash.
-   * @param string       $name the user name
-   * @return User_Definition  the user object, or null if the name was invalid.
-   */
-  static function lookup_user_by_hash($hash) {
-    return self::instance()->driver->lookup_user_by_field("hash", $hash);
+    return self::instance()->driver->lookup_user_by_name($name);
   }
 
   /**
@@ -188,12 +168,10 @@ class Identity_Core {
   }
 
   /**
-   * Look up a group by name.
-   * @param integer      $id the group name
-   * @return Group_Definition  the group object, or null if the name was invalid.
+   * @see Identity_Driver::lookup_group_by_name.
    */
   static function lookup_group_by_name($name) {
-    return self::instance()->driver->lookup_group_by_field("name", $name);
+    return self::instance()->driver->lookup_group_by_name($name);
   }
 
   /**
diff --git a/modules/gallery/libraries/drivers/Identity.php b/modules/gallery/libraries/drivers/Identity.php
index a9e1a75b..6ab001cb 100644
--- a/modules/gallery/libraries/drivers/Identity.php
+++ b/modules/gallery/libraries/drivers/Identity.php
@@ -45,19 +45,18 @@ interface Identity_Driver {
   public function is_correct_password($user, $password);
 
   /**
-   * Create the hashed passwords.
-   * @param string $password a plaintext password
-   * @return string hashed password
+   * Look up a user by id.
+   * @param integer     id
+   * @return User_Definition the user object, or null if the name was invalid.
    */
-  public function hash_password($password);
+  public function lookup_user($id);
 
   /**
-   * Look up a user by by search the specified field.
-   * @param string      search field
-   * @param string      search value
-   * @return User_Definition the user object, or null if the name was invalid.
+   * Look up a user by name.
+   * @param string      name
+  * @return User_Definition the user object, or null if the name was invalid.
    */
-  public function lookup_user_by_field($field, $value);
+  public function lookup_user_by_name($name);
 
   /**
    * Create a new group.
@@ -90,181 +89,6 @@ interface Identity_Driver {
 
 } // End Identity Driver Definition
 
-/**
- * User Data wrapper
- */
-abstract class User_Definition {
-  protected $user;
-  public function __get($column) {
-    switch ($column) {
-    case "id":
-    case "name":
-    case "full_name":
-    case "password":
-    case "login_count":
-    case "last_login":
-    case "email":
-    case "admin":
-    case "guest":
-    case "hash":
-    case "url":
-    case "locale":
-    case "groups":
-    case "hashed_password":
-      return $this->user->$column;
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  public function __set($column, $value) {
-    switch ($column) {
-    case "id":
-    case "groups":
-      throw new Exception("@todo READ ONLY FIELD: $column");
-      break;
-    case "name":
-    case "full_name":
-    case "hashed_password":
-    case "password":
-    case "login_count":
-    case "last_login":
-    case "email":
-    case "admin":
-    case "guest":
-    case "hash":
-    case "url":
-    case "locale":
-      $this->user->$column = $value;
-      break;
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  public function __isset($column) {
-    return isset($this->user->$column);
-  }
-
-  public function __unset($column) {
-    switch ($column) {
-    case "id":
-    case "groups":
-      throw new Exception("@todo READ ONLY FIELD: $column");
-      break;
-    case "name":
-    case "full_name":
-    case "password":
-    case "login_count":
-    case "last_login":
-    case "email":
-    case "admin":
-    case "guest":
-    case "hash":
-    case "url":
-    case "locale":
-    case "hashed_password":
-      unset($this->user->$column);
-      break;
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  /**
-   * Return a url to the user's avatar image.
-   * @param integer $size the target size of the image (default 80px)
-   * @return string a url
-   */
-  abstract public function avatar_url($size=80, $default=null);
-
-  /**
-   * Return the best version of the user's name.  Either their specified full name, or fall back
-   * to the user name.
-   * @return string
-   */
-  abstract public function display_name();
-
-  /**
-   * Return the internal user object without the wrapper.
-   * This method is used by implementing classes to access the internal user object.
-   * Consider it pseudo private and only declared public as PHP as not internal or friend modifier
-   */
-  public function _uncloaked() {
-    return $this->user;
-  }
-
-  abstract public function save();
-  abstract public function delete();
-}
-
-/**
- * Group Data wrapper
- */
-abstract class Group_Definition {
-  protected $group;
-
-  public function __get($column) {
-    switch ($column) {
-    case "id":
-    case "name":
-    case "special":
-    case "users":
-      return $this->group->$column;
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  public function __set($column, $value) {
-    switch ($column) {
-    case "id":
-    case "users":
-      throw new Exception("@todo READ ONLY FIELD: $column");
-      break;
-    case "name":
-    case "special":
-      $this->group->$column = $value;
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  public function __isset($column) {
-    return isset($this->group->$column);
-  }
-
-  public function __unset($column) {
-    switch ($column) {
-    case "id":
-    case "users":
-      throw new Exception("@todo READ ONLY FIELD: $column");
-      break;
-    case "name":
-    case "special":
-      unset($this->group->$column);
-    default:
-      throw new Exception("@todo UNSUPPORTED FIELD: $column");
-      break;
-    }
-  }
-
-  /**
-   * Return the internal group object without the wrapper.
-   * This method is used by implementing classes to access the internal group object.
-   * Consider it pseudo private and only declared public as PHP as not internal or friend modifier
-   */
-  public function _uncloaked() {
-    return $this->group;
-  }
+interface Group_Definition {}
 
-  abstract public function save();
-  abstract public function delete();
-  abstract public function add($user);
-  abstract public function remove($user);
-}
+interface User_Definition {}
diff --git a/modules/gallery/tests/Albums_Controller_Test.php b/modules/gallery/tests/Albums_Controller_Test.php
index 046cb5ad..fa46d924 100644
--- a/modules/gallery/tests/Albums_Controller_Test.php
+++ b/modules/gallery/tests/Albums_Controller_Test.php
@@ -43,6 +43,7 @@ class Albums_Controller_Test extends Unit_Test_Case {
     $_POST["column"] = "weight";
     $_POST["direction"] = "ASC";
     $_POST["csrf"] = access::csrf_token();
+    $_POST["slug"] = "new_name";
     $_POST["_method"] = "put";
     access::allow(Identity::everybody(), "edit", $root);
 
diff --git a/modules/gallery/tests/Photos_Controller_Test.php b/modules/gallery/tests/Photos_Controller_Test.php
index cdb4ae4f..59c3f78a 100644
--- a/modules/gallery/tests/Photos_Controller_Test.php
+++ b/modules/gallery/tests/Photos_Controller_Test.php
@@ -31,7 +31,7 @@ class Photos_Controller_Test extends Unit_Test_Case {
     $root = ORM::factory("item", 1);
     $photo = photo::create(
       $root, MODPATH . "gallery/tests/test.jpg", "test.jpeg",
-      "test", "test", Session::active_user(), "slug");
+      "test", "test", Session::active_user()->id, "slug");
     $orig_name = $photo->name;
 
     $_POST["filename"] = "test.jpeg";
diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
index dcf1dbc1..1405cacb 100644
--- a/modules/gallery/views/admin_identity.html.php
+++ b/modules/gallery/views/admin_identity.html.php
@@ -15,11 +15,11 @@
           height:165,
           modal: true,
           overlay: {
-	    backgroundColor: '#000',
-	    opacity: 0.5
+            backgroundColor: '#000',
+            opacity: 0.5
           },
           buttons: {
-	    "Continue": function() {
+            "Continue": function() {
               $("##g-dialog form").submit();
             },
             Cancel: function() {
diff --git a/modules/gallery/views/reset_password.html.php b/modules/gallery/views/reset_password.html.php
deleted file mode 100644
index 92ca4917..00000000
--- a/modules/gallery/views/reset_password.html.php
+++ /dev/null
@@ -1,17 +0,0 @@
-<?php defined("SYSPATH") or die("No direct script access.") ?>
-<html>
-  <head>
-    <title><?= t("Password Reset Request") ?> </title>
-  </head>
-  <body>
-    <h2><?= t("Password Reset Request") ?> </h2>
-    <p>
-      <?= t("Hello, %name,", array("name" => $user->full_name ? $user->full_name : $user->name)) ?>
-    </p>
-    <p>
-  <?= t("We received a request to reset your password for <a href=\"%site_url\">%site_url</a>.  If you made this request, you can confirm it by <a href=\"%confirm_url\">clicking this link</a>.  If you didn't request this password reset, it's ok to ignore this mail.",
-        array("site_url" => html::mark_clean(url::base(false, "http")),
-              "confirm_url" => $confirm_url)) ?>
-    </p>
-  </body>
-</html>
diff --git a/modules/user/controllers/password.php b/modules/user/controllers/password.php
new file mode 100644
index 00000000..a8f1c5ca
--- /dev/null
+++ b/modules/user/controllers/password.php
@@ -0,0 +1,133 @@
+<?php defined("SYSPATH") or die("No direct script access.");
+/**
+ * Gallery - a web based photo album viewer and editor
+ * Copyright (C) 2000-2009 Bharat Mediratta
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+class Password_Controller extends Controller {
+  public function reset() {
+    if (request::method() == "post") {
+      // @todo separate the post from get parts of this function
+      access::verify_csrf();
+      $this->_send_reset();
+    } else {
+      print $this->_reset_form();
+    }
+  }
+
+  public function do_reset() {
+    if (request::method() == "post") {
+      $this->_change_password();
+    } else {
+      $user = user::lookup_user_by_field("hash", Input::instance()->get("key"));
+      if (!empty($user)) {
+        print $this->_new_password_form($user->hash);
+      } else {
+        throw new Exception("@todo FORBIDDEN", 503);
+      }
+    }
+  }
+
+  private function _send_reset() {
+    $form = $this->_reset_form();
+
+    $valid = $form->validate();
+    if ($valid) {
+      $user = Identity::lookup_user_by_name($form->reset->inputs["name"]->value);
+      if (!$user->loaded || empty($user->email)) {
+        $form->reset->inputs["name"]->add_error("no_email", 1);
+        $valid = false;
+      }
+    }
+
+    if ($valid) {
+      $user->hash = md5(rand());
+      $user->save();
+      $message = new View("reset_password.html");
+      $message->confirm_url = url::abs_site("password/do_reset?key=$user->hash");
+      $message->user = $user;
+
+      Sendmail::factory()
+        ->to($user->email)
+        ->subject(t("Password Reset Request"))
+        ->header("Mime-Version", "1.0")
+        ->header("Content-type", "text/html; charset=iso-8859-1")
+        ->message($message->render())
+        ->send();
+
+      log::success(
+        "user",
+        t("Password reset email sent for user %name", array("name" => $user->name)));
+    } else {
+      // Don't include the username here until you're sure that it's XSS safe
+      log::warning(
+        "user", "Password reset email requested for bogus user");
+    }
+
+    message::success(t("Password reset email sent"));
+    print json_encode(
+      array("result" => "success"));
+  }
+
+  private function _reset_form() {
+    $form = new Forge(url::current(true), "", "post", array("id" => "g-reset-form"));
+    $group = $form->group("reset")->label(t("Reset Password"));
+    $group->input("name")->label(t("Username"))->id("g-name")->class(null)->rules("required");
+    $group->inputs["name"]->error_messages("no_email", t("No email, unable to reset password"));
+    $group->submit("")->value(t("Reset"));
+
+    return $form;
+  }
+
+  private function _new_password_form($hash=null) {
+    $template = new Theme_View("page.html", "reset");
+
+    $form = new Forge("password/do_reset", "", "post", array("id" => "g-change-password-form"));
+    $group = $form->group("reset")->label(t("Change Password"));
+    $hidden = $group->hidden("hash");
+    if (!empty($hash)) {
+      $hidden->value($hash);
+    }
+    $group->password("password")->label(t("Password"))->id("g-password")
+      ->rules("required|length[1,40]");
+    $group->password("password2")->label(t("Confirm Password"))->id("g-password2")
+      ->matches($group->password);
+    $group->inputs["password2"]->error_messages(
+      "mistyped", t("The password and the confirm password must match"));
+    $group->submit("")->value(t("Update"));
+
+    $template->content = $form;
+    return $template;
+  }
+
+  private function _change_password() {
+    $view = $this->_new_password_form();
+    if ($view->content->validate()) {
+      $user = user::lookup_user_by_field("hash", Input::instance()->get("key"));
+      if (empty($user)) {
+        throw new Exception("@todo FORBIDDEN", 503);
+      }
+
+      $user->password = $view->content->reset->password->value;
+      $user->hash = null;
+      $user->save();
+      message::success(t("Password reset successfully"));
+      url::redirect(item::root()->abs_url());
+    } else {
+      print $view;
+    }
+  }
+}
\ No newline at end of file
diff --git a/modules/user/helpers/group.php b/modules/user/helpers/group.php
index cf5c050f..8ad52564 100644
--- a/modules/user/helpers/group.php
+++ b/modules/user/helpers/group.php
@@ -42,14 +42,14 @@ class group_Core {
    * @see Identity_Driver::everbody.
    */
   static function everybody() {
-    return Identity::instance()->everybody();
+    return model_cache::get("group", 1);
   }
 
   /**
    * @see Identity_Driver::registered_users.
    */
   static function registered_users() {
-    return Identity::instance()->everybody();
+    return model_cache::get("group", 2);
   }
 
   /**
diff --git a/modules/user/helpers/user.php b/modules/user/helpers/user.php
index fa7b320f..5ef2b726 100644
--- a/modules/user/helpers/user.php
+++ b/modules/user/helpers/user.php
@@ -25,14 +25,21 @@
  */
 class user_Core {
   /**
-   * @see Identity_Driver::guest.
+   * Return the guest user.
+   *
+   * @return User_Model the user object
    */
   static function guest() {
     return model_cache::get("user", 1);
   }
 
   /**
-   * @see Identity_Driver::create_user.
+   * Create a new user.
+   *
+   * @param string  $name
+   * @param string  $full_name
+   * @param string  $password
+   * @return User_Definition the user object
    */
   static function create($name, $full_name, $password) {
     $user = ORM::factory("user")->where("name", $name)->find();
@@ -53,7 +60,9 @@ class user_Core {
   }
 
   /**
-   * @see Identity_Driver::hash_password.
+   * Hash the password to the internal value
+   * @param string   $password the user password
+   * @param string   The hashed equivalent
    */
   static function hash_password($password) {
     require_once(MODPATH . "user/lib/PasswordHash.php");
diff --git a/modules/user/libraries/drivers/Identity/Gallery.php b/modules/user/libraries/drivers/Identity/Gallery.php
index 77db11a3..f405b710 100644
--- a/modules/user/libraries/drivers/Identity/Gallery.php
+++ b/modules/user/libraries/drivers/Identity/Gallery.php
@@ -25,14 +25,14 @@ class Identity_Gallery_Driver implements Identity_Driver {
    * @see Identity_Driver::guest.
    */
   public function guest() {
-    return new Gallery_User(user::guest());
+    return user::guest();
   }
 
   /**
    * @see Identity_Driver::create_user.
    */
   public function create_user($name, $full_name, $password) {
-    return new Gallery_User(user::create($name, $full_name, $password));
+    return user::create($name, $full_name, $password);
   }
 
   /**
@@ -67,122 +67,55 @@ class Identity_Gallery_Driver implements Identity_Driver {
   }
 
   /**
-   * @see Identity_Driver::hash_password.
+   * @see Identity_Driver::lookup_user.
    */
-  public function hash_password($password) {
-    return user::hash_password($password);
+  public function lookup_user($id) {
+    return user::lookup_by_field("id", $id);
   }
 
   /**
-   * @see Identity_Driver::lookup_user_by_field.
+   * @see Identity_Driver::lookup_user_by_name.
    */
-  public function lookup_user_by_field($field_name, $value) {
-    return new Gallery_User(user::lookup_by_field($field_name, $value));
+  public function lookup_user_by_name($name) {
+    return user::lookup_by_field("name", $name);
   }
 
   /**
    * @see Identity_Driver::create_group.
    */
   public function create_group($name) {
-    return new Gallery_Group(group::create($name));
+    return group::create($name);
   }
 
   /**
    * @see Identity_Driver::everybody.
    */
   public function everybody() {
-    return new Gallery_Group(group::everybody());
+    return group::everybody();
   }
 
   /**
    * @see Identity_Driver::registered_users.
    */
   public function registered_users() {
-    return new Gallery_Group(group::registered_users());
+    return group::registered_users();
   }
 
   /**
-   * @see Identity_Driver::lookup_group_by_field.
+   * @see Identity_Driver::lookup_group_by_name.
    */
-  public function lookup_group_by_field($field_name, $value) {
-    return new Gallery_Group(group::lookup_by_field($field_name, $value));
+  static function lookup_group_by_name($name) {
+    return group::lookup_by_field("name", $name);
   }
 
   /**
    * @see Identity_Driver::get_user_list.
    */
   public function get_user_list($ids) {
-    $results = ORM::factory("user")
+    return ORM::factory("user")
       ->in("id", ids)
       ->find_all()
-      ->as_array();;
-    $users = array();
-    foreach ($results as $user) {
-      $users[] = new Gallery_User($user);
-    }
-    return $users;
+      ->as_array();
   }
 } // End Identity Gallery Driver
 
-/**
- * User Data wrapper
- */
-class Gallery_User extends User_Definition {
-  /*
-   *  Not for general user, allows the back-end to easily create the interface object
-   */
-  function __construct($user) {
-    $this->user = $user;
-  }
-
-  /**
-   * @see User_Definition::avatar_url
-   */
-  public function avatar_url($size=80, $default=null) {
-    return $this->user->avatar_url($size, $default);
-  }
-
-  /**
-   * @see User_Definition::display_name
-   */
-  public function display_name() {
-    return $this->user->display_name();
-  }
-
-  public function save() {
-    $this->user->save();
-  }
-
-  public function delete() {
-    $this->user->delete();
-  }
-
-}
-
-/**
- * Group Data wrapper
- */
-class Gallery_Group extends Group_Definition {
-  /*
-   *  Not for general user, allows the back-end to easily create the interface object
-   */
-  function __construct($group) {
-    $this->group = $group;
-  }
-
-  public function save() {
-    $this->group->save();
-  }
-
-  public function delete() {
-    $this->group->delete();
-  }
-
-  public function add($user) {
-    $this->group->add($user->_uncloaked());
-  }
-
-  public function remove($user) {
-    $this->group->remove($user->_uncloaked());
-  }
-}
diff --git a/modules/user/models/group.php b/modules/user/models/group.php
index 8af78012..4432fc69 100644
--- a/modules/user/models/group.php
+++ b/modules/user/models/group.php
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
-class Group_Model extends ORM {
+class Group_Model extends ORM implements Group_Definition {
   protected $has_and_belongs_to_many = array("users");
 
   var $rules = array(
diff --git a/modules/user/models/user.php b/modules/user/models/user.php
index d99603b2..c51fc720 100644
--- a/modules/user/models/user.php
+++ b/modules/user/models/user.php
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
-class User_Model extends ORM {
+class User_Model extends ORM implements User_Definition {
   protected $has_and_belongs_to_many = array("groups");
 
   var $rules = array(
diff --git a/modules/user/views/admin_users.html.php b/modules/user/views/admin_users.html.php
index 7c54d93d..ee8d413c 100644
--- a/modules/user/views/admin_users.html.php
+++ b/modules/user/views/admin_users.html.php
@@ -91,7 +91,7 @@
                   open_text="<?= t("close") ?>"
                   class="g-panel-link g-button ui-state-default ui-corner-all ui-icon-left">
                 <span class="ui-icon ui-icon-pencil"></span><span class="g-button-text"><?= t("edit") ?></span></a>
-              <? if (user::active()->id != $user->id && !$user->guest): ?>
+              <? if (Session::active_user()->id != $user->id && !$user->guest): ?>
               <a href="<?= url::site("admin/users/delete_user_form/$user->id") ?>"
                   class="g-dialog-link g-button ui-state-default ui-corner-all ui-icon-left">
                 <span class="ui-icon ui-icon-trash"></span><?= t("delete") ?></a>
diff --git a/modules/user/views/reset_password.html.php b/modules/user/views/reset_password.html.php
new file mode 100644
index 00000000..92ca4917
--- /dev/null
+++ b/modules/user/views/reset_password.html.php
@@ -0,0 +1,17 @@
+<?php defined("SYSPATH") or die("No direct script access.") ?>
+<html>
+  <head>
+    <title><?= t("Password Reset Request") ?> </title>
+  </head>
+  <body>
+    <h2><?= t("Password Reset Request") ?> </h2>
+    <p>
+      <?= t("Hello, %name,", array("name" => $user->full_name ? $user->full_name : $user->name)) ?>
+    </p>
+    <p>
+  <?= t("We received a request to reset your password for <a href=\"%site_url\">%site_url</a>.  If you made this request, you can confirm it by <a href=\"%confirm_url\">clicking this link</a>.  If you didn't request this password reset, it's ok to ignore this mail.",
+        array("site_url" => html::mark_clean(url::base(false, "http")),
+              "confirm_url" => $confirm_url)) ?>
+    </p>
+  </body>
+</html>
-- 
cgit v1.2.3


From b74b131e25ca0ddb42d2545a5d0ea2d796452f1d Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Thu, 22 Oct 2009 22:29:56 -0700
Subject: Change Identity adminstration to use the uninstall/install methods
 when changing providers.

---
 modules/gallery/controllers/admin_identity.php     | 19 +++--
 modules/gallery/helpers/identity.php               | 34 ++++-----
 modules/gallery/helpers/module.php                 |  4 +-
 modules/gallery/libraries/IdentityProvider.php     | 26 ++-----
 .../gallery/libraries/drivers/IdentityProvider.php | 10 ---
 modules/gallery/views/admin_identity.html.php      |  4 +-
 .../gallery/views/admin_identity_confirm.html.php  |  2 +-
 modules/user/helpers/user.php                      | 85 ----------------------
 modules/user/helpers/user_installer.php            | 76 +++++++++++++++++--
 .../libraries/drivers/IdentityProvider/Gallery.php | 16 +---
 10 files changed, 110 insertions(+), 166 deletions(-)

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/gallery/controllers/admin_identity.php b/modules/gallery/controllers/admin_identity.php
index d06132ff..0521a0f8 100644
--- a/modules/gallery/controllers/admin_identity.php
+++ b/modules/gallery/controllers/admin_identity.php
@@ -47,23 +47,26 @@ class Admin_Identity_Controller extends Admin_Controller {
 
       module::event("pre_identity_change", $active_provider, $new_provider);
 
-      identity::deactivate();
+      module::deactivate($active_provider);
+      module::uninstall($active_provider);
+
+      try {
+        Session::instance()->destroy();
+      } catch (Exception $e) {
+        // We don't care if there was a problem destroying the session.
+      }
 
       // Switch authentication
-      module::set_var("gallery", "identity_provider", $new_provider);
       identity::reset();
+      module::set_var("gallery", "identity_provider", $new_provider);
 
-      identity::activate();
+      module::install($new_provider);
+      module::activate($new_provider);
 
       // @todo this type of collation is questionable from an i18n perspective
       message::success(t("Changed to %description",
                          array("description" => $providers->$new_provider)));
 
-      try {
-        Session::instance()->destroy();
-      } catch (Exception $e) {
-        // We don't care if there was a problem destroying the session.
-      }
       url::redirect(item::root()->abs_url());
     }
 
diff --git a/modules/gallery/helpers/identity.php b/modules/gallery/helpers/identity.php
index cf84c8a9..d0cba8e7 100644
--- a/modules/gallery/helpers/identity.php
+++ b/modules/gallery/helpers/identity.php
@@ -39,6 +39,16 @@ class identity_Core {
     return self::$available;
   }
 
+  /**
+   * Frees the current instance of the identity provider so the next call to instance will reload
+   *
+   * @param   string  configuration
+   * @return  Identity_Core
+   */
+  static function reset() {
+    IdentityProvider::reset();
+  }
+
   /**
    * Make sure that we have a session and group_ids cached in the session.
    */
@@ -71,12 +81,12 @@ class identity_Core {
         $session->set("group_ids", $ids);
       }
       //} catch (Exception $e) {
-      //try {
-      //Session::instance()->destroy();
-      //} catch (Exception $e) {
+      //  try {
+      //   Session::instance()->destroy();
+        //  } catch (Exception $e) {
         // We don't care if there was a problem destroying the session.
-      //}
-      //url::redirect(item::root()->abs_url());
+      // }
+      // url::redirect(item::root()->abs_url());
       //}
   }
 
@@ -125,20 +135,6 @@ class identity_Core {
     return IdentityProvider::instance()->is_writable();
   }
 
-  /**
-   * @see IdentityProvider_Driver::activate.
-   */
-  static function activate() {
-    IdentityProvider::instance()->activate();
-  }
-
-  /**
-   * @see IdentityProvider_Driver::deactivate.
-   */
-  static function deactivate() {
-    IdentityProvider::instance()->deactivate();
-  }
-
   /**
    * @see IdentityProvider_Driver::guest.
    */
diff --git a/modules/gallery/helpers/module.php b/modules/gallery/helpers/module.php
index 1d77e63d..9d41cd51 100644
--- a/modules/gallery/helpers/module.php
+++ b/modules/gallery/helpers/module.php
@@ -130,6 +130,8 @@ class module_Core {
     array_unshift($kohana_modules, MODPATH . $module_name);
     Kohana::config_set("core.modules",  $kohana_modules);
 
+    // Rebuild the include path so the module installer can benefit from auto loading
+    Kohana::include_paths(true);
     $installer_class = "{$module_name}_installer";
     if (method_exists($installer_class, "install")) {
       call_user_func_array(array($installer_class, "install"), array());
@@ -154,7 +156,7 @@ class module_Core {
    */
   static function upgrade($module_name) {
     $kohana_modules = Kohana::config("core.modules");
-    array_unshift($kohana_modules, MODPATH . $module_name);
+    $kohana_modules = array_unshift($kohana_modules, MODPATH . $module_name);
     Kohana::config_set("core.modules",  $kohana_modules);
 
     $version_before = module::get_version($module_name);
diff --git a/modules/gallery/libraries/IdentityProvider.php b/modules/gallery/libraries/IdentityProvider.php
index 512f28eb..38718d4b 100644
--- a/modules/gallery/libraries/IdentityProvider.php
+++ b/modules/gallery/libraries/IdentityProvider.php
@@ -38,7 +38,7 @@ class IdentityProvider_Core {
    * @return  Identity_Core
    */
   static function & instance() {
-   if (!isset(self::$instance)) {
+   if (empty(self::$instance)) {
       // Create a new instance
       self::$instance = new IdentityProvider();
     }
@@ -47,14 +47,14 @@ class IdentityProvider_Core {
   }
 
   /**
-   * Returns a singleton instance of Identity.
-   * There can only be one Identity driver configured at a given point
+   * Frees the current instance of the identity provider so the next call to instance will reload
    *
    * @param   string  configuration
    * @return  Identity_Core
    */
   static function reset() {
-    self::$instance = new IdentityProvider();
+    self::$instance = null;
+    Kohana::config_clear("identity");
   }
 
   /**
@@ -66,12 +66,12 @@ class IdentityProvider_Core {
     $config = module::get_var("gallery", "identity_provider", "user");
 
     // Test the config group name
-    if (($this->config = Kohana::config("identity.".$config)) === NULL) {
+    if (($this->config = Kohana::config("identity." . $config)) === NULL) {
       throw new Exception("@todo NO USER LIBRARY CONFIGURATION FOR: $config");
     }
 
     // Set driver name
-    $driver = "IdentityProvider_".ucfirst($this->config["driver"])."_Driver";
+    $driver = "IdentityProvider_" . ucfirst($this->config["driver"])  ."_Driver";
 
     // Load the driver
     if ( ! Kohana::auto_load($driver)) {
@@ -100,20 +100,6 @@ class IdentityProvider_Core {
     return !empty($this->config["allow_updates"]);
   }
 
-  /**
-   * @see IdentityProvider_Driver::activate.
-   */
-  public function activate() {
-    $this->driver->activate();
-  }
-
-  /**
-   * @see IdentityProvider_Driver::deactivate.
-   */
-  public function deactivate() {
-    $this->driver->deactivate();
-  }
-
   /**
    * @see IdentityProvider_Driver::guest.
    */
diff --git a/modules/gallery/libraries/drivers/IdentityProvider.php b/modules/gallery/libraries/drivers/IdentityProvider.php
index 8a578d1b..5bb41dcc 100644
--- a/modules/gallery/libraries/drivers/IdentityProvider.php
+++ b/modules/gallery/libraries/drivers/IdentityProvider.php
@@ -18,16 +18,6 @@
  * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
  */
 interface IdentityProvider_Driver {
-  /**
-   * Initialize the provider so it is ready to use
-   */
-  public function activate();
-
-  /**
-   * Cleanup up this provider so it is unavailable for use and won't conflict with the current driver
-   */
-  public function deactivate();
-
   /**
    * Return the guest user.
    *
diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
index 1405cacb..358860cf 100644
--- a/modules/gallery/views/admin_identity.html.php
+++ b/modules/gallery/views/admin_identity.html.php
@@ -10,7 +10,7 @@
         $("#g-dialog").html(data);
         $("#g-dialog").dialog({
           bgiframe: true,
-          title: "<?= t("Confirm Change Identity Provider") ?>",
+          title: <?= t("Confirm identity provider change")->for_js() ?>,
           resizable: false,
           height:165,
           modal: true,
@@ -34,7 +34,7 @@
 
 </script>
 <div id="g-modules">
-  <h1> <?= t("Gallery Identity Management") ?> </h1>
+  <h1> <?= t("Manage Identity Providers") ?> </h1>
   <p>
     <?= t("Choose a different user/group management provider.") ?>
   </p>
diff --git a/modules/gallery/views/admin_identity_confirm.html.php b/modules/gallery/views/admin_identity_confirm.html.php
index e14525b5..54aae9c8 100644
--- a/modules/gallery/views/admin_identity_confirm.html.php
+++ b/modules/gallery/views/admin_identity_confirm.html.php
@@ -4,7 +4,7 @@
   <?= form::hidden("provider", $new_provider) ?>
 
   <p><span class="ui-icon ui-icon-alert" style="float: left; margin:0 7px 20px 0;"></span>
-  <?= t("Do you really want to switch Identity providers? Continuing will delete all existing users.") ?>
+  <?= t("Are you sure you want to change your Identity Provider? Continuing will delete all existing users.") ?>
   </p>
 </form>
 
diff --git a/modules/user/helpers/user.php b/modules/user/helpers/user.php
index 5f154313..5ef2b726 100644
--- a/modules/user/helpers/user.php
+++ b/modules/user/helpers/user.php
@@ -24,91 +24,6 @@
  * Note: by design, this class does not do any permission checking.
  */
 class user_Core {
-  /**
-   * Initialize the provider so it is ready to use
-   */
-  static function activate() {
-    $db = Database::instance();
-    $db->query("CREATE TABLE IF NOT EXISTS {users} (
-                 `id` int(9) NOT NULL auto_increment,
-                 `name` varchar(32) NOT NULL,
-                 `full_name` varchar(255) NOT NULL,
-                 `password` varchar(64) NOT NULL,
-                 `login_count` int(10) unsigned NOT NULL DEFAULT 0,
-                 `last_login` int(10) unsigned NOT NULL DEFAULT 0,
-                 `email` varchar(64) default NULL,
-                 `admin` BOOLEAN default 0,
-                 `guest` BOOLEAN default 0,
-                 `hash` char(32) default NULL,
-                 `url` varchar(255) default NULL,
-                 `locale` char(10) default NULL,
-                 PRIMARY KEY (`id`),
-                 UNIQUE KEY(`hash`),
-                 UNIQUE KEY(`name`))
-               DEFAULT CHARSET=utf8;");
-
-    $db->query("CREATE TABLE IF NOT EXISTS {groups} (
-                 `id` int(9) NOT NULL auto_increment,
-                 `name` char(64) default NULL,
-                 `special` BOOLEAN default 0,
-                 PRIMARY KEY (`id`),
-                 UNIQUE KEY(`name`))
-               DEFAULT CHARSET=utf8;");
-
-    $db->query("CREATE TABLE IF NOT EXISTS {groups_users} (
-                 `group_id` int(9) NOT NULL,
-                 `user_id` int(9) NOT NULL,
-                 PRIMARY KEY (`group_id`, `user_id`),
-                 UNIQUE KEY(`user_id`, `group_id`))
-               DEFAULT CHARSET=utf8;");
-
-    $everybody = group::create("Everybody");
-    $everybody->special = true;
-    $everybody->save();
-
-    $registered = group::create("Registered Users");
-    $registered->special = true;
-    $registered->save();
-
-    $guest = user::create("guest", "Guest User", "");
-    $guest->guest = true;
-    $guest->remove($registered);
-    $guest->save();
-
-    $admin = user::create("admin", "Gallery Administrator", "admin");
-    $admin->admin = true;
-    $admin->save();
-
-    // Let the admin own everything
-    $db->query("update {items} set owner_id = {$admin->id}");
-
-    $root = ORM::factory("item", 1);
-    access::allow($everybody, "view", $root);
-    access::allow($everybody, "view_full", $root);
-
-    access::allow($registered, "view", $root);
-    access::allow($registered, "view_full", $root);
-  }
-
-  /**
-   * Cleanup up this provider so it is unavailable for use and won't conflict with the current driver
-   */
-  static function deactivate() {
-    // Delete all users and groups so that we give other modules an opportunity to clean up
-    foreach (ORM::factory("user")->find_all() as $user) {
-      $user->delete();
-    }
-
-    foreach (ORM::factory("group")->find_all() as $group) {
-      $group->delete();
-    }
-
-    $db = Database::instance();
-    $db->query("DROP TABLE IF EXISTS {users};");
-    $db->query("DROP TABLE IF EXISTS {groups};");
-    $db->query("DROP TABLE IF EXISTS {groups_users};");
-  }
-
   /**
    * Return the guest user.
    *
diff --git a/modules/user/helpers/user_installer.php b/modules/user/helpers/user_installer.php
index 1410f1ef..36c617a8 100644
--- a/modules/user/helpers/user_installer.php
+++ b/modules/user/helpers/user_installer.php
@@ -19,18 +19,84 @@
  */
 class user_installer {
   static function install() {
+    $db = Database::instance();
+    $db->query("CREATE TABLE IF NOT EXISTS {users} (
+                 `id` int(9) NOT NULL auto_increment,
+                 `name` varchar(32) NOT NULL,
+                 `full_name` varchar(255) NOT NULL,
+                 `password` varchar(64) NOT NULL,
+                 `login_count` int(10) unsigned NOT NULL DEFAULT 0,
+                 `last_login` int(10) unsigned NOT NULL DEFAULT 0,
+                 `email` varchar(64) default NULL,
+                 `admin` BOOLEAN default 0,
+                 `guest` BOOLEAN default 0,
+                 `hash` char(32) default NULL,
+                 `url` varchar(255) default NULL,
+                 `locale` char(10) default NULL,
+                 PRIMARY KEY (`id`),
+                 UNIQUE KEY(`hash`),
+                 UNIQUE KEY(`name`))
+               DEFAULT CHARSET=utf8;");
+
+    $db->query("CREATE TABLE IF NOT EXISTS {groups} (
+                 `id` int(9) NOT NULL auto_increment,
+                 `name` char(64) default NULL,
+                 `special` BOOLEAN default 0,
+                 PRIMARY KEY (`id`),
+                 UNIQUE KEY(`name`))
+               DEFAULT CHARSET=utf8;");
+
+    $db->query("CREATE TABLE IF NOT EXISTS {groups_users} (
+                 `group_id` int(9) NOT NULL,
+                 `user_id` int(9) NOT NULL,
+                 PRIMARY KEY (`group_id`, `user_id`),
+                 UNIQUE KEY(`user_id`, `group_id`))
+               DEFAULT CHARSET=utf8;");
+
+    $everybody = group::create("Everybody");
+    $everybody->special = true;
+    $everybody->save();
+
+    $registered = group::create("Registered Users");
+    $registered->special = true;
+    $registered->save();
+
+    $guest = user::create("guest", "Guest User", "");
+    $guest->guest = true;
+    $guest->remove($registered);
+    $guest->save();
+
+    $admin = user::create("admin", "Gallery Administrator", "admin");
+    $admin->admin = true;
+    $admin->save();
+
+    // Let the admin own everything
+    $db->query("update {items} set owner_id = {$admin->id}");
+
+    $root = ORM::factory("item", 1);
+    access::allow($everybody, "view", $root);
+    access::allow($everybody, "view_full", $root);
+
+    access::allow($registered, "view", $root);
+    access::allow($registered, "view_full", $root);
     user::activate();
     module::set_var("gallery", "identity_provider", "user");
     module::set_version("user", 1);
   }
 
   static function uninstall() {
-    user::deactivate();
+    // Delete all users and groups so that we give other modules an opportunity to clean up
+    foreach (ORM::factory("user")->find_all() as $user) {
+      $user->delete();
+    }
 
-    try {
-      Session::instance()->destroy();
-    } catch (Exception $e) {
-      // We don't care if there was a problem destroying the session.
+    foreach (ORM::factory("group")->find_all() as $group) {
+      $group->delete();
     }
+
+    $db = Database::instance();
+    $db->query("DROP TABLE IF EXISTS {users};");
+    $db->query("DROP TABLE IF EXISTS {groups};");
+    $db->query("DROP TABLE IF EXISTS {groups_users};");
   }
 }
\ No newline at end of file
diff --git a/modules/user/libraries/drivers/IdentityProvider/Gallery.php b/modules/user/libraries/drivers/IdentityProvider/Gallery.php
index 5941abb7..026f04e9 100644
--- a/modules/user/libraries/drivers/IdentityProvider/Gallery.php
+++ b/modules/user/libraries/drivers/IdentityProvider/Gallery.php
@@ -20,21 +20,7 @@
 /*
  * Based on the Cache_Sqlite_Driver developed by the Kohana Team
  */
-class Identity_Gallery_Driver implements IdentityProvider_Driver {
-  /**
-   * @see IdentityProvider_Driver::activate.
-   */
-  public function activate() {
-    user::activate();
-  }
-
-  /**
-   * @see IdentityProvider_Driver::deactivate.
-   */
-  public function deactivate() {
-    user::deactivate();
-  }
-
+class IdentityProvider_Gallery_Driver implements IdentityProvider_Driver {
   /**
    * @see IdentityProvider_Driver::guest.
    */
-- 
cgit v1.2.3


From 7ea13b3869dee33804606a17488bb1cd26759bdb Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Wed, 28 Oct 2009 12:15:52 -0700
Subject: Normalize capitalization ticket #596

---
 modules/akismet/views/admin_akismet.html.php       |  4 ++--
 modules/comment/helpers/comment_block.php          |  4 ++--
 modules/comment/helpers/comment_rss.php            |  2 +-
 modules/comment/views/admin_comments.html.php      | 12 +++++-----
 modules/exif/views/exif_dialog.html.php            |  2 +-
 modules/exif/views/exif_sidebar.html.php           |  2 +-
 modules/g2_import/helpers/g2_import.php            |  2 +-
 modules/g2_import/views/admin_g2_import.html.php   |  2 +-
 modules/gallery/controllers/admin_languages.php    |  2 +-
 modules/gallery/helpers/gallery_block.php          | 26 +++++++++++-----------
 modules/gallery/helpers/gallery_installer.php      |  4 ++--
 modules/gallery/helpers/gallery_rss.php            |  4 ++--
 .../gallery/views/admin_advanced_settings.html.php |  4 ++--
 .../gallery/views/admin_block_platform.html.php    |  2 +-
 modules/gallery/views/admin_graphics.html.php      |  6 ++---
 modules/gallery/views/admin_graphics_none.html.php |  2 +-
 modules/gallery/views/admin_identity.html.php      |  2 +-
 modules/gallery/views/admin_languages.html.php     |  4 ++--
 modules/gallery/views/admin_maintenance.html.php   | 12 +++++-----
 modules/gallery/views/admin_sidebar.html.php       |  6 ++---
 modules/gallery/views/admin_themes.html.php        |  4 ++--
 modules/gallery/views/l10n_client.html.php         |  6 ++---
 modules/gallery/views/login.html.php               |  2 +-
 modules/gallery/views/login_ajax.html.php          |  4 ++--
 modules/gallery/views/maintenance.html.php         |  4 ++--
 modules/gallery/views/simple_uploader.html.php     |  4 ++--
 modules/gallery/views/upgrader.html.php            |  2 +-
 modules/gallery/views/welcome_message.html.php     |  4 ++--
 modules/image_block/helpers/image_block_block.php  |  4 ++--
 modules/info/helpers/info_block.php                |  2 +-
 .../notification/views/comment_published.html.php  |  4 ++--
 modules/notification/views/item_updated.html.php   |  4 ++--
 modules/recaptcha/views/admin_recaptcha.html.php   |  6 ++---
 modules/rss/helpers/rss_block.php                  |  4 ++--
 modules/search/views/search.html.php               |  2 +-
 modules/server_add/helpers/server_add_event.php    |  2 +-
 modules/server_add/views/admin_server_add.html.php |  6 ++---
 modules/tag/helpers/tag_block.php                  |  4 ++--
 modules/user/views/admin_users.html.php            | 14 ++++++------
 modules/user/views/admin_users_group.html.php      |  8 +++----
 modules/user/views/reset_password.html.php         |  4 ++--
 modules/watermark/views/admin_watermarks.html.php  |  6 ++---
 themes/admin_wind/views/admin.html.php             |  6 ++---
 themes/admin_wind/views/pager.html.php             | 16 ++++++-------
 themes/night_wind/views/movie.html.php             |  8 +++----
 themes/night_wind/views/pager.html.php             | 16 ++++++-------
 themes/wind/views/movie.html.php                   |  8 +++----
 themes/wind/views/pager.html.php                   | 16 ++++++-------
 48 files changed, 137 insertions(+), 137 deletions(-)

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/akismet/views/admin_akismet.html.php b/modules/akismet/views/admin_akismet.html.php
index d273be5b..399053d8 100644
--- a/modules/akismet/views/admin_akismet.html.php
+++ b/modules/akismet/views/admin_akismet.html.php
@@ -1,6 +1,6 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div id="g-admin-akismet" class="g-block">
-  <h1> <?= t("Akismet Spam Filtering") ?> </h1>
+  <h1> <?= t("Akismet spam filtering") ?> </h1>
   <p>
   <?= t("Akismet is a free, automated spam filtering service.  In order to use it, you need to sign up for a <a href=\"%api_key_url\">Wordpress.com API Key</a>, which is also free.  Your comments will be automatically relayed to <a href=\"%akismet_url\">Akismet.com</a> where they'll be scanned for spam.  Spam messages will be flagged accordingly and hidden from your vistors until you approve or delete them.",
         array("api_key_url" => "http://wordpress.com/api-keys",
@@ -9,7 +9,7 @@
   <div class="g-block-content">
     <? if ($valid_key): ?>
     <div class="g-module-status g-success">
-      <?= t("Your API Key is valid.  Your comments will be filtered!") ?>
+      <?= t("Your API key is valid.  Your comments will be filtered!") ?>
     </div>
     <? endif ?>
 
diff --git a/modules/comment/helpers/comment_block.php b/modules/comment/helpers/comment_block.php
index c00c6c51..7cd5d429 100644
--- a/modules/comment/helpers/comment_block.php
+++ b/modules/comment/helpers/comment_block.php
@@ -19,7 +19,7 @@
  */
 class comment_block_Core {
   static function get_admin_list() {
-    return array("recent_comments" => t("Recent Comments"));
+    return array("recent_comments" => t("Recent comments"));
   }
 
   static function get($block_id) {
@@ -27,7 +27,7 @@ class comment_block_Core {
     switch ($block_id) {
     case "recent_comments":
       $block->css_id = "g-recent-comments";
-      $block->title = t("Recent Comments");
+      $block->title = t("Recent comments");
       $block->content = new View("admin_block_recent_comments.html");
       $block->content->comments =
         ORM::factory("comment")->orderby("created", "DESC")->limit(5)->find_all();
diff --git a/modules/comment/helpers/comment_rss.php b/modules/comment/helpers/comment_rss.php
index 4424981d..3692a30d 100644
--- a/modules/comment/helpers/comment_rss.php
+++ b/modules/comment/helpers/comment_rss.php
@@ -61,7 +61,7 @@ class comment_rss_Core {
     $feed->max_pages = ceil($comments->count_all() / $limit);
     $feed->title = htmlspecialchars(t("Recent Comments"));
     $feed->uri = url::abs_site("albums/" . (empty($id) ? "1" : $id));
-    $feed->description = t("Recent Comments");
+    $feed->description = t("Recent comments");
 
     return $feed;
   }
diff --git a/modules/comment/views/admin_comments.html.php b/modules/comment/views/admin_comments.html.php
index 82e071a8..f0f5ab1c 100644
--- a/modules/comment/views/admin_comments.html.php
+++ b/modules/comment/views/admin_comments.html.php
@@ -35,7 +35,7 @@
 </script>
 
 <div id="g-admin-comments" class="g-block">
-  <h1> <?= t("Manage Comments") ?> </h1>
+  <h1> <?= t("Manage comments") ?> </h1>
 
   <div class="g-block-content">
     <!-- @todo: Highlight active menu option -->
@@ -46,13 +46,13 @@
     <!-- @todo: Remove after setting active option? -->
     <h2>
       <? if ($state == "published"): ?>
-      <?= t("Approved Comments") ?>
+      <?= t("Approved comments") ?>
       <? elseif ($state == "unpublished"): ?>
-      <?= t("Comments Awaiting Moderation") ?>
+      <?= t("Comments awaiting moderation") ?>
       <? elseif ($state == "spam"): ?>
-      <?= t("Spam Comments") ?>
+      <?= t("Spam comments") ?>
       <? elseif ($state == "deleted"): ?>
-      <?= t("Recently Deleted Comments") ?>
+      <?= t("Recently deleted comments") ?>
       <? endif ?>
     </h2>
 
@@ -196,6 +196,6 @@
     <div class="g-pager">
       <?= $pager ?>
     </div>
-    
+
   </div>
 </div>
diff --git a/modules/exif/views/exif_dialog.html.php b/modules/exif/views/exif_dialog.html.php
index b50eea1d..22744e2d 100644
--- a/modules/exif/views/exif_dialog.html.php
+++ b/modules/exif/views/exif_dialog.html.php
@@ -4,7 +4,7 @@
   .g-odd { background: #bdd2ff; }
   .g-even { background: #dfeffc; }
 </style>
-<h1 style="display: none;"><?= t("Photo Detail") ?></h1>
+<h1 style="display: none;"><?= t("Photo detail") ?></h1>
 <div id="g-exif-data">
   <table class="g-metadata" >
     <tbody>
diff --git a/modules/exif/views/exif_sidebar.html.php b/modules/exif/views/exif_sidebar.html.php
index 04f72b02..8af2eb12 100644
--- a/modules/exif/views/exif_sidebar.html.php
+++ b/modules/exif/views/exif_sidebar.html.php
@@ -1,5 +1,5 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
-<a id="g-exif-data-link" href="<?= url::site("exif/show/{$item->id}") ?>" title="<?= t("Photo Details")->for_html_attr() ?>"
+<a id="g-exif-data-link" href="<?= url::site("exif/show/{$item->id}") ?>" title="<?= t("Photo details")->for_html_attr() ?>"
   class="g-dialog-link g-button ui-icon-left ui-state-default ui-corner-all">
   <span class="ui-icon ui-icon-info"></span>
   <?= t("View more information") ?>
diff --git a/modules/g2_import/helpers/g2_import.php b/modules/g2_import/helpers/g2_import.php
index f55e7f32..248f8017 100644
--- a/modules/g2_import/helpers/g2_import.php
+++ b/modules/g2_import/helpers/g2_import.php
@@ -271,7 +271,7 @@ class g2_import_Core {
 
     if (g2(GalleryCoreApi::isAnonymousUser($g2_user_id))) {
       self::set_map($g2_user_id, identity::guest()->id);
-      return t("Skipping Anonymous User");
+      return t("Skipping anonymous user");
     }
 
     $g2_admin_group_id =
diff --git a/modules/g2_import/views/admin_g2_import.html.php b/modules/g2_import/views/admin_g2_import.html.php
index e1443aa7..b2665a5f 100644
--- a/modules/g2_import/views/admin_g2_import.html.php
+++ b/modules/g2_import/views/admin_g2_import.html.php
@@ -1,6 +1,6 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div id="g-admin-g2-import" class="g-block">
-  <h1> <?= t("Gallery 2 Import") ?> </h1>
+  <h1> <?= t("Gallery 2 import") ?> </h1>
   <p>
     <?= t("Import your Gallery 2 users, photos, movies, comments and tags into your new Gallery 3 installation.") ?>
   </p>
diff --git a/modules/gallery/controllers/admin_languages.php b/modules/gallery/controllers/admin_languages.php
index ccc631c7..27537c7f 100644
--- a/modules/gallery/controllers/admin_languages.php
+++ b/modules/gallery/controllers/admin_languages.php
@@ -115,7 +115,7 @@ class Admin_Languages_Controller extends Admin_Controller {
               ? t("This is a unique key that will allow you to send translations to the remote
                   server. To get your API key go to %server-link.",
                   array("server-link" => html::mark_clean(html::anchor($server_link))))
-              : t("API Key"))
+              : t("API key"))
       ->value($api_key)
       ->error_messages("invalid", t("The API key you provided is invalid."));
     $group->submit("save")->value(t("Save settings"));
diff --git a/modules/gallery/helpers/gallery_block.php b/modules/gallery/helpers/gallery_block.php
index 6c08d39a..0052affc 100644
--- a/modules/gallery/helpers/gallery_block.php
+++ b/modules/gallery/helpers/gallery_block.php
@@ -21,15 +21,15 @@ class gallery_block_Core {
   static function get_admin_list() {
     return array(
       "welcome" => t("Welcome to Gallery 3!"),
-      "photo_stream" => t("Photo Stream"),
-      "log_entries" => t("Log Entries"),
-      "stats" => t("Gallery Stats"),
-      "platform_info" => t("Platform Information"),
-      "project_news" => t("Gallery Project News"));
+      "photo_stream" => t("Photo stream"),
+      "log_entries" => t("Log entries"),
+      "stats" => t("Gallery stats"),
+      "platform_info" => t("Platform information"),
+      "project_news" => t("Gallery project news"));
   }
 
   static function get_site_list() {
-    return array("language" => t("Language Preference"));
+    return array("language" => t("Language preference"));
   }
 
   static function get($block_id) {
@@ -43,7 +43,7 @@ class gallery_block_Core {
 
     case "photo_stream":
       $block->css_id = "g-photo-stream";
-      $block->title = t("Photo Stream");
+      $block->title = t("Photo stream");
       $block->content = new View("admin_block_photo_stream.html");
       $block->content->photos =
         ORM::factory("item")->where("type", "photo")->orderby("created", "DESC")->find_all(10);
@@ -51,7 +51,7 @@ class gallery_block_Core {
 
     case "log_entries":
       $block->css_id = "g-log-entries";
-      $block->title = t("Log Entries");
+      $block->title = t("Log entries");
       $block->content = new View("admin_block_log_entries.html");
       $block->content->entries = ORM::factory("log")
         ->orderby(array("timestamp" => "DESC", "id" => "DESC"))->find_all(5);
@@ -59,7 +59,7 @@ class gallery_block_Core {
 
     case "stats":
       $block->css_id = "g-stats";
-      $block->title = t("Gallery Stats");
+      $block->title = t("Gallery stats");
       $block->content = new View("admin_block_stats.html");
       $block->content->album_count =
         ORM::factory("item")->where("type", "album")->where("id <>", 1)->count_all();
@@ -68,7 +68,7 @@ class gallery_block_Core {
 
     case "platform_info":
       $block->css_id = "g-platform";
-      $block->title = t("Platform Information");
+      $block->title = t("Platform information");
       $block->content = new View("admin_block_platform.html");
       if (is_readable("/proc/loadavg")) {
         $block->content->load_average =
@@ -80,14 +80,14 @@ class gallery_block_Core {
 
     case "project_news":
       $block->css_id = "g-project-news";
-      $block->title = t("Gallery Project News");
+      $block->title = t("Gallery project news");
       $block->content = new View("admin_block_news.html");
       $block->content->feed = feed::parse("http://gallery.menalto.com/node/feed", 3);
       break;
 
     case "block_adder":
       $block->css_id = "g-block-adder";
-      $block->title = t("Dashboard Content");
+      $block->title = t("Dashboard content");
       $block->content = self::get_add_block_form();
       break;
 
@@ -99,7 +99,7 @@ class gallery_block_Core {
         }
         $block = new Block();
         $block->css_id = "g-user-language-block";
-        $block->title = t("Language Preference");
+        $block->title = t("Language preference");
         $block->content = new View("user_languages_block.html");
         $block->content->installed_locales =
           array_merge(array("" => t("« none »")), $locales);
diff --git a/modules/gallery/helpers/gallery_installer.php b/modules/gallery/helpers/gallery_installer.php
index 01a213c8..5daf1016 100644
--- a/modules/gallery/helpers/gallery_installer.php
+++ b/modules/gallery/helpers/gallery_installer.php
@@ -199,12 +199,12 @@ class gallery_installer {
     }
 
     access::register_permission("view", "View");
-    access::register_permission("view_full", "View Full Size");
+    access::register_permission("view_full", "View full size");
     access::register_permission("edit", "Edit");
     access::register_permission("add", "Add");
 
     // Mark for translation (must be the same strings as used above)
-    t("View Full Size");
+    t("View full size");
     t("View");
     t("Edit");
     t("Add");
diff --git a/modules/gallery/helpers/gallery_rss.php b/modules/gallery/helpers/gallery_rss.php
index feeab88a..155edfb5 100644
--- a/modules/gallery/helpers/gallery_rss.php
+++ b/modules/gallery/helpers/gallery_rss.php
@@ -39,8 +39,8 @@ class gallery_rss_Core {
         ->orderby("created", "DESC");
 
       $feed->max_pages = ceil($all_children->find_all()->count() / $limit);
-      $feed->title = t("Recent Updates");
-      $feed->description = t("Recent Updates");
+      $feed->title = t("Recent updates");
+      $feed->description = t("Recent updates");
       return $feed;
 
     case "album":
diff --git a/modules/gallery/views/admin_advanced_settings.html.php b/modules/gallery/views/admin_advanced_settings.html.php
index e3ae5f58..32fbc2c3 100644
--- a/modules/gallery/views/admin_advanced_settings.html.php
+++ b/modules/gallery/views/admin_advanced_settings.html.php
@@ -1,10 +1,10 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div id="g-admin-advanced-settings" class="g-block">
-  <h1> <?= t("Advanced Settings") ?> </h1>
+  <h1> <?= t("Advanced settings") ?> </h1>
   <p>
     <?= t("Here are internal Gallery configuration settings.  Most of these settings are accessible elsewhere in the administrative console.") ?>
   </p>
-  
+
   <ul id="g-action-status" class="g-message-block">
     <li class="g-warning"><?= t("Change these values at your own risk!") ?></li>
   </ul>
diff --git a/modules/gallery/views/admin_block_platform.html.php b/modules/gallery/views/admin_block_platform.html.php
index f27b9e7a..b1b8a2f9 100644
--- a/modules/gallery/views/admin_block_platform.html.php
+++ b/modules/gallery/views/admin_block_platform.html.php
@@ -4,7 +4,7 @@
     <?= t("Host name: %host_name", array("host_name" => php_uname("n"))) ?>
   </li>
   <li>
-    <?= t("Operating System: %os %version", array("os" => php_uname("s"), "version" => php_uname("r"))) ?>
+    <?= t("Operating system: %os %version", array("os" => php_uname("s"), "version" => php_uname("r"))) ?>
   </li>
   <li>
     <?= t("Apache: %apache_version", array("apache_version" => function_exists("apache_get_version") ? apache_get_version() : t("Unknown"))) ?>
diff --git a/modules/gallery/views/admin_graphics.html.php b/modules/gallery/views/admin_graphics.html.php
index 0f4c0dd8..3a48e087 100644
--- a/modules/gallery/views/admin_graphics.html.php
+++ b/modules/gallery/views/admin_graphics.html.php
@@ -13,13 +13,13 @@
 </script>
 
 <div id="g-admin-graphics" class="g-block ui-helper-clearfix">
-  <h1> <?= t("Graphics Settings") ?> </h1>
+  <h1> <?= t("Graphics settings") ?> </h1>
   <p>
     <?= t("Gallery needs a graphics toolkit in order to manipulate your photos.  Please choose one from the list below.") ?>
   </p>
 
   <div class="g-block-content">
-    <h2> <?= t("Active Toolkit") ?> </h2>
+    <h2> <?= t("Active toolkit") ?> </h2>
     <? if ($active == "none"): ?>
     <?= new View("admin_graphics_none.html") ?>
     <? else: ?>
@@ -27,7 +27,7 @@
     <? endif ?>
 
     <div class="g-available">
-      <h2> <?= t("Available Toolkits") ?> </h2>
+      <h2> <?= t("Available toolkits") ?> </h2>
       <? foreach (array_keys((array)$tk) as $id): ?>
       <? if ($id != $active): ?>
       <?= new View("admin_graphics_$id.html", array("tk" => $tk->$id, "is_active" => false)) ?>
diff --git a/modules/gallery/views/admin_graphics_none.html.php b/modules/gallery/views/admin_graphics_none.html.php
index 3ac6b4fb..e0fc4170 100644
--- a/modules/gallery/views/admin_graphics_none.html.php
+++ b/modules/gallery/views/admin_graphics_none.html.php
@@ -1,7 +1,7 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 
 <div id="none" class="g-module-status g-warning g-block">
-  <h3> <?= t("No Active Toolkit") ?> </h3>
+  <h3> <?= t("No active toolkit") ?> </h3>
   <p>
     <?= t("We were unable to detect a graphics program.  You must install one of the toolkits below in order to use many Gallery features.") ?>
   </p>
diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
index 358860cf..9a34dcc4 100644
--- a/modules/gallery/views/admin_identity.html.php
+++ b/modules/gallery/views/admin_identity.html.php
@@ -34,7 +34,7 @@
 
 </script>
 <div id="g-modules">
-  <h1> <?= t("Manage Identity Providers") ?> </h1>
+  <h1> <?= t("Manage identity providers") ?> </h1>
   <p>
     <?= t("Choose a different user/group management provider.") ?>
   </p>
diff --git a/modules/gallery/views/admin_languages.html.php b/modules/gallery/views/admin_languages.html.php
index 311672de..908cc892 100644
--- a/modules/gallery/views/admin_languages.html.php
+++ b/modules/gallery/views/admin_languages.html.php
@@ -26,7 +26,7 @@
 </script>
 
 <div class="g-block">
-  <h1> <?= t("Languages and Translation") ?> </h1>
+  <h1> <?= t("Languages and translation") ?> </h1>
 
   <div class="g-block-content">
 
@@ -107,6 +107,6 @@
         <?= $share_translations_form ?>
       </div>
     </div>
-    
+
   </div>
 </div>
diff --git a/modules/gallery/views/admin_maintenance.html.php b/modules/gallery/views/admin_maintenance.html.php
index 73a4bef8..107b35cc 100644
--- a/modules/gallery/views/admin_maintenance.html.php
+++ b/modules/gallery/views/admin_maintenance.html.php
@@ -1,13 +1,13 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div id="g-admin-maintenance" class="g-block">
-  <h1> <?= t("Maintenance Tasks") ?> </h1>
+  <h1> <?= t("Maintenance tasks") ?> </h1>
   <p>
     <?= t("Occasionally your Gallery will require some maintenance.  Here are some tasks you can use to keep it running smoothly.") ?>
   </p>
 
   <div class="g-block-content">
     <div id="g-available-tasks">
-      <h2> <?= t("Available Tasks") ?> </h2>
+      <h2> <?= t("Available tasks") ?> </h2>
       <table>
         <tr>
           <th>
@@ -43,11 +43,11 @@
 
     <? if ($running_tasks->count()): ?>
     <div id="g-running-tasks">
-      <h2> <?= t("Running Tasks") ?> </h2>
+      <h2> <?= t("Running tasks") ?> </h2>
       <table>
         <tr>
           <th>
-            <?= t("Last Updated") ?>
+            <?= t("Last updated") ?>
           </th>
           <th>
             <?= t("Name") ?>
@@ -116,11 +116,11 @@
 
     <? if ($finished_tasks->count()): ?>
     <div id="g-finished-tasks">
-      <h2> <?= t("Finished Tasks") ?> </h2>
+      <h2> <?= t("Finished tasks") ?> </h2>
       <table>
         <tr>
           <th>
-            <?= t("Last Updated") ?>
+            <?= t("Last updated") ?>
           </th>
           <th>
             <?= t("Name") ?>
diff --git a/modules/gallery/views/admin_sidebar.html.php b/modules/gallery/views/admin_sidebar.html.php
index 7c97270c..b394aa19 100644
--- a/modules/gallery/views/admin_sidebar.html.php
+++ b/modules/gallery/views/admin_sidebar.html.php
@@ -36,7 +36,7 @@
 </script>
 
 <div id="g-block-admin" class="g-block ui-helper-clearfix">
-  <h1> <?= t("Manage Sidebar") ?> </h1>
+  <h1> <?= t("Manage sidebar") ?> </h1>
   <p>
     <?= t("Select and drag blocks from the available column to the active column to add to the sidebar; remove by dragging the other way.") ?>
   </p>
@@ -44,7 +44,7 @@
   <div class="g-block-content">
     <div id="g-site-blocks" ref="<?= url::site("admin/sidebar/update?csrf={$csrf}__ACTIVE__") ?>">
       <div class="g-admin-blocks-list">
-        <div><h3><?= t("Available Blocks") ?></h3></div>
+        <div><h3><?= t("Available blocks") ?></h3></div>
         <div>
           <ul id="g-available-blocks" class="g-sortable-blocks">
           <?= $available ?>
@@ -52,7 +52,7 @@
         </div>
       </div>
       <div class="g-admin-blocks-list">
-        <div><h3><?= t("Active Blocks") ?></h3></div>
+        <div><h3><?= t("Active blocks") ?></h3></div>
         <div>
           <ul id="g-active-blocks" class="g-sortable-blocks">
           <?= $active ?>
diff --git a/modules/gallery/views/admin_themes.html.php b/modules/gallery/views/admin_themes.html.php
index dda18265..d14e8bd4 100644
--- a/modules/gallery/views/admin_themes.html.php
+++ b/modules/gallery/views/admin_themes.html.php
@@ -8,7 +8,7 @@
 </script>
 
 <div class="g-block ui-helper-clearfix">
-  <h1> <?= t("Theme Choice") ?> </h1>
+  <h1> <?= t("Theme choice") ?> </h1>
   <p>
     <?= t("Gallery allows you to choose a theme for browsing your Gallery, as well as a special theme for the administration interface.  Click a theme to preview and activate it.") ?>
   </p>
@@ -89,6 +89,6 @@
         <? endif ?>
       </div>
     </div>
-    
+
   </div>
 </div>
\ No newline at end of file
diff --git a/modules/gallery/views/l10n_client.html.php b/modules/gallery/views/l10n_client.html.php
index f4da52dc..9d14bbb2 100644
--- a/modules/gallery/views/l10n_client.html.php
+++ b/modules/gallery/views/l10n_client.html.php
@@ -6,9 +6,9 @@
       <a id="g-close-l10n" title="<?= t("Stop the translation mode")->for_html_attr() ?>"
          href="<?= html::clean_attribute(url::site("l10n_client/toggle_l10n_mode?csrf=".access::csrf_token())) ?>">X</a>
     </span>
-    <div class="label strings"><h2><?= t("Page Text") ?>
+    <div class="label strings"><h2><?= t("Page text") ?>
     <? if (!Input::instance()->get('show_all_l10n_messages')): ?>
-      <a style="background-color:#fff" href="<?= url::site("admin/languages?show_all_l10n_messages=1") ?>"><?= t("(Show All)") ?></a>
+      <a style="background-color:#fff" href="<?= url::site("admin/languages?show_all_l10n_messages=1") ?>"><?= t("(Show all)") ?></a>
     <? endif; ?>
     </h2></div>
     <div class="label source"><h2><?= t("Source") ?></div>
@@ -73,7 +73,7 @@
     </div>
   </div>
   <script type="text/javascript">
-    var MSG_TRANSLATE_TEXT = <?= t("Translate Text")->for_js() ?>;
+    var MSG_TRANSLATE_TEXT = <?= t("Translate text")->for_js() ?>;
     var l10n_client_data = <?= json_encode($string_list) ?>;
     var plural_forms = <?= json_encode($plural_forms) ?>;
     var toggle_l10n_mode_url = <?= html::js_string(url::site("l10n_client/toggle_l10n_mode")) ?>;
diff --git a/modules/gallery/views/login.html.php b/modules/gallery/views/login.html.php
index 971d18b8..a7734369 100644
--- a/modules/gallery/views/login.html.php
+++ b/modules/gallery/views/login.html.php
@@ -11,7 +11,7 @@
     <? if (identity::is_writable()): ?>
     <?= t('Logged in as %name', array('name' => html::mark_clean(
       '<a href="' . url::site("form/edit/users/{$user->id}") .
-      '" title="' . t("Edit Your Profile")->for_html_attr() .
+      '" title="' . t("Edit your profile")->for_html_attr() .
       '" id="g-user-profile-link" class="g-dialog-link">' .
       html::clean($user->display_name()) . '</a>'))) ?>
     <? else: ?>
diff --git a/modules/gallery/views/login_ajax.html.php b/modules/gallery/views/login_ajax.html.php
index a9a9ef11..9741db0c 100644
--- a/modules/gallery/views/login_ajax.html.php
+++ b/modules/gallery/views/login_ajax.html.php
@@ -6,7 +6,7 @@
         url: "<?= url::site("password/reset") ?>",
         success: function(data) {
           $("#g-login").html(data);
-          $("#ui-dialog-title-g-dialog").html(<?= t("Reset Password")->for_js() ?>);
+          $("#ui-dialog-title-g-dialog").html(<?= t("Reset password")->for_js() ?>);
           $(".submit").addClass("g-button ui-state-default ui-corner-all");
           $(".submit").gallery_hover_init();
           ajaxify_login_reset_form();
@@ -38,7 +38,7 @@
     </li>
     <? if (identity::is_writable()): ?>
     <li>
-      <a href="#" id="g-password-reset" class="g-right g-txt-small"><?= t("Forgot Your Password?") ?></a>
+      <a href="#" id="g-password-reset" class="g-right g-txt-small"><?= t("Forgot your password?") ?></a>
     </li>
     <? endif ?>
   </ul>
diff --git a/modules/gallery/views/maintenance.html.php b/modules/gallery/views/maintenance.html.php
index 55395b73..2fdc40a3 100644
--- a/modules/gallery/views/maintenance.html.php
+++ b/modules/gallery/views/maintenance.html.php
@@ -2,7 +2,7 @@
 <html>
   <head>
     <title>
-      <?= t("Gallery - Maintenance Mode") ?>
+      <?= t("Gallery - maintenance mode") ?>
     </title>
     <style>
       body {
@@ -38,7 +38,7 @@
   </head>
   <body>
     <h1>
-      <?= t("Gallery - Maintenance Mode") ?>
+      <?= t("Gallery - maintenance mode") ?>
     </h1>
     <p>
       <?= t("This site is currently only accessible by site administrators.") ?>
diff --git a/modules/gallery/views/simple_uploader.html.php b/modules/gallery/views/simple_uploader.html.php
index 9285fffe..b9c33d32 100644
--- a/modules/gallery/views/simple_uploader.html.php
+++ b/modules/gallery/views/simple_uploader.html.php
@@ -34,7 +34,7 @@
   </ul>
 
   <div id="g-uploadqueue-infobar">
-    <?= t("Upload Queue") ?>
+    <?= t("Upload queue") ?>
     <span id="g-uploadstatus"></span>
     <a id="g-cancelupload" title="<?= t("Cancel all the pending uploads")->for_html_attr() ?>" onclick="swfu.cancelQueue();"><?= t("cancel") ?></a>
   </div>
@@ -60,7 +60,7 @@
       "csrf" => $csrf)) ?>,
     file_size_limit: <?= html::js_string(ini_get("upload_max_filesize") ? num::convert_to_bytes(ini_get("upload_max_filesize"))."B" : "100MB") ?>,
     file_types: "*.gif;*.jpg;*.jpeg;*.png;*.flv;*.mp4;*.GIF;*.JPG;*.JPEG;*.PNG;*.FLV;*.MP4",
-    file_types_description: <?= t("Photos and Movies")->for_js() ?>,
+    file_types_description: <?= t("Photos and movies")->for_js() ?>,
     file_upload_limit: 1000,
     file_queue_limit: 0,
     custom_settings: { },
diff --git a/modules/gallery/views/upgrader.html.php b/modules/gallery/views/upgrader.html.php
index 8a01cd29..fb55c4b2 100644
--- a/modules/gallery/views/upgrader.html.php
+++ b/modules/gallery/views/upgrader.html.php
@@ -1,7 +1,7 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <html>
   <head>
-    <title><?= t("Gallery 3 Upgrader") ?></title>
+    <title><?= t("Gallery 3 upgrader") ?></title>
     <link rel="stylesheet" type="text/css" href="<?= url::file("modules/gallery/css/upgrader.css") ?>"
           media="screen,print,projection" />
     <script src="<?= url::file("lib/jquery.js") ?>" type="text/javascript"></script>
diff --git a/modules/gallery/views/welcome_message.html.php b/modules/gallery/views/welcome_message.html.php
index 4acdb156..b50163fa 100644
--- a/modules/gallery/views/welcome_message.html.php
+++ b/modules/gallery/views/welcome_message.html.php
@@ -16,10 +16,10 @@
 
   <p>
     <a href="<?= url::site("form/edit/users/{$user->id}") ?>"
-      title="<?= t("Edit Your Profile")->for_html_attr() ?>"
+      title="<?= t("Edit your profile")->for_html_attr() ?>"
       id="g-after-install-change-password-link"
       class="g-button ui-state-default ui-corners-all">
-      <?= t("Change Password Now") ?>
+      <?= t("Change password now") ?>
     </a>
     <script>
       $("#g-after-install-change-password-link").gallery_dialog();
diff --git a/modules/image_block/helpers/image_block_block.php b/modules/image_block/helpers/image_block_block.php
index eb4f7aab..79bd92ba 100644
--- a/modules/image_block/helpers/image_block_block.php
+++ b/modules/image_block/helpers/image_block_block.php
@@ -19,7 +19,7 @@
  */
 class image_block_block_Core {
   static function get_site_list() {
-    return array("random_image" => t("Random Image"));
+    return array("random_image" => t("Random image"));
   }
 
   static function get($block_id, $theme) {
@@ -28,7 +28,7 @@ class image_block_block_Core {
     case "random_image":
       $block = new Block();
       $block->css_id = "g-image-block";
-      $block->title = t("Random Image");
+      $block->title = t("Random image");
       $block->content = new View("image_block_block.html");
 
       $random = ((float)mt_rand()) / (float)mt_getrandmax();
diff --git a/modules/info/helpers/info_block.php b/modules/info/helpers/info_block.php
index d28b02e7..a86bbec9 100644
--- a/modules/info/helpers/info_block.php
+++ b/modules/info/helpers/info_block.php
@@ -29,7 +29,7 @@ class info_block_Core {
       if ($theme->item()) {
         $block = new Block();
         $block->css_id = "g-metadata";
-        $block->title = $theme->item()->is_album() ? t("Album Info") : t("Photo Info");
+        $block->title = $theme->item()->is_album() ? t("Album info") : t("Photo info");
         $block->content = new View("info_block.html");
       }
       break;
diff --git a/modules/notification/views/comment_published.html.php b/modules/notification/views/comment_published.html.php
index a8ca1899..ac36a2c1 100644
--- a/modules/notification/views/comment_published.html.php
+++ b/modules/notification/views/comment_published.html.php
@@ -11,11 +11,11 @@
   <td><?= nl2br(html::purify($comment->text)) ?></td>
       </tr>
       <tr>
-        <td><?= t("Author Name:") ?></td>
+        <td><?= t("Author name:") ?></td>
         <td><?= html::clean($comment->author_name()) ?></td>
       </tr>
       <tr>
-        <td><?= t("Author Email:") ?></td>
+        <td><?= t("Author email:") ?></td>
         <td><?= html::clean($comment->author_email()) ?></td>
       </tr>
       <tr>
diff --git a/modules/notification/views/item_updated.html.php b/modules/notification/views/item_updated.html.php
index 9c200964..47856cab 100644
--- a/modules/notification/views/item_updated.html.php
+++ b/modules/notification/views/item_updated.html.php
@@ -8,7 +8,7 @@
     <table>
       <tr>
         <? if ($item->original("title") != $item->title): ?>
-        <td><?= t("New Title:") ?></td>
+        <td><?= t("New title:") ?></td>
         <td><?= html::clean($item->title) ?></td>
         <? else: ?>
         <td><?= t("Title:") ?></td>
@@ -21,7 +21,7 @@
       </tr>
       <? if ($item->original("description") != $item->description): ?>
       <tr>
-        <td><?= t("New Description:") ?></td>
+        <td><?= t("New description:") ?></td>
         <td><?= html::clean($item->description) ?></td>
       </tr>
       <? elseif (!empty($item->description)): ?>
diff --git a/modules/recaptcha/views/admin_recaptcha.html.php b/modules/recaptcha/views/admin_recaptcha.html.php
index a0af3ba8..4f07fef0 100644
--- a/modules/recaptcha/views/admin_recaptcha.html.php
+++ b/modules/recaptcha/views/admin_recaptcha.html.php
@@ -1,6 +1,6 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div class="g-block">
-  <h1> <?= t("reCAPTCHA Challenge Filtering") ?> </h1>
+  <h1> <?= t("reCAPTCHA challenge filtering") ?> </h1>
   <p>
     <?= t("reCAPTCHA is a free CAPTCHA service that helps to digitize books, newspapers and old time radio shows.  In order to use it, you need to sign up for a <a href=\"%domain_url\">reCAPTCHA Public/Private Key pair</a>, which is also free.  Once registered, the challenge and response strings are evaluated at <a href=\"%recaptcha_url\">recaptcha.net</a> to determine if the form content has been entered by a bot.",
           array("domain_url" => $form->get_key_url,
@@ -12,7 +12,7 @@
 
     <? if ($public_key && $private_key): ?>
     <div id="g-admin-recaptcha-test">
-      <h2> <?= t("reCAPTCHA Test") ?> </h2>
+      <h2> <?= t("reCAPTCHA test") ?> </h2>
       <p>
         <?= t("If you see a CAPTCHA form below, then reCAPTCHA is functioning properly.") ?>
       </p>
@@ -30,6 +30,6 @@
       </div>
     </div>
     <? endif ?>
-  
+
   </div>
 </div>
diff --git a/modules/rss/helpers/rss_block.php b/modules/rss/helpers/rss_block.php
index cfd3098d..8da45e98 100644
--- a/modules/rss/helpers/rss_block.php
+++ b/modules/rss/helpers/rss_block.php
@@ -19,7 +19,7 @@
  */
 class rss_block_Core {
   static function get_site_list() {
-    return array("rss_feeds" => t("Available RSS Feeds"));
+    return array("rss_feeds" => t("Available RSS feeds"));
   }
 
   static function get($block_id, $theme) {
@@ -37,7 +37,7 @@ class rss_block_Core {
       if (!empty($feeds)) {
         $block = new Block();
         $block->css_id = "g-rss";
-        $block->title = t("Available RSS Feeds");
+        $block->title = t("Available RSS feeds");
         $block->content = new View("rss_block.html");
         $block->content->feeds = $feeds;
       }
diff --git a/modules/search/views/search.html.php b/modules/search/views/search.html.php
index af14520b..4b67157e 100644
--- a/modules/search/views/search.html.php
+++ b/modules/search/views/search.html.php
@@ -18,7 +18,7 @@
 </form>
 
 <div id="g-search-results">
-  <h1><?= t("Search Results") ?></h1>
+  <h1><?= t("Search results") ?></h1>
 
   <? if (count($items)): ?>
   <ul id="g-album-grid" class="ui-helper-clearfix">
diff --git a/modules/server_add/helpers/server_add_event.php b/modules/server_add/helpers/server_add_event.php
index 1d883a71..e1295bd4 100644
--- a/modules/server_add/helpers/server_add_event.php
+++ b/modules/server_add/helpers/server_add_event.php
@@ -35,7 +35,7 @@ class server_add_event_Core {
       $menu->get("add_menu")
         ->append(Menu::factory("dialog")
                  ->id("server_add")
-                 ->label(t("Server add"))
+                 ->label(t("Server Add"))
                  ->url(url::site("server_add/browse/$item->id")));
     }
   }
diff --git a/modules/server_add/views/admin_server_add.html.php b/modules/server_add/views/admin_server_add.html.php
index 33fd81f3..6dbb8637 100644
--- a/modules/server_add/views/admin_server_add.html.php
+++ b/modules/server_add/views/admin_server_add.html.php
@@ -1,12 +1,12 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <div class="g-block">
-  <h1> <?= t("Add From Server Admininstration") ?> </h1>
+  <h1> <?= t("Add from server admininstration") ?> </h1>
   <div class="g-block-content">
     <?= $form ?>
-    <h2><?= t("Authorized Paths") ?></h2>
+    <h2><?= t("Authorized paths") ?></h2>
     <ul id="g-server-add-paths">
       <? if (empty($paths)): ?>
-      <li class="g-module-status g-info"><?= t("No Authorized image source paths defined yet") ?></li>
+      <li class="g-module-status g-info"><?= t("No authorized image source paths defined yet") ?></li>
       <? endif ?>
       <? foreach ($paths as $id => $path): ?>
       <li>
diff --git a/modules/tag/helpers/tag_block.php b/modules/tag/helpers/tag_block.php
index 37da0b16..20ef18fa 100644
--- a/modules/tag/helpers/tag_block.php
+++ b/modules/tag/helpers/tag_block.php
@@ -19,7 +19,7 @@
  */
 class tag_block_Core {
   static function get_site_list() {
-    return array("tag" => t("Popular Tags"));
+    return array("tag" => t("Popular tags"));
   }
 
   static function get($block_id, $theme) {
@@ -28,7 +28,7 @@ class tag_block_Core {
     case "tag":
       $block = new Block();
       $block->css_id = "g-tag";
-      $block->title = t("Popular Tags");
+      $block->title = t("Popular tags");
       $block->content = new View("tag_block.html");
       $block->content->cloud = tag::cloud(30);
 
diff --git a/modules/user/views/admin_users.html.php b/modules/user/views/admin_users.html.php
index b64f93b1..661f1532 100644
--- a/modules/user/views/admin_users.html.php
+++ b/modules/user/views/admin_users.html.php
@@ -43,7 +43,7 @@
 </script>
 
 <div class="g-block">
-  <h1> <?= t("Users and Groups") ?> </h1>
+  <h1> <?= t("Users and groups") ?> </h1>
 
   <div class="g-block-content">
     <div class="g-block">
@@ -54,7 +54,7 @@
         <?= t("Add a new user") ?>
       </a>
 
-      <h2> <?= t("User Admin") ?> </h2>
+      <h2> <?= t("User admin") ?> </h2>
 
       <div class="g-block-content">
         <table id="g-user-admin-list">
@@ -87,17 +87,17 @@
             </td>
             <td class="g-actions">
               <a href="<?= url::site("admin/users/edit_user_form/$user->id") ?>"
-                  open_text="<?= t("close") ?>"
+                  open_text="<?= t("Close") ?>"
                   class="g-panel-link g-button ui-state-default ui-corner-all ui-icon-left">
-                <span class="ui-icon ui-icon-pencil"></span><span class="g-button-text"><?= t("edit") ?></span></a>
+                <span class="ui-icon ui-icon-pencil"></span><span class="g-button-text"><?= t("Edit") ?></span></a>
               <? if (identity::active_user()->id != $user->id && !$user->guest): ?>
               <a href="<?= url::site("admin/users/delete_user_form/$user->id") ?>"
                   class="g-dialog-link g-button ui-state-default ui-corner-all ui-icon-left">
-                <span class="ui-icon ui-icon-trash"></span><?= t("delete") ?></a>
+                <span class="ui-icon ui-icon-trash"></span><?= t("Delete") ?></a>
               <? else: ?>
               <span title="<?= t("This user cannot be deleted")->for_html_attr() ?>"
                   class="g-button ui-state-disabled ui-corner-all ui-icon-left">
-                <span class="ui-icon ui-icon-trash"></span><?= t("delete") ?></span>
+                <span class="ui-icon ui-icon-trash"></span><?= t("Delete") ?></span>
               <? endif ?>
             </td>
           </tr>
@@ -115,7 +115,7 @@
       </a>
 
       <h2>
-        <?= t("Group Admin") ?>
+        <?= t("Group admin") ?>
       </h2>
 
       <div class="g-block-content">
diff --git a/modules/user/views/admin_users_group.html.php b/modules/user/views/admin_users_group.html.php
index db3645a0..e44cbddd 100644
--- a/modules/user/views/admin_users_group.html.php
+++ b/modules/user/views/admin_users_group.html.php
@@ -5,11 +5,11 @@
   <a href="<?= url::site("admin/users/delete_group_form/$group->id") ?>"
     title="<?= t("Delete the %name group", array("name" => $group->name))->for_html_attr() ?>"
     class="g-dialog-link g-button ui-state-default ui-corner-all">
-    <span class="ui-icon ui-icon-trash"><?= t("delete") ?></span></a>
+    <span class="ui-icon ui-icon-trash"><?= t("Delete") ?></span></a>
   <? else: ?>
   <a title="<?= t("This default group cannot be deleted")->for_html_attr() ?>"
      class="g-dialog-link g-button ui-state-disabled ui-corner-all ui-icon-left">
-    <span class="ui-icon ui-icon-trash"><?= t("delete") ?></span></a>
+    <span class="ui-icon ui-icon-trash"><?= t("Delete") ?></span></a>
   <? endif ?>
 </h4>
 
@@ -23,7 +23,7 @@
        class="g-button ui-state-default ui-corner-all ui-icon-left"
        title="<?= t("Remove %user from %group group",
               array("user" => $user->name, "group" => $group->name))->for_html_attr() ?>">
-      <span class="ui-icon ui-icon-closethick"><?= t("remove") ?></span>
+      <span class="ui-icon ui-icon-closethick"><?= t("Remove") ?></span>
     </a>
     <? endif ?>
   </li>
@@ -32,7 +32,7 @@
 <? else: ?>
 <div>
   <p>
-    <?= t("Drag &amp; drop users from the User Admin above into this group box to add group members.") ?>
+    <?= t("Drag &amp; drop users from the \"User admin\" above into this group box to add group members.") ?>
   </p>
 </div>
 <? endif ?>
diff --git a/modules/user/views/reset_password.html.php b/modules/user/views/reset_password.html.php
index 92ca4917..3afca881 100644
--- a/modules/user/views/reset_password.html.php
+++ b/modules/user/views/reset_password.html.php
@@ -1,10 +1,10 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <html>
   <head>
-    <title><?= t("Password Reset Request") ?> </title>
+    <title><?= t("Password reset request") ?> </title>
   </head>
   <body>
-    <h2><?= t("Password Reset Request") ?> </h2>
+    <h2><?= t("Password reset request") ?> </h2>
     <p>
       <?= t("Hello, %name,", array("name" => $user->full_name ? $user->full_name : $user->name)) ?>
     </p>
diff --git a/modules/watermark/views/admin_watermarks.html.php b/modules/watermark/views/admin_watermarks.html.php
index af38cb41..fc634b82 100644
--- a/modules/watermark/views/admin_watermarks.html.php
+++ b/modules/watermark/views/admin_watermarks.html.php
@@ -11,7 +11,7 @@
        title="<?= t("Upload a watermark")->for_html_attr() ?>"
        class="g-dialog-link g-button ui-icon-left ui-state-default ui-corner-all"><span class="ui-icon ui-icon-document-b"></span><?= t("Upload a watermark") ?></a>
     <? else: ?>
-    <h2> <?= t("Active Watermark") ?> </h2>
+    <h2> <?= t("Active watermark") ?> </h2>
     <p>
       <?= t("Note that changing this watermark will require you to rebuild all of your thumbnails and resized images.") ?>
     </p>
@@ -27,10 +27,10 @@
       </div>
       <div class="controls">
         <a href="<?= url::site("admin/watermarks/form_edit") ?>"
-           title="<?= t("Edit Watermark")->for_html_attr() ?>"
+           title="<?= t("Edit watermark")->for_html_attr() ?>"
            class="g-dialog-link g-button ui-icon-left ui-state-default ui-corner-all"><span class="ui-icon ui-icon-pencil"></span><?= t("edit") ?></a>
         <a href="<?= url::site("admin/watermarks/form_delete") ?>"
-           title="<?= t("Delete Watermark")->for_html_attr() ?>"
+           title="<?= t("Delete watermark")->for_html_attr() ?>"
            class="g-dialog-link g-button ui-icon-left ui-state-default ui-corner-all"><span class="ui-icon ui-icon-trash"></span><?= t("delete") ?></a>
       </div>
     </div>
diff --git a/themes/admin_wind/views/admin.html.php b/themes/admin_wind/views/admin.html.php
index ef1aa1d2..e554b817 100644
--- a/themes/admin_wind/views/admin.html.php
+++ b/themes/admin_wind/views/admin.html.php
@@ -4,7 +4,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
   <head>
     <meta http-equiv="content-type" content="text/html; charset=UTF-8" />
-    <title><?= t("Admin Dashboard") ?></title>
+    <title><?= t("Admin dashboard") ?></title>
     <link rel="shortcut icon" href="<?= url::file("lib/images/favicon.ico") ?>" type="image/x-icon" />
 
     <?= $theme->css("yui/reset-fonts-grids.css") ?>
@@ -23,7 +23,7 @@
    <?= $theme->script("gallery.common.js") ?>
    <? /* MSG_CANCEL is required by gallery.dialog.js */ ?>
    <script type="text/javascript">
-   var MSG_CANCEL = <?= t('Cancel')->for_js() ?>;
+   var MSG_CANCEL = <?= t("Cancel")->for_js() ?>;
    </script>
    <?= $theme->script("gallery.ajax.js") ?>
    <?= $theme->script("gallery.dialog.js") ?>
@@ -48,7 +48,7 @@
             <? if (identity::is_writable()): ?>
             <?= t('Logged in as %name', array('name' => html::mark_clean(
               '<a href="' . url::site("form/edit/users/{$user->id}") .
-              '" title="' . t("Edit Your Profile")->for_html_attr() .
+              '" title="' . t("Edit your profile")->for_html_attr() .
               '" id="g-user-profile-link" class="g-dialog-link">' .
               html::clean($user->display_name()) . '</a>'))) ?>
             <? else: ?>
diff --git a/themes/admin_wind/views/pager.html.php b/themes/admin_wind/views/pager.html.php
index 555a4950..e4fbd5d5 100644
--- a/themes/admin_wind/views/pager.html.php
+++ b/themes/admin_wind/views/pager.html.php
@@ -11,34 +11,34 @@
   <li>
   <? if ($first_page): ?>
     <a href="<?= str_replace('{page}', 1, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? endif ?>
   <? if ($previous_page): ?>
     <a href="<?= str_replace('{page}', $previous_page, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? endif ?>
   </li>
   <li class="g-info"><?= $from_to_msg ?></li>
   <li class="g-txt-right">
   <? if ($next_page): ?>
     <a href="<?= str_replace('{page}', $next_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? endif ?>
   <? if ($last_page): ?>
     <a href="<?= str_replace('{page}', $last_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? endif ?>
   </li>
 </ul>
diff --git a/themes/night_wind/views/movie.html.php b/themes/night_wind/views/movie.html.php
index 17b519ba..9254c7fe 100644
--- a/themes/night_wind/views/movie.html.php
+++ b/themes/night_wind/views/movie.html.php
@@ -6,20 +6,20 @@
     <li>
       <? if ($previous_item): ?>
       <a href="<?= $previous_item->url() ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("Previous") ?></a>
       <? else: ?>
       <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("Previous") ?></a>
       <? endif; ?>
     </li>
     <li class="g-info"><?= t("%position of %total", array("position" => $position, "total" => $sibling_count)) ?></li>
     <li class="g-txt-right">
       <? if ($next_item): ?>
       <a href="<?= $next_item->url() ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("Next") ?></a>
       <? else: ?>
       <a class="g-button ui-icon-right ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("Next") ?></a>
       <? endif ?>
     </li>
   </ul>
diff --git a/themes/night_wind/views/pager.html.php b/themes/night_wind/views/pager.html.php
index 337d658f..ba325d03 100644
--- a/themes/night_wind/views/pager.html.php
+++ b/themes/night_wind/views/pager.html.php
@@ -11,34 +11,34 @@
   <li>
   <? if ($first_page): ?>
     <a href="<?= str_replace('{page}', 1, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? endif ?>
   <? if ($previous_page): ?>
     <a href="<?= str_replace('{page}', $previous_page, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? endif ?>
   </li>
   <li class="g-info"><?= $from_to_msg ?></li>
   <li class="g-txt-right">
   <? if ($next_page): ?>
     <a href="<?= str_replace('{page}', $next_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? endif ?>
   <? if ($last_page): ?>
     <a href="<?= str_replace('{page}', $last_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? endif ?>
   </li>
 </ul>
diff --git a/themes/wind/views/movie.html.php b/themes/wind/views/movie.html.php
index 17b519ba..9254c7fe 100644
--- a/themes/wind/views/movie.html.php
+++ b/themes/wind/views/movie.html.php
@@ -6,20 +6,20 @@
     <li>
       <? if ($previous_item): ?>
       <a href="<?= $previous_item->url() ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("Previous") ?></a>
       <? else: ?>
       <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-w"></span><?= t("Previous") ?></a>
       <? endif; ?>
     </li>
     <li class="g-info"><?= t("%position of %total", array("position" => $position, "total" => $sibling_count)) ?></li>
     <li class="g-txt-right">
       <? if ($next_item): ?>
       <a href="<?= $next_item->url() ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("Next") ?></a>
       <? else: ?>
       <a class="g-button ui-icon-right ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-triangle-1-e"></span><?= t("Next") ?></a>
       <? endif ?>
     </li>
   </ul>
diff --git a/themes/wind/views/pager.html.php b/themes/wind/views/pager.html.php
index 337d658f..ba325d03 100644
--- a/themes/wind/views/pager.html.php
+++ b/themes/wind/views/pager.html.php
@@ -11,34 +11,34 @@
   <li>
   <? if ($first_page): ?>
     <a href="<?= str_replace('{page}', 1, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-first"></span><?= t("first") ?></a>
+      <span class="ui-icon ui-icon-seek-first"></span><?= t("First") ?></a>
   <? endif ?>
   <? if ($previous_page): ?>
     <a href="<?= str_replace('{page}', $previous_page, $url) ?>" class="g-button ui-icon-left ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? else: ?>
     <a class="g-button ui-icon-left ui-state-disabled ui-corner-all">
-      <span class="ui-icon ui-icon-seek-prev"></span><?= t("previous") ?></a>
+      <span class="ui-icon ui-icon-seek-prev"></span><?= t("Previous") ?></a>
   <? endif ?>
   </li>
   <li class="g-info"><?= $from_to_msg ?></li>
   <li class="g-txt-right">
   <? if ($next_page): ?>
     <a href="<?= str_replace('{page}', $next_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-next"></span><?= t("next") ?></a>
+      <span class="ui-icon ui-icon-seek-next"></span><?= t("Next") ?></a>
   <? endif ?>
   <? if ($last_page): ?>
     <a href="<?= str_replace('{page}', $last_page, $url) ?>" class="g-button ui-icon-right ui-state-default ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? else: ?>
     <a class="g-button ui-state-disabled ui-icon-right ui-corner-all">
-      <span class="ui-icon ui-icon-seek-end"></span><?= t("last") ?></a>
+      <span class="ui-icon ui-icon-seek-end"></span><?= t("Last") ?></a>
   <? endif ?>
   </li>
 </ul>
-- 
cgit v1.2.3


From 7f4e71e52688d15cbc53baed10660f81f2de6551 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Sat, 31 Oct 2009 14:15:17 -0700
Subject: fix an issue with the scroll bar appearing on the confirmation dialog
 and insure that dialog is removed if cancel is pressed, so we can correctly
 reshow it if required.

---
 modules/gallery/views/admin_identity.html.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
index 9a34dcc4..70fe401f 100644
--- a/modules/gallery/views/admin_identity.html.php
+++ b/modules/gallery/views/admin_identity.html.php
@@ -12,7 +12,7 @@
           bgiframe: true,
           title: <?= t("Confirm identity provider change")->for_js() ?>,
           resizable: false,
-          height:165,
+          height:180,
           modal: true,
           overlay: {
             backgroundColor: '#000',
@@ -20,10 +20,10 @@
           },
           buttons: {
             "Continue": function() {
-              $("##g-dialog form").submit();
+              $("#g-dialog form").submit();
             },
             Cancel: function() {
-              $(this).dialog('close');
+              $(this).dialog('destroy').remove();
             }
           }
         });
-- 
cgit v1.2.3


From e0f4e6500de0b5f0e9de973eadcd879c45da8e18 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta <bharat@menalto.com>
Date: Sun, 15 Nov 2009 19:34:44 -0800
Subject: Use text::alternate() instead of hand-rolled even/odd code.

---
 modules/comment/views/admin_block_recent_comments.html.php |  4 ++--
 modules/comment/views/admin_comments.html.php              |  4 ++--
 modules/gallery/views/admin_advanced_settings.html.php     |  4 +---
 modules/gallery/views/admin_identity.html.php              |  4 +---
 modules/gallery/views/admin_maintenance.html.php           | 12 +++---------
 modules/gallery/views/admin_modules.html.php               |  4 +---
 6 files changed, 10 insertions(+), 22 deletions(-)

(limited to 'modules/gallery/views/admin_identity.html.php')

diff --git a/modules/comment/views/admin_block_recent_comments.html.php b/modules/comment/views/admin_block_recent_comments.html.php
index 7941e02d..d9776def 100644
--- a/modules/comment/views/admin_block_recent_comments.html.php
+++ b/modules/comment/views/admin_block_recent_comments.html.php
@@ -1,7 +1,7 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
 <ul>
-  <? foreach ($comments as $i => $comment): ?>
-  <li class="<?= ($i % 2 == 0) ? "g-even" : "g-odd" ?>">
+  <? foreach ($comments as $comment): ?>
+  <li class="<?= text::alternate("g-even", "g-odd") ?>">
     <img src="<?= $comment->author()->avatar_url(32, $theme->url("images/avatar.jpg", true)) ?>"
          class="g-avatar"
          alt="<?= html::clean_attribute($comment->author_name()) ?>"
diff --git a/modules/comment/views/admin_comments.html.php b/modules/comment/views/admin_comments.html.php
index b138702c..20236a7a 100644
--- a/modules/comment/views/admin_comments.html.php
+++ b/modules/comment/views/admin_comments.html.php
@@ -103,8 +103,8 @@
           <?= t("Actions") ?>
         </th>
       </tr>
-      <? foreach ($comments as $i => $comment): ?>
-      <tr id="g-comment-<?= $comment->id ?>" class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?>">
+      <? foreach ($comments as $comment): ?>
+      <tr id="g-comment-<?= $comment->id ?>" class="<?= text::alternate("g-odd", "g-even") ?>">
         <td>
           <a href="#">
             <img src="<?= $comment->author()->avatar_url(40, $theme->url("images/avatar.jpg", true)) ?>"
diff --git a/modules/gallery/views/admin_advanced_settings.html.php b/modules/gallery/views/admin_advanced_settings.html.php
index 32fbc2c3..ff4843ab 100644
--- a/modules/gallery/views/admin_advanced_settings.html.php
+++ b/modules/gallery/views/admin_advanced_settings.html.php
@@ -16,10 +16,9 @@
         <th> <?= t("Name") ?> </th>
         <th> <?= t("Value") ?></th>
       </tr>
-      <? $i = 0; ?>
       <? foreach ($vars as $var): ?>
       <? if ($var->module_name == "gallery" && $var->name == "_cache") continue ?>
-      <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?>">
+      <tr class="<?= text::alternate("g-odd", "g-even") ?>">
         <td> <?= $var->module_name ?> </td>
         <td> <?= html::clean($var->name) ?> </td>
         <td>
@@ -34,7 +33,6 @@
         </a>
         </td>
       </tr>
-      <? $i++ ?>
       <? endforeach ?>
     </table>
   </div>
diff --git a/modules/gallery/views/admin_identity.html.php b/modules/gallery/views/admin_identity.html.php
index 70fe401f..51eaa58a 100644
--- a/modules/gallery/views/admin_identity.html.php
+++ b/modules/gallery/views/admin_identity.html.php
@@ -46,14 +46,12 @@
         <th> <?= t("Active") ?> </th>
         <th> <?= t("Description") ?> </th>
       </tr>
-      <? $i = 0 ?>
       <? foreach ($available as $module_name => $description):  ?>
-      <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?>">
+      <tr class="<?= text::alternate("g-odd", "g-even") ?>">
         <? $data = array("name" => "provider"); ?>
         <td> <?= form::radio($data, $module_name, $module_name == $active) ?> </td>
         <td> <?= t($description) ?> </td>
       </tr>
-      <? $i++ ?>
       <? endforeach ?>
     </table>
     <input type="submit" value="<?= t("Change")->for_html_attr() ?>" />
diff --git a/modules/gallery/views/admin_maintenance.html.php b/modules/gallery/views/admin_maintenance.html.php
index 7ad75f85..ac597715 100644
--- a/modules/gallery/views/admin_maintenance.html.php
+++ b/modules/gallery/views/admin_maintenance.html.php
@@ -20,9 +20,8 @@
             <?= t("Action") ?>
           </th>
         </tr>
-        <? $i = 0; ?>
         <? foreach ($task_definitions as $task): ?>
-        <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?> <?= log::severity_class($task->severity) ?>">
+        <tr class="<?= text::alternate("g-odd", "g-even") ?> <?= log::severity_class($task->severity) ?>">
           <td class="<?= log::severity_class($task->severity) ?>">
             <?= $task->name ?>
           </td>
@@ -36,7 +35,6 @@
             </a>
           </td>
         </tr>
-        <? $i++ ?>
         <? endforeach ?>
       </table>
     </div>
@@ -68,9 +66,8 @@
             <?= t("Action") ?>
           </th>
         </tr>
-        <? $i = 0; ?>
         <? foreach ($running_tasks as $task): ?>
-        <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?> <?= $task->state == "stalled" ? "g-warning" : "" ?>">
+        <tr class="<?= text::alternate("g-odd", "g-even") ?> <?= $task->state == "stalled" ? "g-warning" : "" ?>">
           <td class="<?= $task->state == "stalled" ? "g-warning" : "" ?>">
             <?= gallery::date_time($task->updated) ?>
           </td>
@@ -108,7 +105,6 @@
             <? endif ?>
           </td>
         </tr>
-        <? $i++ ?>
         <? endforeach ?>
       </table>
     </div>
@@ -141,9 +137,8 @@
             <?= t("Action") ?>
           </th>
         </tr>
-        <? $i = 0; ?>
         <? foreach ($finished_tasks as $task): ?>
-        <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?> <?= $task->state == "success" ? "g-success" : "g-error" ?>">
+        <tr class="<?= text::alternate("g-odd", "g-even") ?> <?= $task->state == "success" ? "g-success" : "g-error" ?>">
           <td class="<?= $task->state == "success" ? "g-success" : "g-error" ?>">
             <?= gallery::date_time($task->updated) ?>
           </td>
@@ -187,7 +182,6 @@
           </td>
         </tr>
         <? endforeach ?>
-        <? $i++ ?>
       </table>
     </div>
     <? endif ?>
diff --git a/modules/gallery/views/admin_modules.html.php b/modules/gallery/views/admin_modules.html.php
index 4c4976f8..aebedf09 100644
--- a/modules/gallery/views/admin_modules.html.php
+++ b/modules/gallery/views/admin_modules.html.php
@@ -15,9 +15,8 @@
           <th> <?= t("Version") ?> </th>
           <th> <?= t("Description") ?> </th>
         </tr>
-        <? $i = 0 ?>
         <? foreach ($available as $module_name => $module_info):  ?>
-        <tr class="<?= ($i % 2 == 0) ? "g-odd" : "g-even" ?>">
+        <tr class="<?= text::alternate("g-odd", "g-even") ?>">
           <? $data = array("name" => $module_name); ?>
           <? if ($module_info->locked) $data["disabled"] = 1; ?>
           <td> <?= form::checkbox($data, '1', module::is_active($module_name)) ?> </td>
@@ -25,7 +24,6 @@
           <td> <?= $module_info->version ?> </td>
           <td> <?= t($module_info->description) ?> </td>
         </tr>
-        <? $i++ ?>
         <? endforeach ?>
       </table>
       <input type="submit" value="<?= t("Update")->for_html_attr() ?>" />
-- 
cgit v1.2.3