From cbde32b0d2869396ce2863f2e9ce211a1d9fb555 Mon Sep 17 00:00:00 2001 From: Tim Almdal Date: Fri, 6 Nov 2009 23:20:30 -0800 Subject: Make sure the position method works for both ascending and descending sort orders. --- modules/gallery/models/item.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/gallery/models') diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php index 9735ed62..d27e331b 100644 --- a/modules/gallery/models/item.php +++ b/modules/gallery/models/item.php @@ -444,11 +444,11 @@ class Item_Model extends ORM_MPTT { $position = $db->from("items") ->where("parent_id", $this->id) - ->where("$sort_column < ", $child->$sort_column) + ->where("$sort_column $comp ", $child->$sort_column) ->where($where) ->count_records(); - // We stopped short of our target value in the sort (notice that we're using a < comparator + // We stopped short of our target value in the sort (notice that we're using a < comparator // above) because it's possible that we have duplicate values in the sort column. An // equality check would just arbitrarily pick one of those multiple possible equivalent // columns, which would mean that if you choose a sort order that has duplicates, it'd pick -- cgit v1.2.3