From 536bdaa4db6e950cb4f382697964651b8eab63cd Mon Sep 17 00:00:00 2001 From: shadlaws Date: Tue, 29 Jan 2013 18:35:10 +0100 Subject: #1967 - Improve how graphics::generate handles missing/bad images. - Made missing_photo match the image format (jpg, png, etc.). - Swapped missing_photo.png for missing_photo.jpg since it's likely to require less conversion to match. - Improved error messages to user when things go wrong. - Ensured that missing image placeholders are always copied when there's an error. - Ensured we don't mistake no file output for a correct file output (delete target before attempt). - Restructured graphics::generate a bit to work better with above changes. - Added unit tests for graphics::generate. --- modules/gallery/images/missing_photo.jpg | Bin 0 -> 2034 bytes modules/gallery/images/missing_photo.png | Bin 1570 -> 0 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 modules/gallery/images/missing_photo.jpg delete mode 100644 modules/gallery/images/missing_photo.png (limited to 'modules/gallery/images') diff --git a/modules/gallery/images/missing_photo.jpg b/modules/gallery/images/missing_photo.jpg new file mode 100644 index 00000000..a9d176d8 Binary files /dev/null and b/modules/gallery/images/missing_photo.jpg differ diff --git a/modules/gallery/images/missing_photo.png b/modules/gallery/images/missing_photo.png deleted file mode 100644 index 67786275..00000000 Binary files a/modules/gallery/images/missing_photo.png and /dev/null differ -- cgit v1.2.3