From 42a5bd20a550a9edb5ec84625037b9d85889ff63 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Fri, 26 Jun 2009 07:51:29 -0700
Subject: 1) Move the generation of script tags to gallery_theme::head and
 gallery_theme::admin_head. This allows us to potentially manage the scripts
 like we do in g2 (single file and compressed) 2) Change Theme_View::_call to
 always call the gallery_theme::$function first.

---
 modules/gallery/helpers/gallery_theme.php | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

(limited to 'modules/gallery/helpers/gallery_theme.php')

diff --git a/modules/gallery/helpers/gallery_theme.php b/modules/gallery/helpers/gallery_theme.php
index a96c8f5b..24f4129b 100644
--- a/modules/gallery/helpers/gallery_theme.php
+++ b/modules/gallery/helpers/gallery_theme.php
@@ -21,6 +21,18 @@ class gallery_theme_Core {
   static function head($theme) {
     $session = Session::instance();
     $buf = "";
+    $buf .= html::script("lib/jquery.js");
+    $buf .= html::script("lib/jquery.form.js");
+    $buf .= html::script("lib/jquery-ui.js");
+    $buf .= html::script("lib/gallery.common.js");
+    $buf .= html::script("lib/gallery.dialog.js");
+    $buf .= html::script("lib/gallery.form.js");
+    $buf .= html::script("lib/superfish/js/superfish.js");
+    if ($theme->page_type == 'photo') {
+      $buf .= html::script("lib/jquery.scrollTo.js");
+      $buf .= html::script("lib/jquery.localscroll.js");
+    }
+    $buf .= html::script($theme->url("js/ui.init.js", false, true));
     if ($session->get("debug")) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/debug.css") . "\" />";
@@ -79,6 +91,14 @@ class gallery_theme_Core {
   static function admin_head($theme) {
     $session = Session::instance();
     $buf = "";
+    $buf .= html::script("lib/jquery.js");
+    $buf .= html::script("lib/jquery.form.js");
+    $buf .= html::script("lib/jquery-ui.js");
+    $buf .= html::script("lib/gallery.common.js");
+    $buf .= html::script("lib/gallery.dialog.js");
+    $buf .= html::script("lib/superfish/js/superfish.js");
+    $buf .= html::script($theme->url("js/jquery.dropshadow.js", false, true));
+    $buf .= html::script($theme->url("js/ui.init.js", false, true));
     if ($session->get("debug")) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/debug.css") . "\" />";
-- 
cgit v1.2.3


From 84e98e830c4967c277dfcb5bb6d18c0ec3313355 Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Fri, 26 Jun 2009 08:25:24 -0700
Subject: Move the inclusion of photo and movie specific javascript into
 gallery_theme

---
 modules/gallery/helpers/gallery_theme.php | 4 ++++
 themes/default/views/movie.html.php       | 1 -
 themes/default/views/photo.html.php       | 1 -
 3 files changed, 4 insertions(+), 2 deletions(-)

(limited to 'modules/gallery/helpers/gallery_theme.php')

diff --git a/modules/gallery/helpers/gallery_theme.php b/modules/gallery/helpers/gallery_theme.php
index 24f4129b..0679087e 100644
--- a/modules/gallery/helpers/gallery_theme.php
+++ b/modules/gallery/helpers/gallery_theme.php
@@ -31,6 +31,10 @@ class gallery_theme_Core {
     if ($theme->page_type == 'photo') {
       $buf .= html::script("lib/jquery.scrollTo.js");
       $buf .= html::script("lib/jquery.localscroll.js");
+      $buf .= html::script("lib/gallery.show_full_size.js");
+    }
+    if ($theme->page_type == 'movie') {
+      $buf .= html::script("lib/flowplayer.js");
     }
     $buf .= html::script($theme->url("js/ui.init.js", false, true));
     if ($session->get("debug")) {
diff --git a/themes/default/views/movie.html.php b/themes/default/views/movie.html.php
index e8559697..134e3571 100644
--- a/themes/default/views/movie.html.php
+++ b/themes/default/views/movie.html.php
@@ -1,5 +1,4 @@
 <?php defined("SYSPATH") or die("No direct script access.") ?>
-<script src="<?= url::file("lib/flowplayer.js") ?>" type="text/javascript"></script>
 <div id="gItem">
   <?= $theme->photo_top() ?>
 
diff --git a/themes/default/views/photo.html.php b/themes/default/views/photo.html.php
index 1c3b81a7..4765a4e3 100644
--- a/themes/default/views/photo.html.php
+++ b/themes/default/views/photo.html.php
@@ -2,7 +2,6 @@
 
 <? if (access::can("view_full", $theme->item())): ?>
 <!-- Use javascript to show the full size as an overlay on the current page -->
-<script src="<?= url::file("lib/gallery.show_full_size.js") ?>" type="text/javascript"></script>
 <script>
   $(document).ready(function() {
     $(".gFullSizeLink").click(function() {
-- 
cgit v1.2.3


From 4cec0201637d21f8e88c264bb1befff4e891ce3e Mon Sep 17 00:00:00 2001
From: Tim Almdal <tnalmdal@shaw.ca>
Date: Fri, 26 Jun 2009 14:37:15 -0700
Subject: Create a theme_view function script which allows modules in the head
 or admin_head functions to specify javascript files that are required for
 this page. In this commit, these script files are expressed at the end of the
 head or admin_head calls and appended to the beginning of the block stack. 
 In a future commit these will be combined and gzipped for download.

---
 modules/comment/helpers/comment_theme.php |  4 +--
 modules/gallery/helpers/gallery_theme.php | 50 +++++++++++++++----------------
 modules/gallery/libraries/Theme_View.php  | 19 ++++++++++++
 3 files changed, 46 insertions(+), 27 deletions(-)

(limited to 'modules/gallery/helpers/gallery_theme.php')

diff --git a/modules/comment/helpers/comment_theme.php b/modules/comment/helpers/comment_theme.php
index d9f1acf4..89b2f57c 100644
--- a/modules/comment/helpers/comment_theme.php
+++ b/modules/comment/helpers/comment_theme.php
@@ -19,8 +19,8 @@
  */
 class comment_theme_Core {
   static function head($theme) {
-    $url = url::file("modules/comment/js/comment.js");
-    return "<script src=\"$url\" type=\"text/javascript\"></script>\n";
+    $theme->script("modules/comment/js/comment.js");
+    return "";
   }
 
   static function photo_bottom($theme) {
diff --git a/modules/gallery/helpers/gallery_theme.php b/modules/gallery/helpers/gallery_theme.php
index 0679087e..b6b24b27 100644
--- a/modules/gallery/helpers/gallery_theme.php
+++ b/modules/gallery/helpers/gallery_theme.php
@@ -21,22 +21,22 @@ class gallery_theme_Core {
   static function head($theme) {
     $session = Session::instance();
     $buf = "";
-    $buf .= html::script("lib/jquery.js");
-    $buf .= html::script("lib/jquery.form.js");
-    $buf .= html::script("lib/jquery-ui.js");
-    $buf .= html::script("lib/gallery.common.js");
-    $buf .= html::script("lib/gallery.dialog.js");
-    $buf .= html::script("lib/gallery.form.js");
-    $buf .= html::script("lib/superfish/js/superfish.js");
+    $theme->script("lib/jquery.js");
+    $theme->script("lib/jquery.form.js");
+    $theme->script("lib/jquery-ui.js");
+    $theme->script("lib/gallery.common.js");
+    $theme->script("lib/gallery.dialog.js");
+    $theme->script("lib/gallery.form.js");
+    $theme->script("lib/superfish/js/superfish.js");
     if ($theme->page_type == 'photo') {
-      $buf .= html::script("lib/jquery.scrollTo.js");
-      $buf .= html::script("lib/jquery.localscroll.js");
-      $buf .= html::script("lib/gallery.show_full_size.js");
+      $theme->script("lib/jquery.scrollTo.js");
+      $theme->script("lib/jquery.localscroll.js");
+      $theme->script("lib/gallery.show_full_size.js");
     }
     if ($theme->page_type == 'movie') {
-      $buf .= html::script("lib/flowplayer.js");
+      $theme->script("lib/flowplayer.js");
     }
-    $buf .= html::script($theme->url("js/ui.init.js", false, true));
+    $theme->script($theme->url("js/ui.init.js", false, true));
     if ($session->get("debug")) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/debug.css") . "\" />";
@@ -45,7 +45,7 @@ class gallery_theme_Core {
         && access::can("edit", $theme->item())) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/quick.css") . "\" />";
-      $buf .= html::script("modules/gallery/js/quick.js");
+      $theme->script("modules/gallery/js/quick.js");
     }
 
     if (module::is_active("rss")) {
@@ -59,8 +59,8 @@ class gallery_theme_Core {
     if ($session->get("l10n_mode", false)) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/l10n_client.css") . "\" />";
-      $buf .= html::script("lib/jquery.cookie.js");
-      $buf .= html::script("modules/gallery/js/l10n_client.js");
+      $theme->script("lib/jquery.cookie.js");
+      $theme->script("modules/gallery/js/l10n_client.js");
     }
 
     return $buf;
@@ -95,14 +95,14 @@ class gallery_theme_Core {
   static function admin_head($theme) {
     $session = Session::instance();
     $buf = "";
-    $buf .= html::script("lib/jquery.js");
-    $buf .= html::script("lib/jquery.form.js");
-    $buf .= html::script("lib/jquery-ui.js");
-    $buf .= html::script("lib/gallery.common.js");
-    $buf .= html::script("lib/gallery.dialog.js");
-    $buf .= html::script("lib/superfish/js/superfish.js");
-    $buf .= html::script($theme->url("js/jquery.dropshadow.js", false, true));
-    $buf .= html::script($theme->url("js/ui.init.js", false, true));
+    $theme->script("lib/jquery.js");
+    $theme->script("lib/jquery.form.js");
+    $theme->script("lib/jquery-ui.js");
+    $theme->script("lib/gallery.common.js");
+    $theme->script("lib/gallery.dialog.js");
+    $theme->script("lib/superfish/js/superfish.js");
+    $theme->script($theme->url("js/jquery.dropshadow.js", false, true));
+    $theme->script($theme->url("js/ui.init.js", false, true));
     if ($session->get("debug")) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/debug.css") . "\" />";
@@ -111,8 +111,8 @@ class gallery_theme_Core {
     if ($session->get("l10n_mode", false)) {
       $buf .= "<link rel=\"stylesheet\" type=\"text/css\" href=\"" .
         url::file("modules/gallery/css/l10n_client.css") . "\" />";
-      $buf .= html::script("lib/jquery.cookie.js");
-      $buf .= html::script("modules/gallery/js/l10n_client.js");
+      $theme->script("lib/jquery.cookie.js");
+      $theme->script("modules/gallery/js/l10n_client.js");
     }
 
     return $buf;
diff --git a/modules/gallery/libraries/Theme_View.php b/modules/gallery/libraries/Theme_View.php
index 5235fabb..7696f3b0 100644
--- a/modules/gallery/libraries/Theme_View.php
+++ b/modules/gallery/libraries/Theme_View.php
@@ -19,6 +19,7 @@
  */
 class Theme_View_Core extends View {
   private $theme_name = null;
+  private $scripts = array();
 
   /**
    * Attempts to load a view and pre-load view data.
@@ -163,6 +164,19 @@ class Theme_View_Core extends View {
     return message::get();
   }
 
+  public function script($file) {
+    $this->scripts[$file] = 1;
+  }
+
+  private function _combine_script() {
+    $links = array();
+    Kohana::log("error", Kohana::debug($this->scripts));
+    foreach (array_keys($this->scripts) as $file) {
+      $links[] = html::script($file);
+    }
+    return empty($links) ? "" : implode("\n", $links);
+  }
+
   /**
    * Handle all theme functions that insert module content.
    */
@@ -221,6 +235,11 @@ class Theme_View_Core extends View {
             array_merge(array($this), $args));
         }
       }
+
+      if ($function == "head" || $function == "admin_head") {
+        array_unshift($blocks, $this->_combine_script());
+      }
+
       if (Session::instance()->get("debug")) {
         if ($function != "head") {
           array_unshift(
-- 
cgit v1.2.3