From 2826b70bec2fa6d9c852bf62f6ecc440839679ad Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Mon, 10 Jan 2011 14:36:23 -0800 Subject: Use CSS not JS to determine the full size of the full size overlay. Fixes #1541. --- lib/gallery.show_full_size.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'lib/gallery.show_full_size.js') diff --git a/lib/gallery.show_full_size.js b/lib/gallery.show_full_size.js index f617836b..9eb6f3af 100644 --- a/lib/gallery.show_full_size.js +++ b/lib/gallery.show_full_size.js @@ -8,12 +8,12 @@ var size = $.gallery_get_viewport_size(); $("body").append('
'); + 'style="border: none; margin: 0; padding: 0; background-color: #000; ' + + 'position: fixed; top: 0px; left: 0px; ' + + 'width: 100%; height: 100%; ' + + 'opacity: 0.7; filter: alpha(opacity=70); ' + + '-moz-background-clip: -moz-initial; -moz-background-origin: -moz-initial; ' + + '-moz-background-inline-policy: -moz-initial; z-index: 1001;"> '); var image_size; if (image_width >= size.width() - 6 || image_height >= size.height() - 6) { @@ -26,14 +26,14 @@ } $("body").append('
' + - '
'); + 'style="overflow: hidden; display: block; ' + + 'position: absolute; z-index: 1002; outline-color: -moz-use-text-color; ' + + 'outline-style: none; outline-width: 0px; ' + + 'height: ' + image_size.height + 'px; ' + + 'width: ' + image_size.width + 'px; ' + + 'top: ' + image_size.top + 'px; left: ' + image_size.left + 'px;">' + + ''); $().click(function() { $("#g-fullsize-overlay*").remove(); -- cgit v1.2.3 From 7eabf6c1c27c2c0e98895f663bb2853d72976e01 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Tue, 11 Jan 2011 21:21:59 -0800 Subject: Use Math.round() instead of Number() to convert floating point numbers to integer. Fixes overflow probelm that causes #1490. Thanks to nkinkade for the fix. --- lib/gallery.common.js | 8 ++++---- lib/gallery.show_full_size.js | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) (limited to 'lib/gallery.show_full_size.js') diff --git a/lib/gallery.common.js b/lib/gallery.common.js index 2dbd7c7c..697a33cb 100644 --- a/lib/gallery.common.js +++ b/lib/gallery.common.js @@ -171,10 +171,10 @@ // handle the case where the calculation is almost zero (2.14e-14) return { - top: Number((height - imageHeight) / 2), - left: Number((width - imageWidth) / 2), - width: Number(imageWidth), - height: Number(imageHeight) + top: Math.round((height - imageHeight) / 2), + left: Math.round((width - imageWidth) / 2), + width: Math.round(imageWidth), + height: Math.round(imageHeight) }; }; diff --git a/lib/gallery.show_full_size.js b/lib/gallery.show_full_size.js index 9eb6f3af..531d2a3a 100644 --- a/lib/gallery.show_full_size.js +++ b/lib/gallery.show_full_size.js @@ -20,8 +20,10 @@ image_size = $.gallery_auto_fit_window(image_width, image_height); } else { image_size = { - top: Number((height - image_height) / 2), left: Number((width - image_width) / 2), - width: Number(image_width), height: Number(image_height) + top: Math.round((height - image_height) / 2), + left: Math.round((width - image_width) / 2), + width: Math.round(image_width), + height: Math.round(image_height) }; } -- cgit v1.2.3