From b8cf195be8ca684734609cf19e8bf3eec9659cff Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Mon, 9 Mar 2009 04:11:15 +0000 Subject: Don't forget to clean up temp files after uploading. Fixes ticket #120. --- core/controllers/simple_uploader.php | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) (limited to 'core/controllers') diff --git a/core/controllers/simple_uploader.php b/core/controllers/simple_uploader.php index 68eefd8a..67b86e7a 100644 --- a/core/controllers/simple_uploader.php +++ b/core/controllers/simple_uploader.php @@ -59,17 +59,23 @@ class Simple_Uploader_Controller extends Controller { } $temp_filename = upload::save("file"); - $title = substr(basename($temp_filename), 10); // Skip unique identifier Kohana adds - $path_info = pathinfo($temp_filename); - if (in_array(strtolower($path_info["extension"]), array("flv", "mp4"))) { - $movie = movie::create($album, $temp_filename, $title, $title); - log::success("content", t("Added a movie"), - html::anchor("movies/$movie->id", t("view movie"))); - } else { - $photo = photo::create($album, $temp_filename, $title, $title); - log::success("content", t("Added a photo"), - html::anchor("photos/$photo->id", t("view photo"))); + try { + $title = substr(basename($temp_filename), 10); // Skip unique identifier Kohana adds + $path_info = pathinfo($temp_filename); + if (in_array(strtolower($path_info["extension"]), array("flv", "mp4"))) { + $movie = movie::create($album, $temp_filename, $title, $title); + log::success("content", t("Added a movie"), + html::anchor("movies/$movie->id", t("view movie"))); + } else { + $photo = photo::create($album, $temp_filename, $title, $title); + log::success("content", t("Added a photo"), + html::anchor("photos/$photo->id", t("view photo"))); + } + } catch (Exception $e) { + unlink($temp_filename); + throw $e; } + unlink($temp_filename); } } -- cgit v1.2.3