From 3d1ea2904d982422ce24c43b25d0d4bca6f29aa3 Mon Sep 17 00:00:00 2001 From: Bharat Mediratta Date: Sun, 18 Jan 2009 05:01:00 +0000 Subject: Rename theme callback helpers from xxx_block to xxx_theme to make room for us to rename the dashboard helper to be a block helper since sidebar blocks are not just in the dashboard. --- core/helpers/core_block.php | 76 ------------------------- core/helpers/core_theme.php | 75 ++++++++++++++++++++++++ core/libraries/Admin_View.php | 2 +- core/libraries/Theme_View.php | 2 +- modules/comment/helpers/comment_block.php | 42 -------------- modules/comment/helpers/comment_theme.php | 42 ++++++++++++++ modules/gmaps/helpers/gmaps_block.php | 31 ---------- modules/gmaps/helpers/gmaps_theme.php | 30 ++++++++++ modules/info/helpers/info_block.php | 45 --------------- modules/info/helpers/info_theme.php | 45 +++++++++++++++ modules/media_rss/helpers/media_rss_block.php | 32 ----------- modules/media_rss/helpers/media_rss_theme.php | 32 +++++++++++ modules/polar_rose/helpers/polar_rose_block.php | 50 ---------------- modules/polar_rose/helpers/polar_rose_theme.php | 50 ++++++++++++++++ modules/rearrange/helpers/rearrange_block.php | 30 ---------- modules/rearrange/helpers/rearrange_theme.php | 30 ++++++++++ modules/search/helpers/search_block.php | 25 -------- modules/search/helpers/search_theme.php | 25 ++++++++ modules/slideshow/helpers/slideshow_block.php | 25 -------- modules/slideshow/helpers/slideshow_theme.php | 25 ++++++++ modules/tag/helpers/tag_block.php | 46 --------------- modules/tag/helpers/tag_theme.php | 46 +++++++++++++++ modules/user/helpers/user_block.php | 35 ------------ modules/user/helpers/user_theme.php | 35 ++++++++++++ 24 files changed, 437 insertions(+), 439 deletions(-) delete mode 100644 core/helpers/core_block.php create mode 100644 core/helpers/core_theme.php delete mode 100644 modules/comment/helpers/comment_block.php create mode 100644 modules/comment/helpers/comment_theme.php delete mode 100644 modules/gmaps/helpers/gmaps_block.php create mode 100644 modules/gmaps/helpers/gmaps_theme.php delete mode 100644 modules/info/helpers/info_block.php create mode 100644 modules/info/helpers/info_theme.php delete mode 100644 modules/media_rss/helpers/media_rss_block.php create mode 100644 modules/media_rss/helpers/media_rss_theme.php delete mode 100644 modules/polar_rose/helpers/polar_rose_block.php create mode 100644 modules/polar_rose/helpers/polar_rose_theme.php delete mode 100644 modules/rearrange/helpers/rearrange_block.php create mode 100644 modules/rearrange/helpers/rearrange_theme.php delete mode 100644 modules/search/helpers/search_block.php create mode 100644 modules/search/helpers/search_theme.php delete mode 100644 modules/slideshow/helpers/slideshow_block.php create mode 100644 modules/slideshow/helpers/slideshow_theme.php delete mode 100644 modules/tag/helpers/tag_block.php create mode 100644 modules/tag/helpers/tag_theme.php delete mode 100644 modules/user/helpers/user_block.php create mode 100644 modules/user/helpers/user_theme.php diff --git a/core/helpers/core_block.php b/core/helpers/core_block.php deleted file mode 100644 index 48e158be..00000000 --- a/core/helpers/core_block.php +++ /dev/null @@ -1,76 +0,0 @@ -get("debug")) { - $buf .= ""; - } - if ($theme->page_type == "album" && access::can("edit", $theme->item())) { - $buf .= ""; - $buf .= html::script("core/js/quick.js"); - } - return $buf; - } - - static function album_top($theme, $child) { - if (access::can("edit", $album)) { - $edit_link = url::site("quick/pane/$album->id"); - return "
"; - } - } - - static function thumb_top($theme, $child) { - if ($child->type == "photo" && access::can("edit", $child)) { - $edit_link = url::site("quick/pane/$child->id"); - return "
"; - } - } - - static function thumb_bottom($theme, $child) { - if ($child->type == "photo" && access::can("edit", $child)) { - return "
"; - } - } - - static function admin_head($theme) { - if (Session::instance()->get("debug")) { - return ""; - } - } - - static function page_bottom($theme) { - if (Session::instance()->get("profiler", false)) { - $profiler = new Profiler(); - $profiler->render(); - } - } - - static function admin_page_bottom($theme) { - if (Session::instance()->get("profiler", false)) { - $profiler = new Profiler(); - $profiler->render(); - } - } -} \ No newline at end of file diff --git a/core/helpers/core_theme.php b/core/helpers/core_theme.php new file mode 100644 index 00000000..0ccad457 --- /dev/null +++ b/core/helpers/core_theme.php @@ -0,0 +1,75 @@ +get("debug")) { + $buf .= ""; + } + if ($theme->page_type == "album" && access::can("edit", $theme->item())) { + $buf .= ""; + $buf .= html::script("core/js/quick.js"); + } + return $buf; + } + + static function album_top($theme, $child) { + if (access::can("edit", $album)) { + $edit_link = url::site("quick/pane/$album->id"); + return "
"; + } + } + + static function thumb_top($theme, $child) { + if ($child->type == "photo" && access::can("edit", $child)) { + $edit_link = url::site("quick/pane/$child->id"); + return "
"; + } + } + + static function thumb_bottom($theme, $child) { + if ($child->type == "photo" && access::can("edit", $child)) { + return "
"; + } + } + + static function admin_head($theme) { + if (Session::instance()->get("debug")) { + return ""; + } + } + + static function page_bottom($theme) { + if (Session::instance()->get("profiler", false)) { + $profiler = new Profiler(); + $profiler->render(); + } + } + + static function admin_page_bottom($theme) { + if (Session::instance()->get("profiler", false)) { + $profiler = new Profiler(); + $profiler->render(); + } + } +} \ No newline at end of file diff --git a/core/libraries/Admin_View.php b/core/libraries/Admin_View.php index af2d7fa8..e15c0d68 100644 --- a/core/libraries/Admin_View.php +++ b/core/libraries/Admin_View.php @@ -93,7 +93,7 @@ class Admin_View_Core extends View { case "admin_head": $blocks = array(); foreach (module::installed() as $module) { - $helper_class = "{$module->name}_block"; + $helper_class = "{$module->name}_theme"; if (method_exists($helper_class, $function)) { $blocks[] = call_user_func_array( array($helper_class, $function), diff --git a/core/libraries/Theme_View.php b/core/libraries/Theme_View.php index 38e8e056..1f8ca559 100644 --- a/core/libraries/Theme_View.php +++ b/core/libraries/Theme_View.php @@ -165,7 +165,7 @@ class Theme_View_Core extends View { case "photo_bottom": $blocks = array(); foreach (module::installed() as $module) { - $helper_class = "{$module->name}_block"; + $helper_class = "{$module->name}_theme"; if (method_exists($helper_class, $function)) { $blocks[] = call_user_func_array( array($helper_class, $function), diff --git a/modules/comment/helpers/comment_block.php b/modules/comment/helpers/comment_block.php deleted file mode 100644 index d8f08feb..00000000 --- a/modules/comment/helpers/comment_block.php +++ /dev/null @@ -1,42 +0,0 @@ -\n"; - } - - static function photo_bottom($theme) { - $block = new Block; - $block->css_id = "gComments"; - $block->title = t("Comments"); - - $view = new View("comments.html"); - $view->comments = ORM::factory("comment") - ->where("item_id", $theme->item()->id) - ->where("state", "published") - ->orderby("created", "ASC") - ->find_all(); - - $block->content = $view; - $block->content .= comment::get_add_form($theme->item())->render("form.html"); - return $block; - } -} \ No newline at end of file diff --git a/modules/comment/helpers/comment_theme.php b/modules/comment/helpers/comment_theme.php new file mode 100644 index 00000000..3861bae0 --- /dev/null +++ b/modules/comment/helpers/comment_theme.php @@ -0,0 +1,42 @@ +\n"; + } + + static function photo_bottom($theme) { + $block = new Block; + $block->css_id = "gComments"; + $block->title = t("Comments"); + + $view = new View("comments.html"); + $view->comments = ORM::factory("comment") + ->where("item_id", $theme->item()->id) + ->where("state", "published") + ->orderby("created", "ASC") + ->find_all(); + + $block->content = $view; + $block->content .= comment::get_add_form($theme->item())->render("form.html"); + return $block; + } +} \ No newline at end of file diff --git a/modules/gmaps/helpers/gmaps_block.php b/modules/gmaps/helpers/gmaps_block.php deleted file mode 100644 index 06894005..00000000 --- a/modules/gmaps/helpers/gmaps_block.php +++ /dev/null @@ -1,31 +0,0 @@ -item()) { - $block = new Block(); - $block->css_id = "gMaps"; - $block->title = t("Location"); - $block->content = new View("gmaps_block.html"); - return $block; - } - } -} \ No newline at end of file diff --git a/modules/gmaps/helpers/gmaps_theme.php b/modules/gmaps/helpers/gmaps_theme.php new file mode 100644 index 00000000..582eccfe --- /dev/null +++ b/modules/gmaps/helpers/gmaps_theme.php @@ -0,0 +1,30 @@ +item()) { + $block = new Block(); + $block->css_id = "gMaps"; + $block->title = t("Location"); + $block->content = new View("gmaps_block.html"); + return $block; + } + } +} \ No newline at end of file diff --git a/modules/info/helpers/info_block.php b/modules/info/helpers/info_block.php deleted file mode 100644 index c832b4f6..00000000 --- a/modules/info/helpers/info_block.php +++ /dev/null @@ -1,45 +0,0 @@ -item()) { - $block = new Block(); - $block->css_id = "gMetadata"; - $block->title = t("Item Info"); - $block->content = new View("info_block.html"); - return $block; - } - } - - static function thumb_info($theme, $item) { - $results = ""; - if ($item->view_count) { - $results .= "
  • "; - $results .= t("Views: %view_count", array("view_count" => $item->view_count)); - $results .= "
  • "; - } - if ($item->owner) { - $results .= "
  • "; - $results .= t("By: %owner_name", array("owner_name" => "{$item->owner->name}")); - $results .= "
  • "; - } - return $results; - } -} \ No newline at end of file diff --git a/modules/info/helpers/info_theme.php b/modules/info/helpers/info_theme.php new file mode 100644 index 00000000..3b90c640 --- /dev/null +++ b/modules/info/helpers/info_theme.php @@ -0,0 +1,45 @@ +item()) { + $block = new Block(); + $block->css_id = "gMetadata"; + $block->title = t("Item Info"); + $block->content = new View("info_block.html"); + return $block; + } + } + + static function thumb_info($theme, $item) { + $results = ""; + if ($item->view_count) { + $results .= "
  • "; + $results .= t("Views: %view_count", array("view_count" => $item->view_count)); + $results .= "
  • "; + } + if ($item->owner) { + $results .= "
  • "; + $results .= t("By: %owner_name", array("owner_name" => "{$item->owner->name}")); + $results .= "
  • "; + } + return $results; + } +} \ No newline at end of file diff --git a/modules/media_rss/helpers/media_rss_block.php b/modules/media_rss/helpers/media_rss_block.php deleted file mode 100644 index 80fb009e..00000000 --- a/modules/media_rss/helpers/media_rss_block.php +++ /dev/null @@ -1,32 +0,0 @@ -item()) { - $url = media_rss::item_feed($theme->item()); - } else if ($theme->tag()) { - $url = media_rss::tag_feed($theme->tag()); - } - - if (!empty($url)) { - return ""; - } - } -} diff --git a/modules/media_rss/helpers/media_rss_theme.php b/modules/media_rss/helpers/media_rss_theme.php new file mode 100644 index 00000000..84788e61 --- /dev/null +++ b/modules/media_rss/helpers/media_rss_theme.php @@ -0,0 +1,32 @@ +item()) { + $url = media_rss::item_feed($theme->item()); + } else if ($theme->tag()) { + $url = media_rss::tag_feed($theme->tag()); + } + + if (!empty($url)) { + return ""; + } + } +} diff --git a/modules/polar_rose/helpers/polar_rose_block.php b/modules/polar_rose/helpers/polar_rose_block.php deleted file mode 100644 index 85486917..00000000 --- a/modules/polar_rose/helpers/polar_rose_block.php +++ /dev/null @@ -1,50 +0,0 @@ -item()) { - $url = media_rss::item_feed($theme->item()); - } else if ($theme->tag()) { - $url = media_rss::tag_feed($theme->tag()); - } - - // Polar Rose doesn't understand relative URLs. Hack around that until they fix it. - $url = url::abs_site(substr($url, strpos($url, "index.php") + 10)); - - return "" . - ""; - } - } - - static function page_bottom($theme) { - return "
    "; - } -} diff --git a/modules/polar_rose/helpers/polar_rose_theme.php b/modules/polar_rose/helpers/polar_rose_theme.php new file mode 100644 index 00000000..aefc6713 --- /dev/null +++ b/modules/polar_rose/helpers/polar_rose_theme.php @@ -0,0 +1,50 @@ +item()) { + $url = media_rss::item_feed($theme->item()); + } else if ($theme->tag()) { + $url = media_rss::tag_feed($theme->tag()); + } + + // Polar Rose doesn't understand relative URLs. Hack around that until they fix it. + $url = url::abs_site(substr($url, strpos($url, "index.php") + 10)); + + return "" . + ""; + } + } + + static function page_bottom($theme) { + return "
    "; + } +} diff --git a/modules/rearrange/helpers/rearrange_block.php b/modules/rearrange/helpers/rearrange_block.php deleted file mode 100644 index 999be91e..00000000 --- a/modules/rearrange/helpers/rearrange_block.php +++ /dev/null @@ -1,30 +0,0 @@ -"; - - return implode("\n", $head); - } -} diff --git a/modules/rearrange/helpers/rearrange_theme.php b/modules/rearrange/helpers/rearrange_theme.php new file mode 100644 index 00000000..832e7200 --- /dev/null +++ b/modules/rearrange/helpers/rearrange_theme.php @@ -0,0 +1,30 @@ +"; + + return implode("\n", $head); + } +} diff --git a/modules/search/helpers/search_block.php b/modules/search/helpers/search_block.php deleted file mode 100644 index e390b9fc..00000000 --- a/modules/search/helpers/search_block.php +++ /dev/null @@ -1,25 +0,0 @@ -render(); - } -} \ No newline at end of file diff --git a/modules/search/helpers/search_theme.php b/modules/search/helpers/search_theme.php new file mode 100644 index 00000000..63cc41c4 --- /dev/null +++ b/modules/search/helpers/search_theme.php @@ -0,0 +1,25 @@ +render(); + } +} \ No newline at end of file diff --git a/modules/slideshow/helpers/slideshow_block.php b/modules/slideshow/helpers/slideshow_block.php deleted file mode 100644 index 6a5a3f95..00000000 --- a/modules/slideshow/helpers/slideshow_block.php +++ /dev/null @@ -1,25 +0,0 @@ -" . - ""; - } -} diff --git a/modules/slideshow/helpers/slideshow_theme.php b/modules/slideshow/helpers/slideshow_theme.php new file mode 100644 index 00000000..56349dda --- /dev/null +++ b/modules/slideshow/helpers/slideshow_theme.php @@ -0,0 +1,25 @@ +" . + ""; + } +} diff --git a/modules/tag/helpers/tag_block.php b/modules/tag/helpers/tag_block.php deleted file mode 100644 index 8436dd08..00000000 --- a/modules/tag/helpers/tag_block.php +++ /dev/null @@ -1,46 +0,0 @@ -"; - } - - static function sidebar_blocks($theme) { - $block = new Block(); - $block->css_id = "gTag"; - $block->title = t("Popular Tags"); - $block->content = new View("tag_block.html"); - $block->content->cloud = tag::cloud(30); - - if ($theme->page_type() != "tag" && access::can("edit", $theme->item())) { - $controller = new Tags_Controller(); - $block->content->form = tag::get_add_form($theme->item()); - } else { - $block->content->form = ""; - } - - return $block; - } - - static function sort_by_name($tag1, $tag2) { - return strcasecmp($tag1->name, $tag2->name); - } -} \ No newline at end of file diff --git a/modules/tag/helpers/tag_theme.php b/modules/tag/helpers/tag_theme.php new file mode 100644 index 00000000..7a014d24 --- /dev/null +++ b/modules/tag/helpers/tag_theme.php @@ -0,0 +1,46 @@ +"; + } + + static function sidebar_blocks($theme) { + $block = new Block(); + $block->css_id = "gTag"; + $block->title = t("Popular Tags"); + $block->content = new View("tag_block.html"); + $block->content->cloud = tag::cloud(30); + + if ($theme->page_type() != "tag" && access::can("edit", $theme->item())) { + $controller = new Tags_Controller(); + $block->content->form = tag::get_add_form($theme->item()); + } else { + $block->content->form = ""; + } + + return $block; + } + + static function sort_by_name($tag1, $tag2) { + return strcasecmp($tag1->name, $tag2->name); + } +} \ No newline at end of file diff --git a/modules/user/helpers/user_block.php b/modules/user/helpers/user_block.php deleted file mode 100644 index bb9e567f..00000000 --- a/modules/user/helpers/user_block.php +++ /dev/null @@ -1,35 +0,0 @@ -guest) { - $url = url::file("lib/jquery.jeditable.js"); - return ""; - } - } - - static function header_top($theme) { - $view = new View("login.html"); - $view->user = user::active(); - return $view->render(); - } -} diff --git a/modules/user/helpers/user_theme.php b/modules/user/helpers/user_theme.php new file mode 100644 index 00000000..68424708 --- /dev/null +++ b/modules/user/helpers/user_theme.php @@ -0,0 +1,35 @@ +guest) { + $url = url::file("lib/jquery.jeditable.js"); + return ""; + } + } + + static function header_top($theme) { + $view = new View("login.html"); + $view->user = user::active(); + return $view->render(); + } +} -- cgit v1.2.3