From dbbac99356b47d18748001bd1fad7a465636abd9 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 14:27:11 +0300
Subject: fix ticket #1051
---
lib/gallery.common.css | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index 5dd0d031..2b86700f 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -822,6 +822,7 @@ div#g-action-status {
.rtl .sf-menu li:hover ul,
.rtl .sf-menu li.sfHover ul {
right: 0;
+ left: auto;
}
.rtl ul.sf-menu li li:hover ul,
--
cgit v1.2.3
From 53ccc4df11e5b39964a585b3857521921b385a08 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 14:30:56 +0300
Subject: correct format
---
lib/gallery.common.css | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index 2b86700f..054bc29a 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -780,7 +780,7 @@ div#g-action-status {
/* RTL Superfish ~~~~~~~~~~~~~~~~~~~~~~~~~ */
.rtl .sf-menu a {
- border-left: none;
+ border-left: none;
border-right:1px solid #fff;
}
@@ -791,7 +791,7 @@ div#g-action-status {
.rtl .sf-sub-indicator {
left: .75em !important;
- right: auto;
+ right: auto;
background: url('superfish/images/arrows-ffffff-rtl.png') no-repeat -10px -100px; /* 8-bit indexed alpha png. IE6 gets solid image only */
}
.rtl a > .sf-sub-indicator { /* give all except IE6 the correct values */
@@ -822,7 +822,7 @@ div#g-action-status {
.rtl .sf-menu li:hover ul,
.rtl .sf-menu li.sfHover ul {
right: 0;
- left: auto;
+ left: auto;
}
.rtl ul.sf-menu li li:hover ul,
--
cgit v1.2.3
From feb839a11804f5774cbbe10a348d6ffe28aa3f5c Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 14:36:59 +0300
Subject: more fixes for RTL Superfish
---
lib/gallery.common.css | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index 054bc29a..682cef70 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -828,10 +828,12 @@ div#g-action-status {
.rtl ul.sf-menu li li:hover ul,
.rtl ul.sf-menu li li.sfHover ul {
right: 12em; /* match ul width */
+ left: auto;
}
.rtl ul.sf-menu li li li:hover ul,
.rtl ul.sf-menu li li li.sfHover ul {
right: 12em; /* match ul width */
+ left: auto;
}
/*** shadows for all but IE6 ***/
--
cgit v1.2.3
From 2014e2b055fc75ee3aec61c563ce5fac5ba6d534 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 14:56:53 +0300
Subject: flip the window title and cancel button for RTL in dialogue windows
---
lib/gallery.common.css | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index 682cef70..a83acdbb 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -846,6 +846,22 @@ div#g-action-status {
-webkit-border-bottom-right-radius: 17px;
}
+/* RTL ThemeRoller ~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.rtl .ui-dialog .ui-dialog-titlebar {
+ padding: 0.5em 1em 0.3em 0.3em;
+}
+
+.rtl .ui-dialog .ui-dialog-title {
+ float: right;
+}
+
+.rtl .ui-dialog .ui-dialog-titlebar-close {
+ left: 0.3em;
+ right: auto;
+}
+
+
/* RTL paginator ~~~~~~~~~~~~~~~~~~~~~~~~~~ */
.rtl .g-paginator .g-info {
--
cgit v1.2.3
From d91cf72ee9ba27e7c2a97ee807f4a49df2f24ff9 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:10:59 +0300
Subject: flip the padding direction for sidebar blocks contents in RTL
---
themes/admin_wind/css/screen.css | 4 ++++
themes/wind/css/screen.css | 3 +++
2 files changed, 7 insertions(+)
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index dbfb59e8..e2817b78 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -487,4 +487,8 @@ th {
.rtl .g-selected img,
.rtl .g-available .g-block img {
margin: 0 0 1em 1em;
+}
+
+.rtl #g-sidebar .g-block-content {
+ padding-right: 1em;
}
\ No newline at end of file
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index 1e55a967..f5cb6601 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -457,3 +457,6 @@ td {
background-image: url('../images/ico-view-slideshow-rtl.png');
}
+.rtl #g-sidebar .g-block-content {
+ padding-right: 1em;
+}
\ No newline at end of file
--
cgit v1.2.3
From 3f2e68d4b15bea6974201523b70ef18d3d5b1f8a Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:20:14 +0300
Subject: oops.. remove the padding in RTL for admin-wind, since it seems that
it's zero (why the rule is duplicated with different values in the file in
lines: 159, 301?)
---
themes/admin_wind/css/screen.css | 4 ----
1 file changed, 4 deletions(-)
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index e2817b78..dbfb59e8 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -487,8 +487,4 @@ th {
.rtl .g-selected img,
.rtl .g-available .g-block img {
margin: 0 0 1em 1em;
-}
-
-.rtl #g-sidebar .g-block-content {
- padding-right: 1em;
}
\ No newline at end of file
--
cgit v1.2.3
From a77266d8e06ed960955b654197d4bcc9be2cb618 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:20:50 +0300
Subject: remove the original padding
---
themes/wind/css/screen.css | 1 +
1 file changed, 1 insertion(+)
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index f5cb6601..66645cef 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -459,4 +459,5 @@ td {
.rtl #g-sidebar .g-block-content {
padding-right: 1em;
+ padding-left: 0;
}
\ No newline at end of file
--
cgit v1.2.3
From afa99c93f2f7ad5e46a2739a92e1f898dc9afc84 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:33:35 +0300
Subject: improve Superfish menus shadow for RTL, and add round corners support
for Opera
---
lib/gallery.common.css | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index a83acdbb..2bb5b6e2 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -840,10 +840,18 @@ div#g-action-status {
.rtl .sf-shadow ul {
background: url('superfish/images/shadow.png') no-repeat bottom left;
padding: 0 0 9px 8px;
- -moz-border-radius-bottomright: 17px;
+ border-top-right-radius: 0;
+ border-bottom-left-radius: 0;
+ -moz-border-radius-topright: 0;
+ -moz-border-radius-bottomleft: 0;
+ -webkit-border-top-right-radius: 0;
+ -webkit-border-bottom-left-radius: 0;
-moz-border-radius-topleft: 17px;
+ -moz-border-radius-bottomright: 17px;
-webkit-border-top-left-radius: 17px;
-webkit-border-bottom-right-radius: 17px;
+ border-top-left-radius: 17px;
+ border-bottom-right-radius: 17px;
}
/* RTL ThemeRoller ~~~~~~~~~~~~~~~~~~~~~~~~ */
--
cgit v1.2.3
From bd052d72f27efb703d2cf5c128300a2be7f6fb04 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:39:19 +0300
Subject: flip the padding of footer for RTL
---
themes/wind/css/screen.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index 66645cef..063c5015 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -460,4 +460,8 @@ td {
.rtl #g-sidebar .g-block-content {
padding-right: 1em;
padding-left: 0;
+}
+
+.rtl #g-footer #g-credits li {
+ padding-left: 1.2em;
}
\ No newline at end of file
--
cgit v1.2.3
From 9eefbb8d213426d3a74f2b55cfd99e2e608c9f26 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 15:42:42 +0300
Subject: fix the footer padding for RTL, complete the last commit
---
themes/wind/css/screen.css | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index 063c5015..44582a92 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -463,5 +463,6 @@ td {
}
.rtl #g-footer #g-credits li {
- padding-left: 1.2em;
+ padding-left: 1.2em !important;
+ padding-right: 0;
}
\ No newline at end of file
--
cgit v1.2.3
From b46fc38dcc539bf18505b60e0f462aaec6e2c647 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Wed, 23 Jun 2010 17:12:25 +0300
Subject: centerize the group labels in Edit Permission window.. i think it's
much cleaner this way
---
modules/gallery/css/gallery.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/modules/gallery/css/gallery.css b/modules/gallery/css/gallery.css
index 282ebec2..08bd4749 100644
--- a/modules/gallery/css/gallery.css
+++ b/modules/gallery/css/gallery.css
@@ -84,6 +84,10 @@
clear: both;
}
+#g-edit-permissions-form th {
+ text-align: center;
+}
+
#g-edit-permissions-form td {
background-image: none;
}
--
cgit v1.2.3
From 8e1ae7549362688dd38e053dd736ddc5fc6a4982 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Mon, 2 Aug 2010 05:45:05 +0300
Subject: add a little space before the success/fail icons, for RTL status
messages
---
lib/gallery.common.css | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
index 2bb5b6e2..315ec363 100644
--- a/lib/gallery.common.css
+++ b/lib/gallery.common.css
@@ -638,7 +638,7 @@ div#g-action-status {
.rtl .g-warning,
.rtl #g-add-photos-status .g-success,
.rtl #g-add-photos-status .g-error {
- background-position: center right;
+ background-position: 99% 50%;
padding-right: 30px !important;
}
--
cgit v1.2.3
From a0033ce75968b3c134c0e439046f135b1e646550 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Tue, 31 Aug 2010 18:08:01 +0300
Subject: flip the float value for RTL
---
modules/gallery/css/gallery.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/modules/gallery/css/gallery.css b/modules/gallery/css/gallery.css
index 8012c6cc..275a3d7d 100644
--- a/modules/gallery/css/gallery.css
+++ b/modules/gallery/css/gallery.css
@@ -200,3 +200,7 @@
.rtl #g-translations ol {
margin: 0 2em 1em 0;
}
+
+.rtl #g-add-photos-status-message {
+ float: left;
+}
--
cgit v1.2.3
From 078a287d62207c8df757cb9f672a7151cf2c7849 Mon Sep 17 00:00:00 2001
From: mamouneyya
Date: Mon, 20 Sep 2010 04:43:32 +0300
Subject: Revert the revert of (!): 93d1a8103e757a87fb00 f14290f34f097f525a56
ff8ee5bdfcc0d35e14f3
returning Tim changes to merge gallery.common.css contents with the theme css file
---
lib/gallery.common.css | 897 ---------------------------------
themes/admin_wind/css/screen.css | 850 ++++++++++++++++++++++++++++++-
themes/admin_wind/views/admin.html.php | 1 -
themes/wind/css/screen.css | 893 +++++++++++++++++++++++++++++++-
themes/wind/views/page.html.php | 1 -
5 files changed, 1718 insertions(+), 924 deletions(-)
delete mode 100644 lib/gallery.common.css
diff --git a/lib/gallery.common.css b/lib/gallery.common.css
deleted file mode 100644
index 315ec363..00000000
--- a/lib/gallery.common.css
+++ /dev/null
@@ -1,897 +0,0 @@
-/**
- * Gallery 3 commonly re-used screen styles
- *
- * Sheet organization:
- *
- * 1) Text
- * 2) Forms
- * 3) Dimension and scale
- * 4) States and interactions
- * 5) Positioning and order
- * 6) Containers/widgets
- * 7) Right to left language styles
- *
- * @todo Update .g-message-block, don't force it to 100%, bad things happen is themes when you do.
- */
-
-/** *******************************************************************
- * 1) Text
- **********************************************************************/
-
-.g-text-small {
- font-size: .8em;
-}
-
-.g-text-big {
- font-size: 1.2em;
-}
-
-.g-text-right {
- text-align: right;
-}
-
-/** *******************************************************************
- * 2) Forms
- **********************************************************************/
-
-form {
- margin: 0;
-}
-
-fieldset {
- border: 1px solid #ccc;
- padding: 0 1em .8em 1em;
-}
-
-#g-banner fieldset,
-#g-sidebar fieldset {
- border: none;
- padding: 0;
-}
-
-legend {
- font-weight: bold;
- margin: 0;
- padding: 0 .2em;
-}
-
-#g-banner legend,
-#g-sidebar legend,
-input[type="hidden"] {
- display: none;
-}
-
-input.textbox,
-input[type="text"],
-input[type="password"],
-textarea {
- border: 1px solid #e8e8e8;
- border-top-color: #ccc;
- border-left-color: #ccc;
- clear: both;
- color: #333;
- width: 50%;
-}
-
-textarea {
- height: 12em;
- width: 97%;
-}
-
-input:focus,
-input.textbox:focus,
-input[type=text]:focus,
-textarea:focus,
-option:focus {
- background-color: #ffc;
- color: #000;
-}
-
-input.checkbox,
-input[type=checkbox],
-input.radio,
-input[type=radio] {
- float: left;
- margin-right: .4em;
-}
-
-/* Form layout ~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-form li {
- margin: 0;
- padding: 0 0 .2em 0;
-}
-
-form ul {
- margin-top: 0;
-}
-
-form ul ul {
- clear: both;
-}
-
-form ul ul li {
- float: left;
-}
-
-input,
-select,
-textarea {
- display: block;
- clear: both;
- padding: .2em;
-}
-
-input[type="submit"],
-input[type="reset"] {
- display: inline;
- clear: none;
- float: left;
-}
-
-/* Forms in dialogs and panels ~~~~~~~~~ */
-
-#g-dialog ul li {
- padding-bottom: .8em;
-}
-
-#g-dialog fieldset,
-#g-panel fieldset {
- border: none;
- padding: 0;
-}
-
-#g-panel legend {
- display: none;
-}
-
-input[readonly] {
- background-color: #F4F4FC;
-}
-
-#g-dialog input.textbox,
-#g-dialog input[type=text],
-#g-dialog input[type=password],
-#g-dialog textarea {
- width: 97%;
-}
-
-/* Short forms ~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.g-short-form legend,
-.g-short-form label {
- display: none;
-}
-
-.g-short-form fieldset {
- border: none;
- padding: 0;
-}
-
-.g-short-form li {
- float: left;
- margin: 0 !important;
- padding: .4em 0;
-}
-
-.g-short-form .textbox,
-.g-short-form input[type=text] {
- color: #666;
- padding: .3em .6em;
- width: 100%;
-}
-
-.g-short-form .textbox.g-error {
- border: 1px solid #f00;
- color: #f00;
- padding-left: 24px;
-}
-
-.g-short-form .g-cancel {
- display: block;
- margin: .3em .8em;
-}
-
-#g-sidebar .g-short-form li {
- padding-left: 0;
- padding-right: 0;
-}
-
-/** *******************************************************************
- * 3) Dimension and scale
- **********************************************************************/
-
-.g-one-quarter {
- width: 25%;
-}
-
-.g-one-third {
- width: 33%;
-}
-
-.g-one-half {
- width: 50%;
-}
-
-.g-two-thirds {
- width: 66%;
-}
-
-.g-three-quarters {
- width: 75%;
-}
-
-.g-whole {
- width: 100%;
-}
-
-/** *******************************************************************
- * 4) States and interactions
- **********************************************************************/
-
-.g-active,
-.g-enabled,
-.g-available,
-.g-selected,
-.g-highlight {
- font-weight: bold;
-}
-
-.g-inactive,
-.g-disabled,
-.g-unavailable,
-.g-uneditable,
-.g-locked,
-.g-deselected,
-.g-understate {
- color: #ccc;
- font-weight: normal;
-}
-
-.g-editable {
- padding: .2em .3em;
-}
-
-.g-editable:hover {
- background-color: #ffc;
- cursor: text;
-}
-
-.g-error,
-.g-info,
-.g-success,
-.g-warning {
- padding-left: 30px;
-}
-
-form li.g-error,
-form li.g-info,
-form li.g-success,
-form li.g-warning {
- background-image: none;
- padding: .3em .8em .3em 0;
-}
-
-.g-short-form li.g-error {
- padding: .3em 0;
-}
-
-form.g-error input[type="text"],
-li.g-error input[type="text"],
-form.g-error input[type="password"],
-li.g-error input[type="password"],
-form.g-error input[type="checkbox"],
-li.g-error input[type="checkbox"],
-form.g-error input[type="radio"],
-li.g-error input[type="radio"],
-form.g-error textarea,
-li.g-error textarea,
-form.g-error select,
-li.g-error select {
- border: 2px solid #f00;
- margin-bottom: .2em;
-}
-
-.g-error,
-.g-denied,
-tr.g-error td.g-error,
-#g-add-photos-status .g-error {
- background: #f6cbca url('images/ico-error.png') no-repeat .4em 50%;
- color: #f00;
-}
-
-.g-info {
- background: #e8e8e8 url('images/ico-info.png') no-repeat .4em 50%;
-}
-
-.g-success,
-.g-allowed,
-#g-add-photos-status .g-success {
- background: #d9efc2 url('images/ico-success.png') no-repeat .4em 50%;
-}
-
-tr.g-success {
- background-image: none;
-}
-
-tr.g-success td.g-success {
- background-image: url('images/ico-success.png');
-}
-
-.g-warning,
-tr.g-warning td.g-warning {
- background: #fcf9ce url('images/ico-warning.png') no-repeat .4em 50%;
-}
-
-form .g-error {
- background-color: #fff;
- padding-left: 20px;
-}
-
-.g-open {
-}
-
-.g-closed {
-}
-
-.g-installed {
- background-color: #eeeeee;
-}
-
-.g-default {
- background-color: #c5dbec;
- font-weight: bold;
-}
-
-.g-draggable {
- cursor: move;
-}
-
-.g-draggable:hover {
- border: 1px dashed #000;
-}
-
-.ui-sortable .g-target,
-.ui-state-highlight {
- background-color: #fcf9ce;
- border: 2px dotted #999;
- height: 2em;
- margin: 1em 0;
-}
-
-/* Ajax loading indicator ~~~~~~~~~~~~~~~~ */
-
-.g-loading-large,
-.g-dialog-loading-large {
- background: #e8e8e8 url('images/loading-large.gif') no-repeat center center !important;
-}
-
-.g-loading-small {
- background: #e8e8e8 url('images/loading-small.gif') no-repeat center center !important;
-}
-
-/** *******************************************************************
- * 5) Positioning and order
- **********************************************************************/
-
-.g-left {
- clear: none;
- float: left;
-}
-
-.g-right {
- clear: none;
- float: right;
-}
-
-.g-first {
-}
-
-.g-last {
-}
-
-.g-even {
- background-color: #fff;
-}
-
-.g-odd {
- background-color: #eee;
-}
-
-/** *******************************************************************
- * 6) Containers/widgets
- **********************************************************************/
-
-/* Generic block container ~~~~~~~~~~~~~~~ */
-
-.g-block {
- clear: both;
- margin-bottom: 2.5em;
-}
-
-.g-block-content {
-}
-
-/* Superfish menu overrides ~~~~~~~~~~~~~~ */
-
-.sf-menu ul {
- width: 12em;
-}
-
-ul.sf-menu li li:hover ul,
-ul.sf-menu li li.sfHover ul {
- left: 12em;
-}
-
-ul.sf-menu li li li:hover ul,
-ul.sf-menu li li li.sfHover ul {
- left: 12em;
-}
-
-/* jQuery UI Dialog ~~~~~~~~~~~~~~~~~~~~~~ */
-
-.ui-widget-overlay {
- background: #000;
- opacity: .7;
-}
-
-/* Buttons ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.g-button {
- display: inline-block;
- margin: 0 4px 0 0;
- padding: .2em .4em;
-}
-
-.g-button,
-.g-button:hover,
-.g-button:active {
- cursor: pointer !important;
- outline: 0;
- text-decoration: none;
- -moz-outline-style: none;
-}
-
-button {
- padding: 2px 4px 2px 4px;
-}
-
-/* jQuery UI ThemeRoller buttons ~~~~~~~~~ */
-
-.g-buttonset {
- padding-left: 1px;
-}
-
-.g-buttonset li {
- float: left;
-}
-
-.g-buttonset .g-button {
- margin: 0;
-}
-
-.ui-icon-left .ui-icon {
- float: left;
- margin-right: .2em;
-}
-
-.ui-icon-right .ui-icon {
- float: right;
- margin-left: .2em;
-}
-
-/* Rotate icon, ThemeRoller only provides one of these */
-
-.ui-icon-rotate-ccw {
- background-position: -192px -64px;
-}
-
-.ui-icon-rotate-cw {
- background-position: -208px -64px;
-}
-
-.g-progress-bar {
- height: 1em;
- width: 100%;
- margin-top: .5em;
- display: inline-block;
-}
-
-/* Status and validation messages ~~~~ */
-
-.g-message-block {
- background-position: .4em .3em;
- border: 1px solid #ccc;
- padding: 0;
-}
-
-#g-action-status {
- margin-bottom: 1em;
-}
-
-#g-action-status li,
-p#g-action-status,
-div#g-action-status {
- padding: .3em .3em .3em 30px;
-}
-
-#g-site-status li {
- border-bottom: 1px solid #ccc;
- padding: .3em .3em .3em 30px;
-}
-
-.g-module-status {
- clear: both;
- margin-bottom: 1em;
-}
-
-.g-message {
- background-position: 0 50%;
-}
-
-/* Breadcrumbs ~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.g-breadcrumbs {
- clear: both;
- padding: 0 20px;
-}
-
-.g-breadcrumbs li {
- background: transparent url('images/ico-separator.gif') no-repeat scroll left center;
- float: left;
- padding: 1em 8px 1em 18px;
-}
-
-.g-breadcrumbs .g-first {
- background: none;
- padding-left: 0;
-}
-
-.g-breadcrumbs li a,
-.g-breadcrumbs li span {
- display: block;
-}
-
-#g-dialog ul.g-breadcrumbs {
- margin-left: 0;
- padding-left: 0;
-}
-
-/* Pagination ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.g-paginator {
- padding: .2em 0;
- width: 100%;
-}
-
-.g-paginator li {
- float: left;
- width: 30%;
-}
-
-.g-paginator .g-info {
- background: none;
- padding: .2em 0;
- text-align: center;
- width: 40%;
-}
-
-/* Dialogs and panels ~~~~~~~~~~~~~~~~~~ */
-
-#g-dialog {
- text-align: left;
-}
-
-#g-dialog legend {
- display: none;
-}
-
-#g-dialog .g-cancel {
- margin: .4em 1em;
-}
-
-#g-panel {
- display: none;
- padding: 1em;
-}
-
-/* Inline layout ~~~~~~~~~~ */
-
-.g-inline li {
- float: left;
- margin-left: 1.8em;
- padding-left: 0 !important;
-}
-
-.g-inline li.g-first {
- margin-left: 0;
-}
-
-/** *******************************************************************
- * 7) Right to left language styles
- **********************************************************************/
-
-.rtl {
- direction: rtl;
-}
-
-.rtl #g-header,
-.rtl #g-content,
-.rtl #g-sidebar,
-.rtl #g-footer,
-.rtl caption,
-.rtl th,
-.rtl #g-dialog,
-.rtl .g-context-menu li a,
-.rtl .g-message-box li,
-.rtl #g-site-status li {
- text-align: right;
-}
-
-.rtl .g-text-right {
- text-align: left;
-}
-
-.rtl .g-error,
-.rtl .g-info,
-.rtl .g-success,
-.rtl .g-warning,
-.rtl #g-add-photos-status .g-success,
-.rtl #g-add-photos-status .g-error {
- background-position: 99% 50%;
- padding-right: 30px !important;
-}
-
-.rtl form li.g-error,
-.rtl form li.g-info,
-.rtl form li.g-success,
-.rtl form li.g-warning {
- padding-right: 0 !important;
-}
-
-.rtl .g-left,
-.rtl .g-inline li,
-.rtl #g-content #g-album-grid .g-item,
-.rtl .sf-menu li,
-.rtl .g-breadcrumbs li,
-.rtl .g-paginator li,
-.rtl .g-buttonset li,
-.rtl .ui-icon-left .ui-icon,
-.rtl .g-short-form li,
-.rtl form ul ul li,
-.rtl input[type="submit"],
-.rtl input[type="reset"],
-.rtl input.checkbox,
-.rtl input[type=checkbox],
-.rtl input.radio,
-.rtl input[type=radio] {
- float: right;
-}
-
-.rtl .g-right,
-.rtl .ui-icon-right .ui-icon {
- float: left;
-}
-
-.rtl .g-inline li {
- margin-right: 1em;
-}
-
-.rtl .g-inline li.g-first {
- margin-right: 0;
-}
-
-.rtl .g-breadcrumbs li {
- background: transparent url('images/ico-separator-rtl.gif') no-repeat scroll right center;
- padding: 1em 18px 1em 8px;
-}
-
-.rtl .g-breadcrumbs .g-first {
- background: none;
- padding-right: 0;
-}
-
-.rtl input.checkbox {
- margin-left: .4em;
-}
-
-.rtl #g-add-comment {
- right: inherit;
- left: 0;
-}
-
-.rtl .ui-icon-left .ui-icon {
- margin-left: .2em;
-}
-
-.rtl .ui-icon-right .ui-icon {
- margin-right: .2em;
-}
-
-/* RTL Corner radius ~~~~~~~~~~~~~~~~~~~~~~ */
-.rtl .g-buttonset .ui-corner-tl {
- -moz-border-radius-topleft: 0;
- -webkit-border-top-left-radius: 0;
- border-top-left-radius: 0;
- -moz-border-radius-topright: 5px !important;
- -webkit-border-top-right-radius: 5px !important;
- border-top-right-radius: 5px !important;
-}
-
-.rtl .g-buttonset .ui-corner-tr {
- -moz-border-radius-topright: 0;
- -webkit-border-top-right-radius: 0;
- border-top-right-radius: 0;
- -moz-border-radius-topleft: 5px !important;
- -webkit-border-top-left-radius: 5px !important;
- border-top-left-radius: 5px !important;
-}
-
-.rtl .g-buttonset .ui-corner-bl {
- -moz-border-radius-bottomleft: 0;
- -webkit-border-bottom-left-radius: 0;
- border-bottom-left-radius: 0;
- -moz-border-radius-bottomright: 5px !important;
- -webkit-border-bottom-right-radius: 5px !important;
- border-bottom-right-radius: 5px !important;
-}
-
-.rtl .g-buttonset .ui-corner-br {
- -moz-border-radius-bottomright: 0;
- -webkit-border-bottom-right-radius: 0;
- border-bottom-right-radius: 0;
- -moz-border-radius-bottomleft: 5px !important;
- -webkit-border-bottom-left-radius: 5px !important;
- border-bottom-left-radius: 5px !important;
-}
-
-.rtl .g-buttonset .ui-corner-right,
-.rtl .ui-progressbar .ui-corner-right {
- -moz-border-radius-topright: 0;
- -webkit-border-top-right-radius: 0;
- border-top-right-radius: 0;
- -moz-border-radius-topleft: 5px !important;
- -webkit-border-top-left-radius: 5px !important;
- border-top-left-radius: 5px !important;
- -moz-border-radius-bottomright: 0;
- -webkit-border-bottom-right-radius: 0;
- border-bottom-right-radius: 0;
- -moz-border-radius-bottomleft: 5px !important;
- -webkit-border-bottom-left-radius: 5px !important;
- border-bottom-left-radius: 5px !important;
-}
-
-.rtl .g-buttonset .ui-corner-left,
-.rtl .ui-progressbar .ui-corner-left {
- -moz-border-radius-topleft: 0;
- -webkit-border-top-left-radius: 0;
- border-top-left-radius: 0;
- -moz-border-radius-topright: 5px !important;
- -webkit-border-top-right-radius: 5px !important;
- border-top-right-radius: 5px !important;
- -moz-border-radius-bottomleft: 0;
- -webkit-border-bottom-left-radius: 0;
- border-bottom-left-radius: 0;
- -moz-border-radius-bottomright: 5px !important;
- -webkit-border-bottom-right-radius: 5px !important;
- border-bottom-right-radius: 5px !important;
-}
-
-/* RTL Superfish ~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.rtl .sf-menu a {
- border-left: none;
- border-right:1px solid #fff;
-}
-
-.rtl .sf-menu a.sf-with-ul {
- padding-left: 2.25em;
- padding-right: 1em;
-}
-
-.rtl .sf-sub-indicator {
- left: .75em !important;
- right: auto;
- background: url('superfish/images/arrows-ffffff-rtl.png') no-repeat -10px -100px; /* 8-bit indexed alpha png. IE6 gets solid image only */
-}
-.rtl a > .sf-sub-indicator { /* give all except IE6 the correct values */
- top: .8em;
- background-position: -10px -100px; /* use translucent arrow for modern browsers*/
-}
-/* apply hovers to modern browsers */
-.rtl a:focus > .sf-sub-indicator,
-.rtl a:hover > .sf-sub-indicator,
-.rtl a:active > .sf-sub-indicator,
-.rtl li:hover > a > .sf-sub-indicator,
-.rtl li.sfHover > a > .sf-sub-indicator {
- background-position: 0 -100px; /* arrow hovers for modern browsers*/
-}
-
-/* point right for anchors in subs */
-.rtl .sf-menu ul .sf-sub-indicator { background-position: 0 0; }
-.rtl .sf-menu ul a > .sf-sub-indicator { background-position: -10px 0; }
-/* apply hovers to modern browsers */
-.rtl .sf-menu ul a:focus > .sf-sub-indicator,
-.rtl .sf-menu ul a:hover > .sf-sub-indicator,
-.rtl .sf-menu ul a:active > .sf-sub-indicator,
-.rtl .sf-menu ul li:hover > a > .sf-sub-indicator,
-.rtl .sf-menu ul li.sfHover > a > .sf-sub-indicator {
- background-position: 0 0; /* arrow hovers for modern browsers*/
-}
-
-.rtl .sf-menu li:hover ul,
-.rtl .sf-menu li.sfHover ul {
- right: 0;
- left: auto;
-}
-
-.rtl ul.sf-menu li li:hover ul,
-.rtl ul.sf-menu li li.sfHover ul {
- right: 12em; /* match ul width */
- left: auto;
-}
-.rtl ul.sf-menu li li li:hover ul,
-.rtl ul.sf-menu li li li.sfHover ul {
- right: 12em; /* match ul width */
- left: auto;
-}
-
-/*** shadows for all but IE6 ***/
-.rtl .sf-shadow ul {
- background: url('superfish/images/shadow.png') no-repeat bottom left;
- padding: 0 0 9px 8px;
- border-top-right-radius: 0;
- border-bottom-left-radius: 0;
- -moz-border-radius-topright: 0;
- -moz-border-radius-bottomleft: 0;
- -webkit-border-top-right-radius: 0;
- -webkit-border-bottom-left-radius: 0;
- -moz-border-radius-topleft: 17px;
- -moz-border-radius-bottomright: 17px;
- -webkit-border-top-left-radius: 17px;
- -webkit-border-bottom-right-radius: 17px;
- border-top-left-radius: 17px;
- border-bottom-right-radius: 17px;
-}
-
-/* RTL ThemeRoller ~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.rtl .ui-dialog .ui-dialog-titlebar {
- padding: 0.5em 1em 0.3em 0.3em;
-}
-
-.rtl .ui-dialog .ui-dialog-title {
- float: right;
-}
-
-.rtl .ui-dialog .ui-dialog-titlebar-close {
- left: 0.3em;
- right: auto;
-}
-
-
-/* RTL paginator ~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-
-.rtl .g-paginator .g-info {
- width: 35%;
-}
-
-.rtl .g-paginator .g-text-right {
- margin-left: 0;
-}
-
-.rtl .g-paginator .ui-icon-seek-end {
- background-position: -80px -160px;
-}
-
-.rtl .g-paginator .ui-icon-seek-next {
- background-position: -48px -160px;
-}
-
-.rtl .g-paginator .ui-icon-seek-prev {
- background-position: -32px -160px;
-}
-
-.rtl .g-paginator .ui-icon-seek-first {
- background-position: -64px -160px;
-}
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index 0d891149..3e155764 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -4,13 +4,15 @@
* @requires YUI reset, font, grids CSS
*
* Sheet organization:
- * 1) Basic HTML elements
- * 2) Reusable content blocks
- * 3) Page layout containers
- * 4) Content blocks in specific layout containers
- * 5) Navigation and menus
- * 6) jQuery and jQuery UI
- * 7) Right-to-left language styles
+ * 1) Basic HTML elements
+ * 2) Reusable content blocks
+ * 3) Page layout containers
+ * 4) Content blocks in specific layout containers
+ * 5) States and interactions
+ * 6) Positioning and order
+ * 7) Navigation and menus
+ * 8) jQuery and jQuery UI
+ * 9) Right-to-left language styles
*
* @todo Review g-buttonset-vertical
*/
@@ -86,6 +88,168 @@ a:hover,
}
/* Forms ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+form {
+ margin: 0;
+}
+
+fieldset {
+ border: 1px solid #ccc;
+ padding: 0 1em .8em 1em;
+}
+
+#g-banner fieldset,
+#g-sidebar fieldset {
+ border: none;
+ padding: 0;
+}
+
+legend {
+ font-weight: bold;
+ margin: 0;
+ padding: 0 .2em;
+}
+
+#g-banner legend,
+#g-sidebar legend,
+input[type="hidden"] {
+ display: none;
+}
+
+input.textbox,
+input[type="text"],
+input[type="password"],
+textarea {
+ border: 1px solid #e8e8e8;
+ border-top-color: #ccc;
+ border-left-color: #ccc;
+ clear: both;
+ color: #333;
+ width: 50%;
+}
+
+textarea {
+ height: 12em;
+ width: 97%;
+}
+
+input:focus,
+input.textbox:focus,
+input[type=text]:focus,
+textarea:focus,
+option:focus {
+ background-color: #ffc;
+ color: #000;
+}
+
+input.checkbox,
+input[type=checkbox],
+input.radio,
+input[type=radio] {
+ float: left;
+ margin-right: .4em;
+}
+
+/* Form layout ~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+form li {
+ margin: 0;
+ padding: 0 0 .2em 0;
+}
+
+form ul {
+ margin-top: 0;
+}
+
+form ul ul {
+ clear: both;
+}
+
+form ul ul li {
+ float: left;
+}
+
+input,
+select,
+textarea {
+ display: block;
+ clear: both;
+ padding: .2em;
+}
+
+input[type="submit"],
+input[type="reset"] {
+ display: inline;
+ clear: none;
+ float: left;
+}
+
+/* Forms in dialogs and panels ~~~~~~~~~ */
+
+#g-dialog ul li {
+ padding-bottom: .8em;
+}
+
+#g-dialog fieldset,
+#g-panel fieldset {
+ border: none;
+ padding: 0;
+}
+
+#g-panel legend {
+ display: none;
+}
+
+input[readonly] {
+ background-color: #F4F4FC;
+}
+
+#g-dialog input.textbox,
+#g-dialog input[type=text],
+#g-dialog input[type=password],
+#g-dialog textarea {
+ width: 97%;
+}
+
+/* Short forms ~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.g-short-form legend,
+.g-short-form label {
+ display: none;
+}
+
+.g-short-form fieldset {
+ border: none;
+ padding: 0;
+}
+
+.g-short-form li {
+ float: left;
+ margin: 0 !important;
+ padding: .4em 0;
+}
+
+.g-short-form .textbox,
+.g-short-form input[type=text] {
+ color: #666;
+ padding: .3em .6em;
+ width: 100%;
+}
+
+.g-short-form .textbox.g-error {
+ border: 1px solid #f00;
+ color: #f00;
+ padding-left: 24px;
+}
+
+.g-short-form .g-cancel {
+ display: block;
+ margin: .3em .8em;
+}
+
+#g-sidebar .g-short-form li {
+ padding-left: 0;
+ padding-right: 0;
+}
fieldset {
margin-bottom: 1em;
@@ -131,6 +295,19 @@ th {
white-space: nowrap;
}
+/* Text ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+.g-text-small {
+ font-size: .8em;
+}
+
+.g-text-big {
+ font-size: 1.2em;
+}
+
+.g-text-right {
+ text-align: right;
+}
+
/** *******************************************************************
* 2) Reusable content blocks
*********************************************************************/
@@ -230,6 +407,30 @@ ul.enumeration li {
/*** ******************************************************************
* 3) Page layout containers
*********************************************************************/
+/* Dimension and scale ~~~~~~~~~~~~~~~~~~~ */
+.g-one-quarter {
+ width: 25%;
+}
+
+.g-one-third {
+ width: 33%;
+}
+
+.g-one-half {
+ width: 50%;
+}
+
+.g-two-thirds {
+ width: 66%;
+}
+
+.g-three-quarters {
+ width: 75%;
+}
+
+.g-whole {
+ width: 100%;
+}
/* Header ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
@@ -417,7 +618,180 @@ ul.enumeration li {
}
/** *******************************************************************
- * 5) Navigation and menus
+ * 5) States and interactions
+ **********************************************************************/
+
+.g-active,
+.g-enabled,
+.g-available,
+.g-selected,
+.g-highlight {
+ font-weight: bold;
+}
+
+.g-inactive,
+.g-disabled,
+.g-unavailable,
+.g-uneditable,
+.g-locked,
+.g-deselected,
+.g-understate {
+ color: #ccc;
+ font-weight: normal;
+}
+
+.g-editable {
+ padding: .2em .3em;
+}
+
+.g-editable:hover {
+ background-color: #ffc;
+ cursor: text;
+}
+
+.g-error,
+.g-info,
+.g-success,
+.g-warning {
+ padding-left: 30px;
+}
+
+form li.g-error,
+form li.g-info,
+form li.g-success,
+form li.g-warning {
+ background-image: none;
+ padding: .3em .8em .3em 0;
+}
+
+.g-short-form li.g-error {
+ padding: .3em 0;
+}
+
+form.g-error input[type="text"],
+li.g-error input[type="text"],
+form.g-error input[type="password"],
+li.g-error input[type="password"],
+form.g-error input[type="checkbox"],
+li.g-error input[type="checkbox"],
+form.g-error input[type="radio"],
+li.g-error input[type="radio"],
+form.g-error textarea,
+li.g-error textarea,
+form.g-error select,
+li.g-error select {
+ border: 2px solid #f00;
+ margin-bottom: .2em;
+}
+
+.g-error,
+.g-denied,
+tr.g-error td.g-error,
+#g-add-photos-status .g-error {
+ background: #f6cbca url('images/ico-error.png') no-repeat .4em 50%;
+ color: #f00;
+}
+
+.g-info {
+ background: #e8e8e8 url('images/ico-info.png') no-repeat .4em 50%;
+}
+
+.g-success,
+.g-allowed,
+#g-add-photos-status .g-success {
+ background: #d9efc2 url('images/ico-success.png') no-repeat .4em 50%;
+}
+
+tr.g-success {
+ background-image: none;
+}
+
+tr.g-success td.g-success {
+ background-image: url('images/ico-success.png');
+}
+
+.g-warning,
+tr.g-warning td.g-warning {
+ background: #fcf9ce url('images/ico-warning.png') no-repeat .4em 50%;
+}
+
+form .g-error {
+ background-color: #fff;
+ padding-left: 20px;
+}
+
+.g-open {
+}
+
+.g-closed {
+}
+
+.g-installed {
+ background-color: #eeeeee;
+}
+
+.g-default {
+ background-color: #c5dbec;
+ font-weight: bold;
+}
+
+.g-draggable {
+ cursor: move;
+}
+
+.g-draggable:hover {
+ border: 1px dashed #000;
+}
+
+.ui-sortable .g-target,
+.ui-state-highlight {
+ background-color: #fcf9ce;
+ border: 2px dotted #999;
+ height: 2em;
+ margin: 1em 0;
+}
+
+/* Ajax loading indicator ~~~~~~~~~~~~~~~~ */
+
+.g-loading-large,
+.g-dialog-loading-large {
+ background: #e8e8e8 url('images/loading-large.gif') no-repeat center center !important;
+}
+
+.g-loading-small {
+ background: #e8e8e8 url('images/loading-small.gif') no-repeat center center !important;
+}
+
+/** *******************************************************************
+ * 6) Positioning and order
+ **********************************************************************/
+
+.g-left {
+ clear: none;
+ float: left;
+}
+
+.g-right {
+ clear: none;
+ float: right;
+}
+
+.g-first {
+}
+
+.g-last {
+}
+
+.g-even {
+ background-color: #fff;
+}
+
+.g-odd {
+ background-color: #eee;
+}
+
+/** *******************************************************************
+ * 7) Navigation and menus
*********************************************************************/
/* Site Menu ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
@@ -434,10 +808,205 @@ ul.enumeration li {
}
/** *******************************************************************
- * 6) jQuery and jQuery UI
+ * 8) jQuery and jQuery UI
*********************************************************************/
+/* Generic block container ~~~~~~~~~~~~~~~ */
+
+.g-block {
+ clear: both;
+ margin-bottom: 2.5em;
+}
+
+.g-block-content {
+}
+
+/* Buttons ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.g-button {
+ display: inline-block;
+ margin: 0 4px 0 0;
+ padding: .2em .4em;
+}
+
+.g-button,
+.g-button:hover,
+.g-button:active {
+ cursor: pointer !important;
+ outline: 0;
+ text-decoration: none;
+ -moz-outline-style: none;
+}
+
+button {
+ padding: 2px 4px 2px 4px;
+}
+
+/* jQuery UI ThemeRoller buttons ~~~~~~~~~ */
+
+.g-buttonset {
+ padding-left: 1px;
+}
+
+.g-buttonset li {
+ float: left;
+}
+
+.g-buttonset .g-button {
+ margin: 0;
+}
+
+.ui-icon-left .ui-icon {
+ float: left;
+ margin-right: .2em;
+}
+
+.ui-icon-right .ui-icon {
+ float: right;
+ margin-left: .2em;
+}
+
+/* Rotate icon, ThemeRoller only provides one of these */
+
+.ui-icon-rotate-ccw {
+ background-position: -192px -64px;
+}
+
+.ui-icon-rotate-cw {
+ background-position: -208px -64px;
+}
+
+.g-progress-bar {
+ height: 1em;
+ width: 100%;
+ margin-top: .5em;
+ display: inline-block;
+}
+
+/* Status and validation messages ~~~~ */
+
+.g-message-block {
+ background-position: .4em .3em;
+ border: 1px solid #ccc;
+ padding: 0;
+}
+
+#g-action-status {
+ margin-bottom: 1em;
+}
+
+#g-action-status li,
+p#g-action-status,
+div#g-action-status {
+ padding: .3em .3em .3em 30px;
+}
+
+#g-site-status li {
+ border-bottom: 1px solid #ccc;
+ padding: .3em .3em .3em 30px;
+}
+
+.g-module-status {
+ clear: both;
+ margin-bottom: 1em;
+}
+
+.g-message {
+ background-position: 0 50%;
+}
+
+/* Breadcrumbs ~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.g-breadcrumbs {
+ clear: both;
+ padding: 0 20px;
+}
+
+.g-breadcrumbs li {
+ background: transparent url('images/ico-separator.gif') no-repeat scroll left center;
+ float: left;
+ padding: 1em 8px 1em 18px;
+}
+
+.g-breadcrumbs .g-first {
+ background: none;
+ padding-left: 0;
+}
+
+.g-breadcrumbs li a,
+.g-breadcrumbs li span {
+ display: block;
+}
+
+#g-dialog ul.g-breadcrumbs {
+ margin-left: 0;
+ padding-left: 0;
+}
+
+/* Pagination ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.g-paginator {
+ padding: .2em 0;
+ width: 100%;
+}
+
+.g-paginator li {
+ float: left;
+ width: 30%;
+}
+
+.g-paginator .g-info {
+ background: none;
+ padding: .2em 0;
+ text-align: center;
+ width: 40%;
+}
+
+/* Dialogs and panels ~~~~~~~~~~~~~~~~~~ */
+
+#g-dialog {
+ text-align: left;
+}
+
+#g-dialog legend {
+ display: none;
+}
+
+#g-dialog .g-cancel {
+ margin: .4em 1em;
+}
+
+#g-panel {
+ display: none;
+ padding: 1em;
+}
+
+/* Inline layout ~~~~~~~~~~ */
+
+.g-inline li {
+ float: left;
+ margin-left: 1.8em;
+ padding-left: 0 !important;
+}
+
+.g-inline li.g-first {
+ margin-left: 0;
+}
/* Superfish menu overrides ~~~~~~~~~~~~~~ */
+.sf-menu ul {
+ width: 12em;
+}
+
+ul.sf-menu li li:hover ul,
+ul.sf-menu li li.sfHover ul {
+ left: 12em;
+}
+
+ul.sf-menu li li li:hover ul,
+ul.sf-menu li li li.sfHover ul {
+ left: 12em;
+}
+
.sf-menu li li,
.sf-menu li li ul li {
@@ -449,6 +1018,10 @@ ul.enumeration li {
}
/* jQuery UI Dialog ~~~~~~~~~~~~~~~~~~~~~~ */
+.ui-widget-overlay {
+ background: #000;
+ opacity: .7;
+}
#g-admin-dashboard .ui-state-highlight,
#g-sidebar .ui-state-highlight {
@@ -466,8 +1039,265 @@ ul.enumeration li {
}
/** *******************************************************************
- * 7) Right to left styles
+ * 9) Right to left styles
*********************************************************************/
+.rtl {
+ direction: rtl;
+}
+
+.rtl #g-header,
+.rtl #g-content,
+.rtl #g-sidebar,
+.rtl #g-footer,
+.rtl caption,
+.rtl th,
+.rtl #g-dialog,
+.rtl .g-context-menu li a,
+.rtl .g-message-box li,
+.rtl #g-site-status li {
+ text-align: right;
+}
+
+.rtl .g-text-right {
+ text-align: left;
+}
+
+.rtl .g-error,
+.rtl .g-info,
+.rtl .g-success,
+.rtl .g-warning,
+.rtl #g-add-photos-status .g-success,
+.rtl #g-add-photos-status .g-error {
+ background-position: center right;
+ padding-right: 30px !important;
+}
+
+.rtl form li.g-error,
+.rtl form li.g-info,
+.rtl form li.g-success,
+.rtl form li.g-warning {
+ padding-right: 0 !important;
+}
+
+.rtl .g-left,
+.rtl .g-inline li,
+.rtl #g-content #g-album-grid .g-item,
+.rtl .sf-menu li,
+.rtl .g-breadcrumbs li,
+.rtl .g-paginator li,
+.rtl .g-buttonset li,
+.rtl .ui-icon-left .ui-icon,
+.rtl .g-short-form li,
+.rtl form ul ul li,
+.rtl input[type="submit"],
+.rtl input[type="reset"],
+.rtl input.checkbox,
+.rtl input[type=checkbox],
+.rtl input.radio,
+.rtl input[type=radio] {
+ float: right;
+}
+
+.rtl .g-right,
+.rtl .ui-icon-right .ui-icon {
+ float: left;
+}
+
+.rtl .g-inline li {
+ margin-right: 1em;
+}
+
+.rtl .g-inline li.g-first {
+ margin-right: 0;
+}
+
+.rtl .g-breadcrumbs li {
+ background: transparent url('images/ico-separator-rtl.gif') no-repeat scroll right center;
+ padding: 1em 18px 1em 8px;
+}
+
+.rtl .g-breadcrumbs .g-first {
+ background: none;
+ padding-right: 0;
+}
+
+.rtl input.checkbox {
+ margin-left: .4em;
+}
+
+.rtl #g-add-comment {
+ right: inherit;
+ left: 0;
+}
+
+.rtl .ui-icon-left .ui-icon {
+ margin-left: .2em;
+}
+
+.rtl .ui-icon-right .ui-icon {
+ margin-right: .2em;
+}
+
+/* RTL Corner radius ~~~~~~~~~~~~~~~~~~~~~~ */
+.rtl .g-buttonset .ui-corner-tl {
+ -moz-border-radius-topleft: 0;
+ -webkit-border-top-left-radius: 0;
+ border-top-left-radius: 0;
+ -moz-border-radius-topright: 5px !important;
+ -webkit-border-top-right-radius: 5px !important;
+ border-top-right-radius: 5px !important;
+}
+
+.rtl .g-buttonset .ui-corner-tr {
+ -moz-border-radius-topright: 0;
+ -webkit-border-top-right-radius: 0;
+ border-top-right-radius: 0;
+ -moz-border-radius-topleft: 5px !important;
+ -webkit-border-top-left-radius: 5px !important;
+ border-top-left-radius: 5px !important;
+}
+
+.rtl .g-buttonset .ui-corner-bl {
+ -moz-border-radius-bottomleft: 0;
+ -webkit-border-bottom-left-radius: 0;
+ border-bottom-left-radius: 0;
+ -moz-border-radius-bottomright: 5px !important;
+ -webkit-border-bottom-right-radius: 5px !important;
+ border-bottom-right-radius: 5px !important;
+}
+
+.rtl .g-buttonset .ui-corner-br {
+ -moz-border-radius-bottomright: 0;
+ -webkit-border-bottom-right-radius: 0;
+ border-bottom-right-radius: 0;
+ -moz-border-radius-bottomleft: 5px !important;
+ -webkit-border-bottom-left-radius: 5px !important;
+ border-bottom-left-radius: 5px !important;
+}
+
+.rtl .g-buttonset .ui-corner-right,
+.rtl .ui-progressbar .ui-corner-right {
+ -moz-border-radius-topright: 0;
+ -webkit-border-top-right-radius: 0;
+ border-top-right-radius: 0;
+ -moz-border-radius-topleft: 5px !important;
+ -webkit-border-top-left-radius: 5px !important;
+ border-top-left-radius: 5px !important;
+ -moz-border-radius-bottomright: 0;
+ -webkit-border-bottom-right-radius: 0;
+ border-bottom-right-radius: 0;
+ -moz-border-radius-bottomleft: 5px !important;
+ -webkit-border-bottom-left-radius: 5px !important;
+ border-bottom-left-radius: 5px !important;
+}
+
+.rtl .g-buttonset .ui-corner-left,
+.rtl .ui-progressbar .ui-corner-left {
+ -moz-border-radius-topleft: 0;
+ -webkit-border-top-left-radius: 0;
+ border-top-left-radius: 0;
+ -moz-border-radius-topright: 5px !important;
+ -webkit-border-top-right-radius: 5px !important;
+ border-top-right-radius: 5px !important;
+ -moz-border-radius-bottomleft: 0;
+ -webkit-border-bottom-left-radius: 0;
+ border-bottom-left-radius: 0;
+ -moz-border-radius-bottomright: 5px !important;
+ -webkit-border-bottom-right-radius: 5px !important;
+ border-bottom-right-radius: 5px !important;
+}
+
+/* RTL Superfish ~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.rtl .sf-menu a {
+ border-left: none;
+ border-right:1px solid #fff;
+}
+
+.rtl .sf-menu a.sf-with-ul {
+ padding-left: 2.25em;
+ padding-right: 1em;
+}
+
+.rtl .sf-sub-indicator {
+ left: .75em !important;
+ right: auto;
+ background: url('superfish/images/arrows-ffffff-rtl.png') no-repeat -10px -100px; /* 8-bit indexed alpha png. IE6 gets solid image only */
+}
+.rtl a > .sf-sub-indicator { /* give all except IE6 the correct values */
+ top: .8em;
+ background-position: -10px -100px; /* use translucent arrow for modern browsers*/
+}
+/* apply hovers to modern browsers */
+.rtl a:focus > .sf-sub-indicator,
+.rtl a:hover > .sf-sub-indicator,
+.rtl a:active > .sf-sub-indicator,
+.rtl li:hover > a > .sf-sub-indicator,
+.rtl li.sfHover > a > .sf-sub-indicator {
+ background-position: 0 -100px; /* arrow hovers for modern browsers*/
+}
+
+/* point right for anchors in subs */
+.rtl .sf-menu ul .sf-sub-indicator { background-position: 0 0; }
+.rtl .sf-menu ul a > .sf-sub-indicator { background-position: -10px 0; }
+/* apply hovers to modern browsers */
+.rtl .sf-menu ul a:focus > .sf-sub-indicator,
+.rtl .sf-menu ul a:hover > .sf-sub-indicator,
+.rtl .sf-menu ul a:active > .sf-sub-indicator,
+.rtl .sf-menu ul li:hover > a > .sf-sub-indicator,
+.rtl .sf-menu ul li.sfHover > a > .sf-sub-indicator {
+ background-position: 0 0; /* arrow hovers for modern browsers*/
+}
+
+.rtl .sf-menu li:hover ul,
+.rtl .sf-menu li.sfHover ul {
+ right: 0;
+ left: auto;
+}
+
+.rtl ul.sf-menu li li:hover ul,
+.rtl ul.sf-menu li li.sfHover ul {
+ right: 12em; /* match ul width */
+ left: auto;
+}
+.rtl ul.sf-menu li li li:hover ul,
+.rtl ul.sf-menu li li li.sfHover ul {
+ right: 12em; /* match ul width */
+ left: auto;
+}
+
+/*** shadows for all but IE6 ***/
+.rtl .sf-shadow ul {
+ background: url('superfish/images/shadow.png') no-repeat bottom left;
+ padding: 0 0 9px 8px;
+ border-top-right-radius: 0;
+ border-bottom-left-radius: 0;
+ -moz-border-radius-topright: 0;
+ -moz-border-radius-bottomleft: 0;
+ -webkit-border-top-right-radius: 0;
+ -webkit-border-bottom-left-radius: 0;
+ -moz-border-radius-topleft: 17px;
+ -moz-border-radius-bottomright: 17px;
+ -webkit-border-top-left-radius: 17px;
+ -webkit-border-bottom-right-radius: 17px;
+ border-top-left-radius: 17px;
+ border-bottom-right-radius: 17px;
+}
+
+/* RTL ThemeRoller ~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+.rtl .ui-dialog .ui-dialog-titlebar {
+ padding: 0.5em 1em 0.3em 0.3em;
+}
+
+.rtl .ui-dialog .ui-dialog-title {
+ float: right;
+}
+
+.rtl .ui-dialog .ui-dialog-titlebar-close {
+ left: 0.3em;
+ right: auto;
+}
.rtl #g-content #g-album-grid .g-item,
.rtl #g-site-theme,
diff --git a/themes/admin_wind/views/admin.html.php b/themes/admin_wind/views/admin.html.php
index c4b51f41..c8041069 100644
--- a/themes/admin_wind/views/admin.html.php
+++ b/themes/admin_wind/views/admin.html.php
@@ -16,7 +16,6 @@
= $theme->css("yui/reset-fonts-grids.css") ?>
= $theme->css("themeroller/ui.base.css") ?>
= $theme->css("superfish/css/superfish.css") ?>
- = $theme->css("gallery.common.css") ?>
= $theme->css("screen.css") ?>
--
cgit v1.2.3
From 7ec0cc748ac4c2a3b3d11abfbfd0ba50eb63f182 Mon Sep 17 00:00:00 2001
From: Tim Almdal
Date: Sat, 23 Apr 2011 13:55:23 -0700
Subject: Fix for ticket #1699. Make the link to return to the gallery
installation clearer.
---
modules/gallery/views/upgrader.html.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/gallery/views/upgrader.html.php b/modules/gallery/views/upgrader.html.php
index ad2e3421..70d37dd1 100644
--- a/modules/gallery/views/upgrader.html.php
+++ b/modules/gallery/views/upgrader.html.php
@@ -27,7 +27,7 @@
= t("That's it!") ?>
- = t("Your Gallery is up to date.",
+ = t("Your Gallery is up to date.
Return to your Gallery",
array("url" => html::mark_clean(url::base()))) ?>
--
cgit v1.2.3
From 4f27df48da62383ce7ea0a70d5866d2279c49b74 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 13:56:57 -0700
Subject: Automated update of .build_number to 118 for branch master Last
update: f5a9abc26a14dda6c2dce4aaf5ab139d2663808b (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 6e0af3b9..2bf8d285 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=117
+build_number=118
--
cgit v1.2.3
From a469146084e7ba064f171609849c4d8590424f88 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 14:43:33 -0700
Subject: module.info and theme.info files now support author name, author url,
info url and discussion url fields. Those fields show up in the Admin >
Modules and Admin > Appearance > Theme Choice pages. All official modules
and themes updated to contain these values. Fixes #1696, #1698.
---
modules/gallery/module.info | 4 ++
modules/gallery/views/admin_modules.html.php | 52 +++++++++++++++++++++-
modules/gallery/views/admin_themes.html.php | 12 +++--
.../gallery/views/admin_themes_buttonset.html.php | 47 +++++++++++++++++++
4 files changed, 110 insertions(+), 5 deletions(-)
create mode 100644 modules/gallery/views/admin_themes_buttonset.html.php
diff --git a/modules/gallery/module.info b/modules/gallery/module.info
index 74c0658f..fc522d78 100644
--- a/modules/gallery/module.info
+++ b/modules/gallery/module.info
@@ -1,3 +1,7 @@
name = "Gallery 3"
description = "Gallery core application"
version = 49
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:gallery"
+discuss_url = "http://gallery.menalto.com/forum_module_gallery"
diff --git a/modules/gallery/views/admin_modules.html.php b/modules/gallery/views/admin_modules.html.php
index 2cc81b0d..ecd51d30 100644
--- a/modules/gallery/views/admin_modules.html.php
+++ b/modules/gallery/views/admin_modules.html.php
@@ -43,7 +43,7 @@
= t("Gallery Modules") ?>
- = t("Power up your Gallery by adding more modules! Each module provides new cool features.") ?>
+ = t("Power up your Gallery by adding more modules! Each module provides new cool features.", array("url" => "http://codex.gallery2.org/Category:Gallery_3:Modules")) ?>
@@ -55,6 +55,7 @@
= t("Name") ?> |
= t("Version") ?> |
= t("Description") ?> |
+
= t("Details") ?> |
foreach ($available as $module_name => $module_info): ?>
">
@@ -64,6 +65,55 @@
= t($module_info->name) ?> |
= $module_info->version ?> |
= t($module_info->description) ?> |
+
+
+ |
endforeach ?>
diff --git a/modules/gallery/views/admin_themes.html.php b/modules/gallery/views/admin_themes.html.php
index d14e8bd4..7d947b28 100644
--- a/modules/gallery/views/admin_themes.html.php
+++ b/modules/gallery/views/admin_themes.html.php
@@ -10,7 +10,7 @@
= t("Theme choice") ?>
- = t("Gallery allows you to choose a theme for browsing your Gallery, as well as a special theme for the administration interface. Click a theme to preview and activate it.") ?>
+ = t("Make your Gallery beautiful with a new theme! There are separate themes for the regular site and for the administration interface. Click a theme below to preview and activate it.", array("url" => "http://codex.gallery2.org/Category:Gallery_3:Themes")) ?>
@@ -23,6 +23,7 @@
= $themes[$site]->description ?>
+ $v = new View("admin_themes_buttonset.html"); $v->info = $themes[$site]; print $v; ?>
= t("Available Gallery themes") ?>
@@ -40,13 +41,14 @@
= $info->description ?>
+ $v = new View("admin_themes_buttonset.html"); $v->info = $info; print $v; ?>
$count++ ?>
endforeach ?>
if (!$count): ?>
- = t("There are no other site themes available.") ?>
+ = t("There are no other site themes available. Download one now!", array("url" => "http://codex.gallery2.org/Category:Gallery_3:Modules")) ?>
endif ?>
@@ -61,6 +63,7 @@
= $themes[$admin]->description ?>
+ $v = new View("admin_themes_buttonset.html"); $v->info = $themes[$admin]; print $v; ?>
= t("Available admin themes") ?>
@@ -78,17 +81,18 @@
= $info->description ?>
+ $v = new View("admin_themes_buttonset.html"); $v->info = $info; print $v; ?>
$count++ ?>
endforeach ?>
if (!$count): ?>
- = t("There are no other admin themes available.") ?>
+ = t("There are no other admin themes available. Download one now!", array("url" => "http://codex.gallery2.org/Category:Gallery_3:Modules")) ?>
endif ?>
-
\ No newline at end of file
+
diff --git a/modules/gallery/views/admin_themes_buttonset.html.php b/modules/gallery/views/admin_themes_buttonset.html.php
new file mode 100644
index 00000000..5166f36c
--- /dev/null
+++ b/modules/gallery/views/admin_themes_buttonset.html.php
@@ -0,0 +1,47 @@
+
--
cgit v1.2.3
From 7cbcab601f6e30096ae8c3ecf198401eef824327 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 14:45:32 -0700
Subject: Automated update of .build_number to 119 for branch master Last
update: c1779a9e8f1a2c3cbda576815a37fd9b67b3c82c (6 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 2bf8d285..952b87ab 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=118
+build_number=119
--
cgit v1.2.3
From ba20d5a500fbc724376a2fc749ee2c645041a6e1 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 14:46:07 -0700
Subject: Oops, this is the rest of the modules and themes for #1696 and #1698.
---
modules/akismet/module.info | 4 ++++
modules/comment/module.info | 4 ++++
modules/digibug/module.info | 4 ++++
modules/exif/module.info | 4 ++++
modules/g2_import/module.info | 4 ++++
modules/image_block/module.info | 4 ++++
modules/info/module.info | 4 ++++
modules/notification/module.info | 4 ++++
modules/organize/module.info | 4 ++++
modules/recaptcha/module.info | 4 ++++
modules/rest/module.info | 4 ++++
modules/rss/module.info | 4 ++++
modules/search/module.info | 4 ++++
modules/server_add/module.info | 4 ++++
modules/slideshow/module.info | 4 ++++
modules/tag/module.info | 4 ++++
modules/user/module.info | 4 ++++
modules/watermark/module.info | 4 ++++
themes/admin_wind/theme.info | 4 ++++
themes/wind/theme.info | 4 ++++
20 files changed, 80 insertions(+)
diff --git a/modules/akismet/module.info b/modules/akismet/module.info
index b61ed107..afc649d3 100644
--- a/modules/akismet/module.info
+++ b/modules/akismet/module.info
@@ -1,3 +1,7 @@
name = "Akismet"
description = "Filter comments through the Akismet web service to detect and eliminate spam (http://akismet.com). You'll need a WordPress.com API key to use it."
version = 1
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:akismet"
+discuss_url = "http://gallery.menalto.com/forum_module_akismet"
diff --git a/modules/comment/module.info b/modules/comment/module.info
index e5aa454d..63c6af1c 100644
--- a/modules/comment/module.info
+++ b/modules/comment/module.info
@@ -1,3 +1,7 @@
name = "Comments"
description = "Allows users and guests to leave comments on photos and albums."
version = 4
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:comment"
+discuss_url = "http://gallery.menalto.com/forum_module_comment"
diff --git a/modules/digibug/module.info b/modules/digibug/module.info
index be4e880a..ce437611 100644
--- a/modules/digibug/module.info
+++ b/modules/digibug/module.info
@@ -1,3 +1,7 @@
name = "Digibug"
description = "Digibug Photo Printing Module"
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:digibug"
+discuss_url = "http://gallery.menalto.com/forum_module_digibug"
diff --git a/modules/exif/module.info b/modules/exif/module.info
index c8ae688e..c2ffbfa7 100644
--- a/modules/exif/module.info
+++ b/modules/exif/module.info
@@ -1,3 +1,7 @@
name = "Exif Data"
description = "Extract Exif data and display it on photo pages."
version = 1
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:exif"
+discuss_url = "http://gallery.menalto.com/forum_module_exif"
diff --git a/modules/g2_import/module.info b/modules/g2_import/module.info
index 977af251..0e766255 100644
--- a/modules/g2_import/module.info
+++ b/modules/g2_import/module.info
@@ -1,3 +1,7 @@
name = "Gallery2 Import"
description = "Import your Gallery 2 content into Gallery 3"
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:g2_import"
+discuss_url = "http://gallery.menalto.com/forum_module_g2_import"
diff --git a/modules/image_block/module.info b/modules/image_block/module.info
index 6836fabc..aa3c5461 100644
--- a/modules/image_block/module.info
+++ b/modules/image_block/module.info
@@ -1,3 +1,7 @@
name = "Image Block"
description = "Display a random image in the sidebar"
version = 3
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:image_block"
+discuss_url = "http://gallery.menalto.com/forum_module_image_block"
diff --git a/modules/info/module.info b/modules/info/module.info
index 5f84cbb9..e8f30594 100644
--- a/modules/info/module.info
+++ b/modules/info/module.info
@@ -1,3 +1,7 @@
name = "Info"
description = "Display extra information about photos and albums"
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:info"
+discuss_url = "http://gallery.menalto.com/forum_module_info"
diff --git a/modules/notification/module.info b/modules/notification/module.info
index 8c5e1162..dacc00f9 100644
--- a/modules/notification/module.info
+++ b/modules/notification/module.info
@@ -1,3 +1,7 @@
name = "Notification"
description = "Send notifications to users when changes are made to watched albums."
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:notification"
+discuss_url = "http://gallery.menalto.com/forum_module_notification"
diff --git a/modules/organize/module.info b/modules/organize/module.info
index 0d16144d..31d24379 100644
--- a/modules/organize/module.info
+++ b/modules/organize/module.info
@@ -1,3 +1,7 @@
name = "Organize"
description = "Visually rearrange and move photos in your gallery"
version = 4
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:organize"
+discuss_url = "http://gallery.menalto.com/forum_module_organize"
diff --git a/modules/recaptcha/module.info b/modules/recaptcha/module.info
index cfa1bf7a..2a0b419b 100644
--- a/modules/recaptcha/module.info
+++ b/modules/recaptcha/module.info
@@ -1,3 +1,7 @@
name = "reCAPTCHA"
description = "reCAPTCHA displays a graphical verification that protects the input form from abuse from 'bots,' or automated programs usually written to generate spam (http://recaptcha.net)."
version = 1
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:recaptcha"
+discuss_url = "http://gallery.menalto.com/forum_module_recaptcha"
diff --git a/modules/rest/module.info b/modules/rest/module.info
index 5aaffc28..c71c64f9 100644
--- a/modules/rest/module.info
+++ b/modules/rest/module.info
@@ -2,3 +2,7 @@ name = "REST API Module"
description = "A REST-based API that allows desktop clients and other apps to interact with Gallery 3"
version = 3
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:rest"
+discuss_url = "http://gallery.menalto.com/forum_module_rest"
diff --git a/modules/rss/module.info b/modules/rss/module.info
index 48375da1..5ebae9e7 100644
--- a/modules/rss/module.info
+++ b/modules/rss/module.info
@@ -1,3 +1,7 @@
name = "RSS"
description = "Provides RSS feeds"
version = 1
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:rss"
+discuss_url = "http://gallery.menalto.com/forum_module_rss"
diff --git a/modules/search/module.info b/modules/search/module.info
index f417c4fa..a1c58af5 100644
--- a/modules/search/module.info
+++ b/modules/search/module.info
@@ -1,3 +1,7 @@
name = "Search"
description = "Allows users to search their Gallery"
version = 1
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:search"
+discuss_url = "http://gallery.menalto.com/forum_module_search"
diff --git a/modules/server_add/module.info b/modules/server_add/module.info
index 87b317b1..754e06c1 100644
--- a/modules/server_add/module.info
+++ b/modules/server_add/module.info
@@ -1,3 +1,7 @@
name = "Server Add"
description = "Allows authorized users to load images directly from your web server"
version = 4
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:server_add"
+discuss_url = "http://gallery.menalto.com/forum_module_server_add"
diff --git a/modules/slideshow/module.info b/modules/slideshow/module.info
index b56eac81..55cdf9b8 100644
--- a/modules/slideshow/module.info
+++ b/modules/slideshow/module.info
@@ -1,3 +1,7 @@
name = "Slideshow"
description = "Allows users to view a slideshow of photos"
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:slideshow"
+discuss_url = "http://gallery.menalto.com/forum_module_slideshow"
diff --git a/modules/tag/module.info b/modules/tag/module.info
index d9d34386..59d8dfbd 100644
--- a/modules/tag/module.info
+++ b/modules/tag/module.info
@@ -1,3 +1,7 @@
name = "Tags"
description = "Allows users to tag photos and albums"
version = 3
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:tag"
+discuss_url = "http://gallery.menalto.com/forum_module_tag"
diff --git a/modules/user/module.info b/modules/user/module.info
index b7594815..f6dd9529 100644
--- a/modules/user/module.info
+++ b/modules/user/module.info
@@ -2,3 +2,7 @@ name = "Users and Groups"
description = "Gallery 3 user and group management"
version = 4
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:user"
+discuss_url = "http://gallery.menalto.com/forum_module_user"
diff --git a/modules/watermark/module.info b/modules/watermark/module.info
index 41a871bd..1f440016 100644
--- a/modules/watermark/module.info
+++ b/modules/watermark/module.info
@@ -1,3 +1,7 @@
name = "Watermarks"
description = "Allows users to watermark their photos"
version = 2
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Module:watermark"
+discuss_url = "http://gallery.menalto.com/forum_module_watermark"
diff --git a/themes/admin_wind/theme.info b/themes/admin_wind/theme.info
index 4034b64a..aca5c6c5 100644
--- a/themes/admin_wind/theme.info
+++ b/themes/admin_wind/theme.info
@@ -4,3 +4,7 @@ version = 1
author = "Gallery Team"
admin = 1
site = 0
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Theme:admin_wind"
+discuss_url = "http://gallery.menalto.com/forum_theme_admin_wind"
diff --git a/themes/wind/theme.info b/themes/wind/theme.info
index 17ea7c20..c2344c48 100644
--- a/themes/wind/theme.info
+++ b/themes/wind/theme.info
@@ -4,3 +4,7 @@ version = 1
author = "Gallery Team"
site = 1
admin = 0
+author_name = "Gallery Team"
+author_url = "http://codex.gallery2.org/Gallery:Team"
+info_url = "http://codex.gallery2.org/Gallery3:Theme:wind"
+discuss_url = "http://gallery.menalto.com/forum_theme_wind"
--
cgit v1.2.3
From ed21bbcb742b0a1fb763a048e15f025c2c4b715c Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 14:46:42 -0700
Subject: Automated update of .build_number to 120 for branch master Last
update: c1779a9e8f1a2c3cbda576815a37fd9b67b3c82c (8 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 952b87ab..3af1d9a0 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=119
+build_number=120
--
cgit v1.2.3
From c07af35a19905f3241fb77662e8b7c84e41e9a62 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 14:53:34 -0700
Subject: Oops, fix broken codex urls. For #1698.
---
modules/akismet/module.info | 2 +-
modules/comment/module.info | 2 +-
modules/digibug/module.info | 2 +-
modules/exif/module.info | 2 +-
modules/g2_import/module.info | 2 +-
modules/gallery/module.info | 2 +-
modules/image_block/module.info | 2 +-
modules/info/module.info | 2 +-
modules/notification/module.info | 2 +-
modules/organize/module.info | 2 +-
modules/recaptcha/module.info | 2 +-
modules/rest/module.info | 2 +-
modules/rss/module.info | 2 +-
modules/search/module.info | 2 +-
modules/server_add/module.info | 2 +-
modules/slideshow/module.info | 2 +-
modules/tag/module.info | 2 +-
modules/user/module.info | 2 +-
modules/watermark/module.info | 2 +-
themes/admin_wind/theme.info | 2 +-
themes/wind/theme.info | 2 +-
21 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/modules/akismet/module.info b/modules/akismet/module.info
index afc649d3..63473468 100644
--- a/modules/akismet/module.info
+++ b/modules/akismet/module.info
@@ -3,5 +3,5 @@ description = "Filter comments through the Akismet web service to detect and eli
version = 1
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:akismet"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:akismet"
discuss_url = "http://gallery.menalto.com/forum_module_akismet"
diff --git a/modules/comment/module.info b/modules/comment/module.info
index 63c6af1c..4e7df6f1 100644
--- a/modules/comment/module.info
+++ b/modules/comment/module.info
@@ -3,5 +3,5 @@ description = "Allows users and guests to leave comments on photos and albums."
version = 4
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:comment"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:comment"
discuss_url = "http://gallery.menalto.com/forum_module_comment"
diff --git a/modules/digibug/module.info b/modules/digibug/module.info
index ce437611..781d5f01 100644
--- a/modules/digibug/module.info
+++ b/modules/digibug/module.info
@@ -3,5 +3,5 @@ description = "Digibug Photo Printing Module"
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:digibug"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:digibug"
discuss_url = "http://gallery.menalto.com/forum_module_digibug"
diff --git a/modules/exif/module.info b/modules/exif/module.info
index c2ffbfa7..e266e20e 100644
--- a/modules/exif/module.info
+++ b/modules/exif/module.info
@@ -3,5 +3,5 @@ description = "Extract Exif data and display it on photo pages."
version = 1
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:exif"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:exif"
discuss_url = "http://gallery.menalto.com/forum_module_exif"
diff --git a/modules/g2_import/module.info b/modules/g2_import/module.info
index 0e766255..30fb46d4 100644
--- a/modules/g2_import/module.info
+++ b/modules/g2_import/module.info
@@ -3,5 +3,5 @@ description = "Import your Gallery 2 content into Gallery 3"
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:g2_import"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:g2_import"
discuss_url = "http://gallery.menalto.com/forum_module_g2_import"
diff --git a/modules/gallery/module.info b/modules/gallery/module.info
index fc522d78..42345531 100644
--- a/modules/gallery/module.info
+++ b/modules/gallery/module.info
@@ -3,5 +3,5 @@ description = "Gallery core application"
version = 49
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:gallery"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:gallery"
discuss_url = "http://gallery.menalto.com/forum_module_gallery"
diff --git a/modules/image_block/module.info b/modules/image_block/module.info
index aa3c5461..6722cc8f 100644
--- a/modules/image_block/module.info
+++ b/modules/image_block/module.info
@@ -3,5 +3,5 @@ description = "Display a random image in the sidebar"
version = 3
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:image_block"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:image_block"
discuss_url = "http://gallery.menalto.com/forum_module_image_block"
diff --git a/modules/info/module.info b/modules/info/module.info
index e8f30594..f8964a78 100644
--- a/modules/info/module.info
+++ b/modules/info/module.info
@@ -3,5 +3,5 @@ description = "Display extra information about photos and albums"
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:info"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:info"
discuss_url = "http://gallery.menalto.com/forum_module_info"
diff --git a/modules/notification/module.info b/modules/notification/module.info
index dacc00f9..84be8f99 100644
--- a/modules/notification/module.info
+++ b/modules/notification/module.info
@@ -3,5 +3,5 @@ description = "Send notifications to users when changes are made to watched albu
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:notification"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:notification"
discuss_url = "http://gallery.menalto.com/forum_module_notification"
diff --git a/modules/organize/module.info b/modules/organize/module.info
index 31d24379..07b9dc38 100644
--- a/modules/organize/module.info
+++ b/modules/organize/module.info
@@ -3,5 +3,5 @@ description = "Visually rearrange and move photos in your gallery"
version = 4
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:organize"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:organize"
discuss_url = "http://gallery.menalto.com/forum_module_organize"
diff --git a/modules/recaptcha/module.info b/modules/recaptcha/module.info
index 2a0b419b..ebaff7de 100644
--- a/modules/recaptcha/module.info
+++ b/modules/recaptcha/module.info
@@ -3,5 +3,5 @@ description = "reCAPTCHA displays a graphical verification that protects the inp
version = 1
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:recaptcha"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:recaptcha"
discuss_url = "http://gallery.menalto.com/forum_module_recaptcha"
diff --git a/modules/rest/module.info b/modules/rest/module.info
index c71c64f9..33c9f1cf 100644
--- a/modules/rest/module.info
+++ b/modules/rest/module.info
@@ -4,5 +4,5 @@ description = "A REST-based API that allows desktop clients and other apps to in
version = 3
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:rest"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:rest"
discuss_url = "http://gallery.menalto.com/forum_module_rest"
diff --git a/modules/rss/module.info b/modules/rss/module.info
index 5ebae9e7..cd13c1b0 100644
--- a/modules/rss/module.info
+++ b/modules/rss/module.info
@@ -3,5 +3,5 @@ description = "Provides RSS feeds"
version = 1
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:rss"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:rss"
discuss_url = "http://gallery.menalto.com/forum_module_rss"
diff --git a/modules/search/module.info b/modules/search/module.info
index a1c58af5..1389798d 100644
--- a/modules/search/module.info
+++ b/modules/search/module.info
@@ -3,5 +3,5 @@ description = "Allows users to search their Gallery"
version = 1
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:search"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:search"
discuss_url = "http://gallery.menalto.com/forum_module_search"
diff --git a/modules/server_add/module.info b/modules/server_add/module.info
index 754e06c1..4ce0a97d 100644
--- a/modules/server_add/module.info
+++ b/modules/server_add/module.info
@@ -3,5 +3,5 @@ description = "Allows authorized users to load images directly from your web ser
version = 4
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:server_add"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:server_add"
discuss_url = "http://gallery.menalto.com/forum_module_server_add"
diff --git a/modules/slideshow/module.info b/modules/slideshow/module.info
index 55cdf9b8..8c9a3176 100644
--- a/modules/slideshow/module.info
+++ b/modules/slideshow/module.info
@@ -3,5 +3,5 @@ description = "Allows users to view a slideshow of photos"
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:slideshow"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:slideshow"
discuss_url = "http://gallery.menalto.com/forum_module_slideshow"
diff --git a/modules/tag/module.info b/modules/tag/module.info
index 59d8dfbd..75d16bf0 100644
--- a/modules/tag/module.info
+++ b/modules/tag/module.info
@@ -3,5 +3,5 @@ description = "Allows users to tag photos and albums"
version = 3
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:tag"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:tag"
discuss_url = "http://gallery.menalto.com/forum_module_tag"
diff --git a/modules/user/module.info b/modules/user/module.info
index f6dd9529..503bcd0d 100644
--- a/modules/user/module.info
+++ b/modules/user/module.info
@@ -4,5 +4,5 @@ version = 4
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:user"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:user"
discuss_url = "http://gallery.menalto.com/forum_module_user"
diff --git a/modules/watermark/module.info b/modules/watermark/module.info
index 1f440016..58efa43f 100644
--- a/modules/watermark/module.info
+++ b/modules/watermark/module.info
@@ -3,5 +3,5 @@ description = "Allows users to watermark their photos"
version = 2
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Module:watermark"
+info_url = "http://codex.gallery2.org/Gallery3:Modules:watermark"
discuss_url = "http://gallery.menalto.com/forum_module_watermark"
diff --git a/themes/admin_wind/theme.info b/themes/admin_wind/theme.info
index aca5c6c5..466d8e43 100644
--- a/themes/admin_wind/theme.info
+++ b/themes/admin_wind/theme.info
@@ -6,5 +6,5 @@ admin = 1
site = 0
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Theme:admin_wind"
+info_url = "http://codex.gallery2.org/Gallery3:Themes:admin_wind"
discuss_url = "http://gallery.menalto.com/forum_theme_admin_wind"
diff --git a/themes/wind/theme.info b/themes/wind/theme.info
index c2344c48..e0be78b9 100644
--- a/themes/wind/theme.info
+++ b/themes/wind/theme.info
@@ -6,5 +6,5 @@ site = 1
admin = 0
author_name = "Gallery Team"
author_url = "http://codex.gallery2.org/Gallery:Team"
-info_url = "http://codex.gallery2.org/Gallery3:Theme:wind"
+info_url = "http://codex.gallery2.org/Gallery3:Themes:wind"
discuss_url = "http://gallery.menalto.com/forum_theme_wind"
--
cgit v1.2.3
From aa0d98e515983799c370fabf749d6c502a7bac8c Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 15:01:51 -0700
Subject: Automated update of .build_number to 121 for branch master Last
update: c1779a9e8f1a2c3cbda576815a37fd9b67b3c82c (10 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 3af1d9a0..779b30c6 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=120
+build_number=121
--
cgit v1.2.3
From 92c23ea92d7c943d330c12a1c84fdcbdf2678202 Mon Sep 17 00:00:00 2001
From: Tim Almdal
Date: Sat, 23 Apr 2011 15:10:04 -0700
Subject: Set the width of the information column to 60px to prevent icon wrap
---
modules/gallery/views/admin_modules.html.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/gallery/views/admin_modules.html.php b/modules/gallery/views/admin_modules.html.php
index ecd51d30..03993bb2 100644
--- a/modules/gallery/views/admin_modules.html.php
+++ b/modules/gallery/views/admin_modules.html.php
@@ -55,7 +55,7 @@
= t("Name") ?> |
= t("Version") ?> |
= t("Description") ?> |
- = t("Details") ?> |
+ = t("Details") ?> |
foreach ($available as $module_name => $module_info): ?>
">
--
cgit v1.2.3
From f45835e6e1204ac9b05d4c9eb7c59521230c59d4 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 15:10:17 -0700
Subject: Automated update of .build_number to 122 for branch master Last
update: aa0d98e515983799c370fabf749d6c502a7bac8c (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 779b30c6..c9c79ae1 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=121
+build_number=122
--
cgit v1.2.3
From dfd50a6c1f2afc4b4e971ab6899aa69f43397e1c Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 15:18:23 -0700
Subject: Partially revert the CSS change in
76a7ad3161be0994d7ba98e9dff9b317b2430bb3 to center the "Select..." button
because it was causing the SWF object to vanish in Firefox. #1638.
---
modules/gallery/css/gallery.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/gallery/css/gallery.css b/modules/gallery/css/gallery.css
index 97d09454..ecf89565 100644
--- a/modules/gallery/css/gallery.css
+++ b/modules/gallery/css/gallery.css
@@ -29,12 +29,12 @@
#g-add-photos-canvas object,
#g-add-photos-button {
- left: 93px;
+ left: 90px;
margin: .5em 0;
padding: .4em 1em;
position: absolute;
top: 0;
- width: auto;
+ width: 300px;
}
#g-add-photos-canvas object {
--
cgit v1.2.3
From d3992b9983015ca584709478e06f2579283fdc8c Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 15:19:16 -0700
Subject: Automated update of .build_number to 123 for branch master Last
update: c1779a9e8f1a2c3cbda576815a37fd9b67b3c82c (12 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index c9c79ae1..4106864e 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=122
+build_number=123
--
cgit v1.2.3
From 6702104f571413e4d57db3515b2070c48d3e9b55 Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sat, 23 Apr 2011 16:35:00 -0600
Subject: Resolve an infinite recursion that happens when the path caches are
updated during saving.
---
modules/gallery/models/item.php | 1 +
1 file changed, 1 insertion(+)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index aaca832a..a8bca15c 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -432,6 +432,7 @@ class Item_Model_Core extends ORM_MPTT {
if ($original->parent_id != $this->parent_id || $original->name != $this->name) {
// Move all of the items associated data files
+ $this->_build_relative_caches();
@rename($original->file_path(), $this->file_path());
if ($this->is_album()) {
@rename(dirname($original->resize_path()), dirname($this->resize_path()));
--
cgit v1.2.3
From d835c06b5e2c4b718a9269ee22c6079cc0769365 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 15:36:39 -0700
Subject: Automated update of .build_number to 124 for branch master Last
update: d3992b9983015ca584709478e06f2579283fdc8c (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 4106864e..6c34c0c2 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=123
+build_number=124
--
cgit v1.2.3
From e149cf7238a1f8eaddfc68580f2d636dd8255795 Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sat, 23 Apr 2011 16:39:25 -0600
Subject: Support data files that change their extension and MIME type.
---
modules/gallery/models/item.php | 35 ++++++++++++-----------------------
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index a8bca15c..299d3584 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -410,6 +410,15 @@ class Item_Model_Core extends ORM_MPTT {
// If any significant fields have changed, load up a copy of the original item and
// keep it around.
$original = ORM::factory("item", $this->id);
+
+ // Preserve the extension of the data file.
+ if (isset($this->data_file)) {
+ $extension = pathinfo($this->data_file, PATHINFO_EXTENSION);
+ if (!empty($extension)) {
+ $this->name = pathinfo($this->name, PATHINFO_FILENAME) . ".$extension";
+ }
+ }
+
if (array_intersect($this->changed, array("parent_id", "name", "slug"))) {
$original->_build_relative_caches();
$this->relative_path_cache = null;
@@ -463,8 +472,6 @@ class Item_Model_Core extends ORM_MPTT {
}
// Replace the data file, if requested.
- // @todo: we don't handle the case where you swap in a file of a different mime type
- // should we prevent that in validation? or in set_data_file()
if ($this->data_file && ($this->is_photo() || $this->is_movie())) {
copy($this->data_file, $this->file_path());
@@ -520,6 +527,8 @@ class Item_Model_Core extends ORM_MPTT {
$this->name = "$base_name-$rand";
}
$this->slug = "$base_slug-$rand";
+ $this->relative_path_cache = null;
+ $this->relative_url_cache = null;
}
}
@@ -771,16 +780,7 @@ class Item_Model_Core extends ORM_MPTT {
}
if ($this->is_movie() || $this->is_photo()) {
- if ($this->loaded()) {
- // Existing items can't change their extension
- $original = ORM::factory("item", $this->id);
- $new_ext = pathinfo($this->name, PATHINFO_EXTENSION);
- $old_ext = pathinfo($original->name, PATHINFO_EXTENSION);
- if (strcasecmp($new_ext, $old_ext)) {
- $v->add_error("name", "illegal_data_file_extension");
- return;
- }
- } else {
+ if (!$this->loaded()) {
// New items must have an extension
$ext = pathinfo($this->name, PATHINFO_EXTENSION);
if (!$ext) {
@@ -817,17 +817,6 @@ class Item_Model_Core extends ORM_MPTT {
} else if (filesize($this->data_file) == 0) {
$v->add_error("name", "empty_data_file");
}
-
- if ($this->loaded()) {
- if ($this->is_photo()) {
- list ($a, $b, $mime_type) = photo::get_file_metadata($this->data_file);
- } else if ($this->is_movie()) {
- list ($a, $b, $mime_type) = movie::get_file_metadata($this->data_file);
- }
- if ($mime_type != $this->mime_type) {
- $v->add_error("name", "cant_change_mime_type");
- }
- }
}
/**
--
cgit v1.2.3
From 67d2e8081c6e5f0b679881bca3fdc81fe1e78ccc Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 16:12:10 -0700
Subject: Undo the change made in 5ce85636329b14673718836b3631a3e46efdc3bb
because it messes up tag counts (and makes the test fail-- I should have run
that!).
Also, use Tag_Model::items() in save() to avoid code duplication. Follow-on for #1628.
---
modules/tag/models/tag.php | 29 ++++++++++++-----------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/modules/tag/models/tag.php b/modules/tag/models/tag.php
index d4e385a2..13e253ba 100644
--- a/modules/tag/models/tag.php
+++ b/modules/tag/models/tag.php
@@ -69,29 +69,14 @@ class Tag_Model_Core extends ORM {
* to this tag.
*/
public function save() {
- // Figure out what items have changed in this tag for our item_related_update event below
- if (isset($this->object_relations["items"])) {
- $added = array_diff($this->changed_relations["items"], $this->object_relations["items"]);
- $removed = array_diff($this->object_relations["items"], $this->changed_relations["items"]);
- if (isset($this->changed_relations["items"])) {
- $changed = array_merge($added, $removed);
- }
- $this->count = count($this->object_relations["items"]) + count($added) - count($removed);
- }
-
// Check to see if another tag exists with the same name
$duplicate_tag = ORM::factory("tag")
->where("name", "=", $this->name)
->where("id", "!=", $this->id)
->find();
if ($duplicate_tag->loaded()) {
- // If so, tag its items with this tag so as to merge it. Do this after we figure out what's
- // changed so that we don't notify on this change to keep churn down.
- $duplicate_tag_items = ORM::factory("item")
- ->join("items_tags", "items.id", "items_tags.item_id")
- ->where("items_tags.tag_id", "=", $duplicate_tag->id)
- ->find_all();
- foreach ($duplicate_tag_items as $item) {
+ // If so, tag its items with this tag so as to merge it.
+ foreach ($duplicate_tag->items() as $item) {
$this->add($item);
}
@@ -99,6 +84,16 @@ class Tag_Model_Core extends ORM {
$duplicate_tag->delete();
}
+ // Figure out what items have changed in this tag for our item_related_update event below
+ if (isset($this->object_relations["items"])) {
+ $added = array_diff($this->changed_relations["items"], $this->object_relations["items"]);
+ $removed = array_diff($this->object_relations["items"], $this->changed_relations["items"]);
+ if (isset($this->changed_relations["items"])) {
+ $changed = array_merge($added, $removed);
+ }
+ $this->count = count($this->object_relations["items"]) + count($added) - count($removed);
+ }
+
$result = parent::save();
if (!empty($changed)) {
--
cgit v1.2.3
From 5d4d8a893bef935a47b04e72fffa113eba99dd71 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 16:12:29 -0700
Subject: Automated update of .build_number to 125 for branch master Last
update: d835c06b5e2c4b718a9269ee22c6079cc0769365 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 6c34c0c2..74464732 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=124
+build_number=125
--
cgit v1.2.3
From c3b0c96460da336bf720db0de2b396517004f514 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sat, 23 Apr 2011 19:59:54 -0700
Subject: Revert 0235c2062e9d980a4778c4b22678238c525e1cd7 and instead apply the
fix from iptox.net listed here:
http://gallery.menalto.com/node/98768#comment-372398
Fixes for #1681, #1625
---
modules/gallery/helpers/graphics.php | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/modules/gallery/helpers/graphics.php b/modules/gallery/helpers/graphics.php
index 8d8853b0..acb11bfb 100644
--- a/modules/gallery/helpers/graphics.php
+++ b/modules/gallery/helpers/graphics.php
@@ -316,10 +316,10 @@ class graphics_Core {
// ImageMagick & GraphicsMagick
$magick_kits = array(
"imagemagick" => array(
- "name" => "ImageMagick", "binary" => "convert", "version" => "convert -version",
+ "name" => "ImageMagick", "binary" => "convert", "version_arg" => "-v",
"version_regex" => "/Version: \S+ (\S+)/"),
"graphicsmagick" => array(
- "name" => "GraphicsMagick", "binary" => "gm", "version" => "gm version",
+ "name" => "GraphicsMagick", "binary" => "gm", "version_arg" => "version",
"version_regex" => "/\S+ (\S+)/"));
// Loop through the kits
foreach ($magick_kits as $index => $settings) {
@@ -328,7 +328,8 @@ class graphics_Core {
$toolkits->$index->name = $settings["name"];
if ($path) {
if (@is_file($path) &&
- preg_match($settings["version_regex"], shell_exec($settings["version"]), $matches)) {
+ preg_match(
+ $settings["version_regex"], shell_exec($path . " " . $settings["version_arg"]), $matches)) {
$version = $matches[1];
$toolkits->$index->installed = true;
--
cgit v1.2.3
From 4c7f27a1a6a4fc71873093dd787de05a8ee6c079 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 20:00:52 -0700
Subject: Automated update of .build_number to 126 for branch master Last
update: 5d4d8a893bef935a47b04e72fffa113eba99dd71 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 74464732..f5cd72a8 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=125
+build_number=126
--
cgit v1.2.3
From 0d6a3a3cfc4f38f450db9e18da47a5e2ad826af8 Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sat, 23 Apr 2011 21:19:47 -0600
Subject: Create a tempnam substitute that safely creates files with a given
extension.
---
modules/gallery/controllers/quick.php | 4 +--
modules/gallery/helpers/system.php | 25 ++++++++++++++
modules/gallery/tests/Mock_Built_In.php | 39 ++++++++++++++++++++++
modules/gallery/tests/System_Helper_Test.php | 49 ++++++++++++++++++++++++++++
4 files changed, 115 insertions(+), 2 deletions(-)
create mode 100644 modules/gallery/tests/Mock_Built_In.php
create mode 100644 modules/gallery/tests/System_Helper_Test.php
diff --git a/modules/gallery/controllers/quick.php b/modules/gallery/controllers/quick.php
index da4768fd..ce52cb8d 100644
--- a/modules/gallery/controllers/quick.php
+++ b/modules/gallery/controllers/quick.php
@@ -36,8 +36,8 @@ class Quick_Controller extends Controller {
}
if ($degrees) {
- $tmpfile = tempnam(TMPPATH, "rotate") . "." .
- pathinfo($item->file_path(), PATHINFO_EXTENSION);
+ $tmpfile = system::tempnam(TMPPATH, "rotate",
+ "." . pathinfo($item->file_path(), PATHINFO_EXTENSION));
gallery_graphics::rotate($item->file_path(), $tmpfile, array("degrees" => $degrees), $item);
$item->set_data_file($tmpfile);
$item->save();
diff --git a/modules/gallery/helpers/system.php b/modules/gallery/helpers/system.php
index c39c7227..31ecafa7 100644
--- a/modules/gallery/helpers/system.php
+++ b/modules/gallery/helpers/system.php
@@ -40,4 +40,29 @@ class system_Core {
}
return null;
}
+
+ /**
+ * Create a file with a unique file name.
+ * This helper is similar to the built-in tempnam, except that it supports an optional postfix.
+ */
+ static function tempnam($dir = TMPPATH, $prefix = "", $postfix = "") {
+ return self::_tempnam($dir, $prefix, $postfix, "tempnam");
+ }
+
+ // This helper provides a dependency-injected implementation of tempnam.
+ static function _tempnam($dir, $prefix, $postfix, $builtin) {
+ $success = false;
+ do {
+ $basename = call_user_func($builtin, $dir, $prefix);
+ if (!$basename) {
+ return false;
+ }
+ $filename = $basename . $postfix;
+ $success = !file_exists($filename) && @rename($basename, $filename);
+ if (!$success) {
+ @unlink($basename);
+ }
+ } while (!$success);
+ return $filename;
+ }
}
\ No newline at end of file
diff --git a/modules/gallery/tests/Mock_Built_In.php b/modules/gallery/tests/Mock_Built_In.php
new file mode 100644
index 00000000..b02e5ecf
--- /dev/null
+++ b/modules/gallery/tests/Mock_Built_In.php
@@ -0,0 +1,39 @@
+nonces = func_get_args();
+ }
+
+ function _tempnam($dir, $prefix) {
+ if (empty($this->nonces))
+ return false;
+ $filename = "$dir/$prefix" . array_shift($this->nonces);
+ if (!touch($filename))
+ return false;
+ return $filename;
+ }
+}
diff --git a/modules/gallery/tests/System_Helper_Test.php b/modules/gallery/tests/System_Helper_Test.php
new file mode 100644
index 00000000..734f98ac
--- /dev/null
+++ b/modules/gallery/tests/System_Helper_Test.php
@@ -0,0 +1,49 @@
+assert_true(file_exists($filename), "File not created");
+ unlink($filename);
+ }
+
+ public function tempnam_collision_test() {
+ require_once('Mock_Built_In.php');
+ $existing = TMPPATH . "/file1.ext";
+ $available = TMPPATH . "/file2.ext";
+ touch($existing);
+ $filename = system::_tempnam(TMPPATH, "file", ".ext",
+ array(new Mock_Built_In("1", "2"), "_tempnam"));
+ unlink($existing);
+ $this->assert_true(file_exists($filename), "File not created");
+ unlink($filename);
+ $this->assert_equal($available, $filename, "Incorrect filename created");
+ }
+
+ public function tempnam_abort_test() {
+ require_once('Mock_Built_In.php');
+ $filename = system::_tempnam(TMPPATH, "file", ".ext",
+ array(new Mock_Built_In(), "_tempnam"));
+ if ($filename) {
+ @unlink($filename);
+ }
+ $this->assert_false($filename, "Operation not aborted");
+ }
+}
--
cgit v1.2.3
From 342be9818f8c35dd13c8159960a9f71ae33d4c72 Mon Sep 17 00:00:00 2001
From: Chad Kieffer
Date: Sat, 23 Apr 2011 23:26:28 -0400
Subject: Turn off bullets on the tag admin list.
---
themes/admin_wind/css/screen.css | 1 +
1 file changed, 1 insertion(+)
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index 177eb1e6..f01c2a94 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -100,6 +100,7 @@ a:hover,
form ul li,
#g-action-status li,
#g-log-entries li,
+#g-tag-admin li,
.g-buttonset li,
.g-buttonset-vertical li,
.g-paginator li,
--
cgit v1.2.3
From c01a0eac9a09e0fc2ef4ba45a74c23a8a70f51b7 Mon Sep 17 00:00:00 2001
From: Tim Almdal
Date: Sat, 23 Apr 2011 20:30:30 -0700
Subject: Allow the tag rename function to split a tag into multiple tags if a
comma is used to delinate the seperate tags.
---
modules/tag/controllers/admin_tags.php | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/modules/tag/controllers/admin_tags.php b/modules/tag/controllers/admin_tags.php
index fd82bc92..5dc181bd 100644
--- a/modules/tag/controllers/admin_tags.php
+++ b/modules/tag/controllers/admin_tags.php
@@ -85,11 +85,23 @@ class Admin_Tags_Controller extends Admin_Controller {
if ($in_place_edit->validate()) {
$old_name = $tag->name;
- $tag->name = $in_place_edit->value();
+ $tag_name = $in_place_edit->value();
+ Kohana_Log::add("error", $tag_name);
+ $tags = explode(",", $tag_name);
+ $tag_count = count($tags);
+
+ $tag->name = array_shift($tags);
$tag->save();
- $message = t("Renamed tag %old_name to %new_name",
- array("old_name" => $old_name, "new_name" => $tag->name));
+ if (!empty($tags)) {
+ $this->_copy_items_for_tags($tag, $tags);
+ $message = t("Split tag %old_name into %new_tags",
+ array("old_name" => $old_name, "new_tags" => $tag_name));
+ } else {
+ $message = t("Renamed tag %old_name to %new_name",
+ array("old_name" => $old_name, "new_name" => $tag->name));
+ }
+
message::success($message);
log::success("tags", $message);
@@ -99,5 +111,11 @@ class Admin_Tags_Controller extends Admin_Controller {
}
}
+ private function _copy_items_for_tags($tag, $tags) {
+ foreach ($tag->items() as $item) {
+ foreach ($tags as $idx => $new_tag) {
+ tag::add($item, trim($new_tag));
+ }
+ }
+ }
}
-
--
cgit v1.2.3
From aba51feb3d330f30f0e3b68e16c31f6bb250ef02 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sat, 23 Apr 2011 20:30:32 -0700
Subject: Automated update of .build_number to 127 for branch master Last
update: 4c7f27a1a6a4fc71873093dd787de05a8ee6c079 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index f5cd72a8..20417d2b 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=126
+build_number=127
--
cgit v1.2.3
From c6ef706d70c7e48bea1145eec1b13fb5683e023f Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sat, 23 Apr 2011 22:55:59 -0600
Subject: Preserve old data files long enough for them to be available to event
handlers.
---
modules/gallery/models/item.php | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index 299d3584..482b6247 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -442,7 +442,9 @@ class Item_Model_Core extends ORM_MPTT {
if ($original->parent_id != $this->parent_id || $original->name != $this->name) {
// Move all of the items associated data files
$this->_build_relative_caches();
- @rename($original->file_path(), $this->file_path());
+ if (!isset($this->data_file)) {
+ @rename($original->file_path(), $this->file_path());
+ }
if ($this->is_album()) {
@rename(dirname($original->resize_path()), dirname($this->resize_path()));
@rename(dirname($original->thumb_path()), dirname($this->thumb_path()));
@@ -491,6 +493,9 @@ class Item_Model_Core extends ORM_MPTT {
// Null out the data file variable here, otherwise this event will trigger another
// save() which will think that we're doing another file move.
$this->data_file = null;
+ if ($original->file_path() != $this->file_path()) {
+ @unlink($original->file_path());
+ }
module::event("item_updated_data_file", $this);
}
}
--
cgit v1.2.3
From fcb06bf175bb9eeff36d9c294e97ace9374ef0f3 Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sun, 24 Apr 2011 00:45:12 -0600
Subject: Don't assign to the item->name field if the name is unchanged,
because the save method will crash.
---
modules/gallery/models/item.php | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index 482b6247..7a08d9c2 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -414,8 +414,9 @@ class Item_Model_Core extends ORM_MPTT {
// Preserve the extension of the data file.
if (isset($this->data_file)) {
$extension = pathinfo($this->data_file, PATHINFO_EXTENSION);
- if (!empty($extension)) {
- $this->name = pathinfo($this->name, PATHINFO_FILENAME) . ".$extension";
+ $new_name = pathinfo($this->name, PATHINFO_FILENAME) . ".$extension";
+ if (!empty($extension) && strcmp($this->name, $new_name)) {
+ $this->name = $new_name;
}
}
--
cgit v1.2.3
From 41f90e669f75e8e93bd31bf649011d5d315ac326 Mon Sep 17 00:00:00 2001
From: Tim Almdal
Date: Sun, 24 Apr 2011 07:04:11 -0700
Subject: Clarify the meaning of variable names.
---
modules/tag/controllers/admin_tags.php | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/modules/tag/controllers/admin_tags.php b/modules/tag/controllers/admin_tags.php
index 5dc181bd..7a64f7ab 100644
--- a/modules/tag/controllers/admin_tags.php
+++ b/modules/tag/controllers/admin_tags.php
@@ -85,18 +85,17 @@ class Admin_Tags_Controller extends Admin_Controller {
if ($in_place_edit->validate()) {
$old_name = $tag->name;
- $tag_name = $in_place_edit->value();
- Kohana_Log::add("error", $tag_name);
- $tags = explode(",", $tag_name);
- $tag_count = count($tags);
+ $new_name_or_list = $in_place_edit->value();
+ $tag_list = explode(",", $new_name_or_list);
+ $tag_count = count($tag_list);
- $tag->name = array_shift($tags);
+ $tag->name = array_shift($tag_list);
$tag->save();
- if (!empty($tags)) {
- $this->_copy_items_for_tags($tag, $tags);
- $message = t("Split tag %old_name into %new_tags",
- array("old_name" => $old_name, "new_tags" => $tag_name));
+ if (!empty($tag_list)) {
+ $this->_copy_items_for_tags($tag, $tag_list);
+ $message = t("Split tag %old_name into %tag_list",
+ array("old_name" => $old_name, "tag_list" => $new_name_or_list));
} else {
$message = t("Renamed tag %old_name to %new_name",
array("old_name" => $old_name, "new_name" => $tag->name));
@@ -111,10 +110,10 @@ class Admin_Tags_Controller extends Admin_Controller {
}
}
- private function _copy_items_for_tags($tag, $tags) {
+ private function _copy_items_for_tags($tag, $tag_list) {
foreach ($tag->items() as $item) {
- foreach ($tags as $idx => $new_tag) {
- tag::add($item, trim($new_tag));
+ foreach ($tag_list as $new_tag_name) {
+ tag::add($item, trim($new_tag_name));
}
}
}
--
cgit v1.2.3
From b57dd202db3c4b007e83aff3df9da7920691d76d Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 07:06:14 -0700
Subject: Automated update of .build_number to 128 for branch master Last
update: aba51feb3d330f30f0e3b68e16c31f6bb250ef02 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 20417d2b..68a5d742 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=127
+build_number=128
--
cgit v1.2.3
From 809567f12850f59bdeb47a2963f6968b99b5a201 Mon Sep 17 00:00:00 2001
From: Chad Parry
Date: Sun, 24 Apr 2011 08:10:04 -0600
Subject: Expose the data file field.
---
modules/gallery/models/item.php | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index 7a08d9c2..f4d4c521 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -127,6 +127,15 @@ class Item_Model_Core extends ORM_MPTT {
return $this;
}
+ /**
+ * Get the path to the data file associated with this item.
+ * This data file field is only set until you call save().
+ * After that, you can get the path using get_file_path().
+ */
+ public function get_data_file() {
+ return $this->data_file;
+ }
+
/**
* Return the server-relative url to this item, eg:
* /gallery3/index.php/BobsWedding?page=2
--
cgit v1.2.3
From c8f90e861b866d0caa86343a6c7213e923023d39 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 07:14:38 -0700
Subject: Automated update of .build_number to 129 for branch master Last
update: ce14f5fb906335c35bdb2754bb0cd482e7526f09 (8 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 68a5d742..37dc1950 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=128
+build_number=129
--
cgit v1.2.3
From 7f48671186a4bf3a4745cd7a31b48a891dd83078 Mon Sep 17 00:00:00 2001
From: Tim Almdal
Date: Sun, 24 Apr 2011 07:15:30 -0700
Subject: For ticket #1701. Remove unused variable.
---
modules/tag/controllers/admin_tags.php | 1 -
1 file changed, 1 deletion(-)
diff --git a/modules/tag/controllers/admin_tags.php b/modules/tag/controllers/admin_tags.php
index 7a64f7ab..77b5f20a 100644
--- a/modules/tag/controllers/admin_tags.php
+++ b/modules/tag/controllers/admin_tags.php
@@ -87,7 +87,6 @@ class Admin_Tags_Controller extends Admin_Controller {
$old_name = $tag->name;
$new_name_or_list = $in_place_edit->value();
$tag_list = explode(",", $new_name_or_list);
- $tag_count = count($tag_list);
$tag->name = array_shift($tag_list);
$tag->save();
--
cgit v1.2.3
From b89c40242f85ecb49393e4fe6aeb3659550f60a4 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 07:49:41 -0700
Subject: Sentence-case the url. Fixes #1706.
---
modules/g2_import/helpers/g2_import_event.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/g2_import/helpers/g2_import_event.php b/modules/g2_import/helpers/g2_import_event.php
index 0e078d08..0afa62d8 100644
--- a/modules/g2_import/helpers/g2_import_event.php
+++ b/modules/g2_import/helpers/g2_import_event.php
@@ -34,7 +34,7 @@ class g2_import_event_Core {
->get("settings_menu")
->append(Menu::factory("link")
->id("g2_import")
- ->label(t("Gallery 2 Import"))
+ ->label(t("Gallery 2 import"))
->url(url::site("admin/g2_import")));
}
}
--
cgit v1.2.3
From bbd5417fef9c3ad28c6e57cb787e86684f49a71b Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 07:50:19 -0700
Subject: Automated update of .build_number to 130 for branch master Last
update: ce14f5fb906335c35bdb2754bb0cd482e7526f09 (10 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 37dc1950..befc7f03 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=129
+build_number=130
--
cgit v1.2.3
From b4cdd016dc97f2df608bb14d2088cb4ddbd32c35 Mon Sep 17 00:00:00 2001
From: Chad Kieffer
Date: Sun, 24 Apr 2011 11:53:29 -0400
Subject: Third times the charm. Rethink unordered lists and bullets. Revert to
turning them off by default and provide a new class, g-text, to define a list
or a section of text as needing to display bullets.
---
modules/g2_import/views/admin_g2_import.html.php | 4 ++--
modules/gallery/views/admin_block_welcome.html.php | 2 +-
themes/admin_wind/css/screen.css | 17 ++---------------
3 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/modules/g2_import/views/admin_g2_import.html.php b/modules/g2_import/views/admin_g2_import.html.php
index cf5e4755..2f4a1b28 100644
--- a/modules/g2_import/views/admin_g2_import.html.php
+++ b/modules/g2_import/views/admin_g2_import.html.php
@@ -112,8 +112,8 @@ $("document").ready(function() {
endif ?>
-
-
+
+
-
= t("Gallery 3 does not support per-user / per-item permissions. Review permissions!") ?>
diff --git a/modules/gallery/views/admin_block_welcome.html.php b/modules/gallery/views/admin_block_welcome.html.php
index d8c96187..d3765d19 100644
--- a/modules/gallery/views/admin_block_welcome.html.php
+++ b/modules/gallery/views/admin_block_welcome.html.php
@@ -2,7 +2,7 @@
= t("This is your administration dashboard and it provides a quick overview of status messages, recent updates, and frequently used options. Add or remove blocks and rearrange them to tailor to your needs. The admin menu provides quick access to all of Gallery 3's options and settings. Here are a few of the most used options to get you started.") ?>
-
+
-
= t("General Settings - choose your graphics and language settings.",
array("graphics_url" => html::mark_clean(url::site("admin/graphics")),
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index f01c2a94..6f1c0962 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -92,25 +92,12 @@ a:hover,
/* Lists ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
-#g-content ul li {
+ul.g-text li,
+.g-text ul li {
list-style-type: disc;
margin-left: 1em;
}
-form ul li,
-#g-action-status li,
-#g-log-entries li,
-#g-tag-admin li,
-.g-buttonset li,
-.g-buttonset-vertical li,
-.g-paginator li,
-.ui-sortable li,
-.ui-widget-header li {
- list-style: none !important;
- margin-left: 0 !important;
-}
-
-
/* Forms ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
form {
--
cgit v1.2.3
From f8493a1df26f242959e931d862c5f1282dd324e8 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 08:57:09 -0700
Subject: Revert my two "fixes" on top of Andy's tag combine change. Leave
Tag_Model::items() calling Item_Model::viewable() because it's too dangerous
to separate that out, and it's fragile to rely on only admins doing tag
combines.
Revert "Undo the change made in 5ce85636329b14673718836b3631a3e46efdc3bb because it messes up tag counts"
- This reverts commit 67d2e8081c6e5f0b679881bca3fdc81fe1e78ccc.
Revert "Move the calculation for item_related_update ahead of the duplicate"
- This reverts commit 5ce85636329b14673718836b3631a3e46efdc3bb.
---
modules/tag/models/tag.php | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/modules/tag/models/tag.php b/modules/tag/models/tag.php
index 13e253ba..bb79e707 100644
--- a/modules/tag/models/tag.php
+++ b/modules/tag/models/tag.php
@@ -75,8 +75,12 @@ class Tag_Model_Core extends ORM {
->where("id", "!=", $this->id)
->find();
if ($duplicate_tag->loaded()) {
- // If so, tag its items with this tag so as to merge it.
- foreach ($duplicate_tag->items() as $item) {
+ // If so, tag its items with this tag so as to merge it
+ $duplicate_tag_items = ORM::factory("item")
+ ->join("items_tags", "items.id", "items_tags.item_id")
+ ->where("items_tags.tag_id", "=", $duplicate_tag->id)
+ ->find_all();
+ foreach ($duplicate_tag_items as $item) {
$this->add($item);
}
@@ -84,7 +88,6 @@ class Tag_Model_Core extends ORM {
$duplicate_tag->delete();
}
- // Figure out what items have changed in this tag for our item_related_update event below
if (isset($this->object_relations["items"])) {
$added = array_diff($this->changed_relations["items"], $this->object_relations["items"]);
$removed = array_diff($this->object_relations["items"], $this->changed_relations["items"]);
--
cgit v1.2.3
From 6100de33ac9ec61350301b4c1f45bcaf383e4841 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 09:01:18 -0700
Subject: Automated update of .build_number to 131 for branch master Last
update: bbd5417fef9c3ad28c6e57cb787e86684f49a71b (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index befc7f03..efcaa779 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=130
+build_number=131
--
cgit v1.2.3
From ce5a2532ebcd5131056df908d2da831e91407e9d Mon Sep 17 00:00:00 2001
From: Chad Kieffer
Date: Sun, 24 Apr 2011 13:41:12 -0400
Subject: Extend .g-text list styles to ordered lists to admin_wind theme. Add
.g-text list styles to wind theme.
---
themes/admin_wind/css/screen.css | 9 +++++++++
themes/wind/css/screen.css | 17 +++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index 6f1c0962..d67850ec 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -95,6 +95,15 @@ a:hover,
ul.g-text li,
.g-text ul li {
list-style-type: disc;
+}
+
+ol.g-text li,
+.g-text ol li {
+ list-style-type: decimal;
+}
+
+.g-text li,
+.g-text li {
margin-left: 1em;
}
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index b470ab1c..81231426 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -111,6 +111,23 @@ a:hover,
padding-left: 32px;
}
+/* Lists ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
+
+ul.g-text li,
+.g-text ul li {
+ list-style-type: disc;
+}
+
+ol.g-text li,
+.g-text ol li {
+ list-style-type: decimal;
+}
+
+.g-text li,
+.g-text li {
+ margin-left: 1em;
+}
+
/* Forms ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
form {
--
cgit v1.2.3
From f4d76a8abe04612efe01f146617d760ffdd4b69f Mon Sep 17 00:00:00 2001
From: Chad Kieffer
Date: Sun, 24 Apr 2011 13:56:39 -0400
Subject: Don't put the Admin > Theme Options Save button in a fieldset.
---
modules/gallery/controllers/admin_theme_options.php | 1 -
1 file changed, 1 deletion(-)
diff --git a/modules/gallery/controllers/admin_theme_options.php b/modules/gallery/controllers/admin_theme_options.php
index a968a56d..d9323ea0 100644
--- a/modules/gallery/controllers/admin_theme_options.php
+++ b/modules/gallery/controllers/admin_theme_options.php
@@ -108,7 +108,6 @@ class Admin_Theme_Options_Controller extends Admin_Controller {
module::event("theme_edit_form", $form);
- $group = $form->group("buttons");
$group->submit("")->value(t("Save"));
return $form;
}
--
cgit v1.2.3
From 8e7a8fd2dc3245c2d236a2cd33d8c1a61ef9963c Mon Sep 17 00:00:00 2001
From: Chad Kieffer
Date: Sun, 24 Apr 2011 14:09:03 -0400
Subject: Add a bit of space below progress bars. Fixes #1703.
---
themes/admin_wind/css/screen.css | 2 +-
themes/wind/css/screen.css | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/admin_wind/css/screen.css b/themes/admin_wind/css/screen.css
index d67850ec..a26bf6d2 100644
--- a/themes/admin_wind/css/screen.css
+++ b/themes/admin_wind/css/screen.css
@@ -896,7 +896,7 @@ button {
.g-progress-bar {
height: 1em;
width: 100%;
- margin-top: .5em;
+ margin: .5em 0;
display: inline-block;
}
diff --git a/themes/wind/css/screen.css b/themes/wind/css/screen.css
index 81231426..d6909364 100644
--- a/themes/wind/css/screen.css
+++ b/themes/wind/css/screen.css
@@ -945,7 +945,7 @@ button {
.g-progress-bar {
height: 1em;
width: 100%;
- margin-top: .5em;
+ margin: .5em 0;
display: inline-block;
}
--
cgit v1.2.3
From ea2127c3b2ddef5709e02b4804c074bd1f942159 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 21:02:34 -0700
Subject: Fix a bug introduced in f2477703faa7cd05ff1aa16da3ecef7b666bef40
which was a fix for #1581 that caused us to skip adding highlights for any
albums that had no sub-albums.
---
modules/g2_import/helpers/g2_import.php | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/modules/g2_import/helpers/g2_import.php b/modules/g2_import/helpers/g2_import.php
index 23fb29e5..e9c19c9d 100644
--- a/modules/g2_import/helpers/g2_import.php
+++ b/modules/g2_import/helpers/g2_import.php
@@ -518,12 +518,11 @@ class g2_import_Core {
static function set_album_highlight(&$queue) {
// Dequeue the current album and enqueue its children
list($g2_album_id, $children) = each($queue);
- if (empty($children)) {
- return;
- }
unset($queue[$g2_album_id]);
- foreach ($children as $key => $value) {
- $queue[$key] = $value;
+ if (!empty($children)) {
+ foreach ($children as $key => $value) {
+ $queue[$key] = $value;
+ }
}
$messages = array();
--
cgit v1.2.3
From 15f4657452795c2852c58c9f1840ce4e1f58d401 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 21:03:16 -0700
Subject: Automated update of .build_number to 132 for branch master Last
update: 6100de33ac9ec61350301b4c1f45bcaf383e4841 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index efcaa779..ce9a62d4 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=131
+build_number=132
--
cgit v1.2.3
From 701c1fb12f2f254d8d7e7756a09cb5e825123a2f Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 22:45:45 -0700
Subject: Ignore the presort when transferring over sort orders. Fixes #1710.
---
modules/g2_import/helpers/g2_import.php | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/modules/g2_import/helpers/g2_import.php b/modules/g2_import/helpers/g2_import.php
index e9c19c9d..50ab8a23 100644
--- a/modules/g2_import/helpers/g2_import.php
+++ b/modules/g2_import/helpers/g2_import.php
@@ -475,9 +475,10 @@ class g2_import_Core {
1 => "ASC",
ORDER_ASCENDING => "ASC",
ORDER_DESCENDING => "DESC");
- // Only consider G2's first sort order
+ // G2 sorts can either be or |. Right now we can't
+ // map presorts so ignore them.
$g2_order = explode("|", $g2_album->getOrderBy() . "");
- $g2_order = $g2_order[0];
+ $g2_order = end($g2_order);
if (empty($g2_order)) {
$g2_order = g2(GalleryCoreApi::getPluginParameter('module', 'core', 'default.orderBy'));
}
--
cgit v1.2.3
From ded13a931a1e3f12649969bf7188febeb19ceb51 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 22:46:26 -0700
Subject: Automated update of .build_number to 133 for branch master Last
update: 15f4657452795c2852c58c9f1840ce4e1f58d401 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index ce9a62d4..fea9bdb6 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=132
+build_number=133
--
cgit v1.2.3
From 953be781dc91254599224fa6e95fcc435e787975 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 22:51:14 -0700
Subject: Refactor the meat of g2_import::import_album() off into a separate
function so taht we can call it on the root album as well. Fixes
---
modules/g2_import/helpers/g2_import.php | 96 +++++++++++++++-------------
modules/g2_import/helpers/g2_import_task.php | 6 ++
2 files changed, 58 insertions(+), 44 deletions(-)
diff --git a/modules/g2_import/helpers/g2_import.php b/modules/g2_import/helpers/g2_import.php
index 50ab8a23..22a054ac 100644
--- a/modules/g2_import/helpers/g2_import.php
+++ b/modules/g2_import/helpers/g2_import.php
@@ -448,50 +448,8 @@ class g2_import_Core {
$album = ORM::factory("item");
$album->type = "album";
$album->parent_id = self::map($g2_album->getParentId());
- $album->name = $g2_album->getPathComponent();
- $album->title = self::_decode_html_special_chars($g2_album->getTitle());
- $album->title or $album->title = $album->name;
- $album->description = self::_decode_html_special_chars(self::extract_description($g2_album));
- $album->owner_id = self::map($g2_album->getOwnerId());
- try {
- $album->view_count = (int) g2(GalleryCoreApi::fetchItemViewCount($g2_album_id));
- } catch (Exception $e) {
- // @todo log
- $album->view_count = 0;
- }
- $album->created = $g2_album->getCreationTimestamp();
-
- $order_map = array(
- "originationTimestamp" => "captured",
- "creationTimestamp" => "created",
- "description" => "description",
- "modificationTimestamp" => "updated",
- "orderWeight" => "weight",
- "pathComponent" => "name",
- "summary" => "description",
- "title" => "title",
- "viewCount" => "view_count");
- $direction_map = array(
- 1 => "ASC",
- ORDER_ASCENDING => "ASC",
- ORDER_DESCENDING => "DESC");
- // G2 sorts can either be or |. Right now we can't
- // map presorts so ignore them.
- $g2_order = explode("|", $g2_album->getOrderBy() . "");
- $g2_order = end($g2_order);
- if (empty($g2_order)) {
- $g2_order = g2(GalleryCoreApi::getPluginParameter('module', 'core', 'default.orderBy'));
- }
- $g2_order_direction = explode("|", $g2_album->getOrderDirection() . "");
- $g2_order_direction = $g2_order_direction[0];
- if (empty($g2_order_direction)) {
- $g2_order_direction =
- g2(GalleryCoreApi::getPluginParameter('module', 'core', 'default.orderDirection'));
- }
- if (array_key_exists($g2_order, $order_map)) {
- $album->sort_column = $order_map[$g2_order];
- $album->sort_order = $direction_map[$g2_order_direction];
- }
+
+ g2_import::set_album_values($album, $g2_album);
try {
$album->save();
@@ -513,6 +471,56 @@ class g2_import_Core {
self::_import_permissions($g2_album, $album);
}
+ /**
+ * Transfer over all the values from a G2 album to a G3 album.
+ */
+ static function set_album_values($album, $g2_album) {
+ $album->name = $g2_album->getPathComponent();
+ $album->title = self::_decode_html_special_chars($g2_album->getTitle());
+ $album->title or $album->title = $album->name;
+ $album->description = self::_decode_html_special_chars(self::extract_description($g2_album));
+ $album->owner_id = self::map($g2_album->getOwnerId());
+ try {
+ $album->view_count = (int) g2(GalleryCoreApi::fetchItemViewCount($g2_album_id));
+ } catch (Exception $e) {
+ // @todo log
+ $album->view_count = 0;
+ }
+ $album->created = $g2_album->getCreationTimestamp();
+
+ $order_map = array(
+ "originationTimestamp" => "captured",
+ "creationTimestamp" => "created",
+ "description" => "description",
+ "modificationTimestamp" => "updated",
+ "orderWeight" => "weight",
+ "pathComponent" => "name",
+ "summary" => "description",
+ "title" => "title",
+ "viewCount" => "view_count");
+ $direction_map = array(
+ 1 => "ASC",
+ ORDER_ASCENDING => "ASC",
+ ORDER_DESCENDING => "DESC");
+ // G2 sorts can either be or |. Right now we can't
+ // map presorts so ignore them.
+ $g2_order = explode("|", $g2_album->getOrderBy() . "");
+ $g2_order = end($g2_order);
+ if (empty($g2_order)) {
+ $g2_order = g2(GalleryCoreApi::getPluginParameter('module', 'core', 'default.orderBy'));
+ }
+ $g2_order_direction = explode("|", $g2_album->getOrderDirection() . "");
+ $g2_order_direction = $g2_order_direction[0];
+ if (empty($g2_order_direction)) {
+ $g2_order_direction =
+ g2(GalleryCoreApi::getPluginParameter('module', 'core', 'default.orderDirection'));
+ }
+ if (array_key_exists($g2_order, $order_map)) {
+ $album->sort_column = $order_map[$g2_order];
+ $album->sort_order = $direction_map[$g2_order_direction];
+ }
+ }
+
/**
* Set the highlight properly for a single album
*/
diff --git a/modules/g2_import/helpers/g2_import_task.php b/modules/g2_import/helpers/g2_import_task.php
index 5e908676..31615a55 100644
--- a/modules/g2_import/helpers/g2_import_task.php
+++ b/modules/g2_import/helpers/g2_import_task.php
@@ -127,6 +127,12 @@ class g2_import_task_Core {
$g2_root_id = g2(GalleryCoreApi::getDefaultAlbumId());
$tree = g2(GalleryCoreApi::fetchAlbumTree());
$task->set("queue", $queue = array($g2_root_id => $tree));
+
+ // Update the root album to reflect the Gallery2 root album.
+ $root_album = item::root();
+ g2_import::set_album_values(
+ $root_album, g2(GalleryCoreApi::loadEntitiesById($g2_root_id)));
+ $root_album->save();
}
$log_message = g2_import::import_album($queue);
if ($log_message) {
--
cgit v1.2.3
From 84407648fe0115875908ebd8c68fc1755d3ecd2b Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 22:52:02 -0700
Subject: Automated update of .build_number to 134 for branch master Last
update: 15f4657452795c2852c58c9f1840ce4e1f58d401 (3 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index fea9bdb6..049abf42 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=133
+build_number=134
--
cgit v1.2.3
From 8533420f5d307e81a90c3d26a75b666350aee0f2 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 22:55:01 -0700
Subject: Look for and return embed.php files in the autocomplete list if we
can find them. Fixes #1708.
---
modules/g2_import/controllers/admin_g2_import.php | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/modules/g2_import/controllers/admin_g2_import.php b/modules/g2_import/controllers/admin_g2_import.php
index cf68d911..5c4995c9 100644
--- a/modules/g2_import/controllers/admin_g2_import.php
+++ b/modules/g2_import/controllers/admin_g2_import.php
@@ -100,6 +100,11 @@ class Admin_g2_import_Controller extends Admin_Controller {
foreach (glob("{$path_prefix}*") as $file) {
if (is_dir($file) && !is_link($file)) {
$directories[] = $file;
+
+ // If we find an embed.php, include it as well
+ if (file_exists("$file/embed.php")) {
+ $directories[] = "$file/embed.php";
+ }
}
}
--
cgit v1.2.3
From 10f117238a4302092fdfb71a02542281f2b2d356 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 22:55:59 -0700
Subject: Automated update of .build_number to 135 for branch master Last
update: 15f4657452795c2852c58c9f1840ce4e1f58d401 (5 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 049abf42..1df3b5cb 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=134
+build_number=135
--
cgit v1.2.3
From 4ad94639a638c38db7fcd9c89f8f3f241a529c83 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 22:59:55 -0700
Subject: Automated update of .build_number to 136 for branch master Last
update: 10f117238a4302092fdfb71a02542281f2b2d356 (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 1df3b5cb..182fcf4d 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=135
+build_number=136
--
cgit v1.2.3
From 4e7524664a24dd2ca2309c9d67843a19e74b48e0 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Sun, 24 Apr 2011 23:04:50 -0700
Subject: Show the tabs after the page has loaded to prevent Firefox from
rendering the unstyled page and then flashing. Fixes #1705.
---
modules/g2_import/views/admin_g2_import.html.php | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/modules/g2_import/views/admin_g2_import.html.php b/modules/g2_import/views/admin_g2_import.html.php
index 2f4a1b28..9c4eb840 100644
--- a/modules/g2_import/views/admin_g2_import.html.php
+++ b/modules/g2_import/views/admin_g2_import.html.php
@@ -30,9 +30,13 @@ $("document").ready(function() {
.tabs("select", 1)
endif ?>
;
+
+ // Show the tabs after the page has loaded to prevent Firefox from rendering the
+ // unstyled page and then flashing.
+ $("#g-admin-g2-import-tabs").show();
});
-
+
-
= t("1. Configure Gallery2 path") ?>
--
cgit v1.2.3
From 3c63494a2edff31eaae0259ce80c6ced6a618a4f Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Sun, 24 Apr 2011 23:08:19 -0700
Subject: Automated update of .build_number to 137 for branch master Last
update: 10f117238a4302092fdfb71a02542281f2b2d356 (3 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 182fcf4d..a22acc76 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=136
+build_number=137
--
cgit v1.2.3
From b0285f770e72a03591939533485c90c63af00f1b Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Mon, 25 Apr 2011 22:06:36 -0700
Subject: Add appropriate preamble. #1696, #1698
---
.../gallery/views/admin_themes_buttonset.html.php | 93 +++++++++++-----------
1 file changed, 47 insertions(+), 46 deletions(-)
diff --git a/modules/gallery/views/admin_themes_buttonset.html.php b/modules/gallery/views/admin_themes_buttonset.html.php
index 5166f36c..bf474a26 100644
--- a/modules/gallery/views/admin_themes_buttonset.html.php
+++ b/modules/gallery/views/admin_themes_buttonset.html.php
@@ -1,47 +1,48 @@
-
--
cgit v1.2.3
From 11af2bc93f5966c4851d6752ded1da5de8450626 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Mon, 25 Apr 2011 22:06:44 -0700
Subject: Update test golden files.
---
modules/gallery/tests/controller_auth_data.txt | 1 +
modules/gallery/tests/xss_data.txt | 131 ++++++++++++++-----------
2 files changed, 73 insertions(+), 59 deletions(-)
diff --git a/modules/gallery/tests/controller_auth_data.txt b/modules/gallery/tests/controller_auth_data.txt
index f1192071..e35708c0 100644
--- a/modules/gallery/tests/controller_auth_data.txt
+++ b/modules/gallery/tests/controller_auth_data.txt
@@ -1,6 +1,7 @@
modules/comment/controllers/admin_manage_comments.php queue DIRTY_CSRF
modules/comment/helpers/comment_rss.php feed DIRTY_AUTH
modules/digibug/controllers/digibug.php print_proxy DIRTY_CSRF|DIRTY_AUTH
+modules/g2_import/controllers/admin_g2_import.php autocomplete DIRTY_CSRF
modules/g2_import/controllers/g2.php map DIRTY_CSRF
modules/gallery/controllers/admin.php __call DIRTY_AUTH
modules/gallery/controllers/albums.php index DIRTY_AUTH
diff --git a/modules/gallery/tests/xss_data.txt b/modules/gallery/tests/xss_data.txt
index 0c812fb4..7da79b23 100644
--- a/modules/gallery/tests/xss_data.txt
+++ b/modules/gallery/tests/xss_data.txt
@@ -42,7 +42,8 @@ modules/digibug/views/digibug_form.html.php 4 DIRTY form::
modules/digibug/views/digibug_form.html.php 6 DIRTY form::hidden($key,$value)
modules/exif/views/exif_dialog.html.php 14 DIRTY $details[$i]["caption"]
modules/exif/views/exif_dialog.html.php 21 DIRTY $details[$i]["caption"]
-modules/g2_import/views/admin_g2_import.html.php 9 DIRTY $form
+modules/g2_import/views/admin_g2_import.html.php 7 DIRTY_JS url::site("__ARGS__")
+modules/g2_import/views/admin_g2_import.html.php 52 DIRTY $form
modules/gallery/views/admin_advanced_settings.html.php 21 DIRTY_ATTR text::alternate("g-odd","g-even")
modules/gallery/views/admin_advanced_settings.html.php 22 DIRTY $var->module_name
modules/gallery/views/admin_block_log_entries.html.php 4 DIRTY_ATTR log::severity_class($entry->severity)
@@ -77,30 +78,35 @@ modules/gallery/views/admin_languages.html.php 62 DIRTY form::
modules/gallery/views/admin_languages.html.php 63 DIRTY $display_name
modules/gallery/views/admin_languages.html.php 65 DIRTY form::radio("default_locale",$code,($default_locale==$code),((isset($installed_locales[$code]))?'':'disabled="disabled"'))
modules/gallery/views/admin_languages.html.php 113 DIRTY $share_translations_form
-modules/gallery/views/admin_maintenance.html.php 40 DIRTY_ATTR text::alternate("g-odd","g-even")
-modules/gallery/views/admin_maintenance.html.php 40 DIRTY_ATTR log::severity_class($task->severity)
-modules/gallery/views/admin_maintenance.html.php 41 DIRTY_ATTR log::severity_class($task->severity)
-modules/gallery/views/admin_maintenance.html.php 42 DIRTY $task->name
-modules/gallery/views/admin_maintenance.html.php 45 DIRTY $task->description
-modules/gallery/views/admin_maintenance.html.php 86 DIRTY_ATTR text::alternate("g-odd","g-even")
-modules/gallery/views/admin_maintenance.html.php 86 DIRTY_ATTR $task->state=="stalled"?"g-warning":""
-modules/gallery/views/admin_maintenance.html.php 87 DIRTY_ATTR $task->state=="stalled"?"g-warning":""
-modules/gallery/views/admin_maintenance.html.php 88 DIRTY gallery::date_time($task->updated)
-modules/gallery/views/admin_maintenance.html.php 91 DIRTY $task->name
-modules/gallery/views/admin_maintenance.html.php 106 DIRTY $task->status
-modules/gallery/views/admin_maintenance.html.php 162 DIRTY_ATTR text::alternate("g-odd","g-even")
-modules/gallery/views/admin_maintenance.html.php 162 DIRTY_ATTR $task->state=="success"?"g-success":"g-error"
-modules/gallery/views/admin_maintenance.html.php 163 DIRTY_ATTR $task->state=="success"?"g-success":"g-error"
-modules/gallery/views/admin_maintenance.html.php 164 DIRTY gallery::date_time($task->updated)
-modules/gallery/views/admin_maintenance.html.php 167 DIRTY $task->name
-modules/gallery/views/admin_maintenance.html.php 179 DIRTY $task->status
+modules/gallery/views/admin_maintenance.html.php 42 DIRTY_ATTR text::alternate("g-odd","g-even")
+modules/gallery/views/admin_maintenance.html.php 42 DIRTY_ATTR log::severity_class($task->severity)
+modules/gallery/views/admin_maintenance.html.php 43 DIRTY_ATTR log::severity_class($task->severity)
+modules/gallery/views/admin_maintenance.html.php 44 DIRTY $task->name
+modules/gallery/views/admin_maintenance.html.php 47 DIRTY $task->description
+modules/gallery/views/admin_maintenance.html.php 88 DIRTY_ATTR text::alternate("g-odd","g-even")
+modules/gallery/views/admin_maintenance.html.php 88 DIRTY_ATTR $task->state=="stalled"?"g-warning":""
+modules/gallery/views/admin_maintenance.html.php 89 DIRTY_ATTR $task->state=="stalled"?"g-warning":""
+modules/gallery/views/admin_maintenance.html.php 90 DIRTY gallery::date_time($task->updated)
+modules/gallery/views/admin_maintenance.html.php 93 DIRTY $task->name
+modules/gallery/views/admin_maintenance.html.php 108 DIRTY $task->status
+modules/gallery/views/admin_maintenance.html.php 164 DIRTY_ATTR text::alternate("g-odd","g-even")
+modules/gallery/views/admin_maintenance.html.php 164 DIRTY_ATTR $task->state=="success"?"g-success":"g-error"
+modules/gallery/views/admin_maintenance.html.php 165 DIRTY_ATTR $task->state=="success"?"g-success":"g-error"
+modules/gallery/views/admin_maintenance.html.php 166 DIRTY gallery::date_time($task->updated)
+modules/gallery/views/admin_maintenance.html.php 169 DIRTY $task->name
+modules/gallery/views/admin_maintenance.html.php 181 DIRTY $task->status
modules/gallery/views/admin_maintenance_show_log.html.php 8 DIRTY_JS url::site("admin/maintenance/save_log/$task->id?csrf=$csrf")
modules/gallery/views/admin_maintenance_show_log.html.php 13 DIRTY $task->name
modules/gallery/views/admin_maintenance_task.html.php 75 DIRTY $task->name
modules/gallery/views/admin_modules.html.php 51 DIRTY access::csrf_form_field()
-modules/gallery/views/admin_modules.html.php 60 DIRTY_ATTR text::alternate("g-odd","g-even")
-modules/gallery/views/admin_modules.html.php 63 DIRTY form::checkbox($data,'1',module::is_active($module_name))
-modules/gallery/views/admin_modules.html.php 65 DIRTY $module_info->version
+modules/gallery/views/admin_modules.html.php 61 DIRTY_ATTR text::alternate("g-odd","g-even")
+modules/gallery/views/admin_modules.html.php 64 DIRTY form::checkbox($data,'1',module::is_active($module_name))
+modules/gallery/views/admin_modules.html.php 66 DIRTY $module_info->version
+modules/gallery/views/admin_modules.html.php 74 DIRTY_JS $module_info->author_url
+modules/gallery/views/admin_modules.html.php 81 DIRTY_ATTR $module_info->author_name
+modules/gallery/views/admin_modules.html.php 85 DIRTY $module_info->author_name
+modules/gallery/views/admin_modules.html.php 93 DIRTY_JS $module_info->info_url
+modules/gallery/views/admin_modules.html.php 106 DIRTY_JS $module_info->discuss_url
modules/gallery/views/admin_modules_confirm.html.php 11 DIRTY_ATTR $css_class
modules/gallery/views/admin_modules_confirm.html.php 11 DIRTY $message
modules/gallery/views/admin_modules_confirm.html.php 16 DIRTY access::csrf_form_field()
@@ -114,12 +120,17 @@ modules/gallery/views/admin_themes.html.php 3 DIRTY_JS url::s
modules/gallery/views/admin_themes.html.php 5 DIRTY_JS $csrf
modules/gallery/views/admin_themes.html.php 22 DIRTY $themes[$site]->name
modules/gallery/views/admin_themes.html.php 24 DIRTY $themes[$site]->description
-modules/gallery/views/admin_themes.html.php 38 DIRTY $info->name
-modules/gallery/views/admin_themes.html.php 40 DIRTY $info->description
-modules/gallery/views/admin_themes.html.php 60 DIRTY $themes[$admin]->name
-modules/gallery/views/admin_themes.html.php 62 DIRTY $themes[$admin]->description
-modules/gallery/views/admin_themes.html.php 76 DIRTY $info->name
-modules/gallery/views/admin_themes.html.php 78 DIRTY $info->description
+modules/gallery/views/admin_themes.html.php 39 DIRTY $info->name
+modules/gallery/views/admin_themes.html.php 41 DIRTY $info->description
+modules/gallery/views/admin_themes.html.php 62 DIRTY $themes[$admin]->name
+modules/gallery/views/admin_themes.html.php 64 DIRTY $themes[$admin]->description
+modules/gallery/views/admin_themes.html.php 79 DIRTY $info->name
+modules/gallery/views/admin_themes.html.php 81 DIRTY $info->description
+modules/gallery/views/admin_themes_buttonset.html.php 7 DIRTY_JS $info['author_url']
+modules/gallery/views/admin_themes_buttonset.html.php 14 DIRTY_ATTR $info['author_name']
+modules/gallery/views/admin_themes_buttonset.html.php 18 DIRTY $info['author_name']
+modules/gallery/views/admin_themes_buttonset.html.php 26 DIRTY_JS $info['info_url']
+modules/gallery/views/admin_themes_buttonset.html.php 39 DIRTY_JS $info['discuss_url']
modules/gallery/views/admin_themes_preview.html.php 8 DIRTY_ATTR $url
modules/gallery/views/error_404.html.php 14 DIRTY $login_form
modules/gallery/views/error_admin.html.php 178 DIRTY @gallery_block::get("platform_info")
@@ -174,7 +185,8 @@ modules/gallery/views/form_uploadify.html.php 28 DIRTY_JS url::f
modules/gallery/views/form_uploadify.html.php 29 DIRTY_JS url::site("uploader/add_photo/{$album->id}")
modules/gallery/views/form_uploadify.html.php 33 DIRTY_JS url::file("lib/uploadify/cancel.png")
modules/gallery/views/form_uploadify.html.php 34 DIRTY_JS $simultaneous_upload_limit
-modules/gallery/views/form_uploadify.html.php 160 DIRTY_ATTR request::protocol()
+modules/gallery/views/form_uploadify.html.php 35 DIRTY_JS $size_limit_bytes
+modules/gallery/views/form_uploadify.html.php 162 DIRTY_ATTR request::protocol()
modules/gallery/views/in_place_edit.html.php 2 DIRTY form::open($action,array("method"=>"post","id"=>"g-in-place-edit-form","class"=>"g-short-form"))
modules/gallery/views/in_place_edit.html.php 3 DIRTY access::csrf_form_field()
modules/gallery/views/in_place_edit.html.php 6 DIRTY form::input("input",$form["input"]," class=\"textbox\"")
@@ -248,7 +260,7 @@ modules/gallery/views/permissions_form.html.php 80 DIRTY_JS $permi
modules/gallery/views/permissions_form.html.php 80 DIRTY_JS $item->id
modules/gallery/views/quick_delete_confirm.html.php 11 DIRTY $form
modules/gallery/views/reauthenticate.html.php 9 DIRTY $form
-modules/gallery/views/upgrade_checker_block.html.php 17 DIRTY $new_version
+modules/gallery/views/upgrade_checker_block.html.php 19 DIRTY $new_version
modules/gallery/views/upgrader.html.php 76 DIRTY_ATTR $done?"muted":""
modules/gallery/views/upgrader.html.php 94 DIRTY_ATTR $done?"muted":""
modules/gallery/views/upgrader.html.php 102 DIRTY_ATTR $module->version==$module->code_version?"current":"upgradeable"
@@ -330,8 +342,9 @@ modules/search/views/search.html.php 27 DIRTY_ATTR $ite
modules/search/views/search.html.php 28 DIRTY_JS $item->url()
modules/search/views/search.html.php 29 DIRTY $item->thumb_img()
modules/search/views/search.html.php 40 DIRTY $theme->paginator()
-modules/server_add/views/admin_server_add.html.php 5 DIRTY $form
-modules/server_add/views/admin_server_add.html.php 15 DIRTY_ATTR $id
+modules/server_add/views/admin_server_add.html.php 8 DIRTY_JS url::site("__ARGS__")
+modules/server_add/views/admin_server_add.html.php 19 DIRTY $form
+modules/server_add/views/admin_server_add.html.php 30 DIRTY_ATTR $id
modules/server_add/views/server_add_tree.html.php 20 DIRTY_ATTR is_dir($file)?"ui-icon-folder-collapsed":"ui-icon-document"
modules/server_add/views/server_add_tree.html.php 21 DIRTY_ATTR is_dir($file)?"g-directory":"g-file"
modules/server_add/views/server_add_tree_dialog.html.php 3 DIRTY_JS url::site("server_add/children?path=__PATH__")
@@ -365,21 +378,21 @@ modules/watermark/views/admin_watermarks.html.php 20 DIRTY_ATTR $wid
modules/watermark/views/admin_watermarks.html.php 20 DIRTY_ATTR $height
modules/watermark/views/admin_watermarks.html.php 20 DIRTY_ATTR $url
themes/admin_wind/views/admin.html.php 4 DIRTY $theme->html_attributes()
-themes/admin_wind/views/admin.html.php 31 DIRTY $theme->admin_head()
-themes/admin_wind/views/admin.html.php 40 DIRTY_JS $theme->url()
-themes/admin_wind/views/admin.html.php 45 DIRTY $theme->get_combined("script")
-themes/admin_wind/views/admin.html.php 48 DIRTY $theme->get_combined("css")
-themes/admin_wind/views/admin.html.php 52 DIRTY $theme->admin_page_top()
-themes/admin_wind/views/admin.html.php 60 DIRTY $theme->admin_header_top()
-themes/admin_wind/views/admin.html.php 61 DIRTY_JS item::root()->url()
-themes/admin_wind/views/admin.html.php 64 DIRTY $theme->user_menu()
-themes/admin_wind/views/admin.html.php 67 DIRTY $theme->admin_menu()
-themes/admin_wind/views/admin.html.php 70 DIRTY $theme->admin_header_bottom()
-themes/admin_wind/views/admin.html.php 77 DIRTY $content
-themes/admin_wind/views/admin.html.php 83 DIRTY $sidebar
-themes/admin_wind/views/admin.html.php 88 DIRTY $theme->admin_footer()
-themes/admin_wind/views/admin.html.php 91 DIRTY $theme->admin_credits()
-themes/admin_wind/views/admin.html.php 96 DIRTY $theme->admin_page_bottom()
+themes/admin_wind/views/admin.html.php 33 DIRTY $theme->admin_head()
+themes/admin_wind/views/admin.html.php 42 DIRTY_JS $theme->url()
+themes/admin_wind/views/admin.html.php 47 DIRTY $theme->get_combined("css")
+themes/admin_wind/views/admin.html.php 50 DIRTY $theme->get_combined("script")
+themes/admin_wind/views/admin.html.php 54 DIRTY $theme->admin_page_top()
+themes/admin_wind/views/admin.html.php 62 DIRTY $theme->admin_header_top()
+themes/admin_wind/views/admin.html.php 63 DIRTY_JS item::root()->url()
+themes/admin_wind/views/admin.html.php 66 DIRTY $theme->user_menu()
+themes/admin_wind/views/admin.html.php 69 DIRTY $theme->admin_menu()
+themes/admin_wind/views/admin.html.php 72 DIRTY $theme->admin_header_bottom()
+themes/admin_wind/views/admin.html.php 79 DIRTY $content
+themes/admin_wind/views/admin.html.php 85 DIRTY $sidebar
+themes/admin_wind/views/admin.html.php 90 DIRTY $theme->admin_footer()
+themes/admin_wind/views/admin.html.php 93 DIRTY $theme->admin_credits()
+themes/admin_wind/views/admin.html.php 98 DIRTY $theme->admin_page_bottom()
themes/admin_wind/views/block.html.php 3 DIRTY_ATTR $anchor
themes/admin_wind/views/block.html.php 5 DIRTY $id
themes/admin_wind/views/block.html.php 5 DIRTY_ATTR $css_id
@@ -414,19 +427,19 @@ themes/wind/views/page.html.php 4 DIRTY $theme
themes/wind/views/page.html.php 10 DIRTY $page_title
themes/wind/views/page.html.php 13 DIRTY $theme->item()->title
themes/wind/views/page.html.php 17 DIRTY item::root()->title
-themes/wind/views/page.html.php 31 DIRTY $new_width
-themes/wind/views/page.html.php 32 DIRTY $new_height
-themes/wind/views/page.html.php 33 DIRTY $thumb_proportion
-themes/wind/views/page.html.php 70 DIRTY_JS $theme->url()
-themes/wind/views/page.html.php 75 DIRTY $theme->get_combined("script")
-themes/wind/views/page.html.php 78 DIRTY $theme->get_combined("css")
-themes/wind/views/page.html.php 88 DIRTY $header_text
-themes/wind/views/page.html.php 90 DIRTY_JS item::root()->url()
-themes/wind/views/page.html.php 94 DIRTY $theme->user_menu()
-themes/wind/views/page.html.php 115 DIRTY_JS $parent->url($parent->id==$theme->item()->parent_id?"show={$theme->item()->id}":null)
-themes/wind/views/page.html.php 136 DIRTY $content
-themes/wind/views/page.html.php 142 DIRTY newView("sidebar.html")
-themes/wind/views/page.html.php 149 DIRTY $footer_text
+themes/wind/views/page.html.php 32 DIRTY $new_width
+themes/wind/views/page.html.php 33 DIRTY $new_height
+themes/wind/views/page.html.php 34 DIRTY $thumb_proportion
+themes/wind/views/page.html.php 71 DIRTY_JS $theme->url()
+themes/wind/views/page.html.php 76 DIRTY $theme->get_combined("css")
+themes/wind/views/page.html.php 79 DIRTY $theme->get_combined("script")
+themes/wind/views/page.html.php 89 DIRTY $header_text
+themes/wind/views/page.html.php 91 DIRTY_JS item::root()->url()
+themes/wind/views/page.html.php 95 DIRTY $theme->user_menu()
+themes/wind/views/page.html.php 116 DIRTY_JS $parent->url($parent->id==$theme->item()->parent_id?"show={$theme->item()->id}":null)
+themes/wind/views/page.html.php 137 DIRTY $content
+themes/wind/views/page.html.php 143 DIRTY newView("sidebar.html")
+themes/wind/views/page.html.php 150 DIRTY $footer_text
themes/wind/views/paginator.html.php 33 DIRTY_JS $first_page_url
themes/wind/views/paginator.html.php 42 DIRTY_JS $previous_page_url
themes/wind/views/paginator.html.php 70 DIRTY_JS $next_page_url
--
cgit v1.2.3
From b2327f97b47eab849a88652bdfe2106c430288df Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Mon, 25 Apr 2011 22:09:12 -0700
Subject: Automated update of .build_number to 138 for branch master Last
update: 10f117238a4302092fdfb71a02542281f2b2d356 (6 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index a22acc76..c1722df3 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=137
+build_number=138
--
cgit v1.2.3
From 91c83874e518b9106a4d54d8c3bbe28e4c055123 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Mon, 25 Apr 2011 22:15:34 -0700
Subject: Fix a bug introduced in 526859d9605d137ebe053ecbd80f46ca6a331194
where we changed the behavior of the slug code and included the file
extension, not just the name. This broke
Item_Model_Test::move_photo_with_conflicting_target_gets_uniqified_test so
yay for unit tests! #1668
---
modules/gallery/models/item.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/gallery/models/item.php b/modules/gallery/models/item.php
index f46db696..2a5e6894 100644
--- a/modules/gallery/models/item.php
+++ b/modules/gallery/models/item.php
@@ -336,7 +336,7 @@ class Item_Model_Core extends ORM_MPTT {
// Make an url friendly slug from the name, if necessary
if (empty($this->slug)) {
- $this->slug = item::convert_filename_to_slug($this->name);
+ $this->slug = item::convert_filename_to_slug(pathinfo($this->name, PATHINFO_FILENAME));
// If the filename is all invalid characters, then the slug may be empty here. Pick a
// random value.
--
cgit v1.2.3
From 8665988ff37a36fef5042310d196de6250111456 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Mon, 25 Apr 2011 22:16:29 -0700
Subject: Automated update of .build_number to 139 for branch master Last
update: 10f117238a4302092fdfb71a02542281f2b2d356 (8 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index c1722df3..11821c7b 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=138
+build_number=139
--
cgit v1.2.3
From cbd04e1ae02491ab4c213fe03d62d12ca1546251 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Mon, 25 Apr 2011 23:26:43 -0700
Subject: Move random::string() to be test::random_string() and have it return
a random string of any length. Also introduce test::lorem_ipsum() and use
that in places where we want strings of words. Fixes #1713.
---
modules/gallery/helpers/random.php | 10 +-
modules/gallery/tests/Albums_Controller_Test.php | 2 +-
modules/gallery/tests/File_Structure_Test.php | 1 +
modules/gallery/tests/Gallery_Filters.php | 1 +
modules/gallery_unit_test/helpers/test.php | 30 +-
.../gallery_unit_test/vendor/LoremIpsum.class.php | 461 +++++++++++++++++++++
6 files changed, 489 insertions(+), 16 deletions(-)
create mode 100644 modules/gallery_unit_test/vendor/LoremIpsum.class.php
diff --git a/modules/gallery/helpers/random.php b/modules/gallery/helpers/random.php
index 6016df7b..06542e8c 100644
--- a/modules/gallery/helpers/random.php
+++ b/modules/gallery/helpers/random.php
@@ -19,21 +19,13 @@
*/
class random_Core {
/**
- * Return a random 32 bit hash value.
+ * Return a random 32 byte hash value.
* @param string extra entropy data
*/
static function hash($entropy="") {
return md5($entropy . uniqid(mt_rand(), true));
}
- /**
- * Return a random hexadecimal string of the given length.
- * @param int the desired length of the string
- */
- static function string($length) {
- return substr(random::hash(), 0, $length);
- }
-
/**
* Return a random floating point number between 0 and 1
*/
diff --git a/modules/gallery/tests/Albums_Controller_Test.php b/modules/gallery/tests/Albums_Controller_Test.php
index d9983cc2..2ff017d7 100644
--- a/modules/gallery/tests/Albums_Controller_Test.php
+++ b/modules/gallery/tests/Albums_Controller_Test.php
@@ -31,7 +31,7 @@ class Albums_Controller_Test extends Gallery_Unit_Test_Case {
$album = test::random_album();
// Randomize to avoid conflicts.
- $new_name = "new_name_" . random::string(6);
+ $new_name = "new_name_" . test::random_string(6);
$_POST["name"] = $new_name;
$_POST["title"] = "new title";
diff --git a/modules/gallery/tests/File_Structure_Test.php b/modules/gallery/tests/File_Structure_Test.php
index 69c4bbf9..1d1ff5ce 100644
--- a/modules/gallery/tests/File_Structure_Test.php
+++ b/modules/gallery/tests/File_Structure_Test.php
@@ -101,6 +101,7 @@ class File_Structure_Test extends Gallery_Unit_Test_Case {
$expected_4 = array("type = "album";
@@ -34,7 +34,7 @@ class test_Core {
}
static function random_photo_unsaved($parent=null) {
- $rand = random::string(6);
+ $rand = test::random_string(6);
$photo = ORM::factory("item");
$photo->type = "photo";
$photo->parent_id = $parent ? $parent->id : 1;
@@ -49,16 +49,16 @@ class test_Core {
}
static function random_user($password="password") {
- $rand = "name_" . random::string(6);
+ $rand = "name_" . test::random_string(6);
return identity::create_user($rand, $rand, $password, "$rand@rand.com");
}
static function random_group() {
- return identity::create_group(random::string(6));
+ return identity::create_group(test::random_string(6));
}
static function random_name($item=null) {
- $rand = "name_" . random::string(6);
+ $rand = "name_" . test::random_string(6);
if ($item && $item->is_photo()) {
$rand .= ".jpg";
}
@@ -77,7 +77,7 @@ class test_Core {
static function random_tag() {
$tag = ORM::factory("tag");
- $tag->name = random::string(6);
+ $tag->name = test::lorem_ipsum(rand(2, 4));
// Reload so that ORM coerces all fields into strings.
return $tag->save()->reload();
@@ -88,4 +88,22 @@ class test_Core {
fwrite(fopen($b_name = tempnam("/tmp", "test"), "w"), $b);
return `diff $a_name $b_name`;
}
+
+ static function random_string($length) {
+ $buf = "";
+ do {
+ $buf .= random::hash();
+ } while (strlen($buf) < $length);
+ return substr($buf, 0, $length);
+ }
+
+ static function lorem_ipsum($num) {
+ static $lorem_ipsum = null;
+ if (!$lorem_ipsum) {
+ require_once(MODPATH . "gallery_unit_test/vendor/LoremIpsum.class.php");
+ $lorem_ipsum = new LoremIpsumGenerator();
+ }
+ // skip past initial 'lorem ipsum'
+ return substr($lorem_ipsum->getContent($num + 2, "txt"), 13);
+ }
}
diff --git a/modules/gallery_unit_test/vendor/LoremIpsum.class.php b/modules/gallery_unit_test/vendor/LoremIpsum.class.php
new file mode 100644
index 00000000..07050fe5
--- /dev/null
+++ b/modules/gallery_unit_test/vendor/LoremIpsum.class.php
@@ -0,0 +1,461 @@
+ BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+ private $words, $wordsPerParagraph, $wordsPerSentence;
+
+ function __construct($wordsPer = 100)
+ {
+ $this->wordsPerParagraph = $wordsPer;
+ $this->wordsPerSentence = 24.460;
+ $this->words = array(
+ 'lorem',
+ 'ipsum',
+ 'dolor',
+ 'sit',
+ 'amet',
+ 'consectetur',
+ 'adipiscing',
+ 'elit',
+ 'curabitur',
+ 'vel',
+ 'hendrerit',
+ 'libero',
+ 'eleifend',
+ 'blandit',
+ 'nunc',
+ 'ornare',
+ 'odio',
+ 'ut',
+ 'orci',
+ 'gravida',
+ 'imperdiet',
+ 'nullam',
+ 'purus',
+ 'lacinia',
+ 'a',
+ 'pretium',
+ 'quis',
+ 'congue',
+ 'praesent',
+ 'sagittis',
+ 'laoreet',
+ 'auctor',
+ 'mauris',
+ 'non',
+ 'velit',
+ 'eros',
+ 'dictum',
+ 'proin',
+ 'accumsan',
+ 'sapien',
+ 'nec',
+ 'massa',
+ 'volutpat',
+ 'venenatis',
+ 'sed',
+ 'eu',
+ 'molestie',
+ 'lacus',
+ 'quisque',
+ 'porttitor',
+ 'ligula',
+ 'dui',
+ 'mollis',
+ 'tempus',
+ 'at',
+ 'magna',
+ 'vestibulum',
+ 'turpis',
+ 'ac',
+ 'diam',
+ 'tincidunt',
+ 'id',
+ 'condimentum',
+ 'enim',
+ 'sodales',
+ 'in',
+ 'hac',
+ 'habitasse',
+ 'platea',
+ 'dictumst',
+ 'aenean',
+ 'neque',
+ 'fusce',
+ 'augue',
+ 'leo',
+ 'eget',
+ 'semper',
+ 'mattis',
+ 'tortor',
+ 'scelerisque',
+ 'nulla',
+ 'interdum',
+ 'tellus',
+ 'malesuada',
+ 'rhoncus',
+ 'porta',
+ 'sem',
+ 'aliquet',
+ 'et',
+ 'nam',
+ 'suspendisse',
+ 'potenti',
+ 'vivamus',
+ 'luctus',
+ 'fringilla',
+ 'erat',
+ 'donec',
+ 'justo',
+ 'vehicula',
+ 'ultricies',
+ 'varius',
+ 'ante',
+ 'primis',
+ 'faucibus',
+ 'ultrices',
+ 'posuere',
+ 'cubilia',
+ 'curae',
+ 'etiam',
+ 'cursus',
+ 'aliquam',
+ 'quam',
+ 'dapibus',
+ 'nisl',
+ 'feugiat',
+ 'egestas',
+ 'class',
+ 'aptent',
+ 'taciti',
+ 'sociosqu',
+ 'ad',
+ 'litora',
+ 'torquent',
+ 'per',
+ 'conubia',
+ 'nostra',
+ 'inceptos',
+ 'himenaeos',
+ 'phasellus',
+ 'nibh',
+ 'pulvinar',
+ 'vitae',
+ 'urna',
+ 'iaculis',
+ 'lobortis',
+ 'nisi',
+ 'viverra',
+ 'arcu',
+ 'morbi',
+ 'pellentesque',
+ 'metus',
+ 'commodo',
+ 'ut',
+ 'facilisis',
+ 'felis',
+ 'tristique',
+ 'ullamcorper',
+ 'placerat',
+ 'aenean',
+ 'convallis',
+ 'sollicitudin',
+ 'integer',
+ 'rutrum',
+ 'duis',
+ 'est',
+ 'etiam',
+ 'bibendum',
+ 'donec',
+ 'pharetra',
+ 'vulputate',
+ 'maecenas',
+ 'mi',
+ 'fermentum',
+ 'consequat',
+ 'suscipit',
+ 'aliquam',
+ 'habitant',
+ 'senectus',
+ 'netus',
+ 'fames',
+ 'quisque',
+ 'euismod',
+ 'curabitur',
+ 'lectus',
+ 'elementum',
+ 'tempor',
+ 'risus',
+ 'cras' );
+ }
+
+ function getContent($count, $format = 'html', $loremipsum = true)
+ {
+ $format = strtolower($format);
+
+ if($count <= 0)
+ return '';
+
+ switch($format)
+ {
+ case 'txt':
+ return $this->getText($count, $loremipsum);
+ case 'plain':
+ return $this->getPlain($count, $loremipsum);
+ default:
+ return $this->getHTML($count, $loremipsum);
+ }
+ }
+
+ private function getWords(&$arr, $count, $loremipsum)
+ {
+ $i = 0;
+ if($loremipsum)
+ {
+ $i = 2;
+ $arr[0] = 'lorem';
+ $arr[1] = 'ipsum';
+ }
+
+ for($i; $i < $count; $i++)
+ {
+ $index = array_rand($this->words);
+ $word = $this->words[$index];
+ //echo $index . '=>' . $word . '
';
+
+ if($i > 0 && $arr[$i - 1] == $word)
+ $i--;
+ else
+ $arr[$i] = $word;
+ }
+ }
+
+ private function getPlain($count, $loremipsum, $returnStr = true)
+ {
+ $words = array();
+ $this->getWords($words, $count, $loremipsum);
+ //print_r($words);
+
+ $delta = $count;
+ $curr = 0;
+ $sentences = array();
+ while($delta > 0)
+ {
+ $senSize = $this->gaussianSentence();
+ //echo $curr . '
';
+ if(($delta - $senSize) < 4)
+ $senSize = $delta;
+
+ $delta -= $senSize;
+
+ $sentence = array();
+ for($i = $curr; $i < ($curr + $senSize); $i++)
+ $sentence[] = $words[$i];
+
+ $this->punctuate($sentence);
+ $curr = $curr + $senSize;
+ $sentences[] = $sentence;
+ }
+
+ if($returnStr)
+ {
+ $output = '';
+ foreach($sentences as $s)
+ foreach($s as $w)
+ $output .= $w . ' ';
+
+ return $output;
+ }
+ else
+ return $sentences;
+ }
+
+ private function getText($count, $loremipsum)
+ {
+ $sentences = $this->getPlain($count, $loremipsum, false);
+ $paragraphs = $this->getParagraphArr($sentences);
+
+ $paragraphStr = array();
+ foreach($paragraphs as $p)
+ {
+ $paragraphStr[] = $this->paragraphToString($p);
+ }
+
+ $paragraphStr[0] = "\t" . $paragraphStr[0];
+ return implode("\n\n\t", $paragraphStr);
+ }
+
+ private function getParagraphArr($sentences)
+ {
+ $wordsPer = $this->wordsPerParagraph;
+ $sentenceAvg = $this->wordsPerSentence;
+ $total = count($sentences);
+
+ $paragraphs = array();
+ $pCount = 0;
+ $currCount = 0;
+ $curr = array();
+
+ for($i = 0; $i < $total; $i++)
+ {
+ $s = $sentences[$i];
+ $currCount += count($s);
+ $curr[] = $s;
+ if($currCount >= ($wordsPer - round($sentenceAvg / 2.00)) || $i == $total - 1)
+ {
+ $currCount = 0;
+ $paragraphs[] = $curr;
+ $curr = array();
+ //print_r($paragraphs);
+ }
+ //print_r($paragraphs);
+ }
+
+ return $paragraphs;
+ }
+
+ private function getHTML($count, $loremipsum)
+ {
+ $sentences = $this->getPlain($count, $loremipsum, false);
+ $paragraphs = $this->getParagraphArr($sentences);
+ //print_r($paragraphs);
+
+ $paragraphStr = array();
+ foreach($paragraphs as $p)
+ {
+ $paragraphStr[] = "\n" . $this->paragraphToString($p, true) . '
';
+ }
+
+ //add new lines for the sake of clean code
+ return implode("\n", $paragraphStr);
+ }
+
+ private function paragraphToString($paragraph, $htmlCleanCode = false)
+ {
+ $paragraphStr = '';
+ foreach($paragraph as $sentence)
+ {
+ foreach($sentence as $word)
+ $paragraphStr .= $word . ' ';
+
+ if($htmlCleanCode)
+ $paragraphStr .= "\n";
+ }
+ return $paragraphStr;
+ }
+
+ /*
+ * Inserts commas and periods in the given
+ * word array.
+ */
+ private function punctuate(& $sentence)
+ {
+ $count = count($sentence);
+ $sentence[$count - 1] = $sentence[$count - 1] . '.';
+
+ if($count < 4)
+ return $sentence;
+
+ $commas = $this->numberOfCommas($count);
+
+ for($i = 1; $i <= $commas; $i++)
+ {
+ $index = (int) round($i * $count / ($commas + 1));
+
+ if($index < ($count - 1) && $index > 0)
+ {
+ $sentence[$index] = $sentence[$index] . ',';
+ }
+ }
+ }
+
+ /*
+ * Determines the number of commas for a
+ * sentence of the given length. Average and
+ * standard deviation are determined superficially
+ */
+ private function numberOfCommas($len)
+ {
+ $avg = (float) log($len, 6);
+ $stdDev = (float) $avg / 6.000;
+
+ return (int) round($this->gauss_ms($avg, $stdDev));
+ }
+
+ /*
+ * Returns a number on a gaussian distribution
+ * based on the average word length of an english
+ * sentence.
+ * Statistics Source:
+ * http://hearle.nahoo.net/Academic/Maths/Sentence.html
+ * Average: 24.46
+ * Standard Deviation: 5.08
+ */
+ private function gaussianSentence()
+ {
+ $avg = (float) 24.460;
+ $stdDev = (float) 5.080;
+
+ return (int) round($this->gauss_ms($avg, $stdDev));
+ }
+
+ /*
+ * The following three functions are used to
+ * compute numbers with a guassian distrobution
+ * Source:
+ * http://us.php.net/manual/en/function.rand.php#53784
+ */
+ private function gauss()
+ { // N(0,1)
+ // returns random number with normal distribution:
+ // mean=0
+ // std dev=1
+
+ // auxilary vars
+ $x=$this->random_0_1();
+ $y=$this->random_0_1();
+
+ // two independent variables with normal distribution N(0,1)
+ $u=sqrt(-2*log($x))*cos(2*pi()*$y);
+ $v=sqrt(-2*log($x))*sin(2*pi()*$y);
+
+ // i will return only one, couse only one needed
+ return $u;
+ }
+
+ private function gauss_ms($m=0.0,$s=1.0)
+ {
+ return $this->gauss()*$s+$m;
+ }
+
+ private function random_0_1()
+ {
+ return (float)rand()/(float)getrandmax();
+ }
+
+}
\ No newline at end of file
--
cgit v1.2.3
From c6d1d6a6aed96f772690b74ac0be482bc2128a8d Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Mon, 25 Apr 2011 23:27:54 -0700
Subject: Automated update of .build_number to 140 for branch master Last
update: 10f117238a4302092fdfb71a02542281f2b2d356 (10 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index 11821c7b..b9dbbf41 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=139
+build_number=140
--
cgit v1.2.3
From 5cf38ed816006af52fa08475d2957a6f18846887 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Tue, 26 Apr 2011 09:48:21 -0700
Subject: Stop using Pagination() and instead use $theme->pager() in views.
Move the pager() function up to Gallery_View and replace
themes/admin_wind/views/pager.html.php (Pagination based) with a modified
version from the wind theme in themes/admin_wind/views/paginator.html.php.
Fixes #1718.
---
.../comment/controllers/admin_manage_comments.php | 13 ++--
.../comment/views/admin_manage_comments.html.php | 2 +-
modules/gallery/libraries/Gallery_View.php | 46 +++++++++++
modules/gallery/libraries/MY_Pagination.php | 35 ---------
modules/gallery/libraries/Theme_View.php | 46 -----------
modules/user/controllers/admin_users.php | 8 ++
modules/user/views/admin_users.html.php | 2 +-
themes/admin_wind/views/pager.html.php | 44 -----------
themes/admin_wind/views/paginator.html.php | 88 ++++++++++++++++++++++
9 files changed, 151 insertions(+), 133 deletions(-)
delete mode 100644 modules/gallery/libraries/MY_Pagination.php
delete mode 100644 themes/admin_wind/views/pager.html.php
create mode 100644 themes/admin_wind/views/paginator.html.php
diff --git a/modules/comment/controllers/admin_manage_comments.php b/modules/comment/controllers/admin_manage_comments.php
index 9bd1d7f6..effefcbb 100644
--- a/modules/comment/controllers/admin_manage_comments.php
+++ b/modules/comment/controllers/admin_manage_comments.php
@@ -45,6 +45,8 @@ class Admin_Manage_Comments_Controller extends Admin_Controller {
$view = new Admin_View("admin.html");
$view->page_title = t("Manage comments");
+ $view->page_type = "collection";
+ $view->page_subtype = "admin_comments";
$view->content = new View("admin_manage_comments.html");
$view->content->counts = $this->_counts();
$view->content->menu = $this->_menu($view->content->counts);
@@ -56,13 +58,12 @@ class Admin_Manage_Comments_Controller extends Admin_Controller {
->limit(self::$items_per_page)
->offset(($page - 1) * self::$items_per_page)
->find_all();
- $view->content->pager = new Pagination();
- $view->content->pager->initialize(
- array("query_string" => "page",
- "total_items" => $view->content->counts->$state,
- "items_per_page" => self::$items_per_page,
- "style" => "classic"));
+ // Pagination info
+ $view->page = $page;
+ $view->page_size = self::$items_per_page;
+ $view->children_count = $this->_counts()->$state;
+ $view->max_pages = ceil($view->children_count / $view->page_size);
print $view;
}
diff --git a/modules/comment/views/admin_manage_comments.html.php b/modules/comment/views/admin_manage_comments.html.php
index 34a28986..e7a61837 100644
--- a/modules/comment/views/admin_manage_comments.html.php
+++ b/modules/comment/views/admin_manage_comments.html.php
@@ -194,7 +194,7 @@
- = $pager ?>
+ = $theme->paginator() ?>
diff --git a/modules/gallery/libraries/Gallery_View.php b/modules/gallery/libraries/Gallery_View.php
index 1395686c..e04b9169 100644
--- a/modules/gallery/libraries/Gallery_View.php
+++ b/modules/gallery/libraries/Gallery_View.php
@@ -30,6 +30,52 @@ class Gallery_View_Core extends View {
return $absolute_url ? url::abs_file($arg) : url::file($arg);
}
+ /**
+ * Set up the data and render a pager.
+ *
+ * See themes/wind/views/pager.html for documentation on the variables generated here.
+ */
+ public function paginator() {
+ $v = new View("paginator.html");
+ $v->page_type = $this->page_type;
+ $v->page_subtype = $this->page_subtype;
+ $v->first_page_url = null;
+ $v->previous_page_url = null;
+ $v->next_page_url = null;
+ $v->last_page_url = null;
+
+ if ($this->page_type == "collection") {
+ $v->page = $this->page;
+ $v->max_pages = $this->max_pages;
+ $v->total = $this->children_count;
+
+ if ($this->page != 1) {
+ $v->first_page_url = url::site(url::merge(array("page" => 1)));
+ $v->previous_page_url = url::site(url::merge(array("page" => $this->page - 1)));
+ }
+
+ if ($this->page != $this->max_pages) {
+ $v->next_page_url = url::site(url::merge(array("page" => $this->page + 1)));
+ $v->last_page_url = url::site(url::merge(array("page" => $this->max_pages)));
+ }
+
+ $v->first_visible_position = ($this->page - 1) * $this->page_size + 1;
+ $v->last_visible_position = min($this->page * $this->page_size, $v->total);
+ } else if ($this->page_type == "item") {
+ $v->position = $this->position;
+ $v->total = $this->sibling_count;
+ if ($this->previous_item) {
+ $v->previous_page_url = $this->previous_item->url();
+ }
+
+ if ($this->next_item) {
+ $v->next_page_url = $this->next_item->url();
+ }
+ }
+
+ return $v;
+ }
+
/**
* Begin gather up scripts or css files so that they can be combined into a single request.
*
diff --git a/modules/gallery/libraries/MY_Pagination.php b/modules/gallery/libraries/MY_Pagination.php
deleted file mode 100644
index e697c0bd..00000000
--- a/modules/gallery/libraries/MY_Pagination.php
+++ /dev/null
@@ -1,35 +0,0 @@
-auto_hide === TRUE AND $this->total_pages <= 1) {
- return "";
- }
-
- if ($style === NULL) {
- // Use default style
- $style = $this->style;
- }
-
- // Return rendered pagination view
- return View::factory("pager.html", get_object_vars($this))->render();
- }
-}
diff --git a/modules/gallery/libraries/Theme_View.php b/modules/gallery/libraries/Theme_View.php
index 152efc37..d6834464 100644
--- a/modules/gallery/libraries/Theme_View.php
+++ b/modules/gallery/libraries/Theme_View.php
@@ -138,52 +138,6 @@ class Theme_View_Core extends Gallery_View {
return $menu->render();
}
- /**
- * Set up the data and render a pager.
- *
- * See themes/wind/views/pager.html for documentation on the variables generated here.
- */
- public function paginator() {
- $v = new View("paginator.html");
- $v->page_type = $this->page_type;
- $v->page_subtype = $this->page_subtype;
- $v->first_page_url = null;
- $v->previous_page_url = null;
- $v->next_page_url = null;
- $v->last_page_url = null;
-
- if ($this->page_type == "collection") {
- $v->page = $this->page;
- $v->max_pages = $this->max_pages;
- $v->total = $this->children_count;
-
- if ($this->page != 1) {
- $v->first_page_url = url::site(url::merge(array("page" => 1)));
- $v->previous_page_url = url::site(url::merge(array("page" => $this->page - 1)));
- }
-
- if ($this->page != $this->max_pages) {
- $v->next_page_url = url::site(url::merge(array("page" => $this->page + 1)));
- $v->last_page_url = url::site(url::merge(array("page" => $this->max_pages)));
- }
-
- $v->first_visible_position = ($this->page - 1) * $this->page_size + 1;
- $v->last_visible_position = min($this->page * $this->page_size, $v->total);
- } else if ($this->page_type == "item") {
- $v->position = $this->position;
- $v->total = $this->sibling_count;
- if ($this->previous_item) {
- $v->previous_page_url = $this->previous_item->url();
- }
-
- if ($this->next_item) {
- $v->next_page_url = $this->next_item->url();
- }
- }
-
- return $v;
- }
-
/**
* Print out any site wide status information.
*/
diff --git a/modules/user/controllers/admin_users.php b/modules/user/controllers/admin_users.php
index a3633b52..41be6c03 100644
--- a/modules/user/controllers/admin_users.php
+++ b/modules/user/controllers/admin_users.php
@@ -21,6 +21,8 @@ class Admin_Users_Controller extends Admin_Controller {
public function index() {
$view = new Admin_View("admin.html");
$view->page_title = t("Users and groups");
+ $view->page_type = "collection";
+ $view->page_subtype = "admin_users";
$view->content = new View("admin_users.html");
// @todo: add this as a config option
@@ -29,6 +31,12 @@ class Admin_Users_Controller extends Admin_Controller {
$builder = db::build();
$user_count = $builder->from("users")->count_records();
+ // Pagination info
+ $view->page = $page;
+ $view->page_size = $page_size;
+ $view->children_count = $user_count;
+ $view->max_pages = ceil($view->children_count / $view->page_size);
+
$view->content->pager = new Pagination();
$view->content->pager->initialize(
array("query_string" => "page",
diff --git a/modules/user/views/admin_users.html.php b/modules/user/views/admin_users.html.php
index a7bd6b27..033c9dae 100644
--- a/modules/user/views/admin_users.html.php
+++ b/modules/user/views/admin_users.html.php
@@ -110,7 +110,7 @@
- = $pager ?>
+ = $theme->paginator() ?>
diff --git a/themes/admin_wind/views/pager.html.php b/themes/admin_wind/views/pager.html.php
deleted file mode 100644
index 5fff5845..00000000
--- a/themes/admin_wind/views/pager.html.php
+++ /dev/null
@@ -1,44 +0,0 @@
-
- // See http://docs.kohanaphp.com/libraries/pagination ?>
-
diff --git a/themes/admin_wind/views/paginator.html.php b/themes/admin_wind/views/paginator.html.php
new file mode 100644
index 00000000..3cb0223d
--- /dev/null
+++ b/themes/admin_wind/views/paginator.html.php
@@ -0,0 +1,88 @@
+
+
+// This is a generic paginator for admin collections. Depending on the page type, there are
+// different sets of variables available. With this data, you can make a paginator that
+// lets you say "You're viewing photo 5 of 35", or "You're viewing photos 10 - 18 of 37"
+// for album views.
+
+//
+// Available variables for all page types:
+// $page_type - "collection", "item", or "other"
+// $page_subtype - "album", "movie", "photo", "tag", etc.
+// $previous_page_url - the url to the previous page, if there is one
+// $next_page_url - the url to the next page, if there is one
+// $total - the total number of photos in this album
+//
+// Available for the "collection" page types:
+// $page - what page number we're on
+// $max_pages - the maximum page number
+// $page_size - the page size
+// $first_page_url - the url to the first page, or null if we're on the first page
+// $last_page_url - the url to the last page, or null if we're on the last page
+// $first_visible_position - the position number of the first visible photo on this page
+// $last_visible_position - the position number of the last visible photo on this page
+//
+// Available for "item" page types:
+// $position - the position number of this photo
+//
+?>
+
+
+ -
+ if ($page_type == "collection"): ?>
+ if (isset($first_page_url)): ?>
+
+ = t("First") ?>
+ else: ?>
+
+ = t("First") ?>
+ endif ?>
+ endif ?>
+
+ if (isset($previous_page_url)): ?>
+
+ = t("Previous") ?>
+ else: ?>
+
+ = t("Previous") ?>
+ endif ?>
+
+
+ -
+ if ($total): ?>
+ if ($page_type == "collection"): ?>
+ = /* @todo This message isn't easily localizable */
+ t2("Viewing %from_number of %count",
+ "Viewing %from_number - %to_number of %count",
+ $total,
+ array("from_number" => $first_visible_position,
+ "to_number" => $last_visible_position,
+ "count" => $total)) ?>
+ else: ?>
+ = t("%position of %total", array("position" => $position, "total" => $total)) ?>
+ endif ?>
+ else: ?>
+ = t("No photos") ?>
+ endif ?>
+
+
+ -
+ if (isset($next_page_url)): ?>
+
+ = t("Next") ?>
+ else: ?>
+
+ = t("Next") ?>
+ endif ?>
+
+ if ($page_type == "collection"): ?>
+ if (isset($last_page_url)): ?>
+
+ = t("Last") ?>
+ else: ?>
+
+ = t("Last") ?>
+ endif ?>
+ endif ?>
+
+
--
cgit v1.2.3
From ebdc97b140fc5fce83d25da43b8bfcd595315ce4 Mon Sep 17 00:00:00 2001
From: Automatic Build Number Updater
Date: Tue, 26 Apr 2011 09:49:52 -0700
Subject: Automated update of .build_number to 141 for branch master Last
update: c6d1d6a6aed96f772690b74ac0be482bc2128a8d (1 commits ago)
---
.build_number | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.build_number b/.build_number
index b9dbbf41..69e66c62 100644
--- a/.build_number
+++ b/.build_number
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
-build_number=140
+build_number=141
--
cgit v1.2.3
From 466b24307c4ac827cd4075a07a5fff567b6f4093 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Tue, 26 Apr 2011 21:01:36 -0700
Subject: Hide the paginator when there are no children. #1721.
---
themes/admin_wind/views/paginator.html.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/themes/admin_wind/views/paginator.html.php b/themes/admin_wind/views/paginator.html.php
index 3cb0223d..b46d9741 100644
--- a/themes/admin_wind/views/paginator.html.php
+++ b/themes/admin_wind/views/paginator.html.php
@@ -27,6 +27,7 @@
//
?>
+ if ($total): ?>
-
if ($page_type == "collection"): ?>
@@ -61,8 +62,6 @@
else: ?>
= t("%position of %total", array("position" => $position, "total" => $total)) ?>
endif ?>
- else: ?>
- = t("No photos") ?>
endif ?>
@@ -86,3 +85,4 @@
endif ?>
+ endif ?>
\ No newline at end of file
--
cgit v1.2.3
From 77875e2fab86c9fc74c775545cd7df6b9a0fbc40 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Tue, 26 Apr 2011 21:01:58 -0700
Subject: Include jquery.scrollTo.js. Fixes #1720.
---
themes/admin_wind/views/admin.html.php | 1 +
1 file changed, 1 insertion(+)
diff --git a/themes/admin_wind/views/admin.html.php b/themes/admin_wind/views/admin.html.php
index 65473e57..e19c6aeb 100644
--- a/themes/admin_wind/views/admin.html.php
+++ b/themes/admin_wind/views/admin.html.php
@@ -29,6 +29,7 @@
= $theme->script("gallery.ajax.js") ?>
= $theme->script("gallery.dialog.js") ?>
= $theme->script("superfish/js/superfish.js") ?>
+ = $theme->script("jquery.scrollTo.js") ?>
= $theme->admin_head() ?>
--
cgit v1.2.3
From 743e2f88d8cbba7ea5f7b3b78ab721c141d1ec99 Mon Sep 17 00:00:00 2001
From: Bharat Mediratta
Date: Tue, 26 Apr 2011 21:02:43 -0700
Subject: Overhaul the Admin > Content > Comments page. Use a tabbed interface
for consistency with other parts of the admin UI (ie: G2 import).
The UI is now Ajax driven because that's how jQuery tabs works best in
this case. This requires a little finagling in JS to get the
paginator links to load properly. While I'm in there, add a paginator
at the top of the table, make the buttons in the delete tab sane and
smooth scroll back to the top of the tab when switching pages.
Fixes #1702
---
.../comment/controllers/admin_manage_comments.php | 32 ++--
.../comment/views/admin_manage_comments.html.php | 211 +++------------------
.../views/admin_manage_comments_queue.html.php | 157 +++++++++++++++
3 files changed, 205 insertions(+), 195 deletions(-)
create mode 100644 modules/comment/views/admin_manage_comments_queue.html.php
diff --git a/modules/comment/controllers/admin_manage_comments.php b/modules/comment/controllers/admin_manage_comments.php
index effefcbb..72684e70 100644
--- a/modules/comment/controllers/admin_manage_comments.php
+++ b/modules/comment/controllers/admin_manage_comments.php
@@ -28,8 +28,10 @@ class Admin_Manage_Comments_Controller extends Admin_Controller {
->where("updated", "<", db::expr("UNIX_TIMESTAMP() - 86400 * 7"))
->execute();
- // Redirect to the appropriate queue
- url::redirect("admin/manage_comments/queue/unpublished");
+ $view = new Admin_View("admin.html");
+ $view->content = new View("admin_manage_comments.html");
+ $view->content->menu = $this->_menu($this->_counts());
+ print $view;
}
public function menu_labels() {
@@ -43,15 +45,11 @@ class Admin_Manage_Comments_Controller extends Admin_Controller {
public function queue($state) {
$page = max(Input::instance()->get("page"), 1);
- $view = new Admin_View("admin.html");
- $view->page_title = t("Manage comments");
- $view->page_type = "collection";
- $view->page_subtype = "admin_comments";
- $view->content = new View("admin_manage_comments.html");
- $view->content->counts = $this->_counts();
- $view->content->menu = $this->_menu($view->content->counts);
- $view->content->state = $state;
- $view->content->comments = ORM::factory("comment")
+ $view = new Gallery_View("admin_manage_comments_queue.html");
+ $view->counts = $this->_counts();
+ $view->menu = $this->_menu($view->counts);
+ $view->state = $state;
+ $view->comments = ORM::factory("comment")
->order_by("created", "DESC")
->order_by("id", "DESC")
->where("state", "=", $state)
@@ -59,11 +57,21 @@ class Admin_Manage_Comments_Controller extends Admin_Controller {
->offset(($page - 1) * self::$items_per_page)
->find_all();
- // Pagination info
+ // This view is not themed so we can't use $theme->url() in the view and have to
+ // reproduce Gallery_View::url() logic here.
+ $atn = theme::$admin_theme_name;
+ $view->fallback_avatar_url = url::abs_file("themes/$atn/images/avatar.jpg");
+
$view->page = $page;
+ $view->page_type = "collection";
+ $view->page_subtype = "admin_comments";
$view->page_size = self::$items_per_page;
$view->children_count = $this->_counts()->$state;
$view->max_pages = ceil($view->children_count / $view->page_size);
+
+ // Also we want to use $theme->paginator() so we need a dummy theme
+ $view->theme = $view;
+
print $view;
}
diff --git a/modules/comment/views/admin_manage_comments.html.php b/modules/comment/views/admin_manage_comments.html.php
index e7a61837..e3c8546c 100644
--- a/modules/comment/views/admin_manage_comments.html.php
+++ b/modules/comment/views/admin_manage_comments.html.php
@@ -2,200 +2,45 @@
-
-