summaryrefslogtreecommitdiff
path: root/system
AgeCommit message (Collapse)Author
2013-01-25Follow-on to 8e954cf5f0be61eb9ac6fa6e8f04ee6dcf4aaf23 - use HTTP_HOST if ↵Bharat Mediratta
there's no SERVER_NAME
2013-01-25Use SERVER_NAME instead of HTTP_HOST. Fixes #1963.Bharat Mediratta
2012-08-11the HTTP header Cache-Control must contain "public" in order to allow ↵Gerhard Schlager
caching of resources when HTTPS is used
2012-05-19Filter out all style attributes - we don't want them. Further fix for #1849.Bharat Mediratta
2012-05-15Revert "Verify that where() clauses are well formed. Fixes #1865."Bharat Mediratta
This reverts commit 6a6b3f90f36293a40cba091c3ac387abb64f3c1a.
2012-05-14Verify that where() clauses are well formed. Fixes #1865.Bharat Mediratta
2012-05-05Wrap the loop around all regexes for better efficiency. Fixes #1849.Bharat Mediratta
2012-04-23Don't call ob_end_clean() if PHP >= 5.4. Fixes #1839. Thanks toBharat Mediratta
Christopher Kunz and Avuton Olrich for the info.
2010-11-18Fix a bug in ORM where calling reload() on an unloaded instance returns theBharat Mediratta
first instance in the database, which is super bad. Kohana ticket: http://dev.kohanaframework.org/issues/3397 Related G3 ticket: http://sourceforge.net/apps/trac/gallery/ticket/1489
2010-11-07Force the new geometry in the ImageMagick crop() function.Bharat Mediratta
Fixes http://dev.kohanaframework.org/issues/3384
2010-10-09Fix for http://dev.kohanaframework.org/issues/3317 -- don't try to ↵Bharat Mediratta
implicitly convert a string into an array.
2010-07-28Put the having clause after the group by clause to resolve this upstream issue:Bharat Mediratta
http://dev.kohanaframework.org/issues/2923
2010-07-10Replace … with …Bharat Mediratta
UTF-8 symbols are much more tractable with filters like HTML escaping. Follow-on fix to ticket #1184.
2010-02-28Fix Kohana's internal cache for Gallery's usage pattern. Instead of deleting ↵Andy Staudacher
the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths. Benefits for Gallery: - There are about 3000 is_file() invocations for a photo / album page in a vanilla Gallery installation. These are mostly triggered by Kohana::find_file(). - Enabling internal_cache doesn't help at all (see explanation below). The number of is_file() invocations is about the same with or without this cache. - With this patch, more than 95% of these invocations are gone. The cache works as intended. Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run. 1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery. 2. Kohana::setup() loads find_file cache from disk. 3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense). 4. Request processing starts, and thus 80+% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache. The patch doesn't have a significant impact on performance for Kohana applications which don't change their include paths at runtime (after Kohana::setup). And the patch should benefit all Kohana applications which have modules / extensions, i.e. which first need to bootstrap Kohana before they can load a list of all active modules from the database.
2010-02-21Revert "Fix Kohana's internal cache for Gallery's usage pattern."Andy Staudacher
Waiting for feedback from Kohana devevelopers before applying the patch to Gallery 3. This reverts commit 336c3bd264b4af2ab74fe1262366ad6f2e705451.
2010-02-21Fix Kohana's internal cache for Gallery's usage pattern. Instead of deleting ↵Andy Staudacher
the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths. Benefits for Gallery: - There are about 3000 is_file() invocations for a photo / album page in a vanilla Gallery installation. These are mostly triggered by Kohana::find_file(). - Enabling internal_cache doesn't help at all (see explanation below). The number of is_file() invocations is about the same with or without this cache. - With this patch, more than 95% of these invocations are gone. The cache works as intended. Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run. 1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery. 2. Kohana::setup() loads find_file cache from disk. 3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense). 4. Request processing starts, and thus 80+% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache. The patch doesn't have a significant impact on performance for Kohana applications which don't change their include paths at runtime (after Kohana::setup). And the patch should benefit all Kohana applications which have modules / extensions, i.e. which first need to bootstrap Kohana before they can load a list of all active modules from the database.
2010-02-21Revert "Fix Kohana's internal cache for Gallery's usage pattern."Andy Staudacher
This reverts commit 5ddd7c9677b644396981de7df8176a3b168ffe21.
2010-02-21Fix Kohana's internal cache for Gallery's usage pattern.Andy Staudacher
Adds a core.internal_cache_read_only config variable to Kohana's internals. Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run. 1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery. 2. Kohana::setup() loads find_file cache from disk. 3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense). 4. Request processing starts, and thus 80% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache. In the case of my small Gallery installation, we're talking about 3100 is_file() invocations per request with or without internal_cache enabled. With this fix, this number is down to 800 invocations. The basic idea is that we treat the cache as read only and don't write any (possibly dirty) values to it in memory until we're sure that the include path won't change later on in the request processing. Once we know the list of active modules and themes, we can update core.modules and finally flip the read-only state of the cache and start writing to it.
2010-02-21Fix random queries (such as for the random image block) for locales that ↵Andy Staudacher
don't use a period as decimal separator of floating point numbers (such as de_DE). (Integrating a fix Kohana's SQL generation for floating point numbers. See http://dev.kohanaframework.org/issues/2636.)
2010-01-18Updated Kohana to r4742Bharat Mediratta
2010-01-07remove unused calculation of max-ageTim Almdal
2010-01-06Typo when reapply the patch for Kohana ticket #2477Tim Almdal
2010-01-06Updated Kohana to r4737Tim Almdal
2010-01-04Apply patch for Kohana ticket #2477Tim Almdal
2009-12-25Prevent form::dropdown from overzealously escaping ampersands by applying ↵Bharat Mediratta
this diff: http://dev.kohanaframework.org/attachments/1490/form.diff Upstream ticket: http://dev.kohanaframework.org/issues/2463
2009-12-23Updated Kohana to r4728Bharat Mediratta
2009-12-23Revert "Fix preamble issues. Upstream tickets:"Bharat Mediratta
This reverts commit b2291a0e34234ee30ea1d80b70122b68a8869917.
2009-12-22Back out my temporary fix for http://dev.kohanaframework.org/issues/2384Bharat Mediratta
now that the real fix is in.
2009-12-22Fix preamble issues. Upstream tickets:Bharat Mediratta
http://dev.kohanaframework.org/issues/2457 http://dev.kohanaframework.org/issues/2458
2009-12-21Updated Kohana to r4724Bharat Mediratta
2009-11-26Make ORM::__call() always return an ORM so that it's chainable.Bharat Mediratta
2009-11-24Update to Kohana r4684 which is now Kohana 2.4 and has substantialBharat Mediratta
changes.
2009-11-01Update the modified with a local fix for Kohana ticket #2298Tim Almdal
2009-10-23Apply local fix for Kohana ticket 2276.Tim Almdal
2009-09-04Updated upstream to r4554Bharat Mediratta
2009-09-01XSS escape in form helper and forge where missing.Andy Staudacher
2009-08-29Undo url helper changes - url methods no longer return a SafeString.Andy Staudacher
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
2009-08-29Refactor all calls of p::clean() to SafeString::of() and p::purify() to ↵Andy Staudacher
SafeString::purify(). Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
2009-07-23Improve PgSQL compatibility in KohanaRomain LE DISEZ
( see http://dev.kohanaphp.com/issues/1855 ) (cherry picked from commit 8cbf43ed2abe9772045766e598bb9fe3d4def983)
2009-07-23Use BOOLEAN instead of integer to describe the permissions :Romain LE DISEZ
- DENY = false - ALLOW = true - UNKNOW = null (for intent only) - INHERIT = null (for cache) Upgrade is not included for now. (cherry picked from commit 719c59e0402464a0e2b14915f6d10218ff5d4729)
2009-07-21Updated Kohana to r4468Bharat Mediratta
2009-06-30Updated Kohana to r4434Bharat Mediratta
2009-06-30Revert "Add Session::abort_save() to Kohana."Bharat Mediratta
Obsoleted by upstream fix. This reverts commit 06f066164f60fe0babbc7a480e6319a0702e0c46.
2009-06-21Add Session::abort_save() to Kohana.Bharat Mediratta
Filed upstream as: http://dev.kohanaphp.com/issues/1801
2009-06-06Update Kohana to r4409Bharat Mediratta
2009-05-29Update Kohana to r4374Bharat Mediratta
2009-05-28Revert "Change Kohana::include_path() to put APPPATH (core) at the end of the"Bharat Mediratta
This reverts commit 7e3705540875ac30e9610c5a608fe74399afd2b0. No longer necessary now that we're putting all the code into modules/gallery, which we can force to be at the end of the module path.
2009-05-27Rename 'kohana' to 'system' to conform to the Kohana filesystem layout. I'm ↵Bharat Mediratta
comfortable with us not clearly drawing the distinction about the fact that it's Kohana.