Age | Commit message (Collapse) | Author |
|
there's no SERVER_NAME
|
|
|
|
caching of resources when HTTPS is used
|
|
|
|
This reverts commit 6a6b3f90f36293a40cba091c3ac387abb64f3c1a.
|
|
|
|
|
|
Christopher Kunz and Avuton Olrich for the info.
|
|
first instance in the database, which is super bad.
Kohana ticket:
http://dev.kohanaframework.org/issues/3397
Related G3 ticket:
http://sourceforge.net/apps/trac/gallery/ticket/1489
|
|
Fixes http://dev.kohanaframework.org/issues/3384
|
|
implicitly convert a string into an array.
|
|
http://dev.kohanaframework.org/issues/2923
|
|
UTF-8 symbols are much more tractable with filters like HTML escaping.
Follow-on fix to ticket #1184.
|
|
the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths.
Benefits for Gallery:
- There are about 3000 is_file() invocations for a photo / album page in a vanilla Gallery installation. These are mostly triggered by Kohana::find_file().
- Enabling internal_cache doesn't help at all (see explanation below). The number of is_file() invocations is about the same with or without this cache.
- With this patch, more than 95% of these invocations are gone. The cache works as intended.
Kohana's internal_cache for find_file wasn't working in Gallery because
the cache would be emptied on each request after reading it from disk and
before most lookups would run.
1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
2. Kohana::setup() loads find_file cache from disk.
3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
4. Request processing starts, and thus 80+% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache.
The patch doesn't have a significant impact on performance for Kohana applications which don't change their include paths at runtime (after Kohana::setup). And the patch should benefit all Kohana applications which have modules / extensions, i.e. which first need to bootstrap Kohana before they can load a list of all active modules from the database.
|
|
Waiting for feedback from Kohana devevelopers before applying the patch to Gallery 3.
This reverts commit 336c3bd264b4af2ab74fe1262366ad6f2e705451.
|
|
the whole find_files cache when ever include_paths (=core.modules) change, keep a separate find_files cache for each set of include_paths.
Benefits for Gallery:
- There are about 3000 is_file() invocations for a photo / album page in a vanilla Gallery installation. These are mostly triggered by Kohana::find_file().
- Enabling internal_cache doesn't help at all (see explanation below). The number of is_file() invocations is about the same with or without this cache.
- With this patch, more than 95% of these invocations are gone. The cache works as intended.
Kohana's internal_cache for find_file wasn't working in Gallery because
the cache would be emptied on each request after reading it from disk and
before most lookups would run.
1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
2. Kohana::setup() loads find_file cache from disk.
3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
4. Request processing starts, and thus 80+% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache.
The patch doesn't have a significant impact on performance for Kohana applications which don't change their include paths at runtime (after Kohana::setup). And the patch should benefit all Kohana applications which have modules / extensions, i.e. which first need to bootstrap Kohana before they can load a list of all active modules from the database.
|
|
This reverts commit 5ddd7c9677b644396981de7df8176a3b168ffe21.
|
|
Adds a core.internal_cache_read_only config variable to Kohana's internals.
Kohana's internal_cache for find_file wasn't working in Gallery because the cache would be emptied on each request after reading it from disk and before most lookups would run.
1. Bootstrap sets initial core.modules (= include path): forge, kohana23_compat, gallery.
2. Kohana::setup() loads find_file cache from disk.
3. Gallery loads list of active modules and themes, and updates the core.modules value (=include path), which forces the internal find_file cache to be empties (which makes sense).
4. Request processing starts, and thus 80% of all Kohana::find_file() triggered is_file() invocations start off with an empty find_file cache.
In the case of my small Gallery installation, we're talking about 3100 is_file() invocations per request with or without internal_cache enabled. With this fix, this number is down to 800 invocations.
The basic idea is that we treat the cache as read only and don't write any (possibly dirty) values to it in memory until we're sure that the include path won't change later on in the request processing. Once we know the list of active modules and themes, we can update core.modules and finally flip the read-only state of the cache and start writing to it.
|
|
don't use a period as decimal separator of floating point numbers (such as de_DE).
(Integrating a fix Kohana's SQL generation for floating point numbers. See http://dev.kohanaframework.org/issues/2636.)
|
|
|
|
|
|
|
|
|
|
|
|
this diff:
http://dev.kohanaframework.org/attachments/1490/form.diff
Upstream ticket: http://dev.kohanaframework.org/issues/2463
|
|
|
|
This reverts commit b2291a0e34234ee30ea1d80b70122b68a8869917.
|
|
now that the real fix is in.
|
|
http://dev.kohanaframework.org/issues/2457
http://dev.kohanaframework.org/issues/2458
|
|
|
|
|
|
changes.
|
|
|
|
|
|
|
|
|
|
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
|
|
SafeString::purify().
Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
|
|
( see http://dev.kohanaphp.com/issues/1855 )
(cherry picked from commit 8cbf43ed2abe9772045766e598bb9fe3d4def983)
|
|
- DENY = false
- ALLOW = true
- UNKNOW = null (for intent only)
- INHERIT = null (for cache)
Upgrade is not included for now.
(cherry picked from commit 719c59e0402464a0e2b14915f6d10218ff5d4729)
|
|
|
|
|
|
Obsoleted by upstream fix.
This reverts commit 06f066164f60fe0babbc7a480e6319a0702e0c46.
|
|
Filed upstream as: http://dev.kohanaphp.com/issues/1801
|
|
|
|
|
|
This reverts commit 7e3705540875ac30e9610c5a608fe74399afd2b0.
No longer necessary now that we're putting all the code into
modules/gallery, which we can force to be at the end of the module
path.
|
|
comfortable with us not clearly drawing the distinction about the fact that it's Kohana.
|