summaryrefslogtreecommitdiff
path: root/modules
AgeCommit message (Collapse)Author
2013-03-12#2057 - Revise item name and slug validation - backslashes, refactor, error ↵shadlaws
messages. - disallowed backslashes in item validation. - refactored the validation logic in the item model a bit. - added no_backslash error messages in edit album/photo/movie forms. - fixed error messages in add album forum (some missing, some text different from edit) - added unit tests - updated to v58 to correct any existing backslashes in item names
2013-03-11Merge pull request #204 from jozefs/issue1838Bharat Mediratta
#1838 - thumb_proportion should have a minimum size.
2013-03-11Merge pull request #207 from shadlaws/fix_siblings_callbackBharat Mediratta
Fix Theme_View::siblings bug - limit and offset reversed in sibling_callback.
2013-03-11Merge pull request #206 from shadlaws/fix_2050Bharat Mediratta
#2050 - Update Admin_View to handle events like Theme_View.
2013-03-11Fix Theme_View::siblings bug - limit and offset reversed in sibling_callback.shadlaws
I wonder if this could be causing some random issues I see on the forums...
2013-03-11Merge pull request #205 from shadlaws/fix_2053Bharat Mediratta
#2053 - Change all .bind() to .on() for jQuery future-proofing.
2013-03-11Merge pull request #200 from shadlaws/fix_2048Bharat Mediratta
#2048 - Remove unneeded jquery.autocomplete.css/js inclusions.
2013-03-11#2053 - Change all .bind() to .on() for jQuery future-proofing.shadlaws
- on/off are preferred to bind/unbind, live/die, and delegate/undelegate in jQuery 1.7+ - they're likely on the road toward deprecation, so let's replace them now.
2013-03-11Themes can choose child thumbnail when asking for proportion.Jozef Selesi
This helps themes better calculate an item's container size, for cases when the first item significantly differs in size from the rest. Trac-Ticket: #1838
2013-03-11Themes can set minimum thumbnail size when calculating proportions.Jozef Selesi
This prevents broken item rendering when thumbnails are smaller than the theme design allows. Trac-Ticket: #1838
2013-03-11#2050 - Update Admin_View to handle events like Theme_View.shadlaws
- changed Admin_View event handling to reflect that of Theme_View (gallery_theme gets called first, admin theme gets called last, debug mode isn't called for body_attributes and gets g-clear-fix)
2013-03-10#2048 - Remove unneeded jquery.autocomplete.css/js inclusions.shadlaws
- removed autocomplete.css/js calls in server_add, tag, and g2_import. - revised xss_data.txt golden file (line number changes only).
2013-03-10Follow-on fix: if tests throw an exception, don't throw another by calling ↵shadlaws
an undefined variable.
2013-03-09Merge pull request #196 from shadlaws/fix_2046Bharat Mediratta
#2046 - Change Gallery over to using MediaElementJS as its movie player
2013-03-09Merge pull request #197 from shadlaws/followon_2003Bharat Mediratta
Follow-on to #2003 - Fix innocuous typo (unneeded semi-colon).
2013-03-09Follow-on to #1935 - Ensure ffmpeg is executable, remove possible doubled "/".shadlaws
- movie::find_ffmpeg - made it use is_executable instead of just file_exists. - system::find_binary - removed possible doubled "/" in paths.
2013-03-09#2046 - Change Gallery over to using MediaElementJS as its movie player.shadlaws
2013-03-08Follow-on to #2003 - Fix innocuous typo (unneeded semi-colon).shadlaws
2013-03-07#2015 - Update ExtJS to 3.4.0 (in sync with gallery3-vendor).shadlaws
2013-03-06Follow-on fix: count errors as well as test failures.Bharat Mediratta
2013-03-06Set exit status to the number of failed tests. This should fix issues with ↵Bharat Mediratta
Travis.
2013-03-06Revert "Return "1" to CLI if not all unit tests pass.". We're not successfullyBharat Mediratta
passing back $all_passed because the function doesn't take it by reference. Which is my fault because I gave Jozefs bad advice. But I don't think it's necessary anyway so I'm going to try a different approach. This reverts commit 4fe07c6b0a341b0b99ee1b051f7c0bdfda572e04. Conflicts: modules/gallery_unit_test/controllers/gallery_unit_test.php
2013-03-06Explicitly print out the exit status to see if I can narrow down failures on ↵Bharat Mediratta
Travis.
2013-03-06Follow-on for #2043. Fix some tests that made bad assumptions aboutBharat Mediratta
the state of the world. These were uncovered when we ran the tests on Travis which runs the tests in a different order than what I (and apparently others) use on their dev boxes.
2013-03-05Follow-on to 384bc7afc86be706bf61def09afc8306cdad2443 for #2033Bharat Mediratta
Update golden file for XSS test.
2013-03-05Remove stray line of debug output.Bharat Mediratta
2013-03-05#2040 - Deactivate modules that no longer exist.shadlaws
- added module::deactivate_missing_modules() - revised module::deactivate() to change log message if the module is missing - added call to new function in module::get_obsolete_modules_message() - added call to new function when loading admin/maintenance menu
2013-03-04Merge pull request #187 from shadlaws/2033_followonBharat Mediratta
Follow-on to #2033 - Change variables and js script loading for Flash Fl...
2013-03-04Merge pull request #185 from shadlaws/minifyjs_20130304Bharat Mediratta
Minify (and re-minify) JS libraries (in sync with gallery3-vendor).
2013-03-04Merge pull request #183 from shadlaws/fix_2037Bharat Mediratta
#2037 - Fix bug with "item_before_update" event in item model.
2013-03-04Follow-on to #2033 - Change variables and js script loading for Flash ↵shadlaws
Flowplayer. - changed movie_img event variable names to have "flash" in them. - moved flowplayer.js loading from page.html.php to movieplayer-flash. - removed conditional loading for small, photo-specific JS files in page.html.php to keep combined JS consistent between page types (better for caching).
2013-03-04Return "1" to CLI if not all unit tests pass.Jozef Selesi
2013-03-04Minify (and re-minify) JS libraries (in sync with gallery3-vendor).shadlaws
- minified jQuery libraries. - re-minified flowplayer, json2-min, and extjs using new minimizer (more efficient, keeps copyrights).
2013-03-03#2037 - Fix bug with "item_before_update" event in item model.shadlaws
2013-03-03Merge pull request #179 from shadlaws/fix_2034Bharat Mediratta
#2034 - Add webm and ogv as valid movie types.
2013-03-03Follow-on to #2033 - Rename movieplayer.html.php to movieplayer-flash.html.phpshadlaws
- renamed file with "-flash" to make room for html5 player - updated item model and xss_data.txt to reflect changes --HG-- rename : modules/gallery/views/movieplayer.html.php => modules/gallery/views/movieplayer-flash.html.php
2013-03-03#2034 - Add webm and ogv as valid movie types.shadlaws
- added them to legal_file helper - revised unit tests
2013-03-02#2033 - Add Flowplayer 5 to play HTML5 videos.shadlaws
- add Flowplayer 5 to lib/flowplayer-html5 - move existing Flash Flowplayer to lib/flowplayer-flash - update page.html.php and movieplayer.html.php --HG-- rename : lib/flowplayer.controls.swf => lib/flowplayer-flash/flowplayer.controls.swf rename : lib/flowplayer.js => lib/flowplayer-flash/flowplayer.js rename : lib/flowplayer.pseudostreaming-byterange.swf => lib/flowplayer-flash/flowplayer.pseudostreaming-byterange.swf rename : lib/flowplayer.pseudostreaming.swf => lib/flowplayer-flash/flowplayer.pseudostreaming.swf rename : lib/flowplayer.swf => lib/flowplayer-flash/flowplayer.swf
2013-03-02Merge pull request #177 from shadlaws/fix_2032Bharat Mediratta
#2032 - Fix short form submit/cancel button formatting.
2013-03-02#2032 - Fix short form submit/cancel button formatting.shadlaws
- fixed the height of the submit buttons to match the input box - changed the cancel links into cancel buttons - added the hover effect to the buttons when used in in_place_edit (e.g. admin/tags)
2013-03-02#2031 - Add class_exists() before method_exists() if class existence is unknown.shadlaws
- fixed all instances of this in core code - deleted previous Zend Guard Loader workaround in MY_Kohana.php - updated Bootstrap.php to reflect deleted MY_Kohana.php
2013-02-27Merge pull request #170 from shadlaws/fix_2022Bharat Mediratta
#2022 - Fix handling of watermark dialog errors.
2013-02-27Merge pull request #169 from shadlaws/fix_2021Bharat Mediratta
#2021 - Cleanup thumb_dirty and resize_dirty instances.
2013-02-27#2022 - Fix handling of watermark dialog errors.shadlaws
- admin_watermarks: changed header at end of form_add() from text/html to text/plain - admin_watermarks: added header at end of form_edit() and form_delete() just like form_add() (currently omitted) - admin_watermarks/gallery.dialog.js: removed unnecessary encode/decode workaround
2013-02-27#2021 - Cleanup thumb_dirty and resize_dirty instances.shadlaws
- g2_import: changed "false" assignment to "0" assignment for consistency. - admin_theme_options: removed unused variables (they're called/used nowhere else). - graphics: removed stanza that clears thumb_dirty and resize_dirty and returns if we have no ops. This has no effect on Gallery currently (for one, graphics::generate doesn't normally get called on an item with no dirty flags), but can inconsistently set resize_dirty of albums and movies to 0 where it's otherwise left at 1. Going forward, it may be useful to be consistent here. - gallery_installer: added v57 stanza to correct any resize_dirty flags of movies/albums that were previously reset to 0. - module.info, install.sql: update to v57
2013-02-26#2010 - Revise item::find_by_path to search for jpg-converted items.shadlaws
- added extra $var_subdir argument to item::find_by_path. - changed item::find_by_path to use $var_subdir to detect if we should look for a jpg-converted item or not (e.g. movie thumbs) - moved the album thumb detection to item::find_by_path to ensure it knows to look for an exact album match. - added more sanity checks to item::find_by_path (now has fewer false positive possibilities). - updated file_proxy to remove the need to guess different movie files. - updated File_Proxy_Controller - new sanity checks catch previously undetected bug. - added additional unit tests for item::find_by_path.
2013-02-26Follow-on from autocomplete updates.shadlaws
(9345dde83e1f092a9309c45282dc21e3fd408875, d632ef3e50252d388c272cacd29e8cc6e4949cec) - gallery module: added loading-small.gif (so all themes have it by default) - gallery module: added css for .ui-autocomplete-loading (copied from .g-loading-small in wind, but without !important so other themes can override it) - gallery module: updated upgrader.html.php to use new image (removes theme dependence) - wind theme: removed outdated css for .ac_loading (not used in v3.0.5, either) - server_add module: removed multiple argument from autocomplete (doesn't work well with it)
2013-02-25Follow-on from autocomplete and gallery.panel.js revisions.shadlaws
(9345dde83e1f092a9309c45282dc21e3fd408875, d632ef3e50252d388c272cacd29e8cc6e4949cec, fd012276cbf03cc1dc7b8da10aac5cc6f26326c6) - revised xss_data.txt golden file (no new cases). - escaped translated string in admin_users.html.php (would have otherwise been a new case in xss_data.txt).
2013-02-23Merge pull request #160 from shadlaws/fix_2014Bharat Mediratta
#2014 - Clean up gallery.ajax.js.
2013-02-23#2014 - Clean up gallery.ajax.js.shadlaws
- prepend "data-" in front of non-standard attr to be more standards compliant. - fix formatting.