summaryrefslogtreecommitdiff
path: root/modules
AgeCommit message (Collapse)Author
2013-03-03#2034 - Add webm and ogv as valid movie types.shadlaws
- added them to legal_file helper - revised unit tests
2013-03-02Merge pull request #177 from shadlaws/fix_2032Bharat Mediratta
#2032 - Fix short form submit/cancel button formatting.
2013-03-02#2032 - Fix short form submit/cancel button formatting.shadlaws
- fixed the height of the submit buttons to match the input box - changed the cancel links into cancel buttons - added the hover effect to the buttons when used in in_place_edit (e.g. admin/tags)
2013-03-02#2031 - Add class_exists() before method_exists() if class existence is unknown.shadlaws
- fixed all instances of this in core code - deleted previous Zend Guard Loader workaround in MY_Kohana.php - updated Bootstrap.php to reflect deleted MY_Kohana.php
2013-02-27Merge pull request #170 from shadlaws/fix_2022Bharat Mediratta
#2022 - Fix handling of watermark dialog errors.
2013-02-27Merge pull request #169 from shadlaws/fix_2021Bharat Mediratta
#2021 - Cleanup thumb_dirty and resize_dirty instances.
2013-02-27#2022 - Fix handling of watermark dialog errors.shadlaws
- admin_watermarks: changed header at end of form_add() from text/html to text/plain - admin_watermarks: added header at end of form_edit() and form_delete() just like form_add() (currently omitted) - admin_watermarks/gallery.dialog.js: removed unnecessary encode/decode workaround
2013-02-27#2021 - Cleanup thumb_dirty and resize_dirty instances.shadlaws
- g2_import: changed "false" assignment to "0" assignment for consistency. - admin_theme_options: removed unused variables (they're called/used nowhere else). - graphics: removed stanza that clears thumb_dirty and resize_dirty and returns if we have no ops. This has no effect on Gallery currently (for one, graphics::generate doesn't normally get called on an item with no dirty flags), but can inconsistently set resize_dirty of albums and movies to 0 where it's otherwise left at 1. Going forward, it may be useful to be consistent here. - gallery_installer: added v57 stanza to correct any resize_dirty flags of movies/albums that were previously reset to 0. - module.info, install.sql: update to v57
2013-02-26#2010 - Revise item::find_by_path to search for jpg-converted items.shadlaws
- added extra $var_subdir argument to item::find_by_path. - changed item::find_by_path to use $var_subdir to detect if we should look for a jpg-converted item or not (e.g. movie thumbs) - moved the album thumb detection to item::find_by_path to ensure it knows to look for an exact album match. - added more sanity checks to item::find_by_path (now has fewer false positive possibilities). - updated file_proxy to remove the need to guess different movie files. - updated File_Proxy_Controller - new sanity checks catch previously undetected bug. - added additional unit tests for item::find_by_path.
2013-02-26Follow-on from autocomplete updates.shadlaws
(9345dde83e1f092a9309c45282dc21e3fd408875, d632ef3e50252d388c272cacd29e8cc6e4949cec) - gallery module: added loading-small.gif (so all themes have it by default) - gallery module: added css for .ui-autocomplete-loading (copied from .g-loading-small in wind, but without !important so other themes can override it) - gallery module: updated upgrader.html.php to use new image (removes theme dependence) - wind theme: removed outdated css for .ac_loading (not used in v3.0.5, either) - server_add module: removed multiple argument from autocomplete (doesn't work well with it)
2013-02-25Follow-on from autocomplete and gallery.panel.js revisions.shadlaws
(9345dde83e1f092a9309c45282dc21e3fd408875, d632ef3e50252d388c272cacd29e8cc6e4949cec, fd012276cbf03cc1dc7b8da10aac5cc6f26326c6) - revised xss_data.txt golden file (no new cases). - escaped translated string in admin_users.html.php (would have otherwise been a new case in xss_data.txt).
2013-02-23Merge pull request #160 from shadlaws/fix_2014Bharat Mediratta
#2014 - Clean up gallery.ajax.js.
2013-02-23#2014 - Clean up gallery.ajax.js.shadlaws
- prepend "data-" in front of non-standard attr to be more standards compliant. - fix formatting.
2013-02-23#2013 - Clean up gallery.panel.js.shadlaws
- prepend "data-" in front of non-standard attr to be more standards compliant.
2013-02-23Merge branch 'jquery_190'Bharat Mediratta
2013-02-20#2008 - Add warnings if some active modules are obsolete.shadlaws
- added module::get_obsolete_modules_message function - put message on admin/dashboard - put message on admin/modules - put message on upgrader - updated unit test golden file xss_data
2013-02-18Merge pull request #154 from shadlaws/masterBharat Mediratta
Follow-on to fd0051dab7258c817ff01877bd4324530ce79398 for #2006.
2013-02-18Follow-on to fd0051dab7258c817ff01877bd4324530ce79398 for #2006.shadlaws
- fix unit tests for watermarks, which check for deleted files.
2013-02-18Fix up some tests:Bharat Mediratta
- unlink copied files because they confused File_Structure_Test - update golden files
2013-02-18Merge pull request #150 from shadlaws/fix_zend_guard_loader_issuesBharat Mediratta
#1749, 1754, 1901 - Eliminate incompatibility with Zend Guard Loader.
2013-02-18#1749, 1754, 1901 - Eliminate incompatibility with Zend Guard Loader.shadlaws
- added MY_Kohana to provide wrapper for auto_load(), which loads dummy class when none found. - revised Bootstrap to load MY_Kohana. This is based on the patch described here: http://blog.teatime.com.tw/1/post/403
2013-02-18Merge branch 'jquery_190' of github.com:gallery/gallery3 into jquery_190Bharat Mediratta
2013-02-18Merge branch 'master' into jquery_190Bharat Mediratta
2013-02-18Merge pull request #153 from shadlaws/jquery_autocomplete_compatBharat Mediratta
Moved autocomplete CSS to gallery.css to ensure it works for all themes (incl. admin_wind)
2013-02-18#2007 - Change search box text when only looking in the current album.shadlaws
- search.html.php - updated to use new labels. - search_link.html.php - updated to use new labels. Moved code that determines current album to top, then used it for both the new label and the hidden album input. Resulting form code looks more symmetric to search.html.php.
2013-02-18Moved autocomplete CSS to gallery.css to ensure it works for all themes ↵shadlaws
(including admin_wind).
2013-02-18Password strength indicator fixed for new jQuery. Also cleaned up formatting.shadlaws
2013-02-17#2006 - Add system::mark_file_for_delete API to delete files at shutdown.shadlaws
- added system::mark_file_for_delete to be called to mark a file - added system::delete_marked_files to be called at shutdown to delete the list - amended system::temp_filename to, by default, add the temp name to the list - updated a few other places in code where this should be used
2013-02-17Fix autocomplete for admin_g2_import.Bharat Mediratta
2013-02-17Updated for the new jQuery tabs API.Bharat Mediratta
2013-02-17Fix up autocomplete for admin_server_add - found and fixed some bugsBharat Mediratta
in gallery_autocomplete when "multiple" isn't set. Fixed some harmless syntax issues that js2-mode helpfully pointed out.
2013-02-16Merge branch 'master' into jquery_190Bharat Mediratta
2013-02-15Follow-on to 7bdccade98e76df3a7830bc45bc42321a77c709a to excludeBharat Mediratta
directories for now.
2013-02-15Follow-on to 7bdccade98e76df3a7830bc45bc42321a77c709a - point out that there'sBharat Mediratta
duplicated code in gallery_event.
2013-02-15Every 500th request prune a single old file from var/tmp and var/logs.Bharat Mediratta
Might not be aggressive enough. Fixes #2005.
2013-02-15Dialog sizing, titles, and z-index. This should ensure the small <500px dialogsshadlaws
are correct, all titles are correctly sized, and the dialog boxes go to the top for older themes, too.
2013-02-15Change gallery/bin -> gallery3/bin in the comment since I suspect mostBharat Mediratta
people don't change the name of the directory. Follow-on to 1d7f5e3ab117a6cce8f2a1d3de5e311b74dbee81 for #1935
2013-02-15Merge branch 'master' into jquery_190Bharat Mediratta
2013-02-15Digibug up and vanished. Move the module to contrib for now. ThisBharat Mediratta
will leave the module active in any existing installs that had it active, but that shouldn't cause any negative impact. Fixes #2002.
2013-02-14#2003 - Add admin/movies screen.shadlaws
Added admin/movies screen analogous to the admin/graphics screen so the user can: - see how FFmpeg is configured (path and version, similar to toolkits in admin/graphics) - get some instructions on how to install FFmpeg if not found - change the movie_allow_uploads setting - ask Gallery to rebuild their movie thumbs Specifics: - admin_movies, admin_movies.html (new) - new Movies admin screen - ffmpeg.png (new) - logo for admin screen - movie::get_ffmpeg_version (new) - return version number and date of FFmpeg - form_uploadify.html - change admin message if movie uploads are disabled - gallery_event::admin_menu - added Movies link to Settings - xss_data.txt - updated golden file for unit tests
2013-02-14Follow-on to 9dbe2e15ad9db3b2be53e46bc5f67d382fb4089d for #1999.Bharat Mediratta
Fix an issue where siblings() by itself throws an error. The problem is that Theme_View::siblings() passes a null offset and limit to the callback which gets passed down to search::search_within_album, which creates its query in raw SQL and doesn't check for a null offset/limit. We want a reasonable limit on the size of the set here (and 1000 is probably wayyy too high so lower that to 100) so amend get_siblings to stop using default parameters and actually check the inputs. Author: Bharat Mediratta <bharat@menalto.com> Date: Sat Feb 9 14:53:34 2013 -0500 Extend siblings callbacks to take a $limit and an $offset for navigating large sibling sets. Useful for the thumbnav module since we don't want to iterate a thousand siblings to find the one we care about. Fixes #1999.
2013-02-14Merge pull request #133 from shadlaws/followon_1994Bharat Mediratta
Follow-on to 0312d1b071bd4434ddb3f82888b0323da6bf3732 for #1994.
2013-02-13Merge pull request #143 from mikeage/g2_importBharat Mediratta
Replace = with ==
2013-02-13Replace = with ==Mike Miller
This was my mistake; I didn't test it thoroughly. It results in all g2 mappings being broken!
2013-02-12Merge pull request #134 from shadlaws/fix_2001Bharat Mediratta
#2001 - Make filename sanitizing more consistent.
2013-02-12#2001 - Make filename sanitizing more consistent.shadlaws
- legal_file - added sanitize_filname() to sanitize photo/movie filenames. - admin_watermarks - revised add() to use new function. - item model - added _process_data_file_info() to validate the data file, get its metadata, and sanitize the item name. - item model - revised save() for new items to use _process_data_file_info *before* the slug is checked. - item model - revised save() for updated items to use _process_data_file_info. - item model - revised save() for updated items to sanitize name if changed. - uploader - removed call to smash_extensions (item model does this when it calls sanitize_filename). - Legal_File_Helper_Test - added unit tests for sanitize_filename. - Item_Model_Test - revised existing unit tests based on changes. - Item_Model_Test - added new unit tests for names with legal but incorrect extensions. - Averted take over by HAL with fix #2001...
2013-02-12#1988 - Add movie_allow_uploads option ("always", "never", or "autodetect").shadlaws
- gallery_installer, module.info, install.sql - add movie_allow_uploads variable - movie::allow_uploads (new) - return true if movie_allow_uploads is "always" or "autodetect" and FFmpeg found, false otherwise - legal_file - use movie::allow_uploads instead of movie::find_ffmpeg - Form_Uploadify - use movie::allow_uploads instead of movie::find_ffmpeg
2013-02-10Merge pull request #121 from shadlaws/fix_1935_onlyBharat Mediratta
#1935 - Make FFmpeg easier to install.
2013-02-10Merge pull request #132 from shadlaws/fix_2000Bharat Mediratta
#2000 - Make legal_file::smash_extensions more robust.
2013-02-10Follow-on to 0312d1b071bd4434ddb3f82888b0323da6bf3732 for #1994.shadlaws
- Updated function comments to match revisions. - No functional changes.