| Age | Commit message (Collapse) | Author |
|---|
|
in gallery_autocomplete when "multiple" isn't set. Fixed some
harmless syntax issues that js2-mode helpfully pointed out.
|
|
|
|
directories for now.
|
|
duplicated code in gallery_event.
|
|
Might not be aggressive enough. Fixes #2005.
|
|
are correct, all titles are correctly sized, and the dialog boxes go to
the top for older themes, too.
|
|
people don't change the name of the directory. Follow-on to
1d7f5e3ab117a6cce8f2a1d3de5e311b74dbee81 for #1935
|
|
|
|
will leave the module active in any existing installs that had it
active, but that shouldn't cause any negative impact. Fixes #2002.
|
|
Added admin/movies screen analogous to the admin/graphics screen so the user can:
- see how FFmpeg is configured (path and version, similar to toolkits in admin/graphics)
- get some instructions on how to install FFmpeg if not found
- change the movie_allow_uploads setting
- ask Gallery to rebuild their movie thumbs
Specifics:
- admin_movies, admin_movies.html (new) - new Movies admin screen
- ffmpeg.png (new) - logo for admin screen
- movie::get_ffmpeg_version (new) - return version number and date of FFmpeg
- form_uploadify.html - change admin message if movie uploads are disabled
- gallery_event::admin_menu - added Movies link to Settings
- xss_data.txt - updated golden file for unit tests
|
|
Fix an issue where siblings() by itself throws an error. The problem is that
Theme_View::siblings() passes a null offset and limit to the callback which
gets passed down to search::search_within_album, which creates its query
in raw SQL and doesn't check for a null offset/limit. We want a reasonable
limit on the size of the set here (and 1000 is probably wayyy too high so
lower that to 100) so amend get_siblings to stop using default parameters
and actually check the inputs.
Author: Bharat Mediratta <bharat@menalto.com>
Date: Sat Feb 9 14:53:34 2013 -0500
Extend siblings callbacks to take a $limit and an $offset for navigating
large sibling sets. Useful for the thumbnav module since we don't want to
iterate a thousand siblings to find the one we care about. Fixes #1999.
|
|
Follow-on to 0312d1b071bd4434ddb3f82888b0323da6bf3732 for #1994.
|
|
Replace = with ==
|
|
This was my mistake; I didn't test it thoroughly. It results in all g2 mappings being broken!
|
|
#2001 - Make filename sanitizing more consistent.
|
|
- legal_file - added sanitize_filname() to sanitize photo/movie filenames.
- admin_watermarks - revised add() to use new function.
- item model - added _process_data_file_info() to validate the data file, get its metadata, and sanitize the item name.
- item model - revised save() for new items to use _process_data_file_info *before* the slug is checked.
- item model - revised save() for updated items to use _process_data_file_info.
- item model - revised save() for updated items to sanitize name if changed.
- uploader - removed call to smash_extensions (item model does this when it calls sanitize_filename).
- Legal_File_Helper_Test - added unit tests for sanitize_filename.
- Item_Model_Test - revised existing unit tests based on changes.
- Item_Model_Test - added new unit tests for names with legal but incorrect extensions.
- Averted take over by HAL with fix #2001...
|
|
- gallery_installer, module.info, install.sql - add movie_allow_uploads variable
- movie::allow_uploads (new) - return true if movie_allow_uploads is "always" or "autodetect" and FFmpeg found, false otherwise
- legal_file - use movie::allow_uploads instead of movie::find_ffmpeg
- Form_Uploadify - use movie::allow_uploads instead of movie::find_ffmpeg
|
|
#1935 - Make FFmpeg easier to install.
|
|
#2000 - Make legal_file::smash_extensions more robust.
|
|
- Updated function comments to match revisions.
- No functional changes.
|
|
- Fixed legal_file::smash_extensions.
- Added new unit test.
- Removed duplicated condition in existing unit test.
|
|
large sibling sets. Useful for the thumbnav module since we don't want to
iterate a thousand siblings to find the one we care about. Fixes #1999.
|
|
- system::find_binary - add Gallery's bin subdirectory to search
- system::find_binary - auto-fix permissions if found in Gallery's bin directory
|
|
#1997 - Correct movie dimensions and mime type improperly set by contributed modules.
|
|
#1996 - Add blacklist to legal_file helper.
|
|
#1994 - Make get_file_metadata throw an exception if photo or movie is unidentifiable/illegal.
|
|
- Added code to check/correct movie width, height, and mime in graphics::generate.
As the comment says in the commit, this isn't ideal, but doing it in an upgrade
script wouldn't be very ideal either.
|
|
Adding a blacklist to legal_file could prevent possible security holes arising
from a contributed module that adds file types by user input (e.g. an admin screen).
|
|
unidentifiable/illegal.
- photo & movie helpers: modified to throw exceptions when file is known to be unidentifiable/illegal.
- item model: revised to work with exceptions and be more explicit when the data file is invalid.
- item model: removed duplicate get_file_metadata call for updated items.
- admin_watermarks controller: revised to work with exceptions (really cleans up logic here).
- graphics helper: revised to handle invalid placeholders (a nearly-impossible corner case, but still...).
- photo & movie helper tests: revised to work with exceptions, added new tests for illegal files with valid extensions.
- item model tests: revised to work with exceptions, added new tests for illegal files with valid extensions.
|
|
errors.
- Changed redirect if it finished without failures.
- No change to Upgrader_Controller::index(), since its behavior with an empty vs. undefined failed query is identical.
|
|
|
|
Don't try to use an array index on a function return, that's not supported
in PHP 5.3
|
|
Documentation-only changes to examples used in:
- Item_Model::url
- Item_Model::abs_url
- Item_Model::file_path
- Item_Model::file_url
- Item_Model::resize_path
- Item_Model::resize_url
- Item_Model::thumb_path
- Item_Model::thumb_url
|
|
#1991 - Add options to graphics::mark_dirty to specify type and/or mime type
|
|
- graphics::mark_dirty - added $type and $mime_type as options.
- graphics::mark_dirty - used options to set additional where conditions.
|
|
- Add extra condition to Item_Model_Test::urls_test to test cache busters of missing files.
- Previous commit fixes unit test for empty album url, but now no test checks missing files.
|
|
|
|
|
|
|
|
- jQuery 1.90
- jQuery UI 1.10
- Superfish 1.5.1 (minus all plugins)
- jQuery Form 3.26.0-2013.01.28
Deleted all other jQuery plugins for now.
- Reworked autocomplete to use the latest jQuery code.
- Deleted references to $.browser.msie, no longer supported
- Basic CSS support for autocomplete - lots more work needed there
|
|
Follow-on to f83ed5f8716663a45c9d8e8118bbcf0e2849c3fb for #1982.
|
|
|
|
combining CSS/JS
by touching var/DONT_COMBINE. Fixes #1989.
|
|
- Update xss_test golden file (change line numbers).
|
|
- Fix unit test for album url since empty albums now have thumbnails.
|
|
As the g2_import process is generally assumed to be permanent, the
redirect should be a 301, and not a 302.
|
|
|
|
was breaking all unit tests. Use module::install("gallery") instead
of calling gallery_installer::install directly.
|
|
version. It's redundant. Fixes #1985.
|
|
#1982 - Add placeholder for albums with no album cover.
|
