summaryrefslogtreecommitdiff
path: root/modules
AgeCommit message (Collapse)Author
2013-04-14Golden file update follow-on for c37288f0b24c19813405096c087ab0c7c171c358Bharat Mediratta
2013-04-14Sanitize all key values.Bharat Mediratta
2013-03-14#2058 - Separate uploader logic into Kohana-, Item-Model-, and ↵shadlaws
Uploadify-specific functions. - Added _process_upload() to handle upload file validation with Kohana. - Added _add_item() to handle item creation and validation with the item model (and logs). - Removed these pieces from add_photo(), which is now rather Uploadify-specific. - Used $_FILES to get filename instead of assuming it's substr(basename($tmp_name), 10). - No net functional changes - works just like before.
2013-03-14#2062 - Fix extra/missing spaces in search query.shadlaws
- Every to-be-concatenated string now begins with 1 space and ends with 0 spaces.
2013-03-13Merge pull request #202 from shadlaws/fix_2051Bharat Mediratta
#2051 - Revise how Gallery_View returns combined JS and CSS.
2013-03-13Merge pull request #216 from shadlaws/fix_2061Bharat Mediratta
#2061 - Remove Uploadify from add_photo_form/add_photo_form_completed events.
2013-03-13#2061 - Remove Uploadify from add_photo_form/add_photo_form_completed events.shadlaws
- Added code around event calls in uploader to add Uploadify-specific JS to update the inputs. - Removed Uploadify JS from tag_event. Now it's uploader-agnostic. - Refactored tag_event autocomplete code (no functional changes).
2013-03-13#2059 - Add album name sanitizing similar to photo/movie filename sanitizing.shadlaws
- added legal_file::sanitize_dirname(), analogous to sanitize_filename. - revised item model to use new function when adding or updating an album. - added some legal_file unit tests. - revised some item model unit tests.
2013-03-12Merge pull request #209 from shadlaws/fix_2057Bharat Mediratta
#2057 - Revise item name and slug validation - backslashes, refactor, error messages.
2013-03-12Merge pull request #210 from shadlaws/fix_2055_2056Bharat Mediratta
#2055, 2056 - jQuery updates for .attr("value", [value]) and .keyup(handler).
2013-03-12#2051 - Revise how Gallery_View returns combined JS and CSS.shadlaws
Changed Gallery_View's JS and CSS combining to: - have get_combined() combine all groups if called without arguments. - ensure the "core" group is combined first. - always put links where get_combined() is called, even if combining is disabled (otherwise the order isn't preserved). - add key as cache buster when combining is disabled. - make "LOOKING FOR YOUR CSS/JAVASCRIPT..." comments in get_combined(), not in the theme itself. Also, revised xss_data.txt golden file (line number changes only).
2013-03-12#2057 - Revise item name and slug validation - backslashes, refactor, error ↵shadlaws
messages. - disallowed backslashes in item validation. - refactored the validation logic in the item model a bit. - added no_backslash error messages in edit album/photo/movie forms. - fixed error messages in add album forum (some missing, some text different from edit) - added unit tests - updated to v58 to correct any existing backslashes in item names
2013-03-12#2055, 2056 - jQuery updates for .attr("value", [value]) and .keyup(handler).shadlaws
- changed .attr("value", [value]) to .val([value]) for new jQuery. - changed .keyup(handler) to .on("input keyup", handler) to fire on mouse-only cut'n'paste.
2013-03-12#2054 - Revise albums_form_add.js: update for new jQuery, refactor.shadlaws
- changed "change" event to "input" to catch cut'n'paste - kept "keyup" event for old IE compatibility - removed code duplication by using $(this) and combining events using .on() - replaced attr("value",...) with val() - added quotes around input names
2013-03-11Merge pull request #204 from jozefs/issue1838Bharat Mediratta
#1838 - thumb_proportion should have a minimum size.
2013-03-11Merge pull request #207 from shadlaws/fix_siblings_callbackBharat Mediratta
Fix Theme_View::siblings bug - limit and offset reversed in sibling_callback.
2013-03-11Merge pull request #206 from shadlaws/fix_2050Bharat Mediratta
#2050 - Update Admin_View to handle events like Theme_View.
2013-03-11Fix Theme_View::siblings bug - limit and offset reversed in sibling_callback.shadlaws
I wonder if this could be causing some random issues I see on the forums...
2013-03-11Merge pull request #205 from shadlaws/fix_2053Bharat Mediratta
#2053 - Change all .bind() to .on() for jQuery future-proofing.
2013-03-11Merge pull request #200 from shadlaws/fix_2048Bharat Mediratta
#2048 - Remove unneeded jquery.autocomplete.css/js inclusions.
2013-03-11#2053 - Change all .bind() to .on() for jQuery future-proofing.shadlaws
- on/off are preferred to bind/unbind, live/die, and delegate/undelegate in jQuery 1.7+ - they're likely on the road toward deprecation, so let's replace them now.
2013-03-11Themes can choose child thumbnail when asking for proportion.Jozef Selesi
This helps themes better calculate an item's container size, for cases when the first item significantly differs in size from the rest. Trac-Ticket: #1838
2013-03-11Themes can set minimum thumbnail size when calculating proportions.Jozef Selesi
This prevents broken item rendering when thumbnails are smaller than the theme design allows. Trac-Ticket: #1838
2013-03-11#2050 - Update Admin_View to handle events like Theme_View.shadlaws
- changed Admin_View event handling to reflect that of Theme_View (gallery_theme gets called first, admin theme gets called last, debug mode isn't called for body_attributes and gets g-clear-fix)
2013-03-10#2048 - Remove unneeded jquery.autocomplete.css/js inclusions.shadlaws
- removed autocomplete.css/js calls in server_add, tag, and g2_import. - revised xss_data.txt golden file (line number changes only).
2013-03-10Follow-on fix: if tests throw an exception, don't throw another by calling ↵shadlaws
an undefined variable.
2013-03-09Merge pull request #196 from shadlaws/fix_2046Bharat Mediratta
#2046 - Change Gallery over to using MediaElementJS as its movie player
2013-03-09Merge pull request #197 from shadlaws/followon_2003Bharat Mediratta
Follow-on to #2003 - Fix innocuous typo (unneeded semi-colon).
2013-03-09Follow-on to #1935 - Ensure ffmpeg is executable, remove possible doubled "/".shadlaws
- movie::find_ffmpeg - made it use is_executable instead of just file_exists. - system::find_binary - removed possible doubled "/" in paths.
2013-03-09#2046 - Change Gallery over to using MediaElementJS as its movie player.shadlaws
2013-03-08Follow-on to #2003 - Fix innocuous typo (unneeded semi-colon).shadlaws
2013-03-07#2015 - Update ExtJS to 3.4.0 (in sync with gallery3-vendor).shadlaws
2013-03-06Follow-on fix: count errors as well as test failures.Bharat Mediratta
2013-03-06Set exit status to the number of failed tests. This should fix issues with ↵Bharat Mediratta
Travis.
2013-03-06Revert "Return "1" to CLI if not all unit tests pass.". We're not successfullyBharat Mediratta
passing back $all_passed because the function doesn't take it by reference. Which is my fault because I gave Jozefs bad advice. But I don't think it's necessary anyway so I'm going to try a different approach. This reverts commit 4fe07c6b0a341b0b99ee1b051f7c0bdfda572e04. Conflicts: modules/gallery_unit_test/controllers/gallery_unit_test.php
2013-03-06Explicitly print out the exit status to see if I can narrow down failures on ↵Bharat Mediratta
Travis.
2013-03-06Follow-on for #2043. Fix some tests that made bad assumptions aboutBharat Mediratta
the state of the world. These were uncovered when we ran the tests on Travis which runs the tests in a different order than what I (and apparently others) use on their dev boxes.
2013-03-05Follow-on to 384bc7afc86be706bf61def09afc8306cdad2443 for #2033Bharat Mediratta
Update golden file for XSS test.
2013-03-05Remove stray line of debug output.Bharat Mediratta
2013-03-05#2040 - Deactivate modules that no longer exist.shadlaws
- added module::deactivate_missing_modules() - revised module::deactivate() to change log message if the module is missing - added call to new function in module::get_obsolete_modules_message() - added call to new function when loading admin/maintenance menu
2013-03-04Merge pull request #187 from shadlaws/2033_followonBharat Mediratta
Follow-on to #2033 - Change variables and js script loading for Flash Fl...
2013-03-04Merge pull request #185 from shadlaws/minifyjs_20130304Bharat Mediratta
Minify (and re-minify) JS libraries (in sync with gallery3-vendor).
2013-03-04Merge pull request #183 from shadlaws/fix_2037Bharat Mediratta
#2037 - Fix bug with "item_before_update" event in item model.
2013-03-04Follow-on to #2033 - Change variables and js script loading for Flash ↵shadlaws
Flowplayer. - changed movie_img event variable names to have "flash" in them. - moved flowplayer.js loading from page.html.php to movieplayer-flash. - removed conditional loading for small, photo-specific JS files in page.html.php to keep combined JS consistent between page types (better for caching).
2013-03-04Return "1" to CLI if not all unit tests pass.Jozef Selesi
2013-03-04Minify (and re-minify) JS libraries (in sync with gallery3-vendor).shadlaws
- minified jQuery libraries. - re-minified flowplayer, json2-min, and extjs using new minimizer (more efficient, keeps copyrights).
2013-03-03#2037 - Fix bug with "item_before_update" event in item model.shadlaws
2013-03-03Merge pull request #179 from shadlaws/fix_2034Bharat Mediratta
#2034 - Add webm and ogv as valid movie types.
2013-03-03Follow-on to #2033 - Rename movieplayer.html.php to movieplayer-flash.html.phpshadlaws
- renamed file with "-flash" to make room for html5 player - updated item model and xss_data.txt to reflect changes --HG-- rename : modules/gallery/views/movieplayer.html.php => modules/gallery/views/movieplayer-flash.html.php
2013-03-03#2034 - Add webm and ogv as valid movie types.shadlaws
- added them to legal_file helper - revised unit tests