summaryrefslogtreecommitdiff
path: root/modules
AgeCommit message (Collapse)Author
2010-07-31Full pass over all the JSON encoding and JS dialog code. We now abideBharat Mediratta
by the following rules: 1) An initial dialog or panel load can take either HTML or JSON, but the mime type must accurately reflect its payload. 2) dialog form submits can handle a pure HTML response, but the mime type must also be correct. This properly resolves the problem where the reauth code gets a JSON response first from the reauth code, and then an HTML response when you reauth and continue on to a given form -- try it out with Admin > Settings > Advanced. 3) All JSON replies must set the mime type correctly. The json::reply convenience function does this for us. 4) By default, any HTML content sent back in the JSON response should be in the "html" field, no longer the "form" field. The combination of these allows us to stop doing boilerplate code like this in our controllers: // Print our view, JSON encoded json::reply(array("form" => (string) $view)); instead, controllers can just return HTML, eg: // Print our view print $view; That's much more intuitive for developers.
2010-07-31"Save" -> "Download" for clarity.Bharat Mediratta
2010-07-31Resend the entire dialog content (including the wrapping view) instead of ↵Tim Almdal
just the form.
2010-07-31Missing the user name on the reauthenticate form.Tim Almdal
2010-07-31When the admin controller redirects to the reauthenticate controller, the ↵Tim Almdal
value of request::is_ajax() from the original request is lost. This patch stores its value in the session so the reauthenticate controller knows whether its in a dialog/panel or not.
2010-07-31Convert the admin_theme controller to use the json::reply methodTim Almdal
2010-07-31More patches as part of #1225. Change the 'core' modules to use the json::replyTim Almdal
method to set the content type header and encode the response as a json object
2010-07-31Partial fix for #1225 addresses the issues with the user edit forms.Tim Almdal
2010-07-31Partial fix for #1225. Create a json reply helper that sets the content type ↵Tim Almdal
to application/json and then json encodes the reply.
2010-07-31Fix typo: ui-corners-all --> ui-corner-allBharat Mediratta
thanks Lord Beowulf!
2010-07-31Use readfile() instead of fopen()/fpassthru()/fclose() for brevity.Bharat Mediratta
I've done some tests on a 60M flv and found that there's no difference in memory consumption with these three approaches: public function test() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; if ($fd = fopen($file, "rb")) { while (true) { $bits = fread($fd, 65535); if (strlen($bits) == 0) { break; } print $bits; set_time_limit(30); } fclose($fd); } Kohana_Log::add("error","test: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); } public function test2() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; $fd = fopen($file, "rb"); fpassthru($fd); fclose($fd); Kohana_Log::add("error","test2: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); } public function test3() { Kohana::close_buffers(false); $file = "/home/bharat/basketball.flv"; readfile($file); Kohana_Log::add("error","test3: " . print_r(array(memory_get_peak_usage(true),memory_get_peak_usage(false)),1)); }
2010-07-29Add recovery code for dupe slugs and dupe names to the general purpose FixBharat Mediratta
task. Fixes ticket #1260.
2010-07-29We don't care about the name and slug for the root album so don't bother ↵Bharat Mediratta
enforcing them.
2010-07-29Trap ORM_Validation_Exception specially and report which fields failed ↵Bharat Mediratta
validation.
2010-07-28Combine the Fix MPTT and Fix Permissions tasks into one magical fix-itBharat Mediratta
task.
2010-07-27"public static" ==> "static" to match code conventions.Bharat Mediratta
2010-07-27Revert "Combine all the flex runtime libraries into a single downloadable ↵Bharat Mediratta
file. Fixes ticket #1241." This breaks organize on Chrome 5 (Linux) and Chrome 6 (OSX). See ticket #1241. This reverts commit 423fca2d5ffca1e953694793ad118589db1756d0.
2010-07-27VerifiedBharat Mediratta
2010-07-27Fix the "get flashplayer" button. It was throwing a JS error before.Bharat Mediratta
Not sure why it was done in JS in the first place. Fixes ticket #1256.
2010-07-27UpdatedBharat Mediratta
2010-07-27Don't invoke a graphics toolkit when setting the album cover from aBharat Mediratta
clean thumbnail; we can just copy it over. Should be a decent perf improvement in many cases. Fixes ticket #1255.
2010-07-27Update the mock so that all responses return arrays, not stdClass().Bharat Mediratta
2010-07-26Fix ticket #1253 where the maintenance page bombs if you have alreadyBharat Mediratta
configured your Gallery 2 import but you move your Gallery 3.
2010-07-25Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2010-07-25Add a new maintenance task that resyncs album .htaccess files withBharat Mediratta
database access intents. Use this to fix up .htaccess files after you relocate your Gallery. Fixes ticket #1252.
2010-07-25Move the "cancel all" running tasks button up to make it consistent with the ↵Bharat Mediratta
"remove all finished" button.
2010-07-25Don't use hardcoded id 1 as the everybody group; it won't work with ↵Bharat Mediratta
alternative auth schemes.
2010-07-23Merge branch 'master' of github.com:gallery/gallery3Tim Almdal
2010-07-23Fix missing quoate in the organize dialog html template.Tim Almdal
2010-07-23Combine all the flex runtime libraries into a single downloadable file. ↵Tim Almdal
Fixes ticket #1241.
2010-07-22Initialize $request in submit_translations(). Fixes ticket #1239.Bharat Mediratta
2010-07-22Properly handle the case where the album_cover_item_id points to anBharat Mediratta
invalid (probably deleted) item. Fixes ticket #1238.
2010-07-21Catch any exceptions thrown when we try to restore the originalBharat Mediratta
identity provider after we fail to set up a new one.
2010-07-21Null out relative_path_cache and relative_url_cache after we updateBharat Mediratta
the pointers in case the hierarchy was adversely affected by actions when the MPTT pointers were desynced. Fixes ticket #1235.
2010-07-20Show the old group name in the error message when we fail to modify a group. ↵Bharat Mediratta
Fixes ticket #1233.
2010-07-20Fix a bunch of missing or invalid error messages. Fixes ticket #1232.Bharat Mediratta
2010-07-20Elide "; charset=binary" which can be returned from file::mime() from recent ↵Bharat Mediratta
versions of finfo. See http://framework.zend.com/issues/browse/ZF-9383 for details. Fixes ticket #1230.
2010-07-20Localize the error strings in watermark::get_add_form(). Fix for ticket #1230.Bharat Mediratta
2010-07-20Cleanup on the Admin > Languages page.Bharat Mediratta
Hide the fieldset and legend in the theme, since they don't add any value. Change l10n_client::_server_url() to use the short style GMC urls and make the API a little tighter.
2010-07-20Use Session::get_once() instead of Session::get() followed by Session::delete();Bharat Mediratta
2010-07-20Add internationalized error messages for adding and editing groups.Bharat Mediratta
2010-07-20Fix internationalization of REST key.Bharat Mediratta
2010-07-20Style and text cleanup. Parameterize the minimum flash value so that we can ↵Bharat Mediratta
use it in the internationalized string. Fix capitalization.
2010-07-20Oops! Proper fix for #1201. My last fix just redirected back to theBharat Mediratta
main site, and didn't actually log you out.
2010-07-17Fix margin: 0 auto; IE issue in the upgrader view by adding a doctype to the ↵Chad Kieffer
template. Minor code refactoring. Also seems to fix #1188.
2010-07-17Fix closing ul on inactive modules list, replaced <i> with <em> in footer.Chad Kieffer
2010-07-16POST requests create a new entity and should result in a 201 CreatedBharat Mediratta
reply with a Location field that matches the URL of the newly created resource. Fixes ticket #1178.
2010-07-16Trap 404s and return Rest_Exception instead. Fixes ticket #1213.Bharat Mediratta
2010-07-16Merge branch 'master' of github.com:gallery/gallery3Bharat Mediratta
2010-07-16Improve the fix for #1176 to use request::is_ajax() instead of tackingBharat Mediratta
on a query param to urls that appear in dialogs. This keeps things simpler.
generated by cgit v1.2.3 (git 2.46.0) at 2025-10-24 06:22:05 +0000