| Age | Commit message (Collapse) | Author |
|
Instead of overwriting Kohana_Exception::handle() (which we were doing
in MY_Kohana_Exception) we instead use their existing template system.
gallery/views/kohana/error.php overrides system/views/kohana/error.php
and is the standard error template for all exceptions. Our version of
error.php figures out the appropriate view based on context (cli,
authenticated admin, guest viewing a 404, guest viewing a system
error) and delegates appropriately. Each delegated view has a narrow
responsibility.
This paves the way for us to add new error views per module. For
example, the rest module will define its own template in
Rest_Exception and then its exceptions can be rendered the way that it
wants (json encoded, in that case).
|
|
|
|
|
|
in my last change.
|
|
|
|
children, or if organize was being invoked on the root album.
|
|
returns just the access key string for the active user. That's how we
use the API, so keep it simple.
|
|
|
|
dialogWidth and dialogHeight and adjsut the internal controls when added to
the stage.
2) Cleanup the controller code
|
|
|
|
|
|
|
|
follow, even if it's redundant.
Expand a <ul> to multiple lines.
|
|
tag name field from 64 bytes to 128 bytes.
|
|
|
|
comments and the comment access permission is register users.
|
|
|
|
of appearance in the template. Also remove the @todo's
|
|
every time the SWF file changes.
|
|
find the item. Thanks to samdavidoff for the initial fix.
|
|
|
|
|
|
fields if they already contain values.
|
|
|
|
|
|
comments.
|
|
controllerUri instead.
|
|
|
|
Second half of fix for #1054.
|
|
we don't generate album highlights correctly. Possible fix for #1054.
|
|
#1161: guest comments get dropped because of a missing email address.
#1075: G2 comments with " get turned into "
|
|
|
|
|
|
item. Using the left and right pointers find all the comments for the child items. Thanks to jankoprowski for the initial investigation.
|
|
|
|
This reverts commit 98fce83de5f772482382bfabdbcd94c25ecdbb1a.
Conflicts:
modules/gallery/tests/Item_Model_Test.php
|
|
|
|
item::move(source, target) helper when the parent member has changed.
Using the move method insures that names and slugs that could conflict
in the target album are resolved properly. Changed the item::move
method so it returns a message to be displayed if the caller chooses.
And changed the move controller to display the message returned by the
move if the item name was renamed as part of the move."
Rolling this back for a couple of reasons:
1) Bug in move.php ("message.info" is not a function name)
2) Having the message come back from the API call as a side-effect is
sloppy. We should find a cleaner way to do this checking.
3) having item::move() call save() on any changed values in the ORM
is counter-intuitive. Move should move, save should save.
I think the right approach here is to roll the move() code properly into
save().
This reverts commit 2492280cc0ec9eb64a8daeccc7b5698ece7fea66.
|
|
method, which encapsulates saving an item and handling name and slug
conflicts. Call this instead of doing a save directly."
Rolled this back because it fails KISS. We already have an API for
saving models with Item_Model::save() that's consistent with all of
our other model code. Adding a new way to save items is confusing and
inconsistent.
This reverts commit 9504f71efcadc7ed27f6f09e5d663e8025bf3b86.
|
|
REST module is active.
|
|
during the upgrade path, so the 2nd stanza (version 2 to version 3) was never getting executed.
|
|
|
|
|
|
|
|
Skip . and .. (PHP 5.3 iterators seem to include those now).
|
|
|
|
encapsulates saving an item and handling name and slug conflicts. Call this instead of doing a save directly.
|
|
target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Changed the item::move method so it returns a message to be displayed if the caller chooses. And changed the move controller to display the message returned by the move if the item name was renamed as part of the move.
|
|
to weight.
|
|
itemm::move(source, target) helper when the parent member has changed. Using the move method insures that names and slugs that could conflict in the target album are resolved properly. Also, only change the weights of the album children if the item sort_column is set to weight."
This reverts commit 603d4640141a43350f50da747d747456b28fdd93.
|